Sign in to follow this  
nullsquared

OpenGL Re-loading textures fails

Recommended Posts

Exhibits:

Exhibit 1: Exhibit 1
Exhibit 2: Exhibit 2
Exhibit 3:
struct rgl_header {
        unsigned long width;
        unsigned long height;
        unsigned long colorkey;

        //signed long xclip;
        //signed long yclip;
        //unsigned long wclip;
        //unsigned long hclip;
    };




Exhibit 4:
void texture::_save_raw(unsigned char *data) {
    std::ofstream output(m_raw_filename.c_str(), std::ios::binary);
    if (output.bad() || output.fail())
        return;
    #ifdef _DEBUG_
    texture_log << "\n{\n\tsaving raw file with filename: " <<
        m_raw_filename << "\n}\n";
    #endif

    rgl_header header;

    header.width = w();
    header.height = h();
    header.colorkey = m_colorkey;

    //header.xclip = m_clip.x;
    //header.yclip = m_clip.y;
    //header.wclip = m_clip.w;
    //header.hclip = m_clip.h;

    #ifdef _DEBUG_
    texture_log << "\nrgl header (write) {\n\t"
        << "header.w " << header.width << "\n\t"
        << "header.h " << header.height << "\n\t"
        << "header.colorkey " << header.colorkey << "\n}\n";//\t"
        //<< "header.xclip " << header.xclip << "\n\t"
        //<< "header.yclip " << header.yclip << "\n\t"
        //<< "header.wclip " << header.wclip << "\n\t"
        //<< "header.hclip " << header.hclip << "\n}\n";
    #endif

    // valid rgl file
    output.write("RGL", 4);
    // header
    output.write((char*)&header, sizeof(rgl_header));
    // actual data
    output.write((char*)data, header.width * header.height * 4);
}

bool texture::_load_raw(const std::string &filename) {
    #ifdef _DEBUG_
    texture_log << "\n{\n\tloading: " << filename << "\n}\n";
    #endif

    std::ifstream input(filename.c_str(), std::ios::binary);
    if (input.bad() || input.fail() || !input.good()) {
        #ifdef _DEBUG_
        texture_log << "\n{\n\tcannot open raw file: " <<
            filename << "\n}\n";
        #endif
        return false;
    }

    char valid[4];
    // is it a valid rgl file
    input.read(valid, 4);
    if (valid[0] != 'R' || valid[1] != 'G' || valid[2] != 'L') {
        #ifdef _DEBUG_
        texture_log << "\n{\n\tinvalid .rgl file header: " <<
            valid << "\n}\n";
        #endif
        return false;
    }

    // unload previous file
    if (m_loaded || m_id) {
        unload();
    }

    // read the header
    rgl_header header = {0, 0, 0};
    input.read((char*)&header, sizeof(rgl_header));

    #ifdef _DEBUG_
    texture_log << "\nrgl header (read) {\n\t"
        << "header.w " << header.width << "\n\t"
        << "header.h " << header.height << "\n\t"
        << "header.colorkey " << header.colorkey << "\n}\n";//\t"
        //<< "header.xclip " << header.xclip << "\n\t"
        //<< "header.yclip " << header.yclip << "\n\t"
        //<< "header.wclip " << header.wclip << "\n\t"
        //<< "header.hclip " << header.hclip << "\n}\n";
    #endif

    // set up
    m_width = header.width;
    m_height = header.height;
    m_colorkey = header.colorkey;

    //m_clip.x = header.xclip;
    //m_clip.y = header.yclip;
    //m_clip.w = header.wclip;
    //m_clip.h = header.hclip;

    // get the actual data
    const unsigned long SIZE = w() * h() * 4;
    unsigned char *data = new unsigned char[SIZE];
    input.read((char*)data, SIZE);

    // reserve id for texture
    glGenTextures(1, &m_id);

    // bind it so we can get to work!
    this->bind();

    // now it's time for some setting
    // set the data onto the texture
    glTexImage2D(
        GL_TEXTURE_2D,
        0, // mip-map level
        GL_RGBA8, // 4 color components, each taking 8 bits (1 byte)
        m_width,
        m_height,
        0, // border
        GL_RGBA, // type of data
        GL_UNSIGNED_BYTE, // each pixel (or, texel) is an unsigned char
        data
    );

    // set up filtering
    glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, /*GL_NEAREST*/GL_LINEAR);
    glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, /*GL_NEAREST*/GL_LINEAR);

    m_loaded = true;
    return true;
}



Problem:

Hello all! I'm having a slight OpenGL-related problem. As you can see in Exhibit 1, loading a texture and displaying it works fine. This means that my loading function(s) work(s) correctly. However, in Exhibit 2 you see the same scene, but with a messed up texture. What I do in my image loading function(s) is check too see if there is a file with the filename passed in, but instead of with .bmp with .rgl. If there is, load the .rgl file, otherwise, load the .bmp file and make a .rgl file. The first time I run my program, all is fine because the bitmap loads and the .rgl file is made. But the second time I run it, the program sees the .rgl file and loads it, giving me Exhibit 2. Exhibit 3 and 4 are how I save the .rgl file. I pass _save_raw() in the exact data that I pass in to OpenGL's glTexImage2D(). Then when I load I pass in the .rgl filename to _load_raw() and it's supposed to load it. However, I get the garbled mess displayed in Exhibit 2. Does anyone have an idea as to why? I'm sure OpenGL is set up correctly, as if I load from the bitmap all is fine... Thank you, and have a nice day!

Share this post


Link to post
Share on other sites
Are you sure that the image you're saving has four channels? BMP files only support three. Can we see your BMP loading code?

Share this post


Link to post
Share on other sites
Quote:
Original post by Kalidor
Are you sure that the image you're saving has four channels? BMP files only support three. Can we see your BMP loading code?


100% sure.

I load the image into an SDL surface and then create another 32-bit surface which is "fixed" specially for OpenGL. The "fixed" surface has 32 bits in order RGBA.

Anyways, here is the loading code just in case (it relates to SDL, but I'm sure the problem is more on my & OpenGL's side rather than SDL's):

bool texture::load(const std::string &filename) {
if (m_loaded)
unload();

// does an rgl file exist?
m_raw_filename = filename.substr(0, filename.find(".bmp")) + ".rgl";
std::ifstream check(m_raw_filename.c_str(), std::ios::binary);
if (!check.fail() && !check.bad() && check.is_open() && check.good()) {
check.close();
return _load_raw(m_raw_filename);
} else {
check.close();
}

SDL_Surface *raw, *fixed;

raw = SDL_LoadBMP(filename.c_str());
if (!raw) {
#ifdef _DEBUG_
texture_log << "\n{\n\tfailed at loading texture: " << filename
<< "\n\t(.bmp is the only format supported)\n}\n";
#endif
return false;
}

// opengl's y is inverted, so we must flip the data
flipv(raw);

int width = 1, height = 1;
// optimise for square textures: loop only once
while (width < raw->w || height < raw->h) {
if (width < raw->w) width <<= 1;
if (height < raw->h) height <<= 1;
}

m_clip.x = 0;
m_clip.y = 0;
m_clip.w = width;
m_clip.h = height;

m_width = width;
m_height = height;

fixed = SDL_CreateRGBSurface(
SDL_HWSURFACE, // won't be doing any pixel operations
width, height, 32, // w, h, bpp (bpp == 32, using alpha)
#if SDL_BYTEORDER == SDL_BIG_ENDIAN
0xff000000,
0x00ff0000,
0x0000ff00,
0x000000ff
#else
0x000000ff,
0x0000ff00,
0x00ff0000,
0xff000000
#endif
);

if (!fixed) {
#ifdef _DEBUG_
texture_log << "\n{\n\tcould not generate fixed surface for: " << filename
<< "\n}\n";
#endif
return false;
}

// copy the surface onto the other one
SDL_BlitSurface(raw, NULL, fixed, NULL);
// free the old surface
SDL_FreeSurface(raw);

if (SDL_MUSTLOCK(fixed))
while(SDL_LockSurface(fixed));

// rgl
// save the rgl file
_save_raw((unsigned char*)fixed->pixels);

// reserve id for texture
glGenTextures(1, &m_id);

// bind it so we can get to work!
this->bind();

// now it's time for some setting
// set the data onto the texture
glTexImage2D(
GL_TEXTURE_2D,
0, // mip-map level
GL_RGBA8, // 4 color components, each taking 8 bits (1 byte)
width,
height,
0, // border
GL_RGBA, // type of data
GL_UNSIGNED_BYTE, // each pixel (or, texel) is an unsigned char
(unsigned char*)fixed->pixels
);

if (SDL_MUSTLOCK(fixed))
SDL_UnlockSurface(fixed);

// free the new surface
SDL_FreeSurface(fixed);

// set up filtering
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, /*GL_NEAREST*/GL_LINEAR);
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, /*GL_NEAREST*/GL_LINEAR);

m_loaded = true;

return true;
}

Share this post


Link to post
Share on other sites
I'll give a quick *bump* before I have to go...

This is sorta stopping me from coding since I want to optimise stuff.... Anyways, thanks in advance.

Share this post


Link to post
Share on other sites
0) don't optimise prematurely.
1) you should glDeleteTexture before trying to reload or you'll have a memory leak in the ICD.
2) to me, it looks as if your texture coordinates are messed up, not your loading code.
3) try changing the last GL_RGBA to GL_RGB

Share this post


Link to post
Share on other sites
Quote:
Original post by silvermace
0) don't optimise prematurely.

Got it.
Quote:

1) you should glDeleteTexture before trying to reload or you'll have a memory leak in the ICD.

Affirmative -

bool texture::load(const std::string &filename) {
if (m_loaded)
unload();
[...]
}

Quote:

2) to me, it looks as if your texture coordinates are messed up, not your loading code.

I'm 100% sure they are not. Infact, all I do is set the clip rect to 0, 0, width, height - which includes the whole image.
Quote:

3) try changing the last GL_RGBA to GL_RGB

I'll try it, I can't get to the code right now, but I'll reply when I do.

Share this post


Link to post
Share on other sites
Quote:
Original post by silvermace
2) to me, it looks as if your texture coordinates are messed up, not your loading code.


Hmm... I looked into this a little more, and guess what? You're right!!! (Rate++ follows after this post.)

I was loading from my constructor, which sets the clip rect to (0, 0, 1, 1). Since my _load_raw() function does NOT do anything with the clip rect, it was just displaying the first pixel of the texture... [lol]. Anyways, saving the rect along with the data (as I did before, but commented out for no true reason) fixed everything.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Forum Statistics

    • Total Topics
      627759
    • Total Posts
      2978958
  • Similar Content

    • By DelicateTreeFrog
      Hello! As an exercise for delving into modern OpenGL, I'm creating a simple .obj renderer. I want to support things like varying degrees of specularity, geometry opacity, things like that, on a per-material basis. Different materials can also have different textures. Basic .obj necessities. I've done this in old school OpenGL, but modern OpenGL has its own thing going on, and I'd like to conform as closely to the standards as possible so as to keep the program running correctly, and I'm hoping to avoid picking up bad habits this early on.
      Reading around on the OpenGL Wiki, one tip in particular really stands out to me on this page:
      For something like a renderer for .obj files, this sort of thing seems almost ideal, but according to the wiki, it's a bad idea. Interesting to note!
      So, here's what the plan is so far as far as loading goes:
      Set up a type for materials so that materials can be created and destroyed. They will contain things like diffuse color, diffuse texture, geometry opacity, and so on, for each material in the .mtl file. Since .obj files are conveniently split up by material, I can load different groups of vertices/normals/UVs and triangles into different blocks of data for different models. When it comes to the rendering, I get a bit lost. I can either:
      Between drawing triangle groups, call glUseProgram to use a different shader for that particular geometry (so a unique shader just for the material that is shared by this triangle group). or
      Between drawing triangle groups, call glUniform a few times to adjust different parameters within the "master shader", such as specularity, diffuse color, and geometry opacity. In both cases, I still have to call glBindTexture between drawing triangle groups in order to bind the diffuse texture used by the material, so there doesn't seem to be a way around having the CPU do *something* during the rendering process instead of letting the GPU do everything all at once.
      The second option here seems less cluttered, however. There are less shaders to keep up with while one "master shader" handles it all. I don't have to duplicate any code or compile multiple shaders. Arguably, I could always have the shader program for each material be embedded in the material itself, and be auto-generated upon loading the material from the .mtl file. But this still leads to constantly calling glUseProgram, much more than is probably necessary in order to properly render the .obj. There seem to be a number of differing opinions on if it's okay to use hundreds of shaders or if it's best to just use tens of shaders.
      So, ultimately, what is the "right" way to do this? Does using a "master shader" (or a few variants of one) bog down the system compared to using hundreds of shader programs each dedicated to their own corresponding materials? Keeping in mind that the "master shaders" would have to track these additional uniforms and potentially have numerous branches of ifs, it may be possible that the ifs will lead to additional and unnecessary processing. But would that more expensive than constantly calling glUseProgram to switch shaders, or storing the shaders to begin with?
      With all these angles to consider, it's difficult to come to a conclusion. Both possible methods work, and both seem rather convenient for their own reasons, but which is the most performant? Please help this beginner/dummy understand. Thank you!
    • By JJCDeveloper
      I want to make professional java 3d game with server program and database,packet handling for multiplayer and client-server communicating,maps rendering,models,and stuffs Which aspect of java can I learn and where can I learn java Lwjgl OpenGL rendering Like minecraft and world of tanks
    • By AyeRonTarpas
      A friend of mine and I are making a 2D game engine as a learning experience and to hopefully build upon the experience in the long run.

      -What I'm using:
          C++;. Since im learning this language while in college and its one of the popular language to make games with why not.     Visual Studios; Im using a windows so yea.     SDL or GLFW; was thinking about SDL since i do some research on it where it is catching my interest but i hear SDL is a huge package compared to GLFW, so i may do GLFW to start with as learning since i may get overwhelmed with SDL.  
      -Questions
      Knowing what we want in the engine what should our main focus be in terms of learning. File managements, with headers, functions ect. How can i properly manage files with out confusing myself and my friend when sharing code. Alternative to Visual studios: My friend has a mac and cant properly use Vis studios, is there another alternative to it?  
    • By ferreiradaselva
      Both functions are available since 3.0, and I'm currently using `glMapBuffer()`, which works fine.
      But, I was wondering if anyone has experienced advantage in using `glMapBufferRange()`, which allows to specify the range of the mapped buffer. Could this be only a safety measure or does it improve performance?
      Note: I'm not asking about glBufferSubData()/glBufferData. Those two are irrelevant in this case.
    • By xhcao
      Before using void glBindImageTexture(    GLuint unit, GLuint texture, GLint level, GLboolean layered, GLint layer, GLenum access, GLenum format), does need to make sure that texture is completeness. 
  • Popular Now