• Advertisement
Sign in to follow this  

[web] PHP, Perl, and parameterized SQL

This topic is 4210 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

I'm trying to add some parameterized SQL to a particular site written in Perl. But I discover that all it seems to be doing is escaping quotes, which still leaves me vulnerable to injection attacks, and leaves a bunch of slashes in my database that I have to remove whenever I pull anything out. Yuck. So then I tried PHP. At first it seemed to work, but it turns out it does the same thing, only it escapes single quotes instead of double quotes like Perl did. They can't even agree on what kinds of quotes need to be escaped? Or is this not really a problem with PHP or Perl and instead I should blame MySQL 4? If so, does MySQL 5 support parameterized SQL any better?

Share this post


Link to post
Share on other sites
Advertisement
Quote:
Original post by BradDaBug
They can't even agree on what kinds of quotes need to be escaped?


Perl probabely has a different string parsing syntax from PHP, so the escaping needs to be different as well.

Quote:
Or is this not really a problem with PHP or Perl and instead I should blame MySQL 4?


Sounds like a problem in your website code. You're probabely calling mysql_escape_string() or the perl equivalent somewhere on the variables passed in MySQL strings. This is what you should do for non-parameterized SQL but not for parameters since the escapes will become part of the parameter instead of being parsed in a string.

If it's not that, then have a look at the magic quotes setting. Not sure what the Perl variant of that is.

Share this post


Link to post
Share on other sites
Here's an example of how I'm doing parameters in Perl:
# get the message in question
my $sql = "select message, title from bdb_table where id =?";

my $cursor = $dbh->prepare($sql);
# $postid is grabbed from the query string and is supposed to just be some number
$cursor->bind_param(1, $postid);
$cursor->execute;


And here's some PHP:
$sql = "select uid, moderator from user_table where username = ? and password = ?";
$results = $connection->query($sql, array($username, $password));

I'm not calling anything that should be escaping quotes. Also I just looked at the actual DB and it looks like PHP is escaping both " and '.

Share this post


Link to post
Share on other sites
$connection is a custom class? Perhaps that one calls mysql_escape_string() on all elements of the array you pass it.

Share this post


Link to post
Share on other sites
$connection is just my connection to the database. I get it like this:
$connection =& DB::connect($bdb_connect_string);

DB::connect() is something inside DB.php, which I assume is a standard PHP include.

Share this post


Link to post
Share on other sites
It turns out that it was magic quotes (at least for PHP)! I finally got it turned off and now it looks like it works the way I want. Thanks!

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement