• Advertisement
Sign in to follow this  

OpenGL A little help with DirectDraw

This topic is 4038 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

It's been a long time since I've posted to GD.net, and I feel that I've developed a lot as a programmer... HOWEVER, I've been trying to extend my 2D engine to work with directdraw as well as openGL, and I'm running into some issues. Now, the problem is really just loading graphics onto a DDS... Before I had known about the lPitch variable, it seemed like I was able to load the full graphic onto the surface, except it would be tinted with the first color of the RGBA int, so everything would be tinted red for example. After reading up a bit more, I would get the right colors... but something horrible!! It only seemed to fill about 1/4 of the surface!! Free Image Hosting at www.ImageShack.us as demonstrated here... It really baffles me, I don't understand why. So I was hoping someone with more DirectDraw experience could shed some light on this for me, I would be most grateful. PS Yes i have read the articles on loading images in DDraw and what not, I found them very informative, but rereading them again and again havn't been much help to me on this. Here is my "loading image into DDS" code, currently :
int img_to_dds ( struct s_imgload *load, struct s_image *img )
{
    DDSURFACEDESC ddsd;
	int i = 0;
	int x, y, p;
	int pixels, px;
	//DATA8 *pixelptr;
				//DATA32 *pixel;
	DATA8 *pixel;
	unsigned int *lpscreen;

	memset( &ddsd, 0, sizeof(ddsd) );
    ddsd.dwSize = sizeof(ddsd);
    ddsd.dwFlags = DDSD_CAPS | DDSD_HEIGHT |DDSD_WIDTH;
    ddsd.ddsCaps.dwCaps = DDSCAPS_OFFSCREENPLAIN|DDSCAPS_VIDEOMEMORY;
    ddsd.dwWidth = load->w;
    ddsd.dwHeight = load->h;

    if (IDirectDraw_CreateSurface( DDRAW, &ddsd, &img->surface, NULL) != DD_OK)
        return FALSE;

	IDirectDrawSurface_Lock( img->surface, NULL,  &ddsd,  NULL, NULL );
	pixel = (DATA8 *)ddsd.lpSurface;
	p = ddsd.lPitch ;
	pixels = load->w * load->h;
for ( y=0;y<load->h;y++ )
	for ( x=0;x<load->w;x++, i++ )
	{
		int c;
		int r,g,b,a,cr,cb,cg,ca, rgb;
		rgb = 255;
			c = (DATA32)load->data;
			READ_RGBA( &c, cr, cg, cb, ca );
			//pixel = x+y * p;
			r = ( cr * ( 1 << r_bits )) / 256;
			g = ( cg * ( 1 << g_bits )) / 256;
			b = ( cb * ( 1 << b_bits )) / 256;
			a = ( ca * ( 1 << a_bits )) / 256;
   // Convert the Values to the appropriate Location in the returned colour value
			 r <<= r_low;
			 g <<= g_low;
			 b <<= b_low;
			 a <<= a_low;
			 rgb = r | g | b | a;
			 //pixel[x + y] = rgb;
			 pixel[x+y*p] = rgb;
			 //pixel[x+y*p] = 255;
			//memset ( pixel, rgb, 4 );

	}

	IDirectDrawSurface_Unlock ( img->surface, NULL );

	return TRUE;
}

In the above, the imgload struct is just a struct with the height and width of the image, the BPP and a pointer to the data, it gets filled by functions which are modified from imlib2, and work reliably in OpenGL, so I'm not convinced that the problem is in that area. Thanks in advance for helping.

Share this post


Link to post
Share on other sites
Advertisement
Guest Anonymous Poster
You can try to set a pixelformat when you create your surface.

Share this post


Link to post
Share on other sites
set the pixel format? i was under the impression that the pixel format for a surface is the same format of the current video mode o_o

can someone please elaborate on this?

Share this post


Link to post
Share on other sites
You need to adapt that code according to the pixel format of the created surface. Your code right now seems to assume an 8bit format (you're sqashing rgba into a single byte).

Since it seems to work without you setting a format you need to request the used format with GetPixelFormat.

Share this post


Link to post
Share on other sites
Thanks.. Now I can grasp this.. I just want to know this one thing, because this is what I had come to understand from reading I did.

1) The surface should have the same number of elements as the display mode ( EG, RGB for 24 bit display, RGBA for 32 bit display? )

2) (and I'm not 100% on this one) all surfaces created under a IDirectDraw interface should be in the same pixel format.

As demonstrated in that one tutorial paper on GD.net on putting pixels into a DDS, I call getpixelformat after creating the primary surface, and save the bits and low bit as global variables. So this is not enough, I'm guessing?

Also, about the "squashing data into 8 bits" thing, I was getting segfaults when using shorts or longs instead of chars, which just baffled me. The pixel format for my primary surface is 32 bits, 8888 (where only 1 bit of the alpha is being used), and if the above are true then all surfaces should be like that.

I guess I just got a bit flustered and started trying different things instead of rationally thinking about it, but it still confuses me why I would get a segfault doing that.

*Tears hair out*

Share this post


Link to post
Share on other sites
If you try to access the pixel as 32 bit data you have to be careful with the pitch. The pitch is given in bytes, so if your pointer is a DATA32* type you have to divide the pitch by 4.

You'd have to change the loops inner line to

pixel[x + y * ( p / 4 )] = rgb;

Also, if in your case you know both the source data and surface format is 32bit you can simply copy the image data line per line with a memcpy call.


@Nitpickers: Any half decent compiler will change the division to a right shift, don't nag about that bit.

Share this post


Link to post
Share on other sites
hmmm... i tried your advice and, while it does not segfault, it again seems to use the incorrect colours. I know I'm doing something wrong thats really obvious, I just don't see it.

Share this post


Link to post
Share on other sites
Hmm, what order are the RGB bits in the loaddata? Is it ARGB? Cause the DirectDraw surface will be.

If it is that format try the following snippet, it should work cleanly with 32bit to 32bit copying:


for ( y = 0; y < load->h; y++ )
{
memcpy( pixel + y * p, ( (DATA8*)load->data ) + y * load->w * 4, load->w * 4 );
}


Just noticed something, what type is load->data?

Share this post


Link to post
Share on other sites
in the load struct the data is in RGBA, however in following one of the articles on GD.net, I save the num bits and the low bit for each element of the pixel one time during initialization of primary surface.

Now this rides on the assumption that all surfaces have the same pixel format, which would make sense of course but I don't know this to be true for sure. At any rate, it is really making me feel dumb lol.

By incorrect colours, what I mean is the whole screen is tinted blue with black vertical scanlines (I guess those are due to the alpha channel or something not cooperating with the pixel format )

Also, when I try doing a memset, what I get is a correctly colored image that takes up about 12/th of the surface ( which is actually only about a third of the full sized image ), and repeats it several times.

I tell you, things were much simpler with openGL to do this kind of work for ya lol but hey it's a good learning experience I guess. I can't wait to be doing sprite rotations and scaling if this is giving me so much trouble :p

Share this post


Link to post
Share on other sites
Haha, sorry, hardware rotation with DirectDraw is very rare. You're going to have to write your own software routine to rotate an image.

Or, you could move to Direct3D and use ID3DXSprite instead. The D3DX library has functions to load in textures, and since ID3DXSprite uses 3D hardware, it supports things like scaling, rotation and blending.

Share this post


Link to post
Share on other sites
Quote:
Original post by Sc4Freak
Or, you could move to Direct3D and use ID3DXSprite instead. The D3DX library has functions to load in textures, and since ID3DXSprite uses 3D hardware, it supports things like scaling, rotation and blending.
Seconded. I've never come across hardware that supports hardware scaling and rotation. If you want to do that, you'll have to do it all in software (You could have a look at the SDL's implementation of their rotozoomer, that uses DirectDraw I belive).

Direct3D is far better suited to this stuff, even for 2D rendering. I personally wouldn't touch DirectDraw with a 10 foot pole unless it was absolutely nessecary.

Share this post


Link to post
Share on other sites
Hmmm, that may be the way I'll go then. But the textures in D3D are in DDS format as well right? So that still leaves me a bit stuck. ah well :x

Share this post


Link to post
Share on other sites
Quote:
Original post by AAAP
Hmmm, that may be the way I'll go then. But the textures in D3D are in DDS format as well right? So that still leaves me a bit stuck. ah well :x
Yes, but doing load-time pixel conversion is relatively easy, and there's a bunch of D3DX functions which will load most image types (BMP, JPEG, PNG, DDS, Etc) from a file or a buffer in memory into a texture and create and return the texture to you.

And you get free rotation, scaling, shearing, alpha blending, and a whole slew of other goodies.

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Tags

  • Advertisement
  • Popular Now

  • Similar Content

    • By LifeArtist
      Good Evening,
      I want to make a 2D game which involves displaying some debug information. Especially for collision, enemy sights and so on ...
      First of I was thinking about all those shapes which I need will need for debugging purposes: circles, rectangles, lines, polygons.
      I am really stucked right now because of the fundamental question:
      Where do I store my vertices positions for each line (object)? Currently I am not using a model matrix because I am using orthographic projection and set the final position within the VBO. That means that if I add a new line I would have to expand the "points" array and re-upload (recall glBufferData) it every time. The other method would be to use a model matrix and a fixed vbo for a line but it would be also messy to exactly create a line from (0,0) to (100,20) calculating the rotation and scale to make it fit.
      If I proceed with option 1 "updating the array each frame" I was thinking of having 4 draw calls every frame for the lines vao, polygons vao and so on. 
      In addition to that I am planning to use some sort of ECS based architecture. So the other question would be:
      Should I treat those debug objects as entities/components?
      For me it would make sense to treat them as entities but that's creates a new issue with the previous array approach because it would have for example a transform and render component. A special render component for debug objects (no texture etc) ... For me the transform component is also just a matrix but how would I then define a line?
      Treating them as components would'nt be a good idea in my eyes because then I would always need an entity. Well entity is just an id !? So maybe its a component?
      Regards,
      LifeArtist
    • By QQemka
      Hello. I am coding a small thingy in my spare time. All i want to achieve is to load a heightmap (as the lowest possible walking terrain), some static meshes (elements of the environment) and a dynamic character (meaning i can move, collide with heightmap/static meshes and hold a varying item in a hand ). Got a bunch of questions, or rather problems i can't find solution to myself. Nearly all are deal with graphics/gpu, not the coding part. My c++ is on high enough level.
      Let's go:
      Heightmap - i obviously want it to be textured, size is hardcoded to 256x256 squares. I can't have one huge texture stretched over entire terrain cause every pixel would be enormous. Thats why i decided to use 2 specified textures. First will be a tileset consisting of 16 square tiles (u v range from 0 to 0.25 for first tile and so on) and second a 256x256 buffer with 0-15 value representing index of the tile from tileset for every heigtmap square. Problem is, how do i blend the edges nicely and make some computationally cheap changes so its not obvious there are only 16 tiles? Is it possible to generate such terrain with some existing program?
      Collisions - i want to use bounding sphere and aabb. But should i store them for a model or entity instance? Meaning i have 20 same trees spawned using the same tree model, but every entity got its own transformation (position, scale etc). Storing collision component per instance grats faster access + is precalculated and transformed (takes additional memory, but who cares?), so i stick with this, right? What should i do if object is dynamically rotated? The aabb is no longer aligned and calculating per vertex min/max everytime object rotates/scales is pretty expensive, right?
      Drawing aabb - problem similar to above (storing aabb data per instance or model). This time in my opinion per model is enough since every instance also does not have own vertex buffer but uses the shared one (so 20 trees share reference to one tree model). So rendering aabb is about taking the model's aabb, transforming with instance matrix and voila. What about aabb vertex buffer (this is more of a cosmetic question, just curious, bumped onto it in time of writing this). Is it better to make it as 8 points and index buffer (12 lines), or only 2 vertices with min/max x/y/z and having the shaders dynamically generate 6 other vertices and draw the box? Or maybe there should be just ONE 1x1x1 cube box template moved/scaled per entity?
      What if one model got a diffuse texture and a normal map, and other has only diffuse? Should i pass some bool flag to shader with that info, or just assume that my game supports only diffuse maps without fancy stuff?
      There were several more but i forgot/solved them at time of writing
      Thanks in advance
    • By RenanRR
      Hi All,
      I'm reading the tutorials from learnOpengl site (nice site) and I'm having a question on the camera (https://learnopengl.com/Getting-started/Camera).
      I always saw the camera being manipulated with the lookat, but in tutorial I saw the camera being changed through the MVP arrays, which do not seem to be camera, but rather the scene that changes:
      Vertex Shader:
      #version 330 core layout (location = 0) in vec3 aPos; layout (location = 1) in vec2 aTexCoord; out vec2 TexCoord; uniform mat4 model; uniform mat4 view; uniform mat4 projection; void main() { gl_Position = projection * view * model * vec4(aPos, 1.0f); TexCoord = vec2(aTexCoord.x, aTexCoord.y); } then, the matrix manipulated:
      ..... glm::mat4 projection = glm::perspective(glm::radians(fov), (float)SCR_WIDTH / (float)SCR_HEIGHT, 0.1f, 100.0f); ourShader.setMat4("projection", projection); .... glm::mat4 view = glm::lookAt(cameraPos, cameraPos + cameraFront, cameraUp); ourShader.setMat4("view", view); .... model = glm::rotate(model, glm::radians(angle), glm::vec3(1.0f, 0.3f, 0.5f)); ourShader.setMat4("model", model);  
      So, some doubts:
      - Why use it like that?
      - Is it okay to manipulate the camera that way?
      -in this way, are not the vertex's positions that changes instead of the camera?
      - I need to pass MVP to all shaders of object in my scenes ?
       
      What it seems, is that the camera stands still and the scenery that changes...
      it's right?
       
       
      Thank you
       
    • By dpadam450
      Sampling a floating point texture where the alpha channel holds 4-bytes of packed data into the float. I don't know how to cast the raw memory to treat it as an integer so I can perform bit-shifting operations.

      int rgbValue = int(textureSample.w);//4 bytes of data packed as color
      // algorithm might not be correct and endianness might need switching.
      vec3 extractedData = vec3(  rgbValue & 0xFF000000,  (rgbValue << 8) & 0xFF000000, (rgbValue << 16) & 0xFF000000);
      extractedData /= 255.0f;
    • By Devashish Khandelwal
      While writing a simple renderer using OpenGL, I faced an issue with the glGetUniformLocation function. For some reason, the location is coming to be -1.
      Anyone has any idea .. what should I do?
  • Advertisement