• Advertisement
Sign in to follow this  

Unity predefining a class in the namespace of class

This topic is 3898 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Hello Dear community I want to define a class in the namespace of another class, like this:
class A
{
public:
  class B
  {
  ...
  };
  B Something;
  ...
};
But I want to define A and B in sperate files. Since A uses B for a member-variable (like "Something" in the example), B must be defined befor A. So I tried: A.h:
include <B.h>

class A
{
public:
   B Something;
   ...
};
B.h:
class A;

class A::B
{
   ...
}
Does not work, I get "qualified name does not name a class" at the definition of B. How is it done correctly? Thansk! Nathan

Share this post


Link to post
Share on other sites
Advertisement
You can't. C++ does not allow you to declare a single member of a class, you have to declare them all simultaneously. However, you don't have to make B a subclass of A: a typedef is enough.


// B.hpp

class B
{
};

// A.hpp
#include "B.hpp"

class A
{
public:
typedef ::B B;
A::B Something;
};


Share this post


Link to post
Share on other sites
Quote:
Original post by ToohrVyk
You can't. C++ does not allow you to declare a single member of a class, you have to declare them all simultaneously. However, you don't have to make B a subclass of A: a typedef is enough.

*** Source Snippet Removed ***


But what would the benifits of that be?

Class scope definitions of other classes are generally used to reduce the scope and give meaning to the second class, whereas the code you suggest not only leaves class B in the global namespace, but actually gives you multiple ways of defining the same object (since you have to include b.hpp to use a.hpp).

If class B is a generic class that would be used by only a select few classes, then the inclusion and scope of B should be altered, rather than adding additional ways of referencing it.

Spree

Share this post


Link to post
Share on other sites
Quote:
Original post by SpreeTree
But what would the benifits of that be?


Being able to move the definition of B to its own file and out of A.

Quote:
Class scope definitions of other classes are generally used to reduce the scope and give meaning to the second class, whereas the code you suggest not only leaves class B in the global namespace, but actually gives you multiple ways of defining the same object (since you have to include b.hpp to use a.hpp).


_Vector_const_iterator is a template class in the std:: namespace, but nobody ever uses it. In fact, few people even suspect its existence, and it isn't guaranteed to exist on all compilers or libraries either. Most people use std::vector<T>::const_iterator instead, even if it's just a typedef for std::_Vector_const_iterator<T>.

The fact that a class is in the global namespace (or any namespace, for that matter) doesn't mean that it's public—besides, naming it _private_impl_A::_B (with the appropriate name and namespace) is extremely easy to do, and conveys the "don't touch this class" message pretty clearly to programmers. Users should not be aware of the existence of _private_impl_A::_B and the "B.hpp" header.

Ultimately, it is the documentation of the signature of the module, and not the header files, that should be used by the programmers.

Share this post


Link to post
Share on other sites
Quote:
Original post by ToohrVyk
Quote:
Original post by SpreeTree
But what would the benifits of that be?


Being able to move the definition of B to its own file and out of A.


I meant besides that ;)

Quote:
Original post by ToohrVyk
The fact that a class is in the global namespace (or any namespace, for that matter) doesn't mean that it's public—besides, naming it _private_impl_A::_B (with the appropriate name and namespace) is extremely easy to do, and conveys the "don't touch this class" message pretty clearly to programmers. Users should not be aware of the existence of _private_impl_A::_B and the "B.hpp" header.

Ultimately, it is the documentation of the signature of the module, and not the header files, that should be used by the programmers.


I understand your reasoning behind that (and the private impl namespace is a good idea), but unfortunatly to a lot of people the fact that it is global would directly lead them to think it was public.

With the advent of Visual Assist and (to a lesser extent) itellisense showing you everything and more within your current space, people would know of it's existence whether you wanted them to or not.

I have also worked with lot of professional libraries that have little or no documentation (of course you could question the term professional in that case) which is why I try to go to great lengths to show the use and scope of a class directly from the source, rather than only relying on the documentation :)

This is a useful tool in the big box of programmer tools (and there are plenty of ways around limiting the use of B within the space of program), I just thought I would mention a problem some people would have with your solution.

Spree

Share this post


Link to post
Share on other sites
Thanks for your replies.
I want B to be declared in A because it is only used as a member of A and should not be visible from the outside.
On the other hand its big enough to make the class decleration of A look complicated.
For that reason ToohrVyks Idea seems not so good here.

What would you do in this case?
Nathan

Share this post


Link to post
Share on other sites
You also have the possibility of:


// A.hpp
class A
{
// ...
public:

#define A_INCLUDING_B
# include "_B.hpp"
#undef A_INCLUDING_B

B Something;
};

// _B.hpp
#ifndef A_INCLUDING_B
# error This header file should not be included
#endif

class B
{
// ...
};

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Tags

  • Advertisement
  • Popular Now

  • Similar Content

    • By Florencia Sylvester Anelli
      Hi everyone! I've developed a game called The Last Dog (ZOMBIES + DOGS) and was wondering if you could give it a try in order for me to analyse your behaviour in analytics. Give it a shot! Please download it here: https://florsyl.wixsite.com/thelastdog2 and let me know if you detect any bugs. VIDEO.3gp
       

       
       
    • By Manuel Berger
      Hello fellow devs!
      Once again I started working on an 2D adventure game and right now I'm doing the character-movement/animation. I'm not a big math guy and I was happy about my solution, but soon I realized that it's flawed.
      My player has 5 walking-animations, mirrored for the left side: up, upright, right, downright, down. With the atan2 function I get the angle between player and destination. To get an index from 0 to 4, I divide PI by 5 and see how many times it goes into the player-destination angle.

      In Pseudo-Code:
      angle = atan2(destination.x - player.x, destination.y - player.y) //swapped y and x to get mirrored angle around the y axis
      index = (int) (angle / (PI / 5));
      PlayAnimation(index); //0 = up, 1 = up_right, 2 = right, 3 = down_right, 4 = down

      Besides the fact that when angle is equal to PI it produces an index of 5, this works like a charm. Or at least I thought so at first. When I tested it, I realized that the up and down animation is playing more often than the others, which is pretty logical, since they have double the angle.

      What I'm trying to achieve is something like this, but with equal angles, so that up and down has the same range as all other directions.

      I can't get my head around it. Any suggestions? Is the whole approach doomed?

      Thank you in advance for any input!
       
    • By devbyskc
      Hi Everyone,
      Like most here, I'm a newbie but have been dabbling with game development for a few years. I am currently working full-time overseas and learning the craft in my spare time. It's been a long but highly rewarding adventure. Much of my time has been spent working through tutorials. In all of them, as well as my own attempts at development, I used the audio files supplied by the tutorial author, or obtained from one of the numerous sites online. I am working solo, and will be for a while, so I don't want to get too wrapped up with any one skill set. Regarding audio, the files I've found and used are good for what I was doing at the time. However I would now like to try my hand at customizing the audio more. My game engine of choice is Unity and it has an audio mixer built in that I have experimented with following their tutorials. I have obtained a great book called Game Audio Development with Unity 5.x that I am working through. Half way through the book it introduces using FMOD to supplement the Unity Audio Mixer. Later in the book, the author introduces Reaper (a very popular DAW) as an external program to compose and mix music to be integrated with Unity. I did some research on DAWs and quickly became overwhelmed. Much of what I found was geared toward professional sound engineers and sound designers. I am in no way trying or even thinking about getting to that level. All I want to be able to do is take a music file, and tweak it some to get the sound I want for my game. I've played with Audacity as well, but it didn't seem to fit the bill. So that is why I am looking at a better quality DAW. Since being solo, I am also under a budget contraint. So of all the DAW software out there, I am considering Reaper or Presonus Studio One due to their pricing. My question is, is investing the time to learn about using a DAW to tweak a sound file worth it? Are there any solo developers currently using a DAW as part of their overall workflow? If so, which one? I've also come across Fabric which is a Unity plug-in that enhances the built-in audio mixer. Would that be a better alternative?
      I know this is long, and maybe I haven't communicated well in trying to be brief. But any advice from the gurus/vets would be greatly appreciated. I've leaned so much and had a lot of fun in the process. BTW, I am also a senior citizen (I cut my programming teeth back using punch cards and Structured Basic when it first came out). If anyone needs more clarification of what I am trying to accomplish please let me know.  Thanks in advance for any assistance/advice.
    • By Yosef BenSadon
      Hi , I was considering this start up http://adshir.com/, for investment and i would like a little bit of feedback on what the developers community think about the technology.
      So far what they have is a demo that runs in real time on a Tablet at over 60FPS, it runs locally on the  integrated GPU of the i7 . They have a 20 000 triangles  dinosaur that looks impressive,  better than anything i saw on a mobile device, with reflections and shadows looking very close to what they would look in the real world. They achieved this thanks to a  new algorithm of a rendering technique called Path tracing/Ray tracing, that  is very demanding and so far it is done mostly for static images.
      From what i checked around there is no real option for real time ray tracing (60 FPS on consumer devices). There was imagination technologies that were supposed to release a chip that supports real time ray tracing, but i did not found they had a product in the market or even if the technology is finished as their last demo  i found was with a PC.  The other one is OTOY with their brigade engine that is still not released and if i understand well is more a cloud solution than in hardware solution .
      Would there  be a sizable  interest in the developers community in having such a product as a plug-in for existing game engines?  How important  is Ray tracing to the  future of high end real time graphics?
    • By bryandalo
      Good day,

      I just wanted to share our casual game that is available for android.

      Description: Fight your way from the ravenous plant monster for survival through flips. The rules are simple, drag and release your phone screen. Improve your skills and show it to your friends with the games quirky ranks. Select an array of characters using the orb you acquire throughout the game.

      Download: https://play.google.com/store/apps/details?id=com.HellmodeGames.FlipEscape&hl=en
       
      Trailer: 
       
  • Advertisement