Oh, you also didn't include any code to push your registers before you use them, and pop them when you're done (remember FILO order).
Good luck
Starfall
buffers & assembler
I suggest you use simple and more efficient code. Move 160 into ecx then simply rep movsd (keep your code to setup edi and esi first). Do this for each line. This will move 640 bytes at a time (you stil need to increment esi to right the offset after each transfer). I assume you're in 8 bit colour mode, otherwise you'll need to move twice that. I'd recommend you use (or have an option to use) the DDraw blitter though, since most graphics cards today can accelerate this sort of function and make it faster than you can do it.
Author
The buffer is located in the system area so I can't use hardware acceleration (can I?).
I was told that VC++ 6.0 automatically pops and pushes registers.
Putting the labels in the _asm{} block generates a lot of errors (maybe they must be typed differently?).
VC6 may well push and pop automatically - I use VC5. Personally I could see reasons for not wanting it to do that but I suppose there's a way to turn it off.
I've been told labels in ASM code do nasty things in Borland too, though in VC5 they work well enough for me. You shouldn't need them if you just use rep movsd though.
Though the buffer is in the system memory, you will still get system to video h/w acceleration on many modern cards (use the dx diags software to see if you can on your specific card). It's often noticeably faster than doing things yourself, so it's worth at least having the option there.
Regards
Starfall
I don't understand what you're trying
to do, but this might help.
void Copy(void *dest, const void *src, int count)
{
__asm {
mov ecx, count
mov esi, src
mov edi, dest
mov ebx, ecx
shr ecx, 2
and ebx, 3
rep movsd
mov ecx, ebx
rep movsb
}
}
to do, but this might help.
void Copy(void *dest, const void *src, int count)
{
__asm {
mov ecx, count
mov esi, src
mov edi, dest
mov ebx, ecx
shr ecx, 2
and ebx, 3
rep movsd
mov ecx, ebx
rep movsb
}
}
Author
Well, I've found the solution in 320x200 screenmode. Now see if it works with a 640x480 screen...
If you really want to do it in software, than I agree you need to use rep movsd. Also, don't use the loop instruction; EVER. It is very slow, and should be taken out of your instruction vocabulary. It takes about 5 cycles, where a dec/jnz set will pair and take only 1 cycle.
Rock
Author
I have found the solution.
For those interested here's the code:
void buffer_to_backsurface(void){
_asm{
mov ecx,76800
mov edi,backsurface
mov esi,buffer
add esi,32
xor edx,edx
};
Looper:
_asm{
inc edx
cmp edx,161
jnz Store
mov edx,1
add esi,64
};
Store:
_asm{
movsd
loop Looper
};
};
Now there is a problem. I need the pointer to the attached backsurface (I used the screen as backsurface in the code above).
Rock2000:I will look at the loop problem.
For those interested here's the code:
void buffer_to_backsurface(void){
_asm{
mov ecx,76800
mov edi,backsurface
mov esi,buffer
add esi,32
xor edx,edx
};
Looper:
_asm{
inc edx
cmp edx,161
jnz Store
mov edx,1
add esi,64
};
Store:
_asm{
movsd
loop Looper
};
};
Now there is a problem. I need the pointer to the attached backsurface (I used the screen as backsurface in the code above).
Rock2000:I will look at the loop problem.
Ok, Rock is right get 'loop' out of yer asm vocab and that now!
But you should also try to avoid string instructions that are slow as an elephant on molasses on 486 'n' upp.
clever loop unrolling can give you soo much more..
And have you considred MMX?
But you should also try to avoid string instructions that are slow as an elephant on molasses on 486 'n' upp.
clever loop unrolling can give you soo much more..
And have you considred MMX?
Author
Yes, I have got rid of the loop instruction (this topic is quite old). Dec/jnz is faster.
BTW, where can I find more about MMX? I know some instructions but these are a bit vague.
BTW, where can I find more about MMX? I know some instructions but these are a bit vague.
This topic is closed to new replies.
Advertisement
Popular Topics
Advertisement
