OpenGL C++ STL Map for vertex normals. Help?

Recommended Posts

Hello all, Am having a small problem - right now I am exporting a large scene from 3ds into opengl using the .3ds format - and this does not contain any vertex normal information so i need to calculate it myself. Before you see some code you should know my vertices (and vert normals) are organised into vector<Vector3f> where Vector3f is my own structure for a vertex. The verts are organised so that there are repeated vertex, i.e. verts 1,2,3 are for the first triangle, and 3,4,5 are for the second, but none, 1 or 2 of these vertices may in reality be the same as 1,2 or 3. I started out using an extremely extremely time consuming method as below
void calculateSharedVerts(vector<Vector3f>& verts, vector<Vector3f>& vertNormals)
{
Vector3f temp;

//here I set the intial vertex normals to that of the face normal for the face they belong to.
for(int i=0; i< verts.size(); i+=3)
{
temp.calculateNormal_2(verts[i], verts[i+1], verts[i+2]);

vertNormals.push_back(temp);
vertNormals.push_back(temp);
vertNormals.push_back(temp);
}

//Now I loop through and whenever we find a shared vertex, we add the face normals from both
for(int i=0; i< verts.size(); i++)
{

for(int j=0; j< verts.size(); j++)
{
if(i!=j)
{
if(verts[i]==verts[j])
{
vertNormals[i]+= vertNormals[j];
}
}

}
}

//normalise the results
for(int i=0; i< vertNormals.size(); i++)
{
vertNormals[i].normalise();
}
}


The above worked entirely correctly, but because of the size of my scene, even just computing these normals once and writing to a file to be read later takes hours on end and so I searched for a better way of doing it. I realised I could use the stl Map so that whenever I was addressing a shared vertex, I only needed to use that one value so no looping to find shared verts is required. Because the other definition I use for Vector3f "less than" does not meet the requirements of "strict weak ordering" I define a new comparison function vect3fCompare to use. Basically the normals are coming out far from correct and was hoping someone might be able to give me some insight into what I might be doing wrong here.
	bool vect3fCompare(Vector3f p1, Vector3f p2) {

Vector3f zero(0,0,0);

//the below SHOULD satisfy strict weak ordering, which I read was is nessecery for this to work, defined by
//1) a<a is false
//2) equality given by (!(a<b) && !(b<a)) - i.e. less than can be used to determine equality
//3) If a<b and b<c, then a<c must be true.
if(p1.distance(zero) < p2.distance(zero))
return true;

return false;
}

void addNormals(vector<Vector3f>& verts, vector<Vector3f>& vertNormals) {

map<Vector3f, Vector3f, bool(*)(Vector3f, Vector3f)> myMap(vect3fCompare);

Vector3f temp;

//calculate the face normal, and set each vert to that face normal.
for(int i=0; i< verts.size(); i+=3)
{
temp.calculateNormal_2(verts[i], verts[i+1], verts[i+2]);

vertNormals.push_back(temp);
vertNormals.push_back(temp);
vertNormals.push_back(temp);
}

Vector3f zero(0,0,0);

//fill it up with 0s.
for(int i=0; i< verts.size(); i++)
myMap[verts[i]] = zero;

//for every shared vertex, myMap will now collect all the proper face normals together to make individual vert normals.
for(int i=0; i< verts.size(); i++)
{
myMap[verts[i]] += vertNormals[i];
}

//now we loop back through, setting each vertNormal to the value calculated in the map.
for(int i=0; i< verts.size(); i++)
vertNormals[i] = myMap[verts[i]]; //addition of all verts same as verts[i]

//and finally normalise
for(int i=0; i< vertNormals.size(); i++)
{
vertNormals[i].normalise();
}
}



Share on other sites
Cross post. Closed.

Share on other sites
This topic is now closed to further replies.

• Partner Spotlight

• Forum Statistics

• Total Topics
627662
• Total Posts
2978519
• Similar Content

• Both functions are available since 3.0, and I'm currently using glMapBuffer(), which works fine.
But, I was wondering if anyone has experienced advantage in using glMapBufferRange(), which allows to specify the range of the mapped buffer. Could this be only a safety measure or does it improve performance?
Note: I'm not asking about glBufferSubData()/glBufferData. Those two are irrelevant in this case.
• By xhcao
Before using void glBindImageTexture(    GLuint unit, GLuint texture, GLint level, GLboolean layered, GLint layer, GLenum access, GLenum format), does need to make sure that texture is completeness.
• By cebugdev
hi guys,
are there any books, link online or any other resources that discusses on how to build special effects such as magic, lightning, etc. in OpenGL? i mean, yeah most of them are using particles but im looking for resources specifically on how to manipulate the particles to look like an effect that can be use for games,. i did fire particle before, and I want to learn how to do the other 'magic' as well.
Like are there one book or link(cant find in google) that atleast featured how to make different particle effects in OpenGL (or DirectX)? If there is no one stop shop for it, maybe ill just look for some tips on how to make a particle engine that is flexible enough to enable me to design different effects/magic
let me know if you guys have recommendations.
• By dud3
How do we rotate the camera around x axis 360 degrees, without having the strange effect as in my video below?
Mine behaves exactly the same way spherical coordinates would, I'm using euler angles.
Tried googling, but couldn't find a proper answer, guessing I don't know what exactly to google for, googled 'rotate 360 around x axis', got no proper answers.

References:
Code: https://pastebin.com/Hcshj3FQ
The video shows the difference between blender and my rotation:

• By Defend
I've had a Google around for this but haven't yet found some solid advice. There is a lot of "it depends", but I'm not sure on what.
My question is what's a good rule of thumb to follow when it comes to creating/using VBOs & VAOs? As in, when should I use multiple or when should I not? My understanding so far is that if I need a new VBO, then I need a new VAO. So when it comes to rendering multiple objects I can either:
* make lots of VAO/VBO pairs and flip through them to render different objects, or
* make one big VBO and jump around its memory to render different objects.
I also understand that if I need to render objects with different vertex attributes, then a new VAO is necessary in this case.
If that "it depends" really is quite variable, what's best for a beginner with OpenGL, assuming that better approaches can be learnt later with better understanding?

• 10
• 10
• 12
• 22
• 13