cout << "Deleting the " << number << " game listed.\n";listv.erase(listv.begin() + number);

//gamelist.cpp#include <iostream> #include <vector>#include <string>// Only one of the following is needed, but I'm just including both here.#include <sstream> // We'll use std::stringstream later on, so we need the header for it#include <boost/lexical_cast.hpp> // Instead of stringstream, this is easier to use, but requires you to install the boost library// using namespace std; // This pulls everything from the std namespace into your global namespace. May cause conflicts (what if some other library also defined a string type?)// You're right, globals are bad, so let's put them where they belong.//vector<string> listv; // I know that declaring a global variable, like this is bad if over used.//vector<string>::iterator iter; //and that its not good practice - I plan to rewrite this whole thing.void display(); // Nice. Most beginners just cram everything into main(). Good to see you're using functions :)// There's still quite a bit of code that could be factored out into separate functions though. (Basically, anything you end up typing more than once is a good candidate for a function. And you have a lot of code that's duplicated, but you can probably spot them yourself :))int main(){    using namespace std; // It's safer to put it here. Then we're only polluting the namespace inside this function. You may want to remove this though, and prefix vector, cout, string and all other std types with std::// So the following line would have been std::vector<std::string>. That way you can be sure to avoid name collisions. Guess I'll do this in the display function, to show you both options :)    vector<string> listv; // Uncommented. We like local variables :)    vector<string>::iterator iter; //same as above.    system("TITLE My very first - try not to laugh to hard."); // Oh, never knew you could set the title of the console window like that. Fancy...     string add;    //const int MAX_LIST = 5; // By convention, only constants are ALL_CAPS. So might as well stick a const in there as well. Then it actually *acts* like a constant too.// That said, we don't actually need it (you don't even refer to it, and I plan to get rid of this limitation anyway, so just comment it out :)// Variables should be declared as close to where they're used as possible. So lets wait a bit with them. :)//    char add_another;//    char display_list;//    char remove_game;    cout << "Welcome to the game list program" << endl; // Note, I'm adding endl instead of \n. The former flushes the stream, so you're sure it's actually printed to the screen when this executes. Otherwise it may be buffered so it'll only show up later.    cout << "You'll be able to store games on the list, and remove them!\n";    do    {         cout << "Type in the name of a game you liked to store it.\n";         cin >> add;         listv.push_back(add);         system("CLS");         cout << "GAME SAVED TO LIST!\n";         cout << "Would you like to add another game to the list?[Y or N]" << endl;         char add_another; // Declare the variable here, where it's used.         cin >> add_another;    }while((add_another == 'Y') || (add_another == 'y'));        cout << "Would you like to see your list of games?[Y or N]\n";    char display_list; // Declare the variable here, where it's used.    cin >> display_list;    if (display_list == 'y' || display_list == 'Y')    {                     system("CLS");                     display(listv); // Here comes the magic bit. Pass the vector listv to the display function. That's all there is to it. :)                     }    cout << "Now that you've got a list - would you like to remove any games?[Y or N]\n";    char remove_game; // Declare the variable here, where it's used.    cin >> remove_game;    do    {                      //char number; // we need a string, not a char, because the user might type in big numbers that are more than one character                      string number;                      system("CLS");                      cout << "Which game would you like to remove?\n";                      for (int i = 0; i < listv.size(); ++i) { // Note the brackets. You don't *need* them when you only want to execute one line in the loop, but having them makes it clearer where the loop starts and ends (and saves you a lot of headaches if you later add more code to the loop, while forgetting to add brackets)                      cout << i << ": " << listv << endl; // I just made it print out the index as well, to make it easier for the user}                      cout << "Enter a number for the game that wasn't a good favorite\n";                      cout << "If you are done removing games, type [done]\n";                      cin >> number;                                      // Instead of the switch, you should get rid of the constant size limitation on your list, and simply parse the number entered by the user.                     // If you have the boost library installed (hint: Good idea. It can probably wait a few weeks though ;)), you can simply do this:                    int n = boost::static_cast<int>(number); // This doesn't take into account that the user might enter something that isn't a valid number because I'm lazy                     // Without boost, you'd do this instead:                     std::stringstream str(number);                     int n;                     str >> n; // Again, no error checking here, cos I'm lazy                    if (n > 0 && n < vlist.size()){ // Check that the number entered is greater than 0, and no bigger than the number of elements in the list                       listv.erase(listv.begin() + n);                    }                   cout << "Would you like to remove another?[Y or N]\n";                   cin >> add_another;    }while((add_another == 'Y') || (add_another == 'y'));             cout << "Here is a list of your finished favorites!\n";    display(listv);                                        //    system("pause"); // Is generally a bad idea (the user normally doesn't want the program to wait for him to press a key when exiting. While developing, you should just put a breakpoint here (which means you'll have to learn to use the debugger, and until you do that, there's no great harm in keeping this line of code. Just remember that it's only for development purposes. Once the application "ships", remove it to avoid driving your users mad... They paid for your program, after all, don't annoy them ;)    return 0;}void display(const std::vector<std::string>& listv) // And the other half of the magic. Without the &, it would simply receive a copy of the listv from the main function (so changes you made in this function wouldn't be saved No big deal, since you don't make any changes here. But & means it'll be given a reference to the original list instead (which is nicer all around, as it doesn't have to copy the list then). Note that it's const though, to indicate that you (the display function) promise not to make changes to the list. So combined, it means you're working on a reference to the original list (instead of a copy of the list), and you see the list as a constant, so you'll get errors if you try to modify it.{     std::cout << "Your current list!" << std::endl;     for (int i = 0; i < std::listv.size(); ++i) { // Again, I like {}'s around the loop body :)         std::cout << listv << std::endl;     }}