• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
_ArmuT_

use of class template requires template argument list

7 posts in this topic

Hi people, Recently I bought Ron Penton's Data Structure's book (unfortonutally it has no cd, if anybody has a link, I appreciate .. ) and began reading the first chapter which introduces the arrays. I try to test the aray class he was explaining in the book but my compiler keep telling me that my class template requires the argument list ? which according to my very limited knowledge, includes. Would somebody please tell me what I was doing wrong? BTW, I am using Visual Studio 2005 and trying to compile this code as a console application. Thanks all. Array.h
#pragma once

template <class DataType> 

class Array
{
public:
	Array(int p_size);
	DataType* m_array;
	int m_size;
public:
	~Array(void);
};
Array.cpp
#include "StdAfx.h"
#include "Array.h"

Array::Array(int p_size)
{
	m_array = new DataType[p_size];
	m_size = p_size;
}

Array::~Array(void)
{
	if (m_array !=0) delete[] m_array;
	m_array=0;
}
main.cpp
#include "stdafx.h"
#include "Array.h"


int _tmain(int argc, _TCHAR* argv[])
{
        Array <int> intArray(10);
	

	return 0;
}

0

Share this post


Link to post
Share on other sites
AFAIK, the template argument list must also be included in the function definition, e.g.:
template <class DataType>
Array<DataType>::Array(int p_size)
{
m_array = new DataType[p_size];
m_size = p_size;
}
There are a couple of other funky things about that code that I'll mention:

1. Public member data (which doesn't seem like it ought to be public)
2. No use of initializer lists
3. Unnecessary check for null in the destructor
4. Unnecessary assignment of null in the destructor
0

Share this post


Link to post
Share on other sites
When coding templated classes, the whole template definition (including the implementation of member functions) must be in the header file, so forget .cpp files. This is needed as the code from a template must be available to every module which uses it.

EDIT :

// Array.h

#pragma once // Microsoft-specific

template <class DataType>
class Array
{
public:
// You might prefer "unsigned int" or better, "size_t" to your "int"
Array(int p_size)
{
// What if p_size <= 0?
m_array = new DataType[p_size];
m_size = p_size;
}

// Information hiding anyone?
// What if I decide to modify those?
DataType* m_array;
int m_size;
public:
~Array(void)
{
// Why do this test? your constructor ALWAYS allocates memory.
if (m_array !=0) delete[] m_array;
// Unnecessary, the object is to be obliterated from your ram in a nanosecond
m_array=0;
}

// Copy constructor anyone?
// Assignment operator overloading anyone?
};





Sorry for the little comments, I couldn't stop me. And remember that the stl has an implementation of what you're doing called "std::vector" which can only be superior to yours =). But of course if it's only for learning purposes...

[Edited by - Trillian on November 19, 2007 8:38:51 PM]
0

Share this post


Link to post
Share on other sites
Thank you guys : ) I understand it now.

One question though, isn't it always a good practice to assign a pointer
to null after we are finished with it whether it is necessary or not ?
0

Share this post


Link to post
Share on other sites
Quote:
Original post by jyk
AFAIK, the template argument list must also be included in the function definition, e.g.:
template <class DataType>
Array<DataType>::Array(int p_size)
{
m_array = new DataType[p_size];
m_size = p_size;
}


That is correct.
0

Share this post


Link to post
Share on other sites
Quote:
Original post by jyk
AFAIK, the template argument list must also be included in the function definition, e.g.:
template <class DataType>
Array<DataType>::Array(int p_size)
{
m_array = new DataType[p_size];
m_size = p_size;
}
There are a couple of other funky things about that code that I'll mention:

1. Public member data (which doesn't seem like it ought to be public)
2. No use of initializer lists
3. Unnecessary check for null in the destructor
4. Unnecessary assignment of null in the destructor



MSDN:

If unsuccessful, new returns zero or throws an exception; see The new and delete Operators for more information. You can change this default behavior by writing a custom exception-handling routine and calling the _set_new_handler run-time library function with your function name as its argument.

What if the new call is unsuccessfull ? Isn't that makes the use of null check at the destructor necessary ?
0

Share this post


Link to post
Share on other sites
Quote:
Original post by _ArmuT_
What if the new call is unsuccessfull ? Isn't that makes the use of null check at the destructor necessary ?


You should be doing the null checking in your constructor if anywhere.
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0