Sign in to follow this  
JackNJ

OpenGL Yet another per-pixel ligthing question (Cg)

Recommended Posts

JackNJ    122
I realize this is a common topic, my apologies for bringing this up again. I've been trying to move my lighting from object-space to eye-space, my problem is that my diffuse ligthing is not constant when rotating around a given object: I expect the diffuse light to not change when doing this. I assume this is correct, seeing how diffuse is not dependent on eye position. In the code below my ambient/specular lighting has been commented out. VP: // data from application to vertex program struct vertexIn { float4 Position : POSITION; float4 Normal : NORMAL; }; // vertex shader to pixel shader struct vertexOut { float4 HPosition : POSITION; float4 EyeNormal : TEXCOORD2; float4 PosEye : TEXCOORD3; }; // vertex shader vertexOut main(vertexIn IN) { vertexOut OUT; float4x4 ModelView = glstate.matrix.modelview[0]; float4x4 ModelViewIT = glstate.matrix.invtrans.modelview[0]; float4x4 ModelViewProj = glstate.matrix.mvp; // normal in eye coords OUT.EyeNormal.xyz = normalize(mul((float3x3)ModelViewIT, IN.Normal.xyz)); // pos in eye coords OUT.PosEye = mul(ModelView, IN.Position); // pos in clip coords OUT.HPosition = mul(ModelViewProj, IN.Position); return OUT; } FP: // data from vertex shader struct vertexOut { float4 HPosition : POSITION; float4 EyeNormal : TEXCOORD2; float4 PosEye : TEXCOORD3; }; // output from pixel shader struct pixelOut { float4 Color : COLOR0; }; // input from application struct pixelAppData { float4 lightColor; float materialShininess; float4 materialAmbient; float4 materialDiffuse; float4 materialSpecular; }; pixelOut main(vertexOut IN, uniform pixelAppData AppIn) { pixelOut OUT; float3 N = normalize(IN.EyeNormal.xyz); float4 lightPosEye = glstate.light[0].position; float3 L = normalize((lightPosEye - IN.PosEye).xyz); // not used atm float3 V = normalize(-IN.PosEye).xyz; // eye's position is always 0,0,0 in eye space // not used atm float3 H = normalize(L+V); float4 lightCoffs = lit(dot(N,L), dot(N,H), AppIn.materialShininess); // OUT.Color = AppIn.materialAmbient * lightCoffs[0]; OUT.Color = AppIn.lightColor * AppIn.materialDiffuse * lightCoffs[1]; // OUT.Color += AppIn.lightColor * AppIn.materialSpecular * lightCoffs[2]; return OUT; } My assumption is that the light position is somehow not correctly transformed into eye-space, however I'm using glLightfv(GL_LIGHT0, GL_POSITION, ..) to do this and according to my OpenGL manual this position given is automatically transfered into eye-space. Any help is appreciated.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Similar Content

    • By povilaslt2
      Hello. I'm Programmer who is in search of 2D game project who preferably uses OpenGL and C++. You can see my projects in GitHub. Project genre doesn't matter (except MMO's :D).
    • By ZeldaFan555
      Hello, My name is Matt. I am a programmer. I mostly use Java, but can use C++ and various other languages. I'm looking for someone to partner up with for random projects, preferably using OpenGL, though I'd be open to just about anything. If you're interested you can contact me on Skype or on here, thank you!
      Skype: Mangodoor408
    • By tyhender
      Hello, my name is Mark. I'm hobby programmer. 
      So recently,I thought that it's good idea to find people to create a full 3D engine. I'm looking for people experienced in scripting 3D shaders and implementing physics into engine(game)(we are going to use the React physics engine). 
      And,ye,no money =D I'm just looking for hobbyists that will be proud of their work. If engine(or game) will have financial succes,well,then maybe =D
      Sorry for late replies.
      I mostly give more information when people PM me,but this post is REALLY short,even for me =D
      So here's few more points:
      Engine will use openGL and SDL for graphics. It will use React3D physics library for physics simulation. Engine(most probably,atleast for the first part) won't have graphical fron-end,it will be a framework . I think final engine should be enough to set up an FPS in a couple of minutes. A bit about my self:
      I've been programming for 7 years total. I learned very slowly it as "secondary interesting thing" for like 3 years, but then began to script more seriously.  My primary language is C++,which we are going to use for the engine. Yes,I did 3D graphics with physics simulation before. No, my portfolio isn't very impressive. I'm working on that No,I wasn't employed officially. If anybody need to know more PM me. 
       
    • By Zaphyk
      I am developing my engine using the OpenGL 3.3 compatibility profile. It runs as expected on my NVIDIA card and on my Intel Card however when I tried it on an AMD setup it ran 3 times worse than on the other setups. Could this be a AMD driver thing or is this probably a problem with my OGL code? Could a different code standard create such bad performance?
    • By Kjell Andersson
      I'm trying to get some legacy OpenGL code to run with a shader pipeline,
      The legacy code uses glVertexPointer(), glColorPointer(), glNormalPointer() and glTexCoordPointer() to supply the vertex information.
      I know that it should be using setVertexAttribPointer() etc to clearly define the layout but that is not an option right now since the legacy code can't be modified to that extent.
      I've got a version 330 vertex shader to somewhat work:
      #version 330 uniform mat4 osg_ModelViewProjectionMatrix; uniform mat4 osg_ModelViewMatrix; layout(location = 0) in vec4 Vertex; layout(location = 2) in vec4 Normal; // Velocity layout(location = 3) in vec3 TexCoord; // TODO: is this the right layout location? out VertexData { vec4 color; vec3 velocity; float size; } VertexOut; void main(void) { vec4 p0 = Vertex; vec4 p1 = Vertex + vec4(Normal.x, Normal.y, Normal.z, 0.0f); vec3 velocity = (osg_ModelViewProjectionMatrix * p1 - osg_ModelViewProjectionMatrix * p0).xyz; VertexOut.velocity = velocity; VertexOut.size = TexCoord.y; gl_Position = osg_ModelViewMatrix * Vertex; } What works is the Vertex and Normal information that the legacy C++ OpenGL code seem to provide in layout location 0 and 2. This is fine.
      What I'm not getting to work is the TexCoord information that is supplied by a glTexCoordPointer() call in C++.
      Question:
      What layout location is the old standard pipeline using for glTexCoordPointer()? Or is this undefined?
       
      Side note: I'm trying to get an OpenSceneGraph 3.4.0 particle system to use custom vertex, geometry and fragment shaders for rendering the particles.
  • Popular Now