Jump to content
  • Advertisement
Sign in to follow this  
Gage64

Unity Divide by zero - not an error?

This topic is 3807 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

I asked this as part of another post (here), but for this particular problem, I think I'm more likely to get answers here. I wrote some code that might occasionally divide by zero, but I only realized it after I wrote it. I then stepped through it with a debugger, and whenever a float was divided by zero, the result was something like 1.INF. In that particular code it doesn't seem to be a problem because those numbers are apparently not used (the numbers represent clip-space (and then screen-space) coordinates which are later clipped), but is it safe to do any calculations with these numbers? Am I just getting lucky?

Share this post


Link to post
Share on other sites
Advertisement
It's safe in the sense that your program will not die as a result of this. However, using these values will eliminate any hope of numerical stability in your program, so you should either make sure they don't appear, or design your program so that these values are correctly handled when they appear.

Share this post


Link to post
Share on other sites
Quote:
Original post by ToohrVyk
using these values will eliminate any hope of numerical stability in your program


I don't know if that part of the code needs numerical stability, but hopefully that will be answered in my other post.

Quote:
Original post by Evil Steve
I've also seen some pretty severe performance problems from using those "special" floating point values.


Could you please give some examples or point me to a resource that discusses this?

Thanks for the help so far.

Share this post


Link to post
Share on other sites
Quote:
Original post by Gage64
I wrote some code that might occasionally divide by zero, but I only realized it after I wrote it.


Might we see the code in question?

Share this post


Link to post
Share on other sites
Here is one such article, though it's rather old.

Unless you have floating point exceptions enabled (off by default) for division by zero, you will not get a fault as you would with integer division. You just get infinities, as you've observed.

Share this post


Link to post
Share on other sites
Quote:
Original post by Gage64
Quote:
Original post by Evil Steve
I've also seen some pretty severe performance problems from using those "special" floating point values.


Could you please give some examples or point me to a resource that discusses this?
I don't have any resources really, I had some raytracing code that wasn't working correctly and causing divisions by zero. That code took 4 times longer to run than the code that was correct and didn't cause division by zero (Although the code complexity was pretty much identical). This is probably an extreme case though, since I was doing thousands and thousands of floating point calculations.
I assume it's throwing floating point exceptions, and I know you can turn them off, but I never got around to testing that.

Share this post


Link to post
Share on other sites
Quote:
Original post by Zahlman
Might we see the code in question?


Here it is:


Vector2 project(const Vector3 &p) {
// Perspective projection
float x = p.x * distanceToCamera / (p.z * aspectRatio);
float y = p.y * distanceToCamera / p.z;

// Viewport mapping
int w2 = width / 2;
int h2 = height / 2;
return Vector2(x * w2 + w2, -y * h2 + h2);
}



This function takes a vertex in view space and projects it to screen space (it's part of a software renderer I'm working on).

Initially I didn't do any clipping to the near clipping plane (but I did do clipping in screen space). When an object moved behind the camera, I sometimes got inverted projections (because of the division by negative Z), and sometimes the program crashed, but I thought the crashes were normal because they were caused by a division by zero. When I added clipping to the near clipping plane, everything worked normally.

However, in my renderer, I calculate the view-space and screen-space positions before doing any clipping (I am basing the architecture of my renderer on this article), so I realized that I can still get a division by zero, but the crashes stopped. Now that I think about it, I don't know what was causing them (I don't have the old version of the code so I can't check).

The article doesn't say anything about this either. Maybe I should send the author an e-mail...

So I'm basically wondering if this will cause a problem, either with performance or with program correctness in general. If you need to see more code, let me know.

Share this post


Link to post
Share on other sites
Be careful with this, though.

On a technical c++ note, the result of divide by zero is undefined behavior. Specifically:
Quote:
If during the evaluation of an expression, the result is not mathematically defined or not in the range of representable values for its type, the behavior is undefined, unless such an expression is a constant expression (5.19), in which case the program is ill-formed.
[Note: most existing implementations of C++ ignore integer overflows. Treatment of division by zero, forming a remainder using a zero divisor, and all floating point exceptions vary among machines, and is usually adjustable by a library function. ]


In other words:

Your implementation *may* give you an INF.
Your implementation *may* give you an NAN.
Your implementation *may* throw an exception.
Your implementation *may* let you adjust the behavior using library functions.
Your implementation *may* yield "3" (or any other number) and carry on like nothing happened.
Your implementation *may* have different results every time you run it.
Your implementation *may* have different results in different builds.
Your implementation *may* call abort() or terminate().
Your implementation *may* crash the machine.

Any code you write that depends on the behavior of your particular compiler and/or chipset, and is non-portable.


In this case, you can let the floating point exception happen, and take the appropriate performance penalty of 1.INF computations. But it is NOT a portable behavior, it isn't guaranteed to work in the future or on other compilers, and it is NOT a "correct" program (as you mentioned in the post above.)

Share this post


Link to post
Share on other sites
Quote:
Original post by frob
...


Well that's exactly what I was afraid of. I could check for a divide by zero, but that will cause a severe performance penalty and some of the benefits mentioned in that article (like the division by Z occurring simultaneously with the transformation) will probably disappear.

What bothers me the most is that the article doesn't say anything about this. I can certainly believe the author might rely on non-portable behavior, but in that case I think he should at least give a warning.

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Tags

  • Similar Content

    • By D34DPOOL
      Edit Your Profile D34DPOOL 0 Threads 0 Updates 0 Messages Network Mod DB GameFront Sign Out Add jobEdit jobDeleteC# Programmer for a Unity FPS at Anywhere   Programmers located Anywhere.
      Posted by D34DPOOL on May 20th, 2018
      Hello, my name is Mason, and I've been working on a Quake style arena shooter about destroying boxes on and off for about a year now. I have a proof of concept with all of the basic features, but as an artist with little programming skill I've reached the end of my abilities as a programmer haha. I need someone to help fix bugs, optomize code, and to implent new features into the game. As a programmer you will have creative freedom to suggest new features and modes to add into the game if you choose to, I'm usually very open to suggestions :).
      What is required:
      Skill using C#
      Experience with Unity
      Experience using UNET (since it is a multiplayer game), or the effort and ability to learn it
      Compensation:
      Since the game currently has no funding, we can split whatever revenue the game makes in the future. However if you would perfer I can create 2D and/or 3D assets for whatever you need in return for your time and work.
      It's a very open and chill enviornment, where you'll have relative creative freedom. I hope you are interested in joining the team, and have a good day!
       
      To apply email me at mangemason@yahoo.com
    • By davejones
      Is there a way to automatically change the start position of an animation? I have a bunch of animations set up on 3D models in unity. The issue is that I need to move the 3D models, however when I do so the animation start positions are not updated and I have to do it manually.

      Changing the transform of key frames is time consuming with the amount of animations I have, so I was wondering if there was a way to do it automatically?
    • By MoreLion
      hey all! We are looking for members for our Unity horror game! 
      Here’s the story:
      After a deadly virus plunges the world into chaos killing 85% of the human population there are now what they call “zones” these zones are watched very closely by the surviving government, people are checked every day for the virus, even if you touch the spit or any human waste or fluids of the victim who is infected, you will die. But one day, people in the west zone start to go missing, 1 woman goes outside the walls to uncover the mystery, is there more to the virus than meets the eye?, That is where your story starts.
      This game is not a long development game, I have loads other game ideas,
      I will also allow you to have a bit of creative freedom if you wish to add or share a idea!
      And no, it’s not a zombie game lol I feel like zombie games are too generic, in this game you will encounter terrifying beasts!
      There is some concept art one of our concept artists have made
      If interested email liondude12@gmail.com
    • By Canadian Map Makers
      GOVERNOR is a modernized version of the highly popular series of “Caesar” games. Our small team has already developed maps, written specifications, acquired music and performed the historical research needed to create a good base for the programming part of the project.

      Our ultimate goal is to create a world class multi-level strategic city building game, but to start with we would like to create some of the simpler modules to demonstrate proof of concept and graphical elegance.

       

      We would like programmers and graphical artists to come onboard to (initially) create:

      A module where Province wide infrastructure can be built on an interactive 3D map of one of the ancient Roman Provinces.
      A module where city infrastructure can be built on a real 3D interactive landscape.
      For both parts, geographically and historically accurate base maps will be prepared by our team cartographer. Graphics development will be using Blender. The game engine will be Unity.

       

      More information, and examples of the work carried out so far can be found at http://playgovernor.com/ (most of the interesting content is under the Encyclopedia tab).

       

      This project represents a good opportunity for upcoming programmers and 3D modeling artists to develop something for their portfolios in a relatively short time span, working closely with one of Canada’s leading cartographers. There is also the possibility of being involved in this project to the point of a finished game and commercial success! Above all, this is a fun project to work on.

       

      Best regards,

      Steve Chapman (Canadian Map Makers)

       
    • By Scouting Ninja
      So I have hundreds of moving objects that need to check there speed. One of the reasons they need to check there speed is so they don't accelerate into oblivion, as more and more force is added to each object.
      At first I was just using the Unity vector3.magnitude. However this is actually very slow; when used hundreds of times.
      Next I tried the dot-product check:  vector3.dot(this.transform.foward, ShipBody.velocity) The performance boost was fantastic. However this only measures speed in the forward direction. Resulting in bouncing objects accelerating way past the allowed limit.
       
      I am hoping someone else knows a good way for me to check the speed with accuracy, that is fast on the CPU. Or just any magnitude calculations that I can test when I get home later.
       
      What if I used  vector3.dot(ShipBody.velocity.normalized, ShipBody.velocity)?
      How slow is it to normalize a vector, compared to asking it's magnitude?
    • By Ds ds
      Hi, my name is Andres, I'm a programmer with a technician degree and a Diploma in C#, looking for a project in Unity to start my career in game development. I don't do it for a paid but a recognition and start a portfolio, preferably a 2D game. Thanks for read, have a nice day. 
       
    • By Victor Rodriguez
      Hi there! Is the first time that I'm posting here so I'm sorry if I'm doing it wrong ha. 
      So here it comes, my doubt is, I'm doing a game with different levels, each of these levels in one different scene. Each scene contains to cameras that you can change pressing a button. Everything works fine. 
      The only problem is that I would like it to look a bit more professional, and I would like that if you finish the level with camera2, the next level start the same way. I've been thinking about using dontdestroyonloadon both cameras, but obviously this cameras need to be attached to the player to make the movement work, what do you recommend? Sorry If I've explained it in a messy way, and feel free to dm me for anything. Thanks in advance! 
    • By Ike aka Dk
      Hello everyone 
      I am a programmer from Baku.
      I need a 3D Modeller for my shooter project in unity.I have 2 years Unity exp.
      Project will paid when we finish the work 
      If you interested write me on email:
      mr.danilo911@gmail.com
    • By markoal
      Hi,
      I'm Unity developer from Croatia and I'm looking to work on the paid project in my spare time.
      I have 5+ years of experience in Unity and I'm familiar with almost anything, including all platforms (also Switch, PS4 and Xbox).
      Feel free to contact me.
    • By bartekm777
      Hello
      About me
      Lvl 28   Programmer (day job: non-gamedev-programmer, making games as a hobby for about 2 years) Some vector art experience - tried to make some assets on my own using vector software and scripts   Some design experience (designing my own games ) About game
      Turn-based fantasy rpg inspired by games like Heroes 3 (also WoG mod), NEO Scavenger, Battle Brothers I would like to create easy to use editor for creating custom scenarios (similar to the one from Heroes 3) World and story are clean slate, I did some drafts but I'm not good at it so it's possibly subject to change I decided to create graphics using vector software + scripts to make it faster (rpg's tend to have lots of assets), also it's more precise and easier to create tileable graphics (for example: rivers, paths) No sound/music work has been done yet Who do I look for?
      Definitely someone with 2d art skills  I would like to focus more on programming 2D animator (skletal animations are preferred) Additional programmer could make development faster Someone for creating sounds/music/both It's a hobby project, I work on it in my free time. In case the project make it to the finish line and get shipped  - I can offer rev-share  
      Below should be few screens of what I already did (about 2 months of work) - some graphics, editor prototype screenshot and game prototype screenshot




  • Advertisement
  • Popular Now

  • Forum Statistics

    • Total Topics
      631354
    • Total Posts
      2999492
×

Important Information

By using GameDev.net, you agree to our community Guidelines, Terms of Use, and Privacy Policy.

Participate in the game development conversation and more when you create an account on GameDev.net!

Sign me up!