Sign in to follow this  
MindWipe

OpenGL Multitexturing problems

Recommended Posts

MindWipe    940
Hello again. I did google and check old GDnet threads about this issue, but I can't seem to find what I'm doing wrong. So I want to blend topics together to make this anaglyph 3d (blue/red), but first I just wanted to blend the two pics over each other before I'll do anything fancy to it. But I'm having a problem getting my shader to see both textures. Here's my rendering code:
Gl.glClear(Gl.GL_COLOR_BUFFER_BIT | Gl.GL_DEPTH_BUFFER_BIT);
Gl.glDisable(Gl.GL_DEPTH_TEST);
Gl.glUseProgram(p4);

Gl.glActiveTexture(Gl.GL_TEXTURE0);
Gl.glEnable(Gl.GL_TEXTURE_2D);
Gl.glBindTexture(Gl.GL_TEXTURE_2D, leftEye);

Gl.glActiveTexture(Gl.GL_TEXTURE1);
Gl.glEnable(Gl.GL_TEXTURE_2D);
Gl.glBindTexture(Gl.GL_TEXTURE_2D, rightEye);

orthoView(openGLControl.Width, openGLControl.Height);
Gl.glLoadIdentity();

Helper.RenderTexturedQuad2D(new Vector3D(0, 2048, 0), new Vector3D(2048, 0, 0.0f), new Vector3D(0.0f, 0.0f, 1.0f));

And here's my simple shader

uniform sampler2D left;
uniform sampler2D right;
	
void main()
{
	vec4 leftColor = texture2D(left,gl_TexCoord[0].st);
	vec4 rightColor = texture2D(right,gl_TexCoord[0].st);
	
	gl_FragColor = leftColor * 0.5 + rightColor * 0.5;
}


The shader apparently only sees texture0, so both the left & right sampler2d equals that texture. Ideas? /MindWipe

Share this post


Link to post
Share on other sites
purpledog    163
You need to bind the uniform to the active texture as well.

A texture is bound to a "sampler" (I'm not sure of the terminology here), and the sampler is bound to a uniform... And you missing the last step.

In your example, it's going to be something like:
glUniform(locationLeft,0);
glUniform(locationRight,1);

You can get the location using glGetUniformLocation.

Just to make things double clear, you are actually playing with 3 numbers here:
- the texId
- the active texture (or sampler)
- the uniform location
And you "just" need to bind them all (in the darkness if you wish)


edit: replaced glGetAttribLocation by glGetUniformLocation.

[Edited by - purpledog on April 22, 2008 9:11:21 AM]

Share this post


Link to post
Share on other sites
_the_phantom_    11250
purpledog pretty much has it covered, there is just one thing I want to add and that is that you don't need to call "Gl.glEnable(Gl.GL_TEXTURE_2D);" when using shaders; texture are implicately enabled by the act of sampling from them in a shader.

Share this post


Link to post
Share on other sites
MindWipe    940
Quote:
Original post by purpledog
You need to bind the uniform to the active texture as well.

A texture is bound to a "sampler" (I'm not sure of the terminology here), and the sampler is bound to a uniform... And you missing the last step.

In your example, it's going to be something like:
glUniform(locationLeft,0);
glUniform(locationRight,1);

You can get the location using glGetAttribLocation.

Just to make things double clear, you are actually playing with 3 numbers here:
- the texId
- the active texture (or sampler)
- the uniform location
And you "just" need to bind them all (in the darkness if you wish)



I see, thanks for the info. But... it's not working. Shouldn't:

Gl.glActiveTexture(Gl.GL_TEXTURE0);
Gl.glEnable(Gl.GL_TEXTURE_2D);
Gl.glBindTexture(Gl.GL_TEXTURE_2D, leftEye);
Gl.glUniform1i(Gl.glGetAttribLocation(p4, "left"), 0);

Gl.glActiveTexture(Gl.GL_TEXTURE1);
Gl.glEnable(Gl.GL_TEXTURE_2D);
Gl.glBindTexture(Gl.GL_TEXTURE_2D, rightEye);
Gl.glUniform1i(Gl.glGetAttribLocation(p4, "right"), 1);

do it?

/MindWipe

Share this post


Link to post
Share on other sites
ndhb    246

The problem is that you need to specify the samplers from OpenGL. In your shading code, sampler is just a variable (a uniform variable which you can assign from OpenGL).

Before sampling can take place you have to initialize each sampler variable. You do this with glUniform1i function call. The parameters to this function call are, first, the location of the uniform variable in your GLSL code (e.g. the uniform location of "left" or "right") and secondly the texture unit identifier (e.g. 0 for GL_TEXTURE0) - it is important to realize it is NOT the OpenGL texture ID you use for the sampler variable, it is the Texture Unit to which the texture is bound (common mistake).

When you have linked the program you can retrieve the location of each uniform variable with the function call glGetUniformLocation. Note that this retrieves only active uniforms - an active uniform can be thought of as one whose value actually contributes to the output of each shader. Note that the compiler may strip uniforms if they are not deemed active then you will have a problem (an opengl error) when you try to access the uniform with the (invalid) location (also common mistake).

I suggest you retrieve all active uniforms and their location in some data structure (e.g. hashmap) after you have linked your problem successfully. Each time you need to change a uniform, you look up the location in this data structure.

Lets assume you have found the location of each active uniform. Whenever your problem is enabled, you can use function calls like glUniform1i(uniformLocationForLeft, 0) and glUniform1i(uniformLocationForRight, 1) to make your program work. The values for the uniforms stay until the program is relinked (i.e. you do not have to set them ever frame, only when you want them to change).

I recommend the book OpenGL Shading Language (so-called Orange Book) or look at Lighthouse3D tutorials on GLSL (http://www.lighthouse3d.com/opengl/glsl/).

kind regards,
Nicolai

Edited by ndhb

Share this post


Link to post
Share on other sites
ndhb    246
Wups, I see now others have already helped - but look at glGetUniformLocation (see above post) instead of glGetAttribLocation :)

Share this post


Link to post
Share on other sites
MindWipe    940
Quote:
Original post by ndhb
The problem is that you need to specify the samplers from OpenGL. In your shading code, sampler is just a variable (a uniform variable which you can assign from OpenGL).

Before sampling can take place you have to initialize each sampler variable. You do this with glUniform1i function call. The parameters to this function call are, first, the location of the uniform variable in your GLSL code (e.g. the uniform location of "left" or "right") and secondly the texture unit identifier (e.g. 0 for GL_TEXTURE0) - it is important to realize it is NOT the OpenGL texture ID you use for the sampler variable, it is the Texture Unit to which the texture is bound (common mistake).

When you have linked the program you can retrieve the location of each uniform variable with the function call glGetUniformLocation. Note that this retrieves only active uniforms - an active uniform can be thought of as one whose value actually contributes to the output of each shader. Note that the compiler may strip uniforms if they are not deemed active then you will have a problem (an opengl error) when you try to access the uniform with the (invalid) location (also common mistake).

I suggest you retrieve all active uniforms and their location in some data structure (e.g. hashmap) after you have linked your problem successfully. Each time you need to change a uniform, you look up the location in this data structure.

Lets assume you have found the location of each active uniform. Whenever your problem is enabled, you can use function calls like glUniform1i(uniformLocationForLeft, 0) and glUniform1i(uniformLocationForRight, 1) to make your program work. The values for the uniforms stay until the program is relinked (i.e. you do not have to set them ever frame, only when you want them to change).

I recommend the book OpenGL Shading Language (so-called Orange Book) or look at Lighthouse3D tutorials on GLSL (http://www.lighthouse3d.com/opengl/glsl/).

kind regards,
Nicolai de Haan Brøgger



Thanks for an awesome explanation!!

Apparently glGetAttribLocation returns -1 for both left and right so I guess I'll have to findout why.

/MindWipe

Share this post


Link to post
Share on other sites
MindWipe    940
Quote:
Original post by ndhb
Wups, I see now others have already helped - but look at glGetUniformLocation (see above post) instead of glGetAttribLocation :)


Oh! Right! Awesome! Now it works!

Super thanks to all of you!

Share this post


Link to post
Share on other sites
purpledog    163
Quote:
Original post by ndhb
Wups, I see now others have already helped - but look at glGetUniformLocation (see above post) instead of glGetAttribLocation :)


Aouch, sorry for that, my mistake!

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Similar Content

    • By pseudomarvin
      I assumed that if a shader is computationally expensive then the execution is just slower. But running the following GLSL FS instead just crashes
      void main() { float x = 0; float y = 0; int sum = 0; for (float x = 0; x < 10; x += 0.00005) { for (float y = 0; y < 10; y += 0.00005) { sum++; } } fragColor = vec4(1, 1, 1 , 1.0); } with unhandled exception in nvoglv32.dll. Are there any hard limits on the number of steps/time that a shader can take before it is shut down? I was thinking about implementing some time intensive computation in shaders where it would take on the order of seconds to compute a frame, is that possible? Thanks.
    • By Arulbabu Donbosco
      There are studios selling applications which is just copying any 3Dgraphic content and regenerating into another new window. especially for CAVE Virtual reality experience. so that the user opens REvite or CAD or any other 3D applications and opens a model. then when the user selects the rendered window the VR application copies the 3D model information from the OpenGL window. 
      I got the clue that the VR application replaces the windows opengl32.dll file. how this is possible ... how can we copy the 3d content from the current OpenGL window.
      anyone, please help me .. how to go further... to create an application like VR CAVE. 
       
      Thanks
    • By cebugdev
      hi all,

      i am trying to build an OpenGL 2D GUI system, (yeah yeah, i know i should not be re inventing the wheel, but this is for educational and some other purpose only),
      i have built GUI system before using 2D systems such as that of HTML/JS canvas, but in 2D system, i can directly match a mouse coordinates to the actual graphic coordinates with additional computation for screen size/ratio/scale ofcourse.
      now i want to port it to OpenGL, i know that to render a 2D object in OpenGL we specify coordiantes in Clip space or use the orthographic projection, now heres what i need help about.
      1. what is the right way of rendering the GUI? is it thru drawing in clip space or switching to ortho projection?
      2. from screen coordinates (top left is 0,0 nd bottom right is width height), how can i map the mouse coordinates to OpenGL 2D so that mouse events such as button click works? In consideration ofcourse to the current screen/size dimension.
      3. when let say if the screen size/dimension is different, how to handle this? in my previous javascript 2D engine using canvas, i just have my working coordinates and then just perform the bitblk or copying my working canvas to screen canvas and scale the mouse coordinates from there, in OpenGL how to work on a multiple screen sizes (more like an OpenGL ES question).
      lastly, if you guys know any books, resources, links or tutorials that handle or discuss this, i found one with marekknows opengl game engine website but its not free,
      Just let me know. Did not have any luck finding resource in google for writing our own OpenGL GUI framework.
      IF there are no any available online, just let me know, what things do i need to look into for OpenGL and i will study them one by one to make it work.
      thank you, and looking forward to positive replies.
    • By fllwr0491
      I have a few beginner questions about tesselation that I really have no clue.
      The opengl wiki doesn't seem to talk anything about the details.
       
      What is the relationship between TCS layout out and TES layout in?
      How does the tesselator know how control points are organized?
          e.g. If TES input requests triangles, but TCS can output N vertices.
             What happens in this case?
      In this article,
      http://www.informit.com/articles/article.aspx?p=2120983
      the isoline example TCS out=4, but TES in=isoline.
      And gl_TessCoord is only a single one.
      So which ones are the control points?
      How are tesselator building primitives?
    • By Orella
      I've been developing a 2D Engine using SFML + ImGui.
      Here you can see an image
      The editor is rendered using ImGui and the scene window is a sf::RenderTexture where I draw the GameObjects and then is converted to ImGui::Image to render it in the editor.
      Now I need to create a 3D Engine during this year in my Bachelor Degree but using SDL2 + ImGui and I want to recreate what I did with the 2D Engine. 
      I've managed to render the editor like I did in the 2D Engine using this example that comes with ImGui. 
      3D Editor preview
      But I don't know how to create an equivalent of sf::RenderTexture in SDL2, so I can draw the 3D scene there and convert it to ImGui::Image to show it in the editor.
      If you can provide code will be better. And if you want me to provide any specific code tell me.
      Thanks!
  • Popular Now