Sign in to follow this  
MindWipe

OpenGL Multitexturing problems

Recommended Posts

Hello again. I did google and check old GDnet threads about this issue, but I can't seem to find what I'm doing wrong. So I want to blend topics together to make this anaglyph 3d (blue/red), but first I just wanted to blend the two pics over each other before I'll do anything fancy to it. But I'm having a problem getting my shader to see both textures. Here's my rendering code:
Gl.glClear(Gl.GL_COLOR_BUFFER_BIT | Gl.GL_DEPTH_BUFFER_BIT);
Gl.glDisable(Gl.GL_DEPTH_TEST);
Gl.glUseProgram(p4);

Gl.glActiveTexture(Gl.GL_TEXTURE0);
Gl.glEnable(Gl.GL_TEXTURE_2D);
Gl.glBindTexture(Gl.GL_TEXTURE_2D, leftEye);

Gl.glActiveTexture(Gl.GL_TEXTURE1);
Gl.glEnable(Gl.GL_TEXTURE_2D);
Gl.glBindTexture(Gl.GL_TEXTURE_2D, rightEye);

orthoView(openGLControl.Width, openGLControl.Height);
Gl.glLoadIdentity();

Helper.RenderTexturedQuad2D(new Vector3D(0, 2048, 0), new Vector3D(2048, 0, 0.0f), new Vector3D(0.0f, 0.0f, 1.0f));

And here's my simple shader

uniform sampler2D left;
uniform sampler2D right;
	
void main()
{
	vec4 leftColor = texture2D(left,gl_TexCoord[0].st);
	vec4 rightColor = texture2D(right,gl_TexCoord[0].st);
	
	gl_FragColor = leftColor * 0.5 + rightColor * 0.5;
}


The shader apparently only sees texture0, so both the left & right sampler2d equals that texture. Ideas? /MindWipe

Share this post


Link to post
Share on other sites
You need to bind the uniform to the active texture as well.

A texture is bound to a "sampler" (I'm not sure of the terminology here), and the sampler is bound to a uniform... And you missing the last step.

In your example, it's going to be something like:
glUniform(locationLeft,0);
glUniform(locationRight,1);

You can get the location using glGetUniformLocation.

Just to make things double clear, you are actually playing with 3 numbers here:
- the texId
- the active texture (or sampler)
- the uniform location
And you "just" need to bind them all (in the darkness if you wish)


edit: replaced glGetAttribLocation by glGetUniformLocation.

[Edited by - purpledog on April 22, 2008 9:11:21 AM]

Share this post


Link to post
Share on other sites
Quote:
Original post by purpledog
You need to bind the uniform to the active texture as well.

A texture is bound to a "sampler" (I'm not sure of the terminology here), and the sampler is bound to a uniform... And you missing the last step.

In your example, it's going to be something like:
glUniform(locationLeft,0);
glUniform(locationRight,1);

You can get the location using glGetAttribLocation.

Just to make things double clear, you are actually playing with 3 numbers here:
- the texId
- the active texture (or sampler)
- the uniform location
And you "just" need to bind them all (in the darkness if you wish)



I see, thanks for the info. But... it's not working. Shouldn't:

Gl.glActiveTexture(Gl.GL_TEXTURE0);
Gl.glEnable(Gl.GL_TEXTURE_2D);
Gl.glBindTexture(Gl.GL_TEXTURE_2D, leftEye);
Gl.glUniform1i(Gl.glGetAttribLocation(p4, "left"), 0);

Gl.glActiveTexture(Gl.GL_TEXTURE1);
Gl.glEnable(Gl.GL_TEXTURE_2D);
Gl.glBindTexture(Gl.GL_TEXTURE_2D, rightEye);
Gl.glUniform1i(Gl.glGetAttribLocation(p4, "right"), 1);

do it?

/MindWipe

Share this post


Link to post
Share on other sites

The problem is that you need to specify the samplers from OpenGL. In your shading code, sampler is just a variable (a uniform variable which you can assign from OpenGL).

Before sampling can take place you have to initialize each sampler variable. You do this with glUniform1i function call. The parameters to this function call are, first, the location of the uniform variable in your GLSL code (e.g. the uniform location of "left" or "right") and secondly the texture unit identifier (e.g. 0 for GL_TEXTURE0) - it is important to realize it is NOT the OpenGL texture ID you use for the sampler variable, it is the Texture Unit to which the texture is bound (common mistake).

When you have linked the program you can retrieve the location of each uniform variable with the function call glGetUniformLocation. Note that this retrieves only active uniforms - an active uniform can be thought of as one whose value actually contributes to the output of each shader. Note that the compiler may strip uniforms if they are not deemed active then you will have a problem (an opengl error) when you try to access the uniform with the (invalid) location (also common mistake).

I suggest you retrieve all active uniforms and their location in some data structure (e.g. hashmap) after you have linked your problem successfully. Each time you need to change a uniform, you look up the location in this data structure.

Lets assume you have found the location of each active uniform. Whenever your problem is enabled, you can use function calls like glUniform1i(uniformLocationForLeft, 0) and glUniform1i(uniformLocationForRight, 1) to make your program work. The values for the uniforms stay until the program is relinked (i.e. you do not have to set them ever frame, only when you want them to change).

I recommend the book OpenGL Shading Language (so-called Orange Book) or look at Lighthouse3D tutorials on GLSL (http://www.lighthouse3d.com/opengl/glsl/).

kind regards,
Nicolai

Edited by ndhb

Share this post


Link to post
Share on other sites
Quote:
Original post by ndhb
The problem is that you need to specify the samplers from OpenGL. In your shading code, sampler is just a variable (a uniform variable which you can assign from OpenGL).

Before sampling can take place you have to initialize each sampler variable. You do this with glUniform1i function call. The parameters to this function call are, first, the location of the uniform variable in your GLSL code (e.g. the uniform location of "left" or "right") and secondly the texture unit identifier (e.g. 0 for GL_TEXTURE0) - it is important to realize it is NOT the OpenGL texture ID you use for the sampler variable, it is the Texture Unit to which the texture is bound (common mistake).

When you have linked the program you can retrieve the location of each uniform variable with the function call glGetUniformLocation. Note that this retrieves only active uniforms - an active uniform can be thought of as one whose value actually contributes to the output of each shader. Note that the compiler may strip uniforms if they are not deemed active then you will have a problem (an opengl error) when you try to access the uniform with the (invalid) location (also common mistake).

I suggest you retrieve all active uniforms and their location in some data structure (e.g. hashmap) after you have linked your problem successfully. Each time you need to change a uniform, you look up the location in this data structure.

Lets assume you have found the location of each active uniform. Whenever your problem is enabled, you can use function calls like glUniform1i(uniformLocationForLeft, 0) and glUniform1i(uniformLocationForRight, 1) to make your program work. The values for the uniforms stay until the program is relinked (i.e. you do not have to set them ever frame, only when you want them to change).

I recommend the book OpenGL Shading Language (so-called Orange Book) or look at Lighthouse3D tutorials on GLSL (http://www.lighthouse3d.com/opengl/glsl/).

kind regards,
Nicolai de Haan Brøgger



Thanks for an awesome explanation!!

Apparently glGetAttribLocation returns -1 for both left and right so I guess I'll have to findout why.

/MindWipe

Share this post


Link to post
Share on other sites
Quote:
Original post by ndhb
Wups, I see now others have already helped - but look at glGetUniformLocation (see above post) instead of glGetAttribLocation :)


Oh! Right! Awesome! Now it works!

Super thanks to all of you!

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Announcements

  • Forum Statistics

    • Total Topics
      628370
    • Total Posts
      2982300
  • Similar Content

    • By test opty
      Hi all,
       
      I'm starting OpenGL using a tut on the Web. But at this point I would like to know the primitives needed for creating a window using OpenGL. So on Windows and using MS VS 2017, what is the simplest code required to render a window with the title of "First Rectangle", please?
       
       
    • By DejayHextrix
      Hi, New here. 
      I need some help. My fiance and I like to play this mobile game online that goes by real time. Her and I are always working but when we have free time we like to play this game. We don't always got time throughout the day to Queue Buildings, troops, Upgrades....etc.... 
      I was told to look into DLL Injection and OpenGL/DirectX Hooking. Is this true? Is this what I need to learn? 
      How do I read the Android files, or modify the files, or get the in-game tags/variables for the game I want? 
      Any assistance on this would be most appreciated. I been everywhere and seems no one knows or is to lazy to help me out. It would be nice to have assistance for once. I don't know what I need to learn. 
      So links of topics I need to learn within the comment section would be SOOOOO.....Helpful. Anything to just get me started. 
      Thanks, 
      Dejay Hextrix 
    • By mellinoe
      Hi all,
      First time poster here, although I've been reading posts here for quite a while. This place has been invaluable for learning graphics programming -- thanks for a great resource!
      Right now, I'm working on a graphics abstraction layer for .NET which supports D3D11, Vulkan, and OpenGL at the moment. I have implemented most of my planned features already, and things are working well. Some remaining features that I am planning are Compute Shaders, and some flavor of read-write shader resources. At the moment, my shaders can just get simple read-only access to a uniform (or constant) buffer, a texture, or a sampler. Unfortunately, I'm having a tough time grasping the distinctions between all of the different kinds of read-write resources that are available. In D3D alone, there seem to be 5 or 6 different kinds of resources with similar but different characteristics. On top of that, I get the impression that some of them are more or less "obsoleted" by the newer kinds, and don't have much of a place in modern code. There seem to be a few pivots:
      The data source/destination (buffer or texture) Read-write or read-only Structured or unstructured (?) Ordered vs unordered (?) These are just my observations based on a lot of MSDN and OpenGL doc reading. For my library, I'm not interested in exposing every possibility to the user -- just trying to find a good "middle-ground" that can be represented cleanly across API's which is good enough for common scenarios.
      Can anyone give a sort of "overview" of the different options, and perhaps compare/contrast the concepts between Direct3D, OpenGL, and Vulkan? I'd also be very interested in hearing how other folks have abstracted these concepts in their libraries.
    • By aejt
      I recently started getting into graphics programming (2nd try, first try was many years ago) and I'm working on a 3d rendering engine which I hope to be able to make a 3D game with sooner or later. I have plenty of C++ experience, but not a lot when it comes to graphics, and while it's definitely going much better this time, I'm having trouble figuring out how assets are usually handled by engines.
      I'm not having trouble with handling the GPU resources, but more so with how the resources should be defined and used in the system (materials, models, etc).
      This is my plan now, I've implemented most of it except for the XML parts and factories and those are the ones I'm not sure of at all:
      I have these classes:
      For GPU resources:
      Geometry: holds and manages everything needed to render a geometry: VAO, VBO, EBO. Texture: holds and manages a texture which is loaded into the GPU. Shader: holds and manages a shader which is loaded into the GPU. For assets relying on GPU resources:
      Material: holds a shader resource, multiple texture resources, as well as uniform settings. Mesh: holds a geometry and a material. Model: holds multiple meshes, possibly in a tree structure to more easily support skinning later on? For handling GPU resources:
      ResourceCache<T>: T can be any resource loaded into the GPU. It owns these resources and only hands out handles to them on request (currently string identifiers are used when requesting handles, but all resources are stored in a vector and each handle only contains resource's index in that vector) Resource<T>: The handles given out from ResourceCache. The handles are reference counted and to get the underlying resource you simply deference like with pointers (*handle).  
      And my plan is to define everything into these XML documents to abstract away files:
      Resources.xml for ref-counted GPU resources (geometry, shaders, textures) Resources are assigned names/ids and resource files, and possibly some attributes (what vertex attributes does this geometry have? what vertex attributes does this shader expect? what uniforms does this shader use? and so on) Are reference counted using ResourceCache<T> Assets.xml for assets using the GPU resources (materials, meshes, models) Assets are not reference counted, but they hold handles to ref-counted resources. References the resources defined in Resources.xml by names/ids. The XMLs are loaded into some structure in memory which is then used for loading the resources/assets using factory classes:
      Factory classes for resources:
      For example, a texture factory could contain the texture definitions from the XML containing data about textures in the game, as well as a cache containing all loaded textures. This means it has mappings from each name/id to a file and when asked to load a texture with a name/id, it can look up its path and use a "BinaryLoader" to either load the file and create the resource directly, or asynchronously load the file's data into a queue which then can be read from later to create the resources synchronously in the GL context. These factories only return handles.
      Factory classes for assets:
      Much like for resources, these classes contain the definitions for the assets they can load. For example, with the definition the MaterialFactory will know which shader, textures and possibly uniform a certain material has, and with the help of TextureFactory and ShaderFactory, it can retrieve handles to the resources it needs (Shader + Textures), setup itself from XML data (uniform values), and return a created instance of requested material. These factories return actual instances, not handles (but the instances contain handles).
       
       
      Is this a good or commonly used approach? Is this going to bite me in the ass later on? Are there other more preferable approaches? Is this outside of the scope of a 3d renderer and should be on the engine side? I'd love to receive and kind of advice or suggestions!
      Thanks!
    • By nedondev
      I 'm learning how to create game by using opengl with c/c++ coding, so here is my fist game. In video description also have game contain in Dropbox. May be I will make it better in future.
      Thanks.
  • Popular Now