• Advertisement
Sign in to follow this  

OpenGL Multitexturing problems

This topic is 3590 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Hello again. I did google and check old GDnet threads about this issue, but I can't seem to find what I'm doing wrong. So I want to blend topics together to make this anaglyph 3d (blue/red), but first I just wanted to blend the two pics over each other before I'll do anything fancy to it. But I'm having a problem getting my shader to see both textures. Here's my rendering code:
Gl.glClear(Gl.GL_COLOR_BUFFER_BIT | Gl.GL_DEPTH_BUFFER_BIT);
Gl.glDisable(Gl.GL_DEPTH_TEST);
Gl.glUseProgram(p4);

Gl.glActiveTexture(Gl.GL_TEXTURE0);
Gl.glEnable(Gl.GL_TEXTURE_2D);
Gl.glBindTexture(Gl.GL_TEXTURE_2D, leftEye);

Gl.glActiveTexture(Gl.GL_TEXTURE1);
Gl.glEnable(Gl.GL_TEXTURE_2D);
Gl.glBindTexture(Gl.GL_TEXTURE_2D, rightEye);

orthoView(openGLControl.Width, openGLControl.Height);
Gl.glLoadIdentity();

Helper.RenderTexturedQuad2D(new Vector3D(0, 2048, 0), new Vector3D(2048, 0, 0.0f), new Vector3D(0.0f, 0.0f, 1.0f));

And here's my simple shader

uniform sampler2D left;
uniform sampler2D right;
	
void main()
{
	vec4 leftColor = texture2D(left,gl_TexCoord[0].st);
	vec4 rightColor = texture2D(right,gl_TexCoord[0].st);
	
	gl_FragColor = leftColor * 0.5 + rightColor * 0.5;
}


The shader apparently only sees texture0, so both the left & right sampler2d equals that texture. Ideas? /MindWipe

Share this post


Link to post
Share on other sites
Advertisement
You need to bind the uniform to the active texture as well.

A texture is bound to a "sampler" (I'm not sure of the terminology here), and the sampler is bound to a uniform... And you missing the last step.

In your example, it's going to be something like:
glUniform(locationLeft,0);
glUniform(locationRight,1);

You can get the location using glGetUniformLocation.

Just to make things double clear, you are actually playing with 3 numbers here:
- the texId
- the active texture (or sampler)
- the uniform location
And you "just" need to bind them all (in the darkness if you wish)


edit: replaced glGetAttribLocation by glGetUniformLocation.

[Edited by - purpledog on April 22, 2008 9:11:21 AM]

Share this post


Link to post
Share on other sites
purpledog pretty much has it covered, there is just one thing I want to add and that is that you don't need to call "Gl.glEnable(Gl.GL_TEXTURE_2D);" when using shaders; texture are implicately enabled by the act of sampling from them in a shader.

Share this post


Link to post
Share on other sites
Quote:
Original post by purpledog
You need to bind the uniform to the active texture as well.

A texture is bound to a "sampler" (I'm not sure of the terminology here), and the sampler is bound to a uniform... And you missing the last step.

In your example, it's going to be something like:
glUniform(locationLeft,0);
glUniform(locationRight,1);

You can get the location using glGetAttribLocation.

Just to make things double clear, you are actually playing with 3 numbers here:
- the texId
- the active texture (or sampler)
- the uniform location
And you "just" need to bind them all (in the darkness if you wish)



I see, thanks for the info. But... it's not working. Shouldn't:

Gl.glActiveTexture(Gl.GL_TEXTURE0);
Gl.glEnable(Gl.GL_TEXTURE_2D);
Gl.glBindTexture(Gl.GL_TEXTURE_2D, leftEye);
Gl.glUniform1i(Gl.glGetAttribLocation(p4, "left"), 0);

Gl.glActiveTexture(Gl.GL_TEXTURE1);
Gl.glEnable(Gl.GL_TEXTURE_2D);
Gl.glBindTexture(Gl.GL_TEXTURE_2D, rightEye);
Gl.glUniform1i(Gl.glGetAttribLocation(p4, "right"), 1);

do it?

/MindWipe

Share this post


Link to post
Share on other sites

The problem is that you need to specify the samplers from OpenGL. In your shading code, sampler is just a variable (a uniform variable which you can assign from OpenGL).

Before sampling can take place you have to initialize each sampler variable. You do this with glUniform1i function call. The parameters to this function call are, first, the location of the uniform variable in your GLSL code (e.g. the uniform location of "left" or "right") and secondly the texture unit identifier (e.g. 0 for GL_TEXTURE0) - it is important to realize it is NOT the OpenGL texture ID you use for the sampler variable, it is the Texture Unit to which the texture is bound (common mistake).

When you have linked the program you can retrieve the location of each uniform variable with the function call glGetUniformLocation. Note that this retrieves only active uniforms - an active uniform can be thought of as one whose value actually contributes to the output of each shader. Note that the compiler may strip uniforms if they are not deemed active then you will have a problem (an opengl error) when you try to access the uniform with the (invalid) location (also common mistake).

I suggest you retrieve all active uniforms and their location in some data structure (e.g. hashmap) after you have linked your problem successfully. Each time you need to change a uniform, you look up the location in this data structure.

Lets assume you have found the location of each active uniform. Whenever your problem is enabled, you can use function calls like glUniform1i(uniformLocationForLeft, 0) and glUniform1i(uniformLocationForRight, 1) to make your program work. The values for the uniforms stay until the program is relinked (i.e. you do not have to set them ever frame, only when you want them to change).

I recommend the book OpenGL Shading Language (so-called Orange Book) or look at Lighthouse3D tutorials on GLSL (http://www.lighthouse3d.com/opengl/glsl/).

kind regards,
Nicolai

Edited by ndhb

Share this post


Link to post
Share on other sites
Wups, I see now others have already helped - but look at glGetUniformLocation (see above post) instead of glGetAttribLocation :)

Share this post


Link to post
Share on other sites
Quote:
Original post by ndhb
The problem is that you need to specify the samplers from OpenGL. In your shading code, sampler is just a variable (a uniform variable which you can assign from OpenGL).

Before sampling can take place you have to initialize each sampler variable. You do this with glUniform1i function call. The parameters to this function call are, first, the location of the uniform variable in your GLSL code (e.g. the uniform location of "left" or "right") and secondly the texture unit identifier (e.g. 0 for GL_TEXTURE0) - it is important to realize it is NOT the OpenGL texture ID you use for the sampler variable, it is the Texture Unit to which the texture is bound (common mistake).

When you have linked the program you can retrieve the location of each uniform variable with the function call glGetUniformLocation. Note that this retrieves only active uniforms - an active uniform can be thought of as one whose value actually contributes to the output of each shader. Note that the compiler may strip uniforms if they are not deemed active then you will have a problem (an opengl error) when you try to access the uniform with the (invalid) location (also common mistake).

I suggest you retrieve all active uniforms and their location in some data structure (e.g. hashmap) after you have linked your problem successfully. Each time you need to change a uniform, you look up the location in this data structure.

Lets assume you have found the location of each active uniform. Whenever your problem is enabled, you can use function calls like glUniform1i(uniformLocationForLeft, 0) and glUniform1i(uniformLocationForRight, 1) to make your program work. The values for the uniforms stay until the program is relinked (i.e. you do not have to set them ever frame, only when you want them to change).

I recommend the book OpenGL Shading Language (so-called Orange Book) or look at Lighthouse3D tutorials on GLSL (http://www.lighthouse3d.com/opengl/glsl/).

kind regards,
Nicolai de Haan Brøgger



Thanks for an awesome explanation!!

Apparently glGetAttribLocation returns -1 for both left and right so I guess I'll have to findout why.

/MindWipe

Share this post


Link to post
Share on other sites
Quote:
Original post by ndhb
Wups, I see now others have already helped - but look at glGetUniformLocation (see above post) instead of glGetAttribLocation :)


Oh! Right! Awesome! Now it works!

Super thanks to all of you!

Share this post


Link to post
Share on other sites
Quote:
Original post by ndhb
Wups, I see now others have already helped - but look at glGetUniformLocation (see above post) instead of glGetAttribLocation :)


Aouch, sorry for that, my mistake!

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Tags

  • Advertisement
  • Popular Now

  • Similar Content

    • By LifeArtist
      Good Evening,
      I want to make a 2D game which involves displaying some debug information. Especially for collision, enemy sights and so on ...
      First of I was thinking about all those shapes which I need will need for debugging purposes: circles, rectangles, lines, polygons.
      I am really stucked right now because of the fundamental question:
      Where do I store my vertices positions for each line (object)? Currently I am not using a model matrix because I am using orthographic projection and set the final position within the VBO. That means that if I add a new line I would have to expand the "points" array and re-upload (recall glBufferData) it every time. The other method would be to use a model matrix and a fixed vbo for a line but it would be also messy to exactly create a line from (0,0) to (100,20) calculating the rotation and scale to make it fit.
      If I proceed with option 1 "updating the array each frame" I was thinking of having 4 draw calls every frame for the lines vao, polygons vao and so on. 
      In addition to that I am planning to use some sort of ECS based architecture. So the other question would be:
      Should I treat those debug objects as entities/components?
      For me it would make sense to treat them as entities but that's creates a new issue with the previous array approach because it would have for example a transform and render component. A special render component for debug objects (no texture etc) ... For me the transform component is also just a matrix but how would I then define a line?
      Treating them as components would'nt be a good idea in my eyes because then I would always need an entity. Well entity is just an id !? So maybe its a component?
      Regards,
      LifeArtist
    • By QQemka
      Hello. I am coding a small thingy in my spare time. All i want to achieve is to load a heightmap (as the lowest possible walking terrain), some static meshes (elements of the environment) and a dynamic character (meaning i can move, collide with heightmap/static meshes and hold a varying item in a hand ). Got a bunch of questions, or rather problems i can't find solution to myself. Nearly all are deal with graphics/gpu, not the coding part. My c++ is on high enough level.
      Let's go:
      Heightmap - i obviously want it to be textured, size is hardcoded to 256x256 squares. I can't have one huge texture stretched over entire terrain cause every pixel would be enormous. Thats why i decided to use 2 specified textures. First will be a tileset consisting of 16 square tiles (u v range from 0 to 0.25 for first tile and so on) and second a 256x256 buffer with 0-15 value representing index of the tile from tileset for every heigtmap square. Problem is, how do i blend the edges nicely and make some computationally cheap changes so its not obvious there are only 16 tiles? Is it possible to generate such terrain with some existing program?
      Collisions - i want to use bounding sphere and aabb. But should i store them for a model or entity instance? Meaning i have 20 same trees spawned using the same tree model, but every entity got its own transformation (position, scale etc). Storing collision component per instance grats faster access + is precalculated and transformed (takes additional memory, but who cares?), so i stick with this, right? What should i do if object is dynamically rotated? The aabb is no longer aligned and calculating per vertex min/max everytime object rotates/scales is pretty expensive, right?
      Drawing aabb - problem similar to above (storing aabb data per instance or model). This time in my opinion per model is enough since every instance also does not have own vertex buffer but uses the shared one (so 20 trees share reference to one tree model). So rendering aabb is about taking the model's aabb, transforming with instance matrix and voila. What about aabb vertex buffer (this is more of a cosmetic question, just curious, bumped onto it in time of writing this). Is it better to make it as 8 points and index buffer (12 lines), or only 2 vertices with min/max x/y/z and having the shaders dynamically generate 6 other vertices and draw the box? Or maybe there should be just ONE 1x1x1 cube box template moved/scaled per entity?
      What if one model got a diffuse texture and a normal map, and other has only diffuse? Should i pass some bool flag to shader with that info, or just assume that my game supports only diffuse maps without fancy stuff?
      There were several more but i forgot/solved them at time of writing
      Thanks in advance
    • By RenanRR
      Hi All,
      I'm reading the tutorials from learnOpengl site (nice site) and I'm having a question on the camera (https://learnopengl.com/Getting-started/Camera).
      I always saw the camera being manipulated with the lookat, but in tutorial I saw the camera being changed through the MVP arrays, which do not seem to be camera, but rather the scene that changes:
      Vertex Shader:
      #version 330 core layout (location = 0) in vec3 aPos; layout (location = 1) in vec2 aTexCoord; out vec2 TexCoord; uniform mat4 model; uniform mat4 view; uniform mat4 projection; void main() { gl_Position = projection * view * model * vec4(aPos, 1.0f); TexCoord = vec2(aTexCoord.x, aTexCoord.y); } then, the matrix manipulated:
      ..... glm::mat4 projection = glm::perspective(glm::radians(fov), (float)SCR_WIDTH / (float)SCR_HEIGHT, 0.1f, 100.0f); ourShader.setMat4("projection", projection); .... glm::mat4 view = glm::lookAt(cameraPos, cameraPos + cameraFront, cameraUp); ourShader.setMat4("view", view); .... model = glm::rotate(model, glm::radians(angle), glm::vec3(1.0f, 0.3f, 0.5f)); ourShader.setMat4("model", model);  
      So, some doubts:
      - Why use it like that?
      - Is it okay to manipulate the camera that way?
      -in this way, are not the vertex's positions that changes instead of the camera?
      - I need to pass MVP to all shaders of object in my scenes ?
       
      What it seems, is that the camera stands still and the scenery that changes...
      it's right?
       
       
      Thank you
       
    • By dpadam450
      Sampling a floating point texture where the alpha channel holds 4-bytes of packed data into the float. I don't know how to cast the raw memory to treat it as an integer so I can perform bit-shifting operations.

      int rgbValue = int(textureSample.w);//4 bytes of data packed as color
      // algorithm might not be correct and endianness might need switching.
      vec3 extractedData = vec3(  rgbValue & 0xFF000000,  (rgbValue << 8) & 0xFF000000, (rgbValue << 16) & 0xFF000000);
      extractedData /= 255.0f;
    • By Devashish Khandelwal
      While writing a simple renderer using OpenGL, I faced an issue with the glGetUniformLocation function. For some reason, the location is coming to be -1.
      Anyone has any idea .. what should I do?
  • Advertisement