OpenGL Software z-buffer problem

Recommended Posts

Hi I am working on a software renderer based on the renderer described here: http://www.devmaster.net/forums/showthread.php?t=1884 I have got to adding a z-buffer but I have a problem with accuracy. Some triangles are showing through when they shouldn't. Here is my code for working out the gradient to use for the Z value:
vec3<float> pv1(v1.mPosition.x,v1.mPosition.y,v1.mPosition.z);
vec3<float> pv2(v2.mPosition.x,v2.mPosition.y,v2.mPosition.z);
vec3<float> pv3(v3.mPosition.x,v3.mPosition.y,v3.mPosition.z);

Plane<float> p(pv1,pv2,pv3);
float dzdx = (-p.a/p.c);
float dzdy = (-p.b/p.c);

float origz =  (v1.mPosition.z + dzdx * (minx - v1.mPosition.x) + dzdy * (miny - v1.mPosition.y));
origz = 1/2 * origz + 1/2;


my z-test is as follows:
if(z < zbuffer[comm]) {
unsigned char icolour[4];
icolour[0] = (unsigned char) rcolour[0];
icolour[1] = (unsigned char) rcolour[1];
icolour[2] = (unsigned char) rcolour[2];
icolour[3] = 255;
memcpy(&framebuffer[comm],icolour,4);
zbuffer[comm] = z;
}


for each increment of x I adjust z by (when scanning over the triangles bounding box): z += dzdx; and for y: z += dzdy; I have uploaded a screenshot,(using software renderer is in square on the top left, the same thing rendered through OpenGL is in the background). I know there are triangles missing, but thats a different issue. http://img2.freeimagehosting.net/image.php?65ee60069f.png Does anyone have any ideas on what I am doing that is causing it not to be 100% accurate? Thanks Mike

Share on other sites
I don't know if this is the reason and your link is broken but are you using perspective correction on the z values? If not then that could possibly be your problem and it's pretty easy to fix, interpolate the reciprocal of each of the vertices z (1.0/vertex.z) value instead of z. You have to change the z buffer comparison to > and you don't need the divide inside the scanloop and you have to clear the z buffer with 0.0

Some people might say that you don't get the precision in some ranges when you use a 1/z buffer but I've not experienced any problems so far but if you want you can use the reciprocal of the interpolated value and stick with the setup (comparison/clearing) you've got already although it does mean you're forced to have 1 divide per pixel test.

Share on other sites
Hi

I have been looking into my Z values and gradients. The step value for Z seems to be very small. Could this be causing the accuracy problem?
Here are a few Z values (x y z) and the corrosponding gradients (dzdx dzdy).

Z values 0.998719 0.998312 0.998353
Z values 0.998719 0.998683 0.998312
Z values 0.998683 0.998459 0.998312
Z values 0.998683 0.998812 0.998459

I have upload another picture. The background is opengl, whereas my software version on top. The floor is the best place to see what is happening.

Picture

Thanks

Share on other sites
Yep, looks a bit of a mess and I don't think my first idea would show problems like that but it probably won't take much to fix. I'm not familiar with what you're doing with 'Plane' to find your gradients so I don't think I can help much with that.
I only use singles for all my interpolation and the only time I've experienced any problems with accuracy has been with very large skyboxes and even then it's just caused the textures to jump around a bit so just for z buffering a scene like that should be no problem.

Create an account

Register a new account

• Forum Statistics

• Total Topics
628278
• Total Posts
2981789
• Similar Content

• By mellinoe
Hi all,
First time poster here, although I've been reading posts here for quite a while. This place has been invaluable for learning graphics programming -- thanks for a great resource!
Right now, I'm working on a graphics abstraction layer for .NET which supports D3D11, Vulkan, and OpenGL at the moment. I have implemented most of my planned features already, and things are working well. Some remaining features that I am planning are Compute Shaders, and some flavor of read-write shader resources. At the moment, my shaders can just get simple read-only access to a uniform (or constant) buffer, a texture, or a sampler. Unfortunately, I'm having a tough time grasping the distinctions between all of the different kinds of read-write resources that are available. In D3D alone, there seem to be 5 or 6 different kinds of resources with similar but different characteristics. On top of that, I get the impression that some of them are more or less "obsoleted" by the newer kinds, and don't have much of a place in modern code. There seem to be a few pivots:
The data source/destination (buffer or texture) Read-write or read-only Structured or unstructured (?) Ordered vs unordered (?) These are just my observations based on a lot of MSDN and OpenGL doc reading. For my library, I'm not interested in exposing every possibility to the user -- just trying to find a good "middle-ground" that can be represented cleanly across API's which is good enough for common scenarios.
Can anyone give a sort of "overview" of the different options, and perhaps compare/contrast the concepts between Direct3D, OpenGL, and Vulkan? I'd also be very interested in hearing how other folks have abstracted these concepts in their libraries.
• By aejt
I recently started getting into graphics programming (2nd try, first try was many years ago) and I'm working on a 3d rendering engine which I hope to be able to make a 3D game with sooner or later. I have plenty of C++ experience, but not a lot when it comes to graphics, and while it's definitely going much better this time, I'm having trouble figuring out how assets are usually handled by engines.
I'm not having trouble with handling the GPU resources, but more so with how the resources should be defined and used in the system (materials, models, etc).
This is my plan now, I've implemented most of it except for the XML parts and factories and those are the ones I'm not sure of at all:
I have these classes:
For GPU resources:
Geometry: holds and manages everything needed to render a geometry: VAO, VBO, EBO. Texture: holds and manages a texture which is loaded into the GPU. Shader: holds and manages a shader which is loaded into the GPU. For assets relying on GPU resources:
Material: holds a shader resource, multiple texture resources, as well as uniform settings. Mesh: holds a geometry and a material. Model: holds multiple meshes, possibly in a tree structure to more easily support skinning later on? For handling GPU resources:
ResourceCache<T>: T can be any resource loaded into the GPU. It owns these resources and only hands out handles to them on request (currently string identifiers are used when requesting handles, but all resources are stored in a vector and each handle only contains resource's index in that vector) Resource<T>: The handles given out from ResourceCache. The handles are reference counted and to get the underlying resource you simply deference like with pointers (*handle).
And my plan is to define everything into these XML documents to abstract away files:
Resources.xml for ref-counted GPU resources (geometry, shaders, textures) Resources are assigned names/ids and resource files, and possibly some attributes (what vertex attributes does this geometry have? what vertex attributes does this shader expect? what uniforms does this shader use? and so on) Are reference counted using ResourceCache<T> Assets.xml for assets using the GPU resources (materials, meshes, models) Assets are not reference counted, but they hold handles to ref-counted resources. References the resources defined in Resources.xml by names/ids. The XMLs are loaded into some structure in memory which is then used for loading the resources/assets using factory classes:
Factory classes for resources:
For example, a texture factory could contain the texture definitions from the XML containing data about textures in the game, as well as a cache containing all loaded textures. This means it has mappings from each name/id to a file and when asked to load a texture with a name/id, it can look up its path and use a "BinaryLoader" to either load the file and create the resource directly, or asynchronously load the file's data into a queue which then can be read from later to create the resources synchronously in the GL context. These factories only return handles.
Factory classes for assets:
Much like for resources, these classes contain the definitions for the assets they can load. For example, with the definition the MaterialFactory will know which shader, textures and possibly uniform a certain material has, and with the help of TextureFactory and ShaderFactory, it can retrieve handles to the resources it needs (Shader + Textures), setup itself from XML data (uniform values), and return a created instance of requested material. These factories return actual instances, not handles (but the instances contain handles).

Is this a good or commonly used approach? Is this going to bite me in the ass later on? Are there other more preferable approaches? Is this outside of the scope of a 3d renderer and should be on the engine side? I'd love to receive and kind of advice or suggestions!
Thanks!
• By nedondev
I 'm learning how to create game by using opengl with c/c++ coding, so here is my fist game. In video description also have game contain in Dropbox. May be I will make it better in future.
Thanks.

• So I've recently started learning some GLSL and now I'm toying with a POM shader. I'm trying to optimize it and notice that it starts having issues at high texture sizes, especially with self-shadowing.
Now I know POM is expensive either way, but would pulling the heightmap out of the normalmap alpha channel and in it's own 8bit texture make doing all those dozens of texture fetches more cheap? Or is everything in the cache aligned to 32bit anyway? I haven't implemented texture compression yet, I think that would help? But regardless, should there be a performance boost from decoupling the heightmap? I could also keep it in a lower resolution than the normalmap if that would improve performance.
Any help is much appreciated, please keep in mind I'm somewhat of a newbie. Thanks!

• Hi,
I'm trying to learn OpenGL through a website and have proceeded until this page of it. The output is a simple triangle. The problem is the complexity.
I have read that page several times and tried to analyse the code but I haven't understood the code properly and completely yet. This is the code: