Sign in to follow this  
pjyelton

OpenGL Issue using my first rotation matrix in OpenGL

Recommended Posts

pjyelton    122
Hi guys, new to OpenGL, REALLY new to using my own matrices in OpenGL, and I'm having problems getting my code to work. I have a feeling I'm making a false assumption somewhere in my logic, mostly because the tutorials I have spend a lot of time using the built in OpenGL functions, and no time showing how to use your own matrices other than giving the functions glLoadMatrixf() and glMultMatrixf(). In a nutshell, I have a cube object that contains its own matrix that when initialized starts off as the identity matrix. Every frame I load up this matrix using the glLoadMatrix() function and draw the object. When the user presses the up key I want the cube to rotate around the x axis by a specified number of degree/radians, so I create a rotation matrix and call a function from the cube object that multiplies and updates its matrix by the rotation matrix. My assumption is that the next frame when I the cube loads the new updated matrix the cube will have rotated. Nope, no rotation at all. Am I making a false assumption or does it sound like I'm missing some command somewhere? Before anyone asks why I'm doing it this way instead of using the prebuilt OpenGL rotation functions, its because I intend my project to have many of these cube objects. Each cube can be rotate independently from every other cube so I need each object to be able to keep track of its individual orientation and be able to rotate around an arbitrary axis by itself. Here are snippets of my code, anyone see anything amiss?
class cube {
private:
	float centerx, centery, centerz;  // initial offset from origin
	float width;
	GLfloat matrix[16];
public:
	cube(float, float, float, float);
	void draw();
	void rotate(float);
};
void cube::rotate(float xangle)
{
// create rotation matrix and multiply with cube matrix		
        GLfloat r[16] = {1.0f, 0, 0, 0, 
                         0, cos(xangle), sin(xangle), 0,
                         0,-sin(xangle), cos(xangle), 0, 
                         0, 0, 0, 1.0f};

	GLfloat m[16];  // temporary matrix to store values from matrix multiplication

	m[0]=matrix[0]*r[0]+matrix[4]*r[1]+matrix[8]*r[2]+matrix[12]*r[3];
	m[1]=matrix[1]*r[0]+matrix[5]*r[1]+matrix[9]*r[2]+matrix[13]*r[3];
	m[2]=matrix[2]*r[0]+matrix[6]*r[1]+matrix[10]*r[2]+matrix[14]*r[3];
	m[3]=matrix[3]*r[0]+matrix[7]*r[1]+matrix[11]*r[2]+matrix[15]*r[3];

	m[4]=matrix[0]*r[4]+matrix[4]*r[5]+matrix[8]*r[6]+matrix[12]*r[7];
	m[5]=matrix[1]*r[4]+matrix[5]*r[5]+matrix[9]*r[6]+matrix[13]*r[7];
	m[6]=matrix[2]*r[4]+matrix[6]*r[5]+matrix[10]*r[6]+matrix[14]*r[7];
	m[7]=matrix[3]*r[4]+matrix[7]*r[5]+matrix[11]*r[6]+matrix[15]*r[7];

	m[8]=matrix[0]*r[8]+matrix[4]*r[9]+matrix[8]*r[10]+matrix[12]*r[11];
	m[9]=matrix[1]*r[8]+matrix[5]*r[9]+matrix[9]*r[10]+matrix[13]*r[11];
	m[10]=matrix[2]*r[8]+matrix[6]*r[9]+matrix[10]*r[10]+matrix[14]*r[11];
	m[11]=matrix[3]*r[8]+matrix[7]*r[9]+matrix[11]*r[10]+matrix[15]*r[11];

	m[12]=matrix[0]*r[12]+matrix[4]*r[13]+matrix[8]*r[14]+matrix[12]*r[15];
	m[13]=matrix[1]*r[12]+matrix[5]*r[13]+matrix[9]*r[14]+matrix[13]*r[15];
	m[14]=matrix[2]*r[12]+matrix[6]*r[13]+matrix[10]*r[14]+matrix[14]*r[15];
	m[15]=matrix[3]*r[12]+matrix[7]*r[13]+matrix[11]*r[14]+matrix[15]*r[15];

	for ( int x=0; x<=16; x++) {
             matrix[x] = m[x];
        }
}
void cube::draw() {

	glLoadMatrixf(matrix);
	glTranslatef(0.0f,0.0f,-12.0f); // move back 12 units, otherwise can't see objects 
	glBegin(GL_QUADS);
		glVertex3f(centerx-width/2.0f,centery+width/2.0f,centerz-width/2.0f); 
		glVertex3f(centerx+width/2.0f,centery+width/2.0f,centerz-width/2.0f); 
		glVertex3f(centerx+width/2.0f,centery-width/2.0f,centerz-width/2.0f); 
		glVertex3f(centerx-width/2.0f,centery-width/2.0f,centerz-width/2.0f); 
	glEnd();

        // etc etc, 5 more sides are drawn the same as above
}
From my main file:
	case WM_KEYDOWN:
		switch ((int)wParam)
		{
		case VK_ESCAPE:
			PostQuitMessage(0);
			break;
		case VK_UP:
			myCube.rotate(10.0f);
			break;

Then I call myCube.draw() every frame. Anyone see anything? First time ever using matrices this way, anything you could think of that I might have overlooked? When I debug I can clearly see that the cube matrix is updating when I push the up key, but still no rotation. [Edited by - pjyelton on May 13, 2008 3:25:05 PM]

Share this post


Link to post
Share on other sites
pjyelton    122
Nevermind, figured it out, I had my objects stored in a vector and silly me wasn't using pointers so the constructer kept resetting the matrix values every time I passed the vector to a function.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Similar Content

    • By Zaphyk
      I am developing my engine using the OpenGL 3.3 compatibility profile. It runs as expected on my NVIDIA card and on my Intel Card however when I tried it on an AMD setup it ran 3 times worse than on the other setups. Could this be a AMD driver thing or is this probably a problem with my OGL code? Could a different code standard create such bad performance?
    • By Kjell Andersson
      I'm trying to get some legacy OpenGL code to run with a shader pipeline,
      The legacy code uses glVertexPointer(), glColorPointer(), glNormalPointer() and glTexCoordPointer() to supply the vertex information.
      I know that it should be using setVertexAttribPointer() etc to clearly define the layout but that is not an option right now since the legacy code can't be modified to that extent.
      I've got a version 330 vertex shader to somewhat work:
      #version 330 uniform mat4 osg_ModelViewProjectionMatrix; uniform mat4 osg_ModelViewMatrix; layout(location = 0) in vec4 Vertex; layout(location = 2) in vec4 Normal; // Velocity layout(location = 3) in vec3 TexCoord; // TODO: is this the right layout location? out VertexData { vec4 color; vec3 velocity; float size; } VertexOut; void main(void) { vec4 p0 = Vertex; vec4 p1 = Vertex + vec4(Normal.x, Normal.y, Normal.z, 0.0f); vec3 velocity = (osg_ModelViewProjectionMatrix * p1 - osg_ModelViewProjectionMatrix * p0).xyz; VertexOut.velocity = velocity; VertexOut.size = TexCoord.y; gl_Position = osg_ModelViewMatrix * Vertex; } What works is the Vertex and Normal information that the legacy C++ OpenGL code seem to provide in layout location 0 and 2. This is fine.
      What I'm not getting to work is the TexCoord information that is supplied by a glTexCoordPointer() call in C++.
      Question:
      What layout location is the old standard pipeline using for glTexCoordPointer()? Or is this undefined?
       
      Side note: I'm trying to get an OpenSceneGraph 3.4.0 particle system to use custom vertex, geometry and fragment shaders for rendering the particles.
    • By markshaw001
      Hi i am new to this forum  i wanted to ask for help from all of you i want to generate real time terrain using a 32 bit heightmap i am good at c++ and have started learning Opengl as i am very interested in making landscapes in opengl i have looked around the internet for help about this topic but i am not getting the hang of the concepts and what they are doing can some here suggests me some good resources for making terrain engine please for example like tutorials,books etc so that i can understand the whole concept of terrain generation.
       
    • By KarimIO
      Hey guys. I'm trying to get my application to work on my Nvidia GTX 970 desktop. It currently works on my Intel HD 3000 laptop, but on the desktop, every bind textures specifically from framebuffers, I get half a second of lag. This is done 4 times as I have three RGBA textures and one depth 32F buffer. I tried to use debugging software for the first time - RenderDoc only shows SwapBuffers() and no OGL calls, while Nvidia Nsight crashes upon execution, so neither are helpful. Without binding it runs regularly. This does not happen with non-framebuffer binds.
      GLFramebuffer::GLFramebuffer(FramebufferCreateInfo createInfo) { glGenFramebuffers(1, &fbo); glBindFramebuffer(GL_FRAMEBUFFER, fbo); textures = new GLuint[createInfo.numColorTargets]; glGenTextures(createInfo.numColorTargets, textures); GLenum *DrawBuffers = new GLenum[createInfo.numColorTargets]; for (uint32_t i = 0; i < createInfo.numColorTargets; i++) { glBindTexture(GL_TEXTURE_2D, textures[i]); GLint internalFormat; GLenum format; TranslateFormats(createInfo.colorFormats[i], format, internalFormat); // returns GL_RGBA and GL_RGBA glTexImage2D(GL_TEXTURE_2D, 0, internalFormat, createInfo.width, createInfo.height, 0, format, GL_FLOAT, 0); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST); DrawBuffers[i] = GL_COLOR_ATTACHMENT0 + i; glBindTexture(GL_TEXTURE_2D, 0); glFramebufferTexture(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0 + i, textures[i], 0); } if (createInfo.depthFormat != FORMAT_DEPTH_NONE) { GLenum depthFormat; switch (createInfo.depthFormat) { case FORMAT_DEPTH_16: depthFormat = GL_DEPTH_COMPONENT16; break; case FORMAT_DEPTH_24: depthFormat = GL_DEPTH_COMPONENT24; break; case FORMAT_DEPTH_32: depthFormat = GL_DEPTH_COMPONENT32; break; case FORMAT_DEPTH_24_STENCIL_8: depthFormat = GL_DEPTH24_STENCIL8; break; case FORMAT_DEPTH_32_STENCIL_8: depthFormat = GL_DEPTH32F_STENCIL8; break; } glGenTextures(1, &depthrenderbuffer); glBindTexture(GL_TEXTURE_2D, depthrenderbuffer); glTexImage2D(GL_TEXTURE_2D, 0, depthFormat, createInfo.width, createInfo.height, 0, GL_DEPTH_COMPONENT, GL_FLOAT, 0); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST); glBindTexture(GL_TEXTURE_2D, 0); glFramebufferTexture(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, depthrenderbuffer, 0); } if (createInfo.numColorTargets > 0) glDrawBuffers(createInfo.numColorTargets, DrawBuffers); else glDrawBuffer(GL_NONE); if (glCheckFramebufferStatus(GL_FRAMEBUFFER) != GL_FRAMEBUFFER_COMPLETE) std::cout << "Framebuffer Incomplete\n"; glBindFramebuffer(GL_FRAMEBUFFER, 0); width = createInfo.width; height = createInfo.height; } // ... // FBO Creation FramebufferCreateInfo gbufferCI; gbufferCI.colorFormats = gbufferCFs.data(); gbufferCI.depthFormat = FORMAT_DEPTH_32; gbufferCI.numColorTargets = gbufferCFs.size(); gbufferCI.width = engine.settings.resolutionX; gbufferCI.height = engine.settings.resolutionY; gbufferCI.renderPass = nullptr; gbuffer = graphicsWrapper->CreateFramebuffer(gbufferCI); // Bind glBindFramebuffer(GL_DRAW_FRAMEBUFFER, fbo); // Draw here... // Bind to textures glActiveTexture(GL_TEXTURE0); glBindTexture(GL_TEXTURE_2D, textures[0]); glActiveTexture(GL_TEXTURE1); glBindTexture(GL_TEXTURE_2D, textures[1]); glActiveTexture(GL_TEXTURE2); glBindTexture(GL_TEXTURE_2D, textures[2]); glActiveTexture(GL_TEXTURE3); glBindTexture(GL_TEXTURE_2D, depthrenderbuffer); Here is an extract of my code. I can't think of anything else to include. I've really been butting my head into a wall trying to think of a reason but I can think of none and all my research yields nothing. Thanks in advance!
    • By Adrianensis
      Hi everyone, I've shared my 2D Game Engine source code. It's the result of 4 years working on it (and I still continue improving features ) and I want to share with the community. You can see some videos on youtube and some demo gifs on my twitter account.
      This Engine has been developed as End-of-Degree Project and it is coded in Javascript, WebGL and GLSL. The engine is written from scratch.
      This is not a professional engine but it's for learning purposes, so anyone can review the code an learn basis about graphics, physics or game engine architecture. Source code on this GitHub repository.
      I'm available for a good conversation about Game Engine / Graphics Programming
  • Popular Now