• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Instigator

C# 'for each' and 'LIST' Generics

7 posts in this topic

For some strange reason I can't remove an item from a list while iterating the LIST. NOTE: lines with, '*' are the key parts causing this error.

foreach (Employee ae in lstEmployees) // *I get an error here. Is this because of 'lstEmployees.Remove(ae);' below??
             {
                if (ae.getName() == txtName.Text)
                {
                    found = true;
                    lstEmployees.Remove(ae);//*seems to work, but as soon as the loop iteration is done it crashes on the above 'for each'
                    // if the name from the Textbox is in the LIST<>, then remove it and clear all data
                
                    if (MessageBox.Show("Delete? \n", "Confirm Delete", MessageBoxButtons.OKCancel) == DialogResult.OK)
                    {
                        lstEmployees.Remove(ae);
                        MessageBox.Show("Item Removed from list. *comment out later", "Confirm Delete", MessageBoxButtons.OK);
                        
                    }
               }



Quote:
An unhandled exception of type 'System.InvalidOperationException'
Any help would be appreciated!
0

Share this post


Link to post
Share on other sites
Generally you can't use a foreach list to alter the collection of things that the foreach loop is looping through. If you could, it would result in some pretty funky behaviour. There are a few ways around this. I thought I had started a thread like this a while ago. I'll see if I can dredge up a link.
0

Share this post


Link to post
Share on other sites
Okay so that explains to me a lot. Except.. if I can't use 'for each' to delete an object in that list.. what should I be using?

For example, if I'm removing the employee in the 'lstEmployees LIST' where 'employee.getName() = txtBox.text' ..

What's the best solution to this? Can I use a for each to create an index of where 'Employee.getName() = txtBox.text' and then just delete that index outside of the for each?
0

Share this post


Link to post
Share on other sites
Yeah, something like that. Either that or use a for loop, but being careful to not screw up your indices as you loop through.
0

Share this post


Link to post
Share on other sites
If you think about it, you shouldn't be using a foreach loop if you're going to modify the collection you're iterating through. Honestly I think this was a stupid language "feature" that was more of a nod to the VB developers than to others.

Does a for each construct allow you to iterate through the collection faster than a simple "for" loop? what about a do...while? A while...?

I am working at a company that the main developer made a comment about the do/while and while loop not being a construct in C#. Was fun to pull out the book and point to it...

for each loops should ONLY BE USED WHEN *NOT* MODIFYING a collection of objects. Don't use it if you plan of wacking an item from the collection. The underlying iteration mechanism may change and any "hacks" you perform may fail later.

Happy coding.
0

Share this post


Link to post
Share on other sites
hmm

use foreach and add whatever you want to delete to a temporary list. loop through that list using a for loop and call MasterList.Remove(ToBeDelete[i]) on each iteration.
0

Share this post


Link to post
Share on other sites
In C#, there are properties so you shouldn't write get/set methods. Assuming your employee class currently looks like this:
class Employee {
private string name;
public string getName() { return this.name; }
public string setName(string name) { this.name = value; }
}

...you could do this instead:
// C#2:
class Employee {
private string name;
public string Name {
get { return this.name; }
set { this.name = value; }
}
}
// C#3: (If you don't do any error checking on Name)
class Employee {
public string Name { get; set; }
}

To the question in hand, you can do something a little more elegant (hard-coded to delete John here):
// C#2:
Employees.RemoveAll(delegate(Employee E) { return E.Name == "John" && MessageBox.Show("Delete?", "Confirm", MessageBoxButtons.YesNo) == DialogResult.Yes; });
// C#3:
Employees.RemoveAll(E => E.Name == "John" && MessageBox.Show("Delete?", "Confirm", MessageBoxButtons.YesNo) == DialogResult.Yes);
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0