Sign in to follow this  
iAnorak

OpenGL GLSL - per pixel lighting

Recommended Posts

iAnorak    122
I've been following this tutorial for creating per-pixel spot lights, and both shading files seem to work fine if the camera is static. However, when I rotate the camera, the shadowing changes, which shouldn't be happening (I think). Camera rotation is done via the mouse (changing cameraRotate). Here's the basic pseudocode of what I am doing: render function:
glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);
glLoadIdentity();

glTranslated(0.0, 0.0, -10.0);
glRotated(cameraRotate[0], 1.0, 0.0, 0.0);
glRotated(cameraRotate[1], 0.0, 1.0, 0.0);

glLightfv(GL_LIGHT0, GL_POSITION, lpos);
drawLight();

glutSolidTeapot(1);

glFlush();
glutSwapBuffers();
Here are the vertex and fragment shader functions (copied directly from the tutorial). vertex shader:
varying vec4 diffuse,ambientGlobal, ambient;
varying vec3 normal,lightDir,halfVector;
varying float dist;

void main() {
  vec4 ecPos;
  vec3 aux;
	
  /* first transform the normal into eye space and normalize the result */
  normal = normalize(gl_NormalMatrix * gl_Normal);
	
  /* now normalize the light's direction. Note that according to the
  OpenGL specification, the light is stored in eye space.*/
  ecPos = gl_ModelViewMatrix * gl_Vertex;
  aux = vec3(gl_LightSource[0].position-ecPos);
  lightDir = normalize(aux);
	
  /* compute the distance to the light source to a varying variable*/
  dist = length(aux);

  /* Normalize the halfVector to pass it to the fragment shader */
  halfVector = normalize(gl_LightSource[0].halfVector.xyz);
	
  /* Compute the diffuse, ambient and globalAmbient terms */
  diffuse = gl_FrontMaterial.diffuse * gl_LightSource[0].diffuse;
  ambient = gl_FrontMaterial.ambient * gl_LightSource[0].ambient;
  ambientGlobal = gl_LightModel.ambient * gl_FrontMaterial.ambient;

  gl_Position = ftransform();	
}
fragment shader:
varying vec4 diffuse,ambientGlobal, ambient;
varying vec3 normal,lightDir,halfVector;
varying float dist;

void main()
{
  vec3 n,halfV;
  float NdotL,NdotHV;
  vec4 color = ambientGlobal;
  float att,spotEffect;
	
  /* a fragment shader can't write a verying variable, hence we need
  a new variable to store the normalized interpolated normal */
  n = normalize(normal);
	
  /* compute the dot product between normal and ldir */
  NdotL = max(dot(n,normalize(lightDir)),0.0);

  if (NdotL > 0.0) {
    spotEffect = dot(normalize(gl_LightSource[0].spotDirection), normalize(-lightDir));

    if (spotEffect > gl_LightSource[0].spotCosCutoff) {
      spotEffect = pow(spotEffect, gl_LightSource[0].spotExponent);
      att = spotEffect / (gl_LightSource[0].constantAttenuation + gl_LightSource[0].linearAttenuation * dist + gl_LightSource[0].quadraticAttenuation * dist * dist);
				
      color += att * (diffuse * NdotL + ambient);

      halfV = normalize(halfVector);
      NdotHV = max(dot(n,halfV),0.0);
      color += att * gl_FrontMaterial.specular * gl_LightSource[0].specular * pow(NdotHV,gl_FrontMaterial.shininess);
    }
  }

  gl_FragColor = color;
}
Any help would be greatly appreciated!

Share this post


Link to post
Share on other sites
kloffy    1318
Are you sure it's not caused by the specular color of the material/light? The specular reflection can cause some weird effects in combination with camera motion if you're not careful about the values you use...

Share this post


Link to post
Share on other sites
iAnorak    122
Quote:
Original post by kloffy
Are you sure it's not caused by the specular color of the material/light? The specular reflection can cause some weird effects in combination with camera motion if you're not careful about the values you use...


I think I found out what is causing my confusion. The light is being drawn with respect to the camera's position. So if I zoom the camera out, the light will draw a broader spot light; if I zoom the camera in, the light will draw a more narrow spot light on the objects. Any idea how I can fix this? It seems like a simple problem.

Share this post


Link to post
Share on other sites
riku    194
When you set a light position with glLight, the position is multiplied by the current modelview matrix. So, in order to set it in world coordinates, you must have your modelview set to the identity matrix when you set your light position (with glLight).

glLight man page

-Riku

Share this post


Link to post
Share on other sites
iAnorak    122
Quote:
Original post by Rasmadrak
Put the light position before translations and rotations - unless you want to move the light?


I would like the ability to move the light, and also so that if the camera moves the light will stay in the same spot (relative to the world). This would be done by setting the light after the camera rotations/translations have been done.

I guess what I am really asking how to do is deal with the camera in GLSL. I've been reading that I have to pass in the camera inverse matrix, then base my calculations off of that? Are there any tutorials on how I can do that?

Share this post


Link to post
Share on other sites
BlackSeeds    156
I had a similar problem a while back, I send in the light position and camera position as uniform's so no matrix transformations affect the light position.

Share this post


Link to post
Share on other sites
swiftcoder    18432
Quote:
Original post by iAnorak
Quote:
Original post by Rasmadrak
Put the light position before translations and rotations - unless you want to move the light?

I would like the ability to move the light, and also so that if the camera moves the light will stay in the same spot (relative to the world). This would be done by setting the light after the camera rotations/translations have been done.
Nope, it doesn't work quite like that. You need to set the light position (in world coordinates) *before* you apply the camera transform. You can move the light around by changing its position, but if you apply the camera transform first, it ends up in eye-space; i.e. it will move relative to the camera.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Similar Content

    • By povilaslt2
      Hello. I'm Programmer who is in search of 2D game project who preferably uses OpenGL and C++. You can see my projects in GitHub. Project genre doesn't matter (except MMO's :D).
    • By ZeldaFan555
      Hello, My name is Matt. I am a programmer. I mostly use Java, but can use C++ and various other languages. I'm looking for someone to partner up with for random projects, preferably using OpenGL, though I'd be open to just about anything. If you're interested you can contact me on Skype or on here, thank you!
      Skype: Mangodoor408
    • By tyhender
      Hello, my name is Mark. I'm hobby programmer. 
      So recently,I thought that it's good idea to find people to create a full 3D engine. I'm looking for people experienced in scripting 3D shaders and implementing physics into engine(game)(we are going to use the React physics engine). 
      And,ye,no money =D I'm just looking for hobbyists that will be proud of their work. If engine(or game) will have financial succes,well,then maybe =D
      Sorry for late replies.
      I mostly give more information when people PM me,but this post is REALLY short,even for me =D
      So here's few more points:
      Engine will use openGL and SDL for graphics. It will use React3D physics library for physics simulation. Engine(most probably,atleast for the first part) won't have graphical fron-end,it will be a framework . I think final engine should be enough to set up an FPS in a couple of minutes. A bit about my self:
      I've been programming for 7 years total. I learned very slowly it as "secondary interesting thing" for like 3 years, but then began to script more seriously.  My primary language is C++,which we are going to use for the engine. Yes,I did 3D graphics with physics simulation before. No, my portfolio isn't very impressive. I'm working on that No,I wasn't employed officially. If anybody need to know more PM me. 
       
    • By Zaphyk
      I am developing my engine using the OpenGL 3.3 compatibility profile. It runs as expected on my NVIDIA card and on my Intel Card however when I tried it on an AMD setup it ran 3 times worse than on the other setups. Could this be a AMD driver thing or is this probably a problem with my OGL code? Could a different code standard create such bad performance?
    • By Kjell Andersson
      I'm trying to get some legacy OpenGL code to run with a shader pipeline,
      The legacy code uses glVertexPointer(), glColorPointer(), glNormalPointer() and glTexCoordPointer() to supply the vertex information.
      I know that it should be using setVertexAttribPointer() etc to clearly define the layout but that is not an option right now since the legacy code can't be modified to that extent.
      I've got a version 330 vertex shader to somewhat work:
      #version 330 uniform mat4 osg_ModelViewProjectionMatrix; uniform mat4 osg_ModelViewMatrix; layout(location = 0) in vec4 Vertex; layout(location = 2) in vec4 Normal; // Velocity layout(location = 3) in vec3 TexCoord; // TODO: is this the right layout location? out VertexData { vec4 color; vec3 velocity; float size; } VertexOut; void main(void) { vec4 p0 = Vertex; vec4 p1 = Vertex + vec4(Normal.x, Normal.y, Normal.z, 0.0f); vec3 velocity = (osg_ModelViewProjectionMatrix * p1 - osg_ModelViewProjectionMatrix * p0).xyz; VertexOut.velocity = velocity; VertexOut.size = TexCoord.y; gl_Position = osg_ModelViewMatrix * Vertex; } What works is the Vertex and Normal information that the legacy C++ OpenGL code seem to provide in layout location 0 and 2. This is fine.
      What I'm not getting to work is the TexCoord information that is supplied by a glTexCoordPointer() call in C++.
      Question:
      What layout location is the old standard pipeline using for glTexCoordPointer()? Or is this undefined?
       
      Side note: I'm trying to get an OpenSceneGraph 3.4.0 particle system to use custom vertex, geometry and fragment shaders for rendering the particles.
  • Popular Now