Manager Effects;
LightEffect* TwoLight = new LightEffect();
Effects.add(TwoLight);
std::vector<effect*>FX_List;
class effect{
//common attributes
};
class TwoLight : public effect{
}
class InfrRedLight : public effect{
}
class Blur: public effect{
}
class Drunk: public effect{
}
typedef boost::shared_ptr<effect> EffectHandle;typedef std::map<std::string, EffectHandle> EffectMap;EffectMap effects;effects["blur"].reset(new Blur());Quote:Original post by wforlAt some point you have to construct these effects, do it through their constructors.
And the other question, is how to set up each effect before rendering, when you only have access to the EffectManager.
Quote:i can correctly call the derived render() and build() methods, but i can't access the members that are defined in the derived classes, as i only have a base pointer, unless i cast them of course, but this is still a little awkward.Try and design it so that you don't need access to the subclasses. The effect class provides it's interface, hopefully that should be all that is needed.
Quote:Original post by wforlManagers almost always do more than one thing. Both in the real world and in software design. That's why they're almost always not good designs. [smile]
The manager class does a lot more than what i have showed, so i want to keep it in.
Quote:The build function is called in the constructor, i just took it out here to make things simpler.Keep in mind that you cannot reliably use functions polymorphically from a constructor.
Quote:I cant really just iterate over everything in one go, as thats not really what this class was designed for, it was designed for me to be able to create classes that do other stuff (terrain, water, etc) , and have them point to whatever effect i want in the manager for the effect i want them to render as.Hmm, so I don't understand why do you need a manager to do that? These other renderable objects could just hold shared_ptrs to your effects without the need of a central manager. That's not to say that having some kind of collection of all effects isn't useful, just that it isn't necessary to implement what you've just described.
Quote:The problem is that before an effect can be rendered it has to be set up, which will involve setting up members in both the base class and the derived class. Such as i might have to set up the World matrix in the base class, but also the light diffuse or light position etc in the derived class. And these adjustments have to be made every frame, hence my problematic situationCode outside of the effect classes shouldn't care about the attributes contained within the effect classes - that violates encapsulation.
Quote:Original post by wforlI suppose that depends how you implement it. I would be trying to find a data-centric approach based on rich high level states, naturally compromises would have to be made but that's what software engineering is all about [smile]
But, as you've mentioned its going to involve making everything public, and having some sort of method or descripter is'nt going to work either, as it would require soooo much code, as the list of shaders is going to end up being in the 20's or more, with most shaders having completly different variables and functions,and it really is just going to make things error prone.
typedef std::map<std::string, boost::any> PropertyMap;PropertyMap params; params["transform"] = transform(); params["age"] = age(); params["seven"] = 7; params["name"] = "wforl";// functions needn't care about parameters they're not interested insomeFunctionRequiringTransformAndAge(params);someFunctionRequiringAgeAndName(params);Quote:I will make a simplified version of what i want to do and post it up, and maybe it will make things clearer, as to the problems im facing, what i want to do, and what sucks about my system :)Good idea - A new thread for it might be best too.
#include <windows.h>#include <stdio.h>#include <iostream>#include <vector>using namespace std;class BaseEffect{public: BaseEffect(const char * dir) : Tech(0), WVP(0){ this->Build(dir); } void SetStatistics() const { cout << "In BaseEffect SetStatistics" << endl; cout << "...storing vertex/triangle/texture count etc" << endl; *(this->WhereToUpdateTris) += 55; *(this->WhereToUpdateVerts) += 78; } virtual void Render() const { this->SetStatistics(); cout << "In BaseEffect Render" << endl; } virtual void Build(const char * dir) { cout << "In BaseEffect Building base part of effect" << endl; } int Tech; int WVP; int* WhereToUpdateTris; int* WhereToUpdateVerts;};class HeightEffect : public BaseEffect{public: HeightEffect(const char * dir) : BaseEffect(dir) , MaxHeight(10){ this->Build(dir); } virtual void Render() const { BaseEffect::Render(); cout << "In HeightEffect Render" << endl; cout << "Rendering with, MaxHeight:" << this->MaxHeight << endl; } virtual void Build(const char * dir) { cout << "In HeightEffect Build" << endl; cout << "Building Specific HeightEffect stuff" << endl; } int MaxHeight; int MinHeight; int Colour; };class FX_Manager{public: vector<BaseEffect*>FX_List; FX_Manager() : numTris(0), numVerts(0){} void Add(BaseEffect*in){ in->WhereToUpdateTris = &this->numTris; in->WhereToUpdateVerts = &this->numVerts; this->FX_List.push_back(in); } void Stats(){ cout << "verts: " << this->numVerts << " Tris: " << this->numTris; }private: int numTris; int numVerts;};void main(){ FX_Manager Effects; BaseEffect *t = new BaseEffect("dir"); Effects.Add(t); HeightEffect *r = new HeightEffect("dir"); Effects.Add(r); cout << endl; Effects.FX_List[0]->Render(); cout << endl; cout << endl; for( int i = 0; i < 5; ++i){ static_cast<HeightEffect*>(Effects.FX_List[1])->MaxHeight = i; Effects.FX_List[1]->Render(); } Effects.Stats();}class PrimitiveStats{public: typedef unsigned long SizeType; PrimitiveStats() : tris(0), verts(0) { } void advanceTris(SizeType tris) { this->tris += tris; verts += (tris * 3); } void advanceTriStrip(SizeType tris) { this->tris += tris; verts += (tris + 2); } SizeType triCount() const { return tris; } SizeType vertCount() const { return verts; } void reset() { tris = verts = 0; }private: SizeType tris; SizeType verts;};// Allow us to write the stats to an output streamstd::ostream & operator<<(std::ostream & os, const PrimitiveStats & ps){ os << "Tris: " << ps.triCount() << "\n"; os << "Verts: " << ps.vertCount() << std::endl; return os;}class Box{public: Box(int x1, int y1, int x2, int y2) : x1(x1), y1(y1), x2(x2), y2(y2) { } int x1, y1, x2, y2;};// Calculates the height of a boxint height(const Box & b){ return (b.y2 > b.y1) ? b.y2 - b.y1 : b.y1 - b.y2;}class RenderDescriptor{public: RenderDescriptor(const Box & bounding) : bounding(bounding) { } Box bounding; // other fixed properties here // offers the ability to add new properties dynamically typedef std::map<std::string, boost::any> PropertyMap; PropertyMap attribs;};#include <iostream>#include <string>#include <map>#include <boost/any.hpp>#include <boost/ptr_container/ptr_map.hpp>class PrimitiveStats{public: typedef unsigned long SizeType; PrimitiveStats() : tris(0), verts(0) { } void advanceTris(SizeType tris) { this->tris += tris; verts += (tris * 3); } void advanceTriStrip(SizeType tris) { this->tris += tris; verts += (tris + 2); } SizeType triCount() const { return tris; } SizeType vertCount() const { return verts; } void reset() { tris = verts = 0; }private: SizeType tris; SizeType verts;};std::ostream & operator<<(std::ostream & os, const PrimitiveStats & ps){ os << "Tris: " << ps.triCount() << "\n"; os << "Verts: " << ps.vertCount() << std::endl; return os;}class Box{public: Box(int x1, int y1, int x2, int y2) : x1(x1), y1(y1), x2(x2), y2(y2) { } int x1, y1, x2, y2;};int height(const Box & b){ return (b.y2 > b.y1) ? b.y2 - b.y1 : b.y1 - b.y2;}class RenderDescriptor{public: RenderDescriptor(const Box & bounding) : bounding(bounding) { } Box bounding; // other fixed properties // misc properties typedef std::map<std::string, boost::any> PropertyMap; PropertyMap attribs;};class BaseEffect{public: BaseEffect() { std::cout << "In BaseEffect Building base part of effect" << std::endl; } virtual ~BaseEffect() { } void render(PrimitiveStats & stats, const RenderDescriptor & desc) const { updateStatistics(stats); std::cout << "In BaseEffect Render" << std::endl; render(desc); }private: virtual void render(const RenderDescriptor & desc) const = 0; virtual void updateStatistics(PrimitiveStats & stats) const = 0;};class HeightEffect : public BaseEffect{public: HeightEffect() { std::cout << "In HeightEffect Building Specific HeightEffect stuff" << endl; }private: virtual void render(const RenderDescriptor & desc) const { int maxHeight = height(desc.bounding); std::cout << "In HeightEffect Render" << endl; std::cout << "Rendering with, MaxHeight:" << maxHeight << endl; } virtual void updateStatistics(PrimitiveStats & stats) { std::cout << "In HeightEffect updateStatistics" << std::endl; std::cout << "...storing vertex/triangle/texture count etc" << std::endl; stats.advanceTris(24); stats.advanceTriStrip(4); }};typedef boost::ptr_map<std::string, BaseEffect> EffectDepository;RenderDescriptor makeRenderData(int i){ return RenderDescriptor(Box(0, 0, i, i));}int main(){ EffectDepository effects; effects.insert("height", new HeightEffect()); PrimitiveStats stats; for( int i = 0; i < 5; ++i) { effects["height"].render(stats, makeRenderData(i)); } std::cout << stats;}
