• Advertisement
Sign in to follow this  

OpenGL OpenGL Lighting Problem

This topic is 3349 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Hi! This is my first post here! I started OpenGL one week ago and I like it so far. Now I am working on a little application that rotates a rectangle. I already added a texture. But now I got some Problems with my light. I'm trying to make a light like the sun. It should be constant. Here is my source code so far:
// Textures by CGTextures
#include <SDL/SDL.h>
#include <GL/glu.h>
#include <GL/gl.h>
#include <string>
#include <iostream>
using namespace std;

// Funktion zum Zeichnen
void DrawScreen();
GLuint LoadTexture(string name);

GLuint Texture[2];

int main(int argc, char* argv[]) {

const SDL_VideoInfo* info = NULL; // Zum lesen von Video Informationen
SDL_Surface *Surf_Window; // Surface des windows
SDL_Event event; // Für das event handling
int bpp; // bit per pixer -> Bildschirmtiefe
int width = 800, height = 600; // Breite und Höhe des Fensters
bool active = true; // Die Loop läuft solange, bis diese Variable false ist

// SDL Initialisieren
if ( SDL_Init( SDL_INIT_VIDEO ) < 0 ) {
 return -1;
}

// Setze bit per pixel
info = SDL_GetVideoInfo();
bpp = info->vfmt->BitsPerPixel;

// Setze OpenGL Attribute
SDL_GL_SetAttribute(SDL_GL_RED_SIZE, 5); // größe des roten Framebuffers
SDL_GL_SetAttribute(SDL_GL_GREEN_SIZE, 5); // größe des grünen Framebuffers
SDL_GL_SetAttribute(SDL_GL_BLUE_SIZE, 5); // größe des blauen Framebuffers
SDL_GL_SetAttribute(SDL_GL_DEPTH_SIZE, 16); // Größe des Tiefenpuffers
SDL_GL_SetAttribute(SDL_GL_DOUBLEBUFFER, 1); // Doppel Pufferung einschalten

// Setze SDL in den Video Mode
if((Surf_Window = SDL_SetVideoMode(width, height, bpp, SDL_OPENGL)) == NULL) {
    return -1;
}

glEnable(GL_TEXTURE_2D); // Erlaubt die Benutzung von 2D Texturen
glShadeModel(GL_SMOOTH); // Farbtechnik auf SMOOTH setzen
                         // Bildet Farbverläufe zwischen Eckpunkten
glClearColor(0.3, 0.3, 0.7, 1.0); // Farbe mit der der
                                  // Bildschirm bereinigt wird
glViewport(0, 0, width, height); // Gibt OpenGL den "Malbereich"
glMatrixMode(GL_PROJECTION); // Matrix Mode ändern
glLoadIdentity(); // Setzt die aktieve Matrix zurück
gluPerspective(60.0, width/height, 1.0, 1024.0); // Ändert die Perspektive
glMatrixMode(GL_MODELVIEW); // Ändert den Matrix Mode wieder auf MODELVIEW

// Depth Puffer Einstellen
glClearDepth(1.0f); // Wert festlegen mit dem der
                    // Tiefenpuffer beim Löschen gefüllt wird
glEnable(GL_DEPTH_TEST); // Tiefen Test aktivieren
glDepthFunc(GL_LEQUAL); // Legt fest wann ein Segment den Test besteht

glEnable(GL_LIGHTING); // Erlaubt das Benutzen von Lichtquellen
glEnable(GL_COLOR_MATERIAL);
glEnable(GL_LIGHT0);

// Eigenschaften der Lichtquellen
GLfloat LightAmbient[]= {0.0f, 0.0f, 0.0f, 1.0f};
GLfloat LightDiffuse[]= {1.0f, 1.0f, 1.0f, 1.0f};
GLfloat LightSpecular[]= {1.0f, 1.0, 1.0f, 1.0f};
glLightfv(GL_LIGHT0, GL_AMBIENT, LightAmbient);
glLightfv(GL_LIGHT0, GL_DIFFUSE, LightDiffuse);
glLightfv(GL_LIGHT0, GL_SPECULAR, LightSpecular);
glColorMaterial(GL_FRONT_AND_BACK, GL_AMBIENT);
glColorMaterial(GL_FRONT_AND_BACK, GL_DIFFUSE);

/*
// Culling
glCullFace(GL_BACK); // Hinterseite soll nicht angezeigt werden
glFrontFace(GL_CCW); // definiere die Vorderseite
glEnable(GL_CULL_FACE); // Culling aktivieren
*/

// Textur laden
Texture[0] = LoadTexture("images/texture1.bmp");
Texture[1] = LoadTexture("images/texture2.bmp");

// Loop startet
while(active) {

 // bearbeite Events
 while(SDL_PollEvent(&event)) {
  switch(event.type) {
   case SDL_KEYDOWN:
    switch(event.key.keysym.sym) {
     case SDLK_ESCAPE:
      active = false;
      break;
     case SDLK_SPACE:
      SDL_WM_ToggleFullScreen(Surf_Window);
      break;
    }
    break;
   case SDL_QUIT:
    active = false;
    break;
  }
 }

 // Bildschirm zeichnen
 DrawScreen();

 // Warten, um den CPU nicht auf 100% zu bringen
 SDL_Delay(50);

}

// Textur löschen
glDeleteTextures(sizeof(Texture) / sizeof(GLuint), Texture);

// SDL beenden
SDL_Quit();

return 0;
}

void DrawScreen() {

// Variable die den aktuellen Winkel speichert
static float angle = 0.0f;
static GLfloat LightPosition[]= {-2.0f, 1.0, 1.0f, 1.0f};

glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT); // Buffer leeren
glLoadIdentity(); // Matrix zurücksetzen

gluLookAt(0, 0, -10, 0, 0, 0, 0, 1, 0);
glLightfv(GL_LIGHT0, GL_POSITION, LightPosition);

glDisable(GL_LIGHT0);
glTranslatef( 0.0f, -1.0f,-5.0f); // verschiebt die Matrix
glRotatef(angle, 0.0f, 1.0f, 0.0f); // rotiert die Matrix um die y Achse
glEnable(GL_LIGHT0);
angle += 2; // Winkel vergrößern -> drehen
if(angle >= 360) // Wenn der Winkel größer gleich 360 wird auf 0 setzten
 angle = 0;      // da 0° = 360°
glBindTexture(GL_TEXTURE_2D, Texture[0]);

glBegin(GL_QUADS); // Zeichnen eines Viereckes

 // Boden
 glTexCoord2i(0, 1);
 glVertex3f(-1.0f, 0.0, 1.0);
 glTexCoord2i(0, 0);
 glVertex3f(-1.0f, 0.0,-1.0);
 glTexCoord2i(1, 0);
 glVertex3f( 1.0f, 0.0,-1.0);
 glTexCoord2i(1, 1);
 glVertex3f( 1.0f, 0.0, 1.0);

 // Oben
 glTexCoord2i(0, 1);
 glVertex3f(-1.0f, 2.0, 1.0);
 glTexCoord2i(0, 0);
 glVertex3f(-1.0f, 2.0,-1.0);
 glTexCoord2i(1, 0);
 glVertex3f( 1.0f, 2.0,-1.0);
 glTexCoord2i(1, 1);
 glVertex3f( 1.0f, 2.0, 1.0);

 // Links
 glTexCoord2i(1, 1);
 glVertex3f(-1.0f, 0.0, 1.0);
 glTexCoord2i(1, 0);
 glVertex3f(-1.0f, 2.0, 1.0);
 glTexCoord2i(0, 0);
 glVertex3f(-1.0f, 2.0,-1.0);
 glTexCoord2i(0, 1);
 glVertex3f(-1.0f, 0.0,-1.0);

 // Rechts
 glTexCoord2i(1, 1);
 glVertex3f( 1.0f, 0.0, 1.0);
 glTexCoord2i(1, 0);
 glVertex3f( 1.0f, 2.0, 1.0);
 glTexCoord2i(0, 0);
 glVertex3f( 1.0f, 2.0,-1.0);
 glTexCoord2i(0, 1);
 glVertex3f( 1.0f, 0.0,-1.0);

 // Vorne
 glTexCoord2i(1, 1);
 glVertex3f(-1.0f, 0.0, 1.0);
 glTexCoord2i(0, 1);
 glVertex3f( 1.0f, 0.0, 1.0);
 glTexCoord2i(0, 0);
 glVertex3f( 1.0f, 2.0, 1.0);
 glTexCoord2i(1, 0);
 glVertex3f(-1.0f, 2.0, 1.0);

 // Hinten
 glTexCoord2i(1, 1);
 glVertex3f(-1.0f, 0.0,-1.0);
 glTexCoord2i(0, 1);
 glVertex3f( 1.0f, 0.0,-1.0);
 glTexCoord2i(0, 0);
 glVertex3f( 1.0f, 2.0,-1.0);
 glTexCoord2i(1, 0);
 glVertex3f(-1.0f, 2.0,-1.0);

glEnd(); // Zeichnen beenden

SDL_GL_SwapBuffers(); // erneuert den Bildschirm

}

GLuint LoadTexture(string name) {

GLuint texture; // Rückgabewert, der die id der Textur enthält
SDL_Surface *surface; // SDL Surface zum laden der Bit Map
GLenum textureFormat; // Variable zum Speichern der Formates
GLint colors; // Variable zum Speichern von der Anzahl der Farben
              // RGB  -> 3
              // RGBA -> 4

// Öffnen der Bitmap und Speichern in dem Surface
if((surface = SDL_LoadBMP(name.c_str())) == NULL) {
 cout << "Couldn't find texture" << endl;
}

// speichere Anzahl der bytes
colors = surface->format->BytesPerPixel;

// Definition des Formates
if(colors == 4) {
  if(surface->format->Rmask == 0x000000ff)
    textureFormat = GL_RGBA;
  else
    textureFormat = GL_BGRA;
} else if(colors == 3) {
  if (surface->format->Rmask == 0x000000ff)
    textureFormat = GL_RGB;
  else
    textureFormat = GL_BGR;
} else {
    cout << "Can not use color format of the bit map" << endl;
}

glGenTextures(1, &texture); // Namen(Nummer) der Textur zuweisen
glBindTexture(GL_TEXTURE_2D, texture); // an die 2D Textur binden
// Setzen der Textureigenschaften
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR);
// Textur Einstellungen
glTexImage2D(GL_TEXTURE_2D, 0, colors, surface->w, surface->h, 0, textureFormat, GL_UNSIGNED_BYTE, surface->pixels);

// Surface freilassen
SDL_FreeSurface(surface);

return texture;
}
Please ignore my German comments xD My problem is now that the light rotates with the box. I searched for that here and in Google. But nobody really has a answer. Can anybody help me or change my code so the light is constant? Phille Ps: I am learning English xD

Share this post


Link to post
Share on other sites
Advertisement
hi,
My understanding is that lights must be positioned after the world is transform otherwise they also get transformed, so try puting the light code after the rotations. I might be wrong tho..

Share this post


Link to post
Share on other sites
As for sunlight: You should possibly think about a directional light in this case. It's not a big deal, all you've to do is to set 'w' for your lightpos to 0.

Ps: Wieso denn? Die Kommentare sind doch total interessant? :-O

Share this post


Link to post
Share on other sites
Thank you all for your answers.
Helped me a lot!

But the problem is not solved yet. It is still not working correct.
I read this: http://www.swiftless.com/tutorials/opengl/lighting_types.html
The code from that tutorial worked fine. Then I copied everything to one of my little examples with SDL and it didn't work any more. The same problem: The light is rotating.

Here is my new source code:

#include <SDL/SDL.h>
#include <GL/glu.h>
#include <GL/gl.h>

void DrawScreen();

GLfloat angle = 0.0;

GLfloat dlr = 1.0;
GLfloat dlg = 1.0;
GLfloat dlb = 1.0;

GLfloat alr = 1.0;
GLfloat alg = 1.0;
GLfloat alb = 1.0;

GLfloat lx = 0.0;
GLfloat ly = 0.0;
GLfloat lz = 1.0;
GLfloat lw = 0.0;

int main(int argc, char* argv[]) {

const SDL_VideoInfo* info = NULL;
SDL_Surface *Surf_Window;
SDL_Event event;
int bpp;
int width = 800, height = 600;
bool active = true;

if ( SDL_Init( SDL_INIT_VIDEO ) < 0 ) {
return -1;
}

info = SDL_GetVideoInfo();
bpp = info->vfmt->BitsPerPixel;

SDL_GL_SetAttribute(SDL_GL_RED_SIZE, 5);
SDL_GL_SetAttribute(SDL_GL_GREEN_SIZE, 5);
SDL_GL_SetAttribute(SDL_GL_BLUE_SIZE, 5);
SDL_GL_SetAttribute(SDL_GL_DEPTH_SIZE, 16);
SDL_GL_SetAttribute(SDL_GL_DOUBLEBUFFER, 1);

if((Surf_Window = SDL_SetVideoMode(width, height, bpp, SDL_OPENGL)) == NULL) {
return -1;
}

glShadeModel(GL_SMOOTH);
glViewport(0, 0, width, height);

glMatrixMode(GL_PROJECTION);
glLoadIdentity();
gluPerspective(60.0, width/height, 1.0, 100.0);
glMatrixMode(GL_MODELVIEW);

glEnable(GL_DEPTH_TEST);

glEnable(GL_LIGHTING);
glEnable(GL_LIGHT0);

while(active) {

while(SDL_PollEvent(&event)) {
switch(event.type) {
case SDL_KEYDOWN:
switch(event.key.keysym.sym) {
case SDLK_ESCAPE:
active = false;
break;
}
break;
case SDL_QUIT:
active = false;
break;
}
}

DrawScreen();

SDL_Delay(50);

}

SDL_Quit();

return 0;
}

void DrawScreen() {

glClearColor(0.0, 0.0, 0.0, 1.0);

glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);
glLoadIdentity();

GLfloat DiffuseLight[] = {dlr, dlg, dlb};
GLfloat AmbientLight[] = {alr, alg, alb};

glLightfv(GL_LIGHT0, GL_DIFFUSE, DiffuseLight);
glLightfv(GL_LIGHT0, GL_AMBIENT, AmbientLight);

GLfloat LightPosition[] = {lx, ly, lz, lw};
glLightfv(GL_LIGHT0, GL_POSITION, LightPosition);

gluLookAt(0.0, 0.0, 5.0, 0.0, 0.0, 0.0, 0.0, 1.0, 0.0);

glRotatef(angle, 1.0, 1.0, 1.0);

glBegin(GL_QUADS);

glVertex3f(-1.0f, 0.0, 1.0);
glVertex3f(-1.0f, 0.0,-1.0);
glVertex3f( 1.0f, 0.0,-1.0);
glVertex3f( 1.0f, 0.0, 1.0);

glEnd();

glBegin(GL_TRIANGLES);

glVertex3f(-1.0f, 0.0f, 1.0f);
glVertex3f( 0.0f, 2.0f, 0.0f);
glVertex3f(-1.0f, 0.0f,-1.0f);

glVertex3f( 1.0f, 0.0f, 1.0f);
glVertex3f( 0.0f, 2.0f, 0.0f);
glVertex3f(-1.0f, 0.0f, 1.0f);

glVertex3f( 1.0f, 0.0f,-1.0f);
glVertex3f( 0.0f, 2.0f, 0.0f);
glVertex3f( 1.0f, 0.0f, 1.0f);

glVertex3f(-1.0f, 0.0f,-1.0f);
glVertex3f( 0.0f, 2.0f, 0.0f);
glVertex3f( 1.0f, 0.0f,-1.0f);

glEnd();

SDL_GL_SwapBuffers();

angle++;
if(angle >= 360)
angle = 0;

}


Should do it?! But it doesn't.
The only differences are that i am using SDL for my window handling and buffering instead for glut and that i am not using glutSolidCube(2); to create my object.
What is up with that??

Did I forget to set one SDL attribute?( SDL_GL_SetAttribute() -> http://www.libsdl.org/cgi/docwiki.cgi/SDL_GLattr)

I hope somebody can give me a solution. I am going crease!

Phille

Share this post


Link to post
Share on other sites
anyone?

If not does somebody have a good sdl + opengl tutorial with a lighting lesson?
Could somebody compile my code and check if it's just my system or compiler that is wrong?

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Tags

  • Advertisement
  • Popular Now

  • Similar Content

    • By LifeArtist
      Good Evening,
      I want to make a 2D game which involves displaying some debug information. Especially for collision, enemy sights and so on ...
      First of I was thinking about all those shapes which I need will need for debugging purposes: circles, rectangles, lines, polygons.
      I am really stucked right now because of the fundamental question:
      Where do I store my vertices positions for each line (object)? Currently I am not using a model matrix because I am using orthographic projection and set the final position within the VBO. That means that if I add a new line I would have to expand the "points" array and re-upload (recall glBufferData) it every time. The other method would be to use a model matrix and a fixed vbo for a line but it would be also messy to exactly create a line from (0,0) to (100,20) calculating the rotation and scale to make it fit.
      If I proceed with option 1 "updating the array each frame" I was thinking of having 4 draw calls every frame for the lines vao, polygons vao and so on. 
      In addition to that I am planning to use some sort of ECS based architecture. So the other question would be:
      Should I treat those debug objects as entities/components?
      For me it would make sense to treat them as entities but that's creates a new issue with the previous array approach because it would have for example a transform and render component. A special render component for debug objects (no texture etc) ... For me the transform component is also just a matrix but how would I then define a line?
      Treating them as components would'nt be a good idea in my eyes because then I would always need an entity. Well entity is just an id !? So maybe its a component?
      Regards,
      LifeArtist
    • By QQemka
      Hello. I am coding a small thingy in my spare time. All i want to achieve is to load a heightmap (as the lowest possible walking terrain), some static meshes (elements of the environment) and a dynamic character (meaning i can move, collide with heightmap/static meshes and hold a varying item in a hand ). Got a bunch of questions, or rather problems i can't find solution to myself. Nearly all are deal with graphics/gpu, not the coding part. My c++ is on high enough level.
      Let's go:
      Heightmap - i obviously want it to be textured, size is hardcoded to 256x256 squares. I can't have one huge texture stretched over entire terrain cause every pixel would be enormous. Thats why i decided to use 2 specified textures. First will be a tileset consisting of 16 square tiles (u v range from 0 to 0.25 for first tile and so on) and second a 256x256 buffer with 0-15 value representing index of the tile from tileset for every heigtmap square. Problem is, how do i blend the edges nicely and make some computationally cheap changes so its not obvious there are only 16 tiles? Is it possible to generate such terrain with some existing program?
      Collisions - i want to use bounding sphere and aabb. But should i store them for a model or entity instance? Meaning i have 20 same trees spawned using the same tree model, but every entity got its own transformation (position, scale etc). Storing collision component per instance grats faster access + is precalculated and transformed (takes additional memory, but who cares?), so i stick with this, right? What should i do if object is dynamically rotated? The aabb is no longer aligned and calculating per vertex min/max everytime object rotates/scales is pretty expensive, right?
      Drawing aabb - problem similar to above (storing aabb data per instance or model). This time in my opinion per model is enough since every instance also does not have own vertex buffer but uses the shared one (so 20 trees share reference to one tree model). So rendering aabb is about taking the model's aabb, transforming with instance matrix and voila. What about aabb vertex buffer (this is more of a cosmetic question, just curious, bumped onto it in time of writing this). Is it better to make it as 8 points and index buffer (12 lines), or only 2 vertices with min/max x/y/z and having the shaders dynamically generate 6 other vertices and draw the box? Or maybe there should be just ONE 1x1x1 cube box template moved/scaled per entity?
      What if one model got a diffuse texture and a normal map, and other has only diffuse? Should i pass some bool flag to shader with that info, or just assume that my game supports only diffuse maps without fancy stuff?
      There were several more but i forgot/solved them at time of writing
      Thanks in advance
    • By RenanRR
      Hi All,
      I'm reading the tutorials from learnOpengl site (nice site) and I'm having a question on the camera (https://learnopengl.com/Getting-started/Camera).
      I always saw the camera being manipulated with the lookat, but in tutorial I saw the camera being changed through the MVP arrays, which do not seem to be camera, but rather the scene that changes:
      Vertex Shader:
      #version 330 core layout (location = 0) in vec3 aPos; layout (location = 1) in vec2 aTexCoord; out vec2 TexCoord; uniform mat4 model; uniform mat4 view; uniform mat4 projection; void main() { gl_Position = projection * view * model * vec4(aPos, 1.0f); TexCoord = vec2(aTexCoord.x, aTexCoord.y); } then, the matrix manipulated:
      ..... glm::mat4 projection = glm::perspective(glm::radians(fov), (float)SCR_WIDTH / (float)SCR_HEIGHT, 0.1f, 100.0f); ourShader.setMat4("projection", projection); .... glm::mat4 view = glm::lookAt(cameraPos, cameraPos + cameraFront, cameraUp); ourShader.setMat4("view", view); .... model = glm::rotate(model, glm::radians(angle), glm::vec3(1.0f, 0.3f, 0.5f)); ourShader.setMat4("model", model);  
      So, some doubts:
      - Why use it like that?
      - Is it okay to manipulate the camera that way?
      -in this way, are not the vertex's positions that changes instead of the camera?
      - I need to pass MVP to all shaders of object in my scenes ?
       
      What it seems, is that the camera stands still and the scenery that changes...
      it's right?
       
       
      Thank you
       
    • By dpadam450
      Sampling a floating point texture where the alpha channel holds 4-bytes of packed data into the float. I don't know how to cast the raw memory to treat it as an integer so I can perform bit-shifting operations.

      int rgbValue = int(textureSample.w);//4 bytes of data packed as color
      // algorithm might not be correct and endianness might need switching.
      vec3 extractedData = vec3(  rgbValue & 0xFF000000,  (rgbValue << 8) & 0xFF000000, (rgbValue << 16) & 0xFF000000);
      extractedData /= 255.0f;
    • By Devashish Khandelwal
      While writing a simple renderer using OpenGL, I faced an issue with the glGetUniformLocation function. For some reason, the location is coming to be -1.
      Anyone has any idea .. what should I do?
  • Advertisement