• Advertisement
Sign in to follow this  

Unity Boost lambda, sorting objects?

This topic is 3314 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Note: this is a related thread but I could post there: http://www.gamedev.net/community/forums/topic.asp?topic_id=503958 I'm new to boost lambda and am trying to sort a vector of objects, but it won't compile.. Can anybody explain to me why please? Thanks! /* class I'm trying to sort */ class component_info { public: cell* comp; grid_bag_contraints cnstr; int space1; int space2; int preff; // delegates, makes lambda expressions easier :) int cnstr_off() { return cnstr.off; }; int cnstr_len() { return cnstr.len; }; int cnstr_space1() { return cnstr.space1; }; int cnstr_space2() { return cnstr.space2; }; int cnstr_ins1() { return cnstr.ins1; }; int cnstr_ins2() { return cnstr.ins2; }; float cnstr_weight() { return cnstr.weight; }; component_info(): comp(NULL), space1(0), space2(0) { cnstr = grid_bag_contraints(); preff = 0; }; }; void main() { vector<component_info> component_infos(10); sort(component_infos.begin(), component_infos.end(), bind(&component_info::cnstr_len, _1) < bind(&component_info::cnstr_len, _2)); }

Share this post


Link to post
Share on other sites
Advertisement
Quote:
Original post by nreyntje
Note: this is a related thread but I could post there:
http://www.gamedev.net/community/forums/topic.asp?topic_id=503958

I'm new to boost lambda and am trying to sort a vector of objects, but it
won't compile..
Can anybody explain to me why please? Thanks!

/*
class I'm trying to sort
*/

class component_info {
public:

cell* comp;
grid_bag_contraints cnstr;
int space1;
int space2;
int preff;

// delegates, makes lambda expressions easier :)
int cnstr_off() { return cnstr.off; };
int cnstr_len() { return cnstr.len; };
int cnstr_space1() { return cnstr.space1; };
int cnstr_space2() { return cnstr.space2; };
int cnstr_ins1() { return cnstr.ins1; };
int cnstr_ins2() { return cnstr.ins2; };
float cnstr_weight() { return cnstr.weight; };


component_info(): comp(NULL), space1(0), space2(0) {
cnstr = grid_bag_contraints();
preff = 0;
};
};

void main() {
vector<component_info> component_infos(10);

sort(component_infos.begin(), component_infos.end(),
bind(&component_info::cnstr_len, _1) <
bind(&component_info::cnstr_len, _2));
}
Your code is a little hard to follow ([ source ] tags would help), but it doesn't look to me like you're actually using boost::lambda anywhere in this example.

In order to create a lambda expression, you need to use one of the lambda placeholders (AFAIK, at least), which you're not doing (you're using _1 and _2, but in this context those are bind placeholders, not lambda placeholders).

I'm not sure off the top of my head whether or how the comparison in your example can be expressed using boost::lambda - perhaps someone else can clarify that. There are plenty of (perhaps easier) alternatives though, for example a named free function, a free or member overload of operator<(), or a function object that overloads the () operator.

Share this post


Link to post
Share on other sites
My boost::lambda fu is weak, I generally stick to binds and explicit function composition, but I think the problem is that the lambda library can't deduce the return type of function objects produced by bind.

See lambda.overriding_deduced_return_type in the documentation.

I'm pretty sure that you just need to wrap the binds in the ret<T>() adaptor.

Share this post


Link to post
Share on other sites
First off all, thanx for the reply!
but you left my confused..

In http://www.boost.org/doc/libs/1_37_0/doc/html/lambda/s03.html#id3397831
I found that
"bind(foo, _1, _2)"
is called a "bind expression" and not a lambda expression..my mistake..

But I have some questions:

"bind(&component_info::cnstr_len, _1)"
is a unary functiod right?

"bind(&component_info::cnstr_len, _2)"
is a binary functiod rigth?

and than
"bind(&component_info::cnstr_len, _1) < bind(&component_info::cnstr_len, _2)"
is also a binary functiod right?

Share this post


Link to post
Share on other sites
Quote:
"bind(&component_info::cnstr_len, _1) < bind(&component_info::cnstr_len, _2)"
is also a binary functiod right?
When the compiler sees the above expression, it goes looking for a non-member overload of operator<() whose argument types are compatible with the return types of the two bind expressions. It can't find such an overload, so a compiler error is generated. (Or so I assume - it would probably be a good idea to post the actual error.)

std::sort() is expecting a function object as the third argument: an object that can be invoked using the syntax expression(...). The lambda library functions return such objects, but since you're not actually invoking any of the boost::lambda functions, that doesn't really help you at all here.

What it kind of looks like to me is that you're expecting C++ to construct a 'generic' lambda expression for you here, but that's not going to happen (C++ doesn't have built-in support for lambda expressions - boost::lambda is quite handy, but it's basically a very complicated workaround, and will only work if you use the syntax that it requires).

Share this post


Link to post
Share on other sites
It is also possible that you have a const correctness issue: your getters are not const, and this causes an error in below simplified code (since you didn't provide the grid_bag_contraints class) which compiles fine otherwise. In any case, if I'm not mistaken, the comparison functions/objects should always guarantee not to modify what is being compared.

(Also note that the getter isn't really necessary, since you apparently can bind class members too.)


#include <boost/lambda/lambda.hpp>
#include <boost/lambda/bind.hpp>
#include <vector>
using namespace std;
using namespace boost::lambda;

class component_info {
public:

//cell* comp;
//grid_bag_contraints cnstr;
int space1;
int space2;
int preff;

// delegates, makes lambda expressions easier :)
/*int cnstr_off() { return cnstr.off; };
int cnstr_len() { return cnstr.len; };
int cnstr_space1() { return cnstr.space1; };
int cnstr_space2() { return cnstr.space2; };
int cnstr_ins1() { return cnstr.ins1; };
int cnstr_ins2() { return cnstr.ins2; };
float cnstr_weight() { return cnstr.weight; };
*/

int get_space1() const { return space1; }

component_info(): /*comp(NULL),*/ space1(0), space2(0)
{
//cnstr = grid_bag_contraints();
preff = 0;
}
};

int main() {
vector<component_info> component_infos(10);

sort(component_infos.begin(), component_infos.end(),
bind(&component_info::get_space1, _1) < bind(&component_info::get_space1, _2));
sort(component_infos.begin(), component_infos.end(),
bind(&component_info::space1, _1) < bind(&component_info::space1, _2));
}



Share this post


Link to post
Share on other sites
EDIT: I think victor has it. It looks like < may be sufficently overloaded in the boost lambda library to not need all of those wrappers. That's good to know. I've only used it to get _1 and _2 in simple expressions.

Okay, now that the workday is winding down, I can give a bit more thought to this. The basic problem you're running into is the one jyk has pointed out: < is not creating a functor. It's just an operator, and there's no overload for the templated functors generated by bind.

Fortunately, with a couple more adaptors we can do this:


boost::bind(
std::less<int>(),
boost::bind(&component_info::cnstr_len,_1),
boost::bind(&component_info::cnstr_len,_2));




So, now we have two binary functors produced by bind, that pass their result to std::less's arguments. And we need one more bind to wrap this up. Whee!

The final functor has the the operator we need:

bool operator()(const component_info&, const component_info&).

Share this post


Link to post
Share on other sites
Quote:

The basic problem you're running into is the one jyk has pointed out: < is not creating a functor. It's just an operator, and there's no overload for the templated functors generated by bind.


boost.bind documentation claims otherwise: the operators are overloaded since version 1.33

Share this post


Link to post
Share on other sites
Both methods are good to know!
I'll never write have to write custom functiods again!
Great!

Share this post


Link to post
Share on other sites
The original code looks perfectly correct.
You probably confused boost::bind with boost::lambda::bind.

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Tags

  • Advertisement
  • Popular Now

  • Similar Content

    • By GytisDev
      Hello,
      without going into any details I am looking for any articles or blogs or advice about city building and RTS games in general. I tried to search for these on my own, but would like to see your input also. I want to make a very simple version of a game like Banished or Kingdoms and Castles,  where I would be able to place like two types of buildings, make farms and cut trees for resources while controlling a single worker. I have some problem understanding how these games works in the back-end: how various data can be stored about the map and objects, how grids works, implementing work system (like a little cube (human) walks to a tree and cuts it) and so on. I am also pretty confident in my programming capabilities for such a game. Sorry if I make any mistakes, English is not my native language.
      Thank you in advance.
    • By Ovicior
      Hey,
      So I'm currently working on a rogue-like top-down game that features melee combat. Getting basic weapon stats like power, weight, and range is not a problem. I am, however, having a problem with coming up with a flexible and dynamic system to allow me to quickly create unique effects for the weapons. I want to essentially create a sort of API that is called when appropriate and gives whatever information is necessary (For example, I could opt to use methods called OnPlayerHit() or IfPlayerBleeding() to implement behavior for each weapon). The issue is, I've never actually made a system as flexible as this.
      My current idea is to make a base abstract weapon class, and then have calls to all the methods when appropriate in there (OnPlayerHit() would be called whenever the player's health is subtracted from, for example). This would involve creating a sub-class for every weapon type and overriding each method to make sure the behavior works appropriately. This does not feel very efficient or clean at all. I was thinking of using interfaces to allow for the implementation of whatever "event" is needed (such as having an interface for OnPlayerAttack(), which would force the creation of a method that is called whenever the player attacks something).
       
      Here's a couple unique weapon ideas I have:
      Explosion sword: Create explosion in attack direction.
      Cold sword: Chance to freeze enemies when they are hit.
      Electric sword: On attack, electricity chains damage to nearby enemies.
       
      I'm basically trying to create a sort of API that'll allow me to easily inherit from a base weapon class and add additional behaviors somehow. One thing to know is that I'm on Unity, and swapping the weapon object's weapon component whenever the weapon changes is not at all a good idea. I need some way to contain all this varying data in one Unity component that can contain a Weapon field to hold all this data. Any ideas?
       
      I'm currently considering having a WeaponController class that can contain a Weapon class, which calls all the methods I use to create unique effects in the weapon (Such as OnPlayerAttack()) when appropriate.
    • By Vu Chi Thien
      Hi fellow game devs,
      First, I would like to apologize for the wall of text.
      As you may notice I have been digging in vehicle simulation for some times now through my clutch question posts. And thanks to the generous help of you guys, especially @CombatWombat I have finished my clutch model (Really CombatWombat you deserve much more than a post upvote, I would buy you a drink if I could ha ha). 
      Now the final piece in my vehicle physic model is the differential. For now I have an open-differential model working quite well by just outputting torque 50-50 to left and right wheel. Now I would like to implement a Limited Slip Differential. I have very limited knowledge about LSD, and what I know about LSD is through readings on racer.nl documentation, watching Youtube videos, and playing around with games like Assetto Corsa and Project Cars. So this is what I understand so far:
      - The LSD acts like an open-diff when there is no torque from engine applied to the input shaft of the diff. However, in clutch-type LSD there is still an amount of binding between the left and right wheel due to preload spring.
      - When there is torque to the input shaft (on power and off power in 2 ways LSD), in ramp LSD, the ramp will push the clutch patch together, creating binding force. The amount of binding force depends on the amount of clutch patch and ramp angle, so the diff will not completely locked up and there is still difference in wheel speed between left and right wheel, but when the locking force is enough the diff will lock.
      - There also something I'm not sure is the amount of torque ratio based on road resistance torque (rolling resistance I guess)., but since I cannot extract rolling resistance from the tire model I'm using (Unity wheelCollider), I think I would not use this approach. Instead I'm going to use the speed difference in left and right wheel, similar to torsen diff. Below is my rough model with the clutch type LSD:
      speedDiff = leftWheelSpeed - rightWheelSpeed; //torque to differential input shaft. //first treat the diff as an open diff with equal torque to both wheels inputTorque = gearBoxTorque * 0.5f; //then modify torque to each wheel based on wheel speed difference //the difference in torque depends on speed difference, throttleInput (on/off power) //amount of locking force wanted at different amount of speed difference, //and preload force //torque to left wheel leftWheelTorque = inputTorque - (speedDiff * preLoadForce + lockingForce * throttleInput); //torque to right wheel rightWheelTorque = inputTorque + (speedDiff * preLoadForce + lockingForce * throttleInput); I'm putting throttle input in because from what I've read the amount of locking also depends on the amount of throttle input (harder throttle -> higher  torque input -> stronger locking). The model is nowhere near good, so please jump in and correct me.
      Also I have a few questions:
      - In torsen/geared LSD, is it correct that the diff actually never lock but only split torque based on bias ratio, which also based on speed difference between wheels? And does the bias only happen when the speed difference reaches the ratio (say 2:1 or 3:1) and below that it will act like an open diff, which basically like an open diff with an if statement to switch state?
      - Is it correct that the amount of locking force in clutch LSD depends on amount of input torque? If so, what is the threshold of the input torque to "activate" the diff (start splitting torque)? How can I get the amount of torque bias ratio (in wheelTorque = inputTorque * biasRatio) based on the speed difference or rolling resistance at wheel?
      - Is the speed at the input shaft of the diff always equals to the average speed of 2 wheels ie (left + right) / 2?
      Please help me out with this. I haven't found any topic about this yet on gamedev, and this is my final piece of the puzzle. Thank you guys very very much.
    • By Estra
      Memory Trees is a PC game and Life+Farming simulation game. Harvest Moon and Rune Factory , the game will be quite big. I believe that this will take a long time to finish
      Looking for
      Programmer
      1 experience using Unity/C++
      2 have a portfolio of Programmer
      3 like RPG game ( Rune rune factory / zelda series / FF series )
      4 Have responsibility + Time Management
      and friendly easy working with others Programmer willing to use Skype for communication with team please E-mail me if you're interested
      Split %: Revenue share. We can discuss. Fully Funded servers and contents
      and friendly easy working with others willing to use Skype for communication with team please E-mail me if you're interested
      we can talk more detail in Estherfanworld@gmail.com Don't comment here
      Thank you so much for reading
      More about our game
      Memory Trees : forget me not

      Thank you so much for reading
      Ps.Please make sure that you have unity skill and Have responsibility + Time Management,
      because If not it will waste time not one but both of us
       

  • Advertisement