Sign in to follow this  
serious_learner07

OpenGL glDrawElements crashing

Recommended Posts

Below is the opengl code for rendering a mesh using glDrawElements. The vertices and indices are read from a file. Application is crashing at glDrawElements. Please check the code(only relevant code have been included) and pin point the issue behind the crash.
struct Vertex
{
	float flx;
	float fly;
	float flz;
};
struct Vertex  vertices[500];
struct  Index
{
	int  index1;
	int  index2;
	int  index3;
};
struct Index  indices[1000];
// function pointer to OpenGL extensions
PFNGLDRAWRANGEELEMENTSPROC glDrawRangeElements = 0;
void draw()
{
    glEnableClientState(GL_NORMAL_ARRAY);
    glEnableClientState(GL_VERTEX_ARRAY);
    glVertexPointer(3, GL_FLOAT, 0, vertices);
    glPushMatrix();
	glTranslatef(0,0,2 );                // move to bottom-left
  	glDrawElements(GL_QUADS, 1000, GL_UNSIGNED_BYTE, indices);
    glPopMatrix();
    glDisableClientState(GL_VERTEX_ARRAY);  // disable vertex arrays
    glDisableClientState(GL_COLOR_ARRAY);
    glDisableClientState(GL_NORMAL_ARRAY);
}
void displayCB()
{
     glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT | GL_STENCIL_BUFFER_BIT);
    // save the initial ModelView matrix before modifying ModelView matrix
    glPushMatrix();
    // tramsform camera
    glTranslatef(0, 0, cameraDistance);
    glRotatef(cameraAngleX, 1, 0, 0);   // pitch
    glRotatef(cameraAngleY, 0, 1, 0);   // heading
	draw();        // with glDrawElements()
    glPopMatrix();
    glutSwapBuffers();
}

void initGL()
{
    initLights();
    setCamera(0, 0, 10, 0, 0, 0);
    	// Reading ivertices and indices from a  file.
	FILE *fpvert = fopen("C:\\cow-1000vert.txt", "r"); 
	for(int i = 0; i< 500;  i ++)
	{
		fscanf(fpvert,"%f", & vertices[i].flx);
		fscanf(fpvert,"%f", &vertices[i].fly);
		fscanf(fpvert,"%f", &vertices[i].flz);
	}
	fclose(fpvert);
	FILE *fpindex = fopen("C:\\cow-1000index.txt", "r"); 
	for(int i = 0; i< 1000;  i ++)
	{
		fscanf(fpindex,"%d", &indices[i].index1);
		fscanf(fpindex,"%d", &indices[i].index2);
		fscanf(fpindex,"%d", &indices[i].index3);
	}	
	fclose(fpindex);
}

///////////////////////////////////////////////////////////////////////////////
int main(int argc, char **argv)
{
    // get function pointer to glDrawRangeElements
    initGL(); 
    glutInit(&argc, argv);
    glutInitDisplayMode(GLUT_RGB | GLUT_DOUBLE | GLUT_DEPTH );         glutInitWindowSize(400, 300);               // window size
    glutInitWindowPosition(100, 100);           // window location
     int handle = glutCreateWindow(argv[0]);     // param is the title of window
        glutDisplayFunc(displayCB);
    glutReshapeFunc(reshapeCB);
    return handle;
    glDrawRangeElements = (PFNGLDRAWRANGEELEMENTSPROC)wglGetProcAddress("glDrawRangeElements");
    glutMainLoop(); /* Start GLUT event-processing loop */
    return 0;
}

Share this post


Link to post
Share on other sites
I'm new to openGL and havn't used this function before, so I just read about it then, but maybe it's because you're using GL_UNSIGNED_BYTE when your indices are ints, and you're trying to draw quads when indices only contains 3 numbers (so it's trying to read up to 4000 ints, when your array only contains 3000 ints).

If you want to draw quads:
Make your indices struct have 4 GLuints
the function call should be: glDrawElements(GL_QUADS, 1000, GL_UNSIGNED_INT, indices);

If you want to draw triangles:
Make your indices struct use 3 GLuints
the function call should be: glDrawElements(GL_TRIANGLES, 1000, GL_UNSIGNED_INT, indices);

Share this post


Link to post
Share on other sites
You enabled the normals array (GL_NORMAL_ARRAY), but never provided the normal pointer using glNormalPointer, so it's probably dereferencing a NULL pointer because of that. Don't enable the normals array if you aren't gonna use it, or provide normal data using glNormalPointer.

Share this post


Link to post
Share on other sites
That's probably has to do with the Index structure, as OpenGL only supports and uses only one index per vertex, and doesn't support different indices for each array. What's struct Index used for?

Share this post


Link to post
Share on other sites
My vertex file.

0.151632 -0.043319 -0.08824
0.163424 -0.033934 -0.08411
0.163118 -0.053632 -0.080509
0.176307 -0.028912 -0.075048
0.174429 -0.051613 -0.073945
0.186153 -0.032952 -0.063704
0.189315 -0.049201 -0.055717
0.173804 -0.063906 -0.070661
0.161034 -0.067741 -0.076137
0.140389 -0.06919 -0.082181
0.145322 -0.055406 -0.086283
0.157816 -0.075509 -0.073519
0.138192 -0.077096 -0.078394
0.154266 -0.085543 -0.067386
0.135011 -0.089151 -0.072101
0.149841 -0.099483 -0.056737
0.171041 -0.083631 -0.062782
0.168093 -0.09623 -0.053987
.....
.....
Total no of vertices 500

My index file.

3 1 4
4 2 3
2 4 6
4 1 5
7 8 4
8 200 6
200 278 2
1 10 11
11 5 1
13 12 14
15 13 14
19 205 15
205 20 13
20 206 16
22 417 418
.....
( Total no of indices 1000)


 struct Index indices[1000] 
defined for acessing the indices (see the code above).

[code]
As per your suggestion, I changed the code to (one index per vertex)
 struct Index indices[3000] 
...
glDrawElements(GL_TRIANGLES, 3000 GL_UNSIGNED_BYTE, indices);



Now the output looks like this.(Cow shape is formed with some noise)





[Edited by - serious_learner07 on June 4, 2009 11:40:33 PM]
I don't think changing the indices array to an array of 3000 ints will be any different, because it should produce the same as an array of 1000 structs containing 3 ints.

By the looks of the function call you are using:
glDrawElements(GL_TRIANGLES, 3000 GL_UNSIGNED_BYTE, indices);

You've still got GL_UNSIGNED_BYTE in there... Are your indices actually unsigned bytes?

Because if your indices are ints, each int will be read as 4 seperate numbers. So if you had an indices struct which had, say 4, 2 and 1 in it, this is what it would be like in memory:
0000 0000 0000 0100
0000 0000 0000 0010
0000 0000 0000 0001

and if you specified GL_UNSIGNED_BYTE in the call, then I imagine openGL would draw triangles these indices:
0, 0, 0 (first triangle drawn)
4, 0, 0
0, 2, 0
0, 0, 1

instead of 1 triangle with indices 4, 2 and 1.

I would try changing it back to the way you had it before, but store your indices as unsigned ints:

struct indices
{
Gluint a;
Gluint b;
Gluint c;
}

and call glDrawElements like this:
glDrawElements(GL_TRIANGLES, 1000, GL_UNSIGNED_INT, indices);

Tell me how it goes :)

Share this post


Link to post
Share on other sites



Oh sorry. It was a mistake. I copied from my old code.
Last output was based on GL_UNSIGNED_INT only.

But I have another question, How then output of
glDrawElements(GL_TRIANGLES, 1000, GL_UNSIGNED_INT, indices); and
glDrawElements(GL_TRIANGLES, 3000, GL_UNSIGNED_INT, indices); are different.




Share this post


Link to post
Share on other sites
So it still isn't working?

Quote:
Original post by serious_learner07
But I have another question, How then output of
glDrawElements(GL_TRIANGLES, 1000, GL_UNSIGNED_INT, indices); and
glDrawElements(GL_TRIANGLES, 3000, GL_UNSIGNED_INT, indices); are different.


Well like I said before I havn't used this function before so I'm just going by what the man page says. But it says that size specifies the number of elements to be drawn. So I imagine that it means, 1000 triangles, so it will expect an array of 3000 unsigned ints (or if it was quads, it would expect an array of 4000 indices if you have 1000 there). Otherwise I guess the man page would say it's the size of the indices array.

I'm not sure though. But if I'm wrong I'm sure someone will step in and tell me :)

Anyway, if it wasn't that then maybe you are reading the vert positions in incorrectly (because of the strange large square in the screenshot).

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Announcements

  • Forum Statistics

    • Total Topics
      628306
    • Total Posts
      2981940
  • Similar Content

    • By mellinoe
      Hi all,
      First time poster here, although I've been reading posts here for quite a while. This place has been invaluable for learning graphics programming -- thanks for a great resource!
      Right now, I'm working on a graphics abstraction layer for .NET which supports D3D11, Vulkan, and OpenGL at the moment. I have implemented most of my planned features already, and things are working well. Some remaining features that I am planning are Compute Shaders, and some flavor of read-write shader resources. At the moment, my shaders can just get simple read-only access to a uniform (or constant) buffer, a texture, or a sampler. Unfortunately, I'm having a tough time grasping the distinctions between all of the different kinds of read-write resources that are available. In D3D alone, there seem to be 5 or 6 different kinds of resources with similar but different characteristics. On top of that, I get the impression that some of them are more or less "obsoleted" by the newer kinds, and don't have much of a place in modern code. There seem to be a few pivots:
      The data source/destination (buffer or texture) Read-write or read-only Structured or unstructured (?) Ordered vs unordered (?) These are just my observations based on a lot of MSDN and OpenGL doc reading. For my library, I'm not interested in exposing every possibility to the user -- just trying to find a good "middle-ground" that can be represented cleanly across API's which is good enough for common scenarios.
      Can anyone give a sort of "overview" of the different options, and perhaps compare/contrast the concepts between Direct3D, OpenGL, and Vulkan? I'd also be very interested in hearing how other folks have abstracted these concepts in their libraries.
    • By aejt
      I recently started getting into graphics programming (2nd try, first try was many years ago) and I'm working on a 3d rendering engine which I hope to be able to make a 3D game with sooner or later. I have plenty of C++ experience, but not a lot when it comes to graphics, and while it's definitely going much better this time, I'm having trouble figuring out how assets are usually handled by engines.
      I'm not having trouble with handling the GPU resources, but more so with how the resources should be defined and used in the system (materials, models, etc).
      This is my plan now, I've implemented most of it except for the XML parts and factories and those are the ones I'm not sure of at all:
      I have these classes:
      For GPU resources:
      Geometry: holds and manages everything needed to render a geometry: VAO, VBO, EBO. Texture: holds and manages a texture which is loaded into the GPU. Shader: holds and manages a shader which is loaded into the GPU. For assets relying on GPU resources:
      Material: holds a shader resource, multiple texture resources, as well as uniform settings. Mesh: holds a geometry and a material. Model: holds multiple meshes, possibly in a tree structure to more easily support skinning later on? For handling GPU resources:
      ResourceCache<T>: T can be any resource loaded into the GPU. It owns these resources and only hands out handles to them on request (currently string identifiers are used when requesting handles, but all resources are stored in a vector and each handle only contains resource's index in that vector) Resource<T>: The handles given out from ResourceCache. The handles are reference counted and to get the underlying resource you simply deference like with pointers (*handle).  
      And my plan is to define everything into these XML documents to abstract away files:
      Resources.xml for ref-counted GPU resources (geometry, shaders, textures) Resources are assigned names/ids and resource files, and possibly some attributes (what vertex attributes does this geometry have? what vertex attributes does this shader expect? what uniforms does this shader use? and so on) Are reference counted using ResourceCache<T> Assets.xml for assets using the GPU resources (materials, meshes, models) Assets are not reference counted, but they hold handles to ref-counted resources. References the resources defined in Resources.xml by names/ids. The XMLs are loaded into some structure in memory which is then used for loading the resources/assets using factory classes:
      Factory classes for resources:
      For example, a texture factory could contain the texture definitions from the XML containing data about textures in the game, as well as a cache containing all loaded textures. This means it has mappings from each name/id to a file and when asked to load a texture with a name/id, it can look up its path and use a "BinaryLoader" to either load the file and create the resource directly, or asynchronously load the file's data into a queue which then can be read from later to create the resources synchronously in the GL context. These factories only return handles.
      Factory classes for assets:
      Much like for resources, these classes contain the definitions for the assets they can load. For example, with the definition the MaterialFactory will know which shader, textures and possibly uniform a certain material has, and with the help of TextureFactory and ShaderFactory, it can retrieve handles to the resources it needs (Shader + Textures), setup itself from XML data (uniform values), and return a created instance of requested material. These factories return actual instances, not handles (but the instances contain handles).
       
       
      Is this a good or commonly used approach? Is this going to bite me in the ass later on? Are there other more preferable approaches? Is this outside of the scope of a 3d renderer and should be on the engine side? I'd love to receive and kind of advice or suggestions!
      Thanks!
    • By nedondev
      I 'm learning how to create game by using opengl with c/c++ coding, so here is my fist game. In video description also have game contain in Dropbox. May be I will make it better in future.
      Thanks.
    • By Abecederia
      So I've recently started learning some GLSL and now I'm toying with a POM shader. I'm trying to optimize it and notice that it starts having issues at high texture sizes, especially with self-shadowing.
      Now I know POM is expensive either way, but would pulling the heightmap out of the normalmap alpha channel and in it's own 8bit texture make doing all those dozens of texture fetches more cheap? Or is everything in the cache aligned to 32bit anyway? I haven't implemented texture compression yet, I think that would help? But regardless, should there be a performance boost from decoupling the heightmap? I could also keep it in a lower resolution than the normalmap if that would improve performance.
      Any help is much appreciated, please keep in mind I'm somewhat of a newbie. Thanks!
    • By test opty
      Hi,
      I'm trying to learn OpenGL through a website and have proceeded until this page of it. The output is a simple triangle. The problem is the complexity.
      I have read that page several times and tried to analyse the code but I haven't understood the code properly and completely yet. This is the code:
       
      #include <glad/glad.h> #include <GLFW/glfw3.h> #include <C:\Users\Abbasi\Desktop\std_lib_facilities_4.h> using namespace std; //****************************************************************************** void framebuffer_size_callback(GLFWwindow* window, int width, int height); void processInput(GLFWwindow *window); // settings const unsigned int SCR_WIDTH = 800; const unsigned int SCR_HEIGHT = 600; const char *vertexShaderSource = "#version 330 core\n" "layout (location = 0) in vec3 aPos;\n" "void main()\n" "{\n" " gl_Position = vec4(aPos.x, aPos.y, aPos.z, 1.0);\n" "}\0"; const char *fragmentShaderSource = "#version 330 core\n" "out vec4 FragColor;\n" "void main()\n" "{\n" " FragColor = vec4(1.0f, 0.5f, 0.2f, 1.0f);\n" "}\n\0"; //******************************* int main() { // glfw: initialize and configure // ------------------------------ glfwInit(); glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 3); glfwWindowHint(GLFW_CONTEXT_VERSION_MINOR, 3); glfwWindowHint(GLFW_OPENGL_PROFILE, GLFW_OPENGL_CORE_PROFILE); // glfw window creation GLFWwindow* window = glfwCreateWindow(SCR_WIDTH, SCR_HEIGHT, "My First Triangle", nullptr, nullptr); if (window == nullptr) { cout << "Failed to create GLFW window" << endl; glfwTerminate(); return -1; } glfwMakeContextCurrent(window); glfwSetFramebufferSizeCallback(window, framebuffer_size_callback); // glad: load all OpenGL function pointers if (!gladLoadGLLoader((GLADloadproc)glfwGetProcAddress)) { cout << "Failed to initialize GLAD" << endl; return -1; } // build and compile our shader program // vertex shader int vertexShader = glCreateShader(GL_VERTEX_SHADER); glShaderSource(vertexShader, 1, &vertexShaderSource, nullptr); glCompileShader(vertexShader); // check for shader compile errors int success; char infoLog[512]; glGetShaderiv(vertexShader, GL_COMPILE_STATUS, &success); if (!success) { glGetShaderInfoLog(vertexShader, 512, nullptr, infoLog); cout << "ERROR::SHADER::VERTEX::COMPILATION_FAILED\n" << infoLog << endl; } // fragment shader int fragmentShader = glCreateShader(GL_FRAGMENT_SHADER); glShaderSource(fragmentShader, 1, &fragmentShaderSource, nullptr); glCompileShader(fragmentShader); // check for shader compile errors glGetShaderiv(fragmentShader, GL_COMPILE_STATUS, &success); if (!success) { glGetShaderInfoLog(fragmentShader, 512, nullptr, infoLog); cout << "ERROR::SHADER::FRAGMENT::COMPILATION_FAILED\n" << infoLog << endl; } // link shaders int shaderProgram = glCreateProgram(); glAttachShader(shaderProgram, vertexShader); glAttachShader(shaderProgram, fragmentShader); glLinkProgram(shaderProgram); // check for linking errors glGetProgramiv(shaderProgram, GL_LINK_STATUS, &success); if (!success) { glGetProgramInfoLog(shaderProgram, 512, nullptr, infoLog); cout << "ERROR::SHADER::PROGRAM::LINKING_FAILED\n" << infoLog << endl; } glDeleteShader(vertexShader); glDeleteShader(fragmentShader); // set up vertex data (and buffer(s)) and configure vertex attributes float vertices[] = { -0.5f, -0.5f, 0.0f, // left 0.5f, -0.5f, 0.0f, // right 0.0f, 0.5f, 0.0f // top }; unsigned int VBO, VAO; glGenVertexArrays(1, &VAO); glGenBuffers(1, &VBO); // bind the Vertex Array Object first, then bind and set vertex buffer(s), //and then configure vertex attributes(s). glBindVertexArray(VAO); glBindBuffer(GL_ARRAY_BUFFER, VBO); glBufferData(GL_ARRAY_BUFFER, sizeof(vertices), vertices, GL_STATIC_DRAW); glVertexAttribPointer(0, 3, GL_FLOAT, GL_FALSE, 3 * sizeof(float), (void*)0); glEnableVertexAttribArray(0); // note that this is allowed, the call to glVertexAttribPointer registered VBO // as the vertex attribute's bound vertex buffer object so afterwards we can safely unbind glBindBuffer(GL_ARRAY_BUFFER, 0); // You can unbind the VAO afterwards so other VAO calls won't accidentally // modify this VAO, but this rarely happens. Modifying other // VAOs requires a call to glBindVertexArray anyways so we generally don't unbind // VAOs (nor VBOs) when it's not directly necessary. glBindVertexArray(0); // uncomment this call to draw in wireframe polygons. //glPolygonMode(GL_FRONT_AND_BACK, GL_LINE); // render loop while (!glfwWindowShouldClose(window)) { // input // ----- processInput(window); // render // ------ glClearColor(0.2f, 0.3f, 0.3f, 1.0f); glClear(GL_COLOR_BUFFER_BIT); // draw our first triangle glUseProgram(shaderProgram); glBindVertexArray(VAO); // seeing as we only have a single VAO there's no need to // bind it every time, but we'll do so to keep things a bit more organized glDrawArrays(GL_TRIANGLES, 0, 3); // glBindVertexArray(0); // no need to unbind it every time // glfw: swap buffers and poll IO events (keys pressed/released, mouse moved etc.) glfwSwapBuffers(window); glfwPollEvents(); } // optional: de-allocate all resources once they've outlived their purpose: glDeleteVertexArrays(1, &VAO); glDeleteBuffers(1, &VBO); // glfw: terminate, clearing all previously allocated GLFW resources. glfwTerminate(); return 0; } //************************************************** // process all input: query GLFW whether relevant keys are pressed/released // this frame and react accordingly void processInput(GLFWwindow *window) { if (glfwGetKey(window, GLFW_KEY_ESCAPE) == GLFW_PRESS) glfwSetWindowShouldClose(window, true); } //******************************************************************** // glfw: whenever the window size changed (by OS or user resize) this callback function executes void framebuffer_size_callback(GLFWwindow* window, int width, int height) { // make sure the viewport matches the new window dimensions; note that width and // height will be significantly larger than specified on retina displays. glViewport(0, 0, width, height); } As you see, about 200 lines of complicated code only for a simple triangle. 
      I don't know what parts are necessary for that output. And also, what the correct order of instructions for such an output or programs is, generally. That start point is too complex for a beginner of OpenGL like me and I don't know how to make the issue solved. What are your ideas please? What is the way to figure both the code and the whole program out correctly please?
      I wish I'd read a reference that would teach me OpenGL through a step-by-step method. 
  • Popular Now