• Advertisement
Sign in to follow this  

OpenGL Lighting GLSL 1.5

This topic is 2997 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

I'm having a weird problem with my lighting. I think the cause is the normals which I feed a mat3x3 to the shader to multiply against the normal going into the shader. I'm trying to attempt just opengl 3.2 core functionality. My matrices are correct the only matrix that's most likely not correct is my normal matrix. I was reading that the normal matrix is the inverse of the model matrix transposed but doing that doesn't seem to change anything. PROBLEM: Whatever the case the cube is lighted on the inside instead of the outside. Yes the uniforms do get the data as I've tested each one to make sure. I tried switching the normals around but it did nothing. The cube is hard-coded so I set 36 vertices to get all normal directions. An image of what's going on: Here
//Vertex Shader

#version 150 core


uniform transform
{
	mat4 MVP;
	
} Transform;

in attrib
{
	vec3 Position;
} Attrib;

uniform vec3 lightPosition;

uniform mat3 NormalMatrix;

in  vec3 Normal;

out vec3 normal; 
out vec3 lightDir;
out vec3 eyeDir;



void main()
{

	vec4 vVertex = Transform.MVP * vec4(Attrib.Position, 1.0);
	vec4 LP = Transform.MVP * vec4(lightPosition, 1.0);
	vec3 N = NormalMatrix * (Normal);
	
	
	normal = N.xyz;
	lightDir = LP.xyz - vVertex.xyz;
	eyeDir   = -vVertex.xyz;
	
	gl_Position = vVertex;
}










//Fragment Shader

#version 150 core

out frag
{
	vec4 Color;
} Frag;

uniform vec4 color;
uniform vec4 specularcolor;
uniform vec4 ambient;
uniform float shine;


in vec3 normal; 
in vec3 lightDir;
in vec3 eyeDir;

void main()
{
	vec4 matColor = vec4(1.0, 1.0, 1.0, 1.0);

	vec4 finalColor = ambient;
	
	vec3 N = normalize(normal);
	vec3 L = normalize(lightDir);
	
	float lambertTerm = dot(N, L);
	
	if( lambertTerm > 0.0 )
	{
		finalColor = color * matColor * lambertTerm;
		
		vec3 E = normalize(eyeDir);
		vec3 R = reflect(-L, N);
		
		float specularpower = pow( max( dot(R, E), 0.0 ), shine);
		
		finalColor += specularcolor * vec4(0.8, 0.8, 0.8, 1.0) * specularpower;
	}


	Frag.Color = finalColor;

}








//Code

    Mat4X4lookAtCam = LookAtMatrix(movement[0], movement[1], movement[2], movement[4], 0.0f, 0.0f, 0.0f, 0.0f, 1.0f);
    gluLookAt(movement[0], movement[1], movement[2], movement[4], 0.0f, 0.0f, 0.0f, 0.0f, 1.0f);

    Mat4X4 MVP;
    Mat4X4 world;
    Mat4X4 scale;
    Mat4X4 trans;
    Mat4X4 rot;

    scale = MatrixScale(1.0f, 1.0f, 1.0f);
    trans = MatrixTranslation(0.0f, 0.0f, 0.0f);
    world = scale * trans;

    MVP =  world * lookAtCam * projection;
 
    Mat3X3 NormalMatrix;
    NormalMatrix.identityClear();

    NormalMatrix = MatrixInverse( MVP );
    NormalMatrix = MatrixTranspose( NormalMatrix );


    ////////////////////////
    ////////////////////////
    ////////////////////////

    glColor3f(0.0,1.0,0.0);
    glPointSize(10.0);
    glBegin( GL_POINTS );
        glVertex3f(2.0, 2.0, 3.0);
    glEnd();

    lightProp.color = Vec4(1.0f, 1.0f, 1.0f, 1.0f);
    lightProp.ambientColor = Vec4(0.2f, 0.2f, 0.2f, 1.0f);
    lightProp.specColor = Vec4(0.0f, 0.0f, 1.0f, 1.0f);
    lightProp.shine = 2.0f;

    glProgramUniformMatrix3fvEXT(pointlight_shader_15->GetHandle(), UniformNormalMatrix, 1, GL_FALSE, &NormalMatrix.matrixA[0]);

    glProgramUniform3fEXT(pointlight_shader_15->GetHandle(), uniformLP, 2.0f, 2.0f, 3.0f);

    glProgramUniform4fvEXT(pointlight_shader_15->GetHandle(), LColor, 1, lightProp.color.getXYZW());
    glProgramUniform4fvEXT(pointlight_shader_15->GetHandle(), LSpec , 1, lightProp.specColor.getXYZW());
    glProgramUniform4fvEXT(pointlight_shader_15->GetHandle(), LAmb  , 1, lightProp.ambientColor.getXYZW());
    glProgramUniform1fEXT (pointlight_shader_15->GetHandle(), LShine, lightProp.shine);

    pointlight_shader_15->UseShader();

    glBindBuffer( GL_UNIFORM_BUFFER, UniformBufferTransPHandle );
        glBufferSubData( GL_UNIFORM_BUFFER, 0, sizeof(MVP), &MVP.matrixA[0]);

    glBindBuffer(GL_UNIFORM_BUFFER, 0);

    myCube->Draw(); //Calls a VAO. Also though it's not shown I did make sure that the attributes were set correctly for position and normal

    pointlight_shader_15->StopShader();










Share this post


Link to post
Share on other sites
Advertisement
Perhaps your vertices are in the wrong order?
Try switching between glFrontFace(GL_CW) and glFrontFace(GL_CCW), or glDisable(GL_CULL_FACE) to disable face culling.

Share this post


Link to post
Share on other sites
I thought that would do the trick but it doesn't affect anything. Does glFrontFace affect some matrix?

Share this post


Link to post
Share on other sites
No, it decides which faces are visible. Triangles are usually considered having a front and a back side, and your image seems to indicate that you see the faces on the opposite side of the cube (the inside should be back-facing, if the cube is supposed to be viewed from the outside). The problem could also be with depth-testing, in case the further faces are drawn after the first ones, without face-culling. Do you enable depth-testing with glEnable(GL_DEPTH_TEST), and clear the depth buffer with glClear(GL_DEPTH_BUFFER_BIT)?

Share this post


Link to post
Share on other sites
Original post by Asem
    glColor3f(0.0,1.0,0.0);
glPointSize(10.0);
glBegin( GL_POINTS );
glVertex3f(2.0, 2.0, 3.0);
glEnd();




What is this? This is definitely not 3.2 core.

Share this post


Link to post
Share on other sites
I know what glFrontFace does. I kinda made it seem like I didn't but for whatever reason it didn't work. GL_DEPTH_TEST is enabled too.

Yes, I know that is not opengl 3.2 core code. I did it to be clear on where the light is positioned.

I have it on compatibility mode and I avoid it in pretty much all my code except that one bit of code. I didn't feel like trying to create some type of buffer for one point and etc although I probably could have just used the geometry shader to pull that off. Even though I'm using the compatibility mode this doesn't stop the shader from working. Also if I try to use the core opengl crashes if I use glSubBuffer which I find really weird. (nvidia 9500 gt)

I made 2 separate buffers. 1 for the position data and another for the normal data because I didn't want to think about offsetting the data but I do make sure they match.

This should be okay right? I might have missed something that has completely skipped my mind since I don't really run into this situation.



//Cube Data

//Bottom
vertices[0] = vector_math::Vec3<float>(-1.0f, 1.0f, -1.0f); normals[0] = vector_math::Vec3<float>(0.0f, 0.0f, -1.0f);
vertices[1] = vector_math::Vec3<float>( 1.0f, -1.0f, -1.0f); normals[1] = vector_math::Vec3<float>(0.0f, 0.0f, -1.0f);
vertices[2] = vector_math::Vec3<float>(-1.0f, -1.0f, -1.0f); normals[2] = vector_math::Vec3<float>(0.0f, 0.0f, -1.0f);
vertices[3] = vector_math::Vec3<float>(-1.0f, 1.0f, -1.0f); normals[3] = vector_math::Vec3<float>(0.0f, 0.0f, -1.0f);
vertices[4] = vector_math::Vec3<float>( 1.0f, 1.0f, -1.0f); normals[4] = vector_math::Vec3<float>(0.0f, 0.0f, -1.0f);
vertices[5] = vector_math::Vec3<float>( 1.0f, -1.0f, -1.0f); normals[5] = vector_math::Vec3<float>(0.0f, 0.0f, -1.0f);

//Top
vertices[6] = vector_math::Vec3<float>(-1.0f, 1.0f, 1.0f); normals[6] = vector_math::Vec3<float>(0.0f, 0.0f, 1.0f);
vertices[7] = vector_math::Vec3<float>( 1.0f, -1.0f, 1.0f); normals[7] = vector_math::Vec3<float>(0.0f, 0.0f, 1.0f);
vertices[8] = vector_math::Vec3<float>(-1.0f, -1.0f, 1.0f); normals[8] = vector_math::Vec3<float>(0.0f, 0.0f, 1.0f);
vertices[9] = vector_math::Vec3<float>(-1.0f, 1.0f, 1.0f); normals[9] = vector_math::Vec3<float>(0.0f, 0.0f, 1.0f);
vertices[10] = vector_math::Vec3<float>( 1.0f, 1.0f, 1.0f); normals[10] = vector_math::Vec3<float>(0.0f, 0.0f, 1.0f);
vertices[11] = vector_math::Vec3<float>( 1.0f, -1.0f, 1.0f); normals[11] = vector_math::Vec3<float>(0.0f, 0.0f, 1.0f);

//Left
vertices[12] = vector_math::Vec3<float>(-1.0f, -1.0f, 1.0f); normals[12] = vector_math::Vec3<float>(0.0f, -1.0f, 0.0f);
vertices[13] = vector_math::Vec3<float>( 1.0f, -1.0f, -1.0f); normals[13] = vector_math::Vec3<float>(0.0f, -1.0f, 0.0f);
vertices[14] = vector_math::Vec3<float>(-1.0f, -1.0f, -1.0f); normals[14] = vector_math::Vec3<float>(0.0f, -1.0f, 0.0f);
vertices[15] = vector_math::Vec3<float>(-1.0f, -1.0f, 1.0f); normals[15] = vector_math::Vec3<float>(0.0f, -1.0f, 0.0f);
vertices[16] = vector_math::Vec3<float>( 1.0f, -1.0f, 1.0f); normals[16] = vector_math::Vec3<float>(0.0f, -1.0f, 0.0f);
vertices[17] = vector_math::Vec3<float>( 1.0f, -1.0f, -1.0f); normals[17] = vector_math::Vec3<float>(0.0f, -1.0f, 0.0f);

//Right
vertices[18] = vector_math::Vec3<float>(-1.0f, 1.0f, 1.0f); normals[18] = vector_math::Vec3<float>(0.0f, 1.0f, 0.0f);
vertices[19] = vector_math::Vec3<float>( 1.0f, 1.0f, -1.0f); normals[19] = vector_math::Vec3<float>(0.0f, 1.0f, 0.0f);
vertices[20] = vector_math::Vec3<float>(-1.0f, 1.0f, -1.0f); normals[20] = vector_math::Vec3<float>(0.0f, 1.0f, 0.0f);
vertices[21] = vector_math::Vec3<float>(-1.0f, 1.0f, 1.0f); normals[21] = vector_math::Vec3<float>(0.0f, 1.0f, 0.0f);
vertices[22] = vector_math::Vec3<float>( 1.0f, 1.0f, 1.0f); normals[22] = vector_math::Vec3<float>(0.0f, 1.0f, 0.0f);
vertices[23] = vector_math::Vec3<float>( 1.0f, 1.0f, -1.0f); normals[23] = vector_math::Vec3<float>(0.0f, 1.0f, 0.0f);

//Back
vertices[24] = vector_math::Vec3<float>(-1.0f, -1.0f, 1.0f); normals[24] = vector_math::Vec3<float>(-1.0f, 0.0f, 0.0f);
vertices[25] = vector_math::Vec3<float>(-1.0f, 1.0f, -1.0f); normals[25] = vector_math::Vec3<float>(-1.0f, 0.0f, 0.0f);
vertices[26] = vector_math::Vec3<float>(-1.0f, -1.0f, -1.0f); normals[26] = vector_math::Vec3<float>(-1.0f, 0.0f, 0.0f);
vertices[27] = vector_math::Vec3<float>(-1.0f, -1.0f, 1.0f); normals[27] = vector_math::Vec3<float>(-1.0f, 0.0f, 0.0f);
vertices[28] = vector_math::Vec3<float>(-1.0f, 1.0f, 1.0f); normals[28] = vector_math::Vec3<float>(-1.0f, 0.0f, 0.0f);
vertices[29] = vector_math::Vec3<float>(-1.0f, 1.0f, -1.0f); normals[29] = vector_math::Vec3<float>(-1.0f, 0.0f, 0.0f);

//Front
vertices[30] = vector_math::Vec3<float>( 1.0f, -1.0f, 1.0f); normals[30] = vector_math::Vec3<float>( 1.0f, 0.0f, 0.0f);
vertices[31] = vector_math::Vec3<float>( 1.0f, 1.0f, -1.0f); normals[31] = vector_math::Vec3<float>( 1.0f, 0.0f, 0.0f);
vertices[32] = vector_math::Vec3<float>( 1.0f, -1.0f, -1.0f); normals[32] = vector_math::Vec3<float>( 1.0f, 0.0f, 0.0f);
vertices[33] = vector_math::Vec3<float>( 1.0f, -1.0f, 1.0f); normals[33] = vector_math::Vec3<float>( 1.0f, 0.0f, 0.0f);
vertices[34] = vector_math::Vec3<float>( 1.0f, 1.0f, 1.0f); normals[34] = vector_math::Vec3<float>( 1.0f, 0.0f, 0.0f);
vertices[35] = vector_math::Vec3<float>( 1.0f, 1.0f, -1.0f); normals[35] = vector_math::Vec3<float>( 1.0f, 0.0f, 0.0f);

for(int i=0; i<36; i++)
indices = i;

glBindBuffer(GL_ARRAY_BUFFER, vertexBuffer);
glBufferData(GL_ARRAY_BUFFER, sizeof(vertices), vertices, GL_STATIC_DRAW);

glBindBuffer(GL_ARRAY_BUFFER, normalBuffer);
glBufferData(GL_ARRAY_BUFFER, sizeof(normals), normals, GL_STATIC_DRAW);

glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, iBuffer);
glBufferData(GL_ELEMENT_ARRAY_BUFFER, sizeof(indices), indices, GL_STATIC_DRAW );


glBindVertexArray(vaoBuffer);
glBindBuffer(GL_ARRAY_BUFFER, vertexBuffer);
glVertexAttribPointer(attribVertex, 3, GL_FLOAT, GL_FALSE, sizeof(vector_math::Vec3<float>), 0);

glBindBuffer(GL_ARRAY_BUFFER, normalBuffer);
glVertexAttribPointer(attribNormal, 3, GL_FLOAT, GL_FALSE, sizeof(vector_math::Vec3<float>), 0);

glEnableVertexAttribArray(attribVertex);
glEnableVertexAttribArray(attribNormal);

glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, iBuffer);

glBindVertexArray(0);







[Edited by - Asem on December 5, 2009 7:41:12 PM]

Share this post


Link to post
Share on other sites
solved it. I thought the vertices were in the right order as I've checked over them many times but I was wrong oops. Thank you guys for the suggestions though. [freaking duh on my part!]

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Tags

  • Advertisement
  • Popular Now

  • Similar Content

    • By LifeArtist
      Good Evening,
      I want to make a 2D game which involves displaying some debug information. Especially for collision, enemy sights and so on ...
      First of I was thinking about all those shapes which I need will need for debugging purposes: circles, rectangles, lines, polygons.
      I am really stucked right now because of the fundamental question:
      Where do I store my vertices positions for each line (object)? Currently I am not using a model matrix because I am using orthographic projection and set the final position within the VBO. That means that if I add a new line I would have to expand the "points" array and re-upload (recall glBufferData) it every time. The other method would be to use a model matrix and a fixed vbo for a line but it would be also messy to exactly create a line from (0,0) to (100,20) calculating the rotation and scale to make it fit.
      If I proceed with option 1 "updating the array each frame" I was thinking of having 4 draw calls every frame for the lines vao, polygons vao and so on. 
      In addition to that I am planning to use some sort of ECS based architecture. So the other question would be:
      Should I treat those debug objects as entities/components?
      For me it would make sense to treat them as entities but that's creates a new issue with the previous array approach because it would have for example a transform and render component. A special render component for debug objects (no texture etc) ... For me the transform component is also just a matrix but how would I then define a line?
      Treating them as components would'nt be a good idea in my eyes because then I would always need an entity. Well entity is just an id !? So maybe its a component?
      Regards,
      LifeArtist
    • By QQemka
      Hello. I am coding a small thingy in my spare time. All i want to achieve is to load a heightmap (as the lowest possible walking terrain), some static meshes (elements of the environment) and a dynamic character (meaning i can move, collide with heightmap/static meshes and hold a varying item in a hand ). Got a bunch of questions, or rather problems i can't find solution to myself. Nearly all are deal with graphics/gpu, not the coding part. My c++ is on high enough level.
      Let's go:
      Heightmap - i obviously want it to be textured, size is hardcoded to 256x256 squares. I can't have one huge texture stretched over entire terrain cause every pixel would be enormous. Thats why i decided to use 2 specified textures. First will be a tileset consisting of 16 square tiles (u v range from 0 to 0.25 for first tile and so on) and second a 256x256 buffer with 0-15 value representing index of the tile from tileset for every heigtmap square. Problem is, how do i blend the edges nicely and make some computationally cheap changes so its not obvious there are only 16 tiles? Is it possible to generate such terrain with some existing program?
      Collisions - i want to use bounding sphere and aabb. But should i store them for a model or entity instance? Meaning i have 20 same trees spawned using the same tree model, but every entity got its own transformation (position, scale etc). Storing collision component per instance grats faster access + is precalculated and transformed (takes additional memory, but who cares?), so i stick with this, right? What should i do if object is dynamically rotated? The aabb is no longer aligned and calculating per vertex min/max everytime object rotates/scales is pretty expensive, right?
      Drawing aabb - problem similar to above (storing aabb data per instance or model). This time in my opinion per model is enough since every instance also does not have own vertex buffer but uses the shared one (so 20 trees share reference to one tree model). So rendering aabb is about taking the model's aabb, transforming with instance matrix and voila. What about aabb vertex buffer (this is more of a cosmetic question, just curious, bumped onto it in time of writing this). Is it better to make it as 8 points and index buffer (12 lines), or only 2 vertices with min/max x/y/z and having the shaders dynamically generate 6 other vertices and draw the box? Or maybe there should be just ONE 1x1x1 cube box template moved/scaled per entity?
      What if one model got a diffuse texture and a normal map, and other has only diffuse? Should i pass some bool flag to shader with that info, or just assume that my game supports only diffuse maps without fancy stuff?
      There were several more but i forgot/solved them at time of writing
      Thanks in advance
    • By RenanRR
      Hi All,
      I'm reading the tutorials from learnOpengl site (nice site) and I'm having a question on the camera (https://learnopengl.com/Getting-started/Camera).
      I always saw the camera being manipulated with the lookat, but in tutorial I saw the camera being changed through the MVP arrays, which do not seem to be camera, but rather the scene that changes:
      Vertex Shader:
      #version 330 core layout (location = 0) in vec3 aPos; layout (location = 1) in vec2 aTexCoord; out vec2 TexCoord; uniform mat4 model; uniform mat4 view; uniform mat4 projection; void main() { gl_Position = projection * view * model * vec4(aPos, 1.0f); TexCoord = vec2(aTexCoord.x, aTexCoord.y); } then, the matrix manipulated:
      ..... glm::mat4 projection = glm::perspective(glm::radians(fov), (float)SCR_WIDTH / (float)SCR_HEIGHT, 0.1f, 100.0f); ourShader.setMat4("projection", projection); .... glm::mat4 view = glm::lookAt(cameraPos, cameraPos + cameraFront, cameraUp); ourShader.setMat4("view", view); .... model = glm::rotate(model, glm::radians(angle), glm::vec3(1.0f, 0.3f, 0.5f)); ourShader.setMat4("model", model);  
      So, some doubts:
      - Why use it like that?
      - Is it okay to manipulate the camera that way?
      -in this way, are not the vertex's positions that changes instead of the camera?
      - I need to pass MVP to all shaders of object in my scenes ?
       
      What it seems, is that the camera stands still and the scenery that changes...
      it's right?
       
       
      Thank you
       
    • By dpadam450
      Sampling a floating point texture where the alpha channel holds 4-bytes of packed data into the float. I don't know how to cast the raw memory to treat it as an integer so I can perform bit-shifting operations.

      int rgbValue = int(textureSample.w);//4 bytes of data packed as color
      // algorithm might not be correct and endianness might need switching.
      vec3 extractedData = vec3(  rgbValue & 0xFF000000,  (rgbValue << 8) & 0xFF000000, (rgbValue << 16) & 0xFF000000);
      extractedData /= 255.0f;
    • By Devashish Khandelwal
      While writing a simple renderer using OpenGL, I faced an issue with the glGetUniformLocation function. For some reason, the location is coming to be -1.
      Anyone has any idea .. what should I do?
  • Advertisement