• Advertisement
Sign in to follow this  

OpenGL GLSL confusion

This topic is 2992 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Edit: Rewrote this first post, since noone were interested. I will be trying to get a grip of GLSL in another way instead. So, the first thing I've got to ask is how this texturing thing works. I've got shader designer 1.6 at it's working with these shaders:
// vertex shader
varying vec3 lightDir, normal;

void main(){
	normal = normalize(gl_NormalMatrix * gl_Normal);
	lightDir = normalize(vec3(gl_LightSource[0].position));

	gl_TexCoord[0] = gl_MultiTexCoord0;
	
	gl_Position = ftransform();
}


// fragment shader
varying vec3 lightDir, normal;
uniform sampler2D tex;

void main(){
	vec3 ct, cf;
	vec4 texel;
	float intensity, at, af;
	
	intensity = max(dot(lightDir, normalize(normal)), 0.0);
	
	cf = intensity * (gl_FrontMaterial.diffuse).rgb + gl_FrontMaterial.ambient.rgb;
	af = gl_FrontMaterial.diffuse.a;
	
	texel = texture2D(tex, gl_TexCoord[0].st);
	ct = texel.rgb;
	at = texel.a;
	
	gl_FragColor = vec4(ct * cf, at * af) * 2;
}

But it doesn't work in my OpenGL application. I create my texture like this:
glGenTextures(1, &texture[0].texID);
glBindTexture(GL_TEXTURE_2D, texture[0].texID);
glTexEnvf(GL_TEXTURE_ENV, GL_TEXTURE_ENV_MODE, GL_MODULATE);
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR);
glTexImage2D(GL_TEXTURE_2D, 0, 3,texture[0].width, texture[0].height,
		0, GL_RGB, GL_UNSIGNED_BYTE, texture[0].imageData);

Then I bind it where I create my globe, like this (and this is where I also create the uniform)
glTranslatef(potX, potY, 0.0f);

glActiveTexture(GL_TEXTURE0);
int tex_loc = glGetUniformLocation(shader.id(), "tex");
glUniform1i(tex_loc, 0);
glBindTexture(GL_TEXTURE_2D, texture[0].texID);

glRotatef(-65.0f, 0, 1, 0);
glCallList(globe);

I have to say, that it doesn't really seem to matter if I initialize my shaders or not. No errors in my program. It compiles and shows my globe and the text and the star field behind it. The light is there (can't really tell if I'm using fragment lighting or not). I also do not see the big deal with shaders if I have to do what I've allways done and then create a shader to do it again? I've been using the Lighthouse2D and Swiftless tutorials to get to this point. Here's to hoping someone might want to give a hand :) Thanks, Marcus Axelsson [Edited by - tre on December 9, 2009 10:52:22 AM]

Share this post


Link to post
Share on other sites
Advertisement
Sorry for bumping this. But the OP has been totally edited and the thread has a new direction :)

Share this post


Link to post
Share on other sites
I don't see that you even activated the shader program, that might be you're problem: glUseProgramObjectARB(ShaderProgram);

Are you using some sort of class to manage shaders? The problem could be with something associated to that. Did you forget to instantiate/configure anything?

Also, create a 'varying vec2 TexCoord' instead. Then in the vertex shader assign it: TexCoord = gl_MultiTexCoord0.st, in the fragment shader you then access TexCoord instead. I can't remember off the top of my head the reason for it, but that's the recommended approach in the OpenGL spec. I'll have to look it up later and ref.

Oh, don't forget to disable the shader afterwards, or use a new one.
glUseProgramObjectARB(0);

[Edited by - npeqp on December 9, 2009 11:07:10 AM]

Share this post


Link to post
Share on other sites
Quote:
Original post by npeqp
I don't see that you even activated the shader program, that might be you're problem: glUseProgramObjectARB(ShaderProgram);

Are you using some sort of class to manage shaders? The problem could be with something associated to that. Did you forget to instantiate/configure anything?

Also, create a 'varying vec2 TexCoord' instead. Then in the vertex shader assign it: TexCoord = gl_MultiTexCoord0.st, in the fragment shader you then access TexCoord instead. I can't remember off the top of my head the reason for it, but that's the recommended approach in the OpenGL spec. I'll have to look it up later and ref.

Oh, don't forget to disable the shader afterwards, or use a new one.
glUseProgramObjectARB(0);


I use a shader class:
// snippet from "shaderProcessor.h"
class Shader {
public:
Shader();
Shader(const char *vsFile, const char *fsFile);
~Shader();

void init(const char *vsFile, const char *fsFile);

void bind();
void unbind();

unsigned int id();
private:
unsigned int shader_id;
unsigned int shader_vp;
unsigned int shader_fp;
};


Which I use to create my shaders.
// snippet from "shaderProcessor.cpp"
...
void Shader::init(const char *vsFile, const char *fsFile){
shader_vp = glCreateShader(GL_VERTEX_SHADER);
shader_fp = glCreateShader(GL_FRAGMENT_SHADER);

const char *vsText = textFileRead(vsFile);
const char *fsText = textFileRead(fsFile);

if(vsText == NULL || fsText == NULL){
// felmeddelande
return;
}

glShaderSource(shader_vp, 1, &vsText, 0);
glShaderSource(shader_fp, 1, &fsText, 0);

glCompileShader(shader_vp);
glCompileShader(shader_fp);

shader_id = glCreateProgram();
glAttachShader(shader_id, shader_fp);
glAttachShader(shader_id, shader_vp);
glLinkProgram(shader_id);
}
...

I use glUseProgram(0) to unbind shaders.

Then to initialize a shader I call shader.init("test.vert", "test.frag");.

Share this post


Link to post
Share on other sites
How do you set up the display list? (what calls are in it etc)
I would suggest starting with a minimal triangle and no lighting or anything, to make it easier to troubleshoot. I don't really understand what the problem is, is it just that the texture isn't showing, but the rest seems fine?
You should also check the result of glCompileShader, as it can fail if there's a typo or something in the shader code.

Share this post


Link to post
Share on other sites
Quote:
Original post by Erik Rufelt
How do you set up the display list? (what calls are in it etc)
I would suggest starting with a minimal triangle and no lighting or anything, to make it easier to troubleshoot. I don't really understand what the problem is, is it just that the texture isn't showing, but the rest seems fine?
You should also check the result of glCompileShader, as it can fail if there's a typo or something in the shader code.


The problem is that no matter what I do in the shader I'm not seeing any results. This row in the vertex shader: texCoord = gl_MultiTexCoord0.st * 0; should result in me not having a texture at all (as in Shader Designer 1.6). But the texture shows anyway.
This makes me wonder if I'm using any shaders at all.

This is how I set up my display lists
void buildLists(void){
Vertices vGlobe, vStars;
vGlobe.vPos("models/globe2.obj");
vStars.vPos("models/starmodel.obj");

int i = 0;

globe = glGenLists(1);
glNewList(globe, GL_COMPILE);
glBegin(GL_TRIANGLES);
glColor3f(0.0f, 1.0f, 0.0f);
for(i = 0; i < (int)vGlobe.f_v1.size(); i++){
glNormal3f(vGlobe.vNx[vGlobe.f_n1], vGlobe.vNy[vGlobe.f_n1], vGlobe.vNz[vGlobe.f_n1]);
glTexCoord3f(vGlobe.vTu[vGlobe.f_vt1], vGlobe.vTv[vGlobe.f_vt1], vGlobe.vTw[vGlobe.f_vt1]);
glVertex3f(vGlobe.vX[vGlobe.f_v1], vGlobe.vY[vGlobe.f_v1], vGlobe.vZ[vGlobe.f_v1]);

glNormal3f(vGlobe.vNx[vGlobe.f_n2], vGlobe.vNy[vGlobe.f_n2], vGlobe.vNz[vGlobe.f_n2]);
glTexCoord3f(vGlobe.vTu[vGlobe.f_vt2], vGlobe.vTv[vGlobe.f_vt2], vGlobe.vTw[vGlobe.f_vt2]);
glVertex3f(vGlobe.vX[vGlobe.f_v2], vGlobe.vY[vGlobe.f_v2], vGlobe.vZ[vGlobe.f_v2]);

glNormal3f(vGlobe.vNx[vGlobe.f_n3], vGlobe.vNy[vGlobe.f_n3], vGlobe.vNz[vGlobe.f_n3]);
glTexCoord3f(vGlobe.vTu[vGlobe.f_vt3], vGlobe.vTv[vGlobe.f_vt3], vGlobe.vTw[vGlobe.f_vt3]);
glVertex3f(vGlobe.vX[vGlobe.f_v3], vGlobe.vY[vGlobe.f_v3], vGlobe.vZ[vGlobe.f_v3]);
}
glEnd();
glEndList();

stars = glGenLists(1);
glNewList(stars, GL_COMPILE);
glBegin(GL_TRIANGLES);
for(i = 0; i < (int)vStars.f_v1.size(); i++){
glNormal3f(vStars.vNx[vStars.f_n1], vStars.vNy[vStars.f_n1], vStars.vNz[vStars.f_n1]);
glTexCoord3f(vStars.vTu[vStars.f_vt1], vStars.vTv[vStars.f_vt1], vStars.vTw[vStars.f_vt1]);
glVertex3f(vStars.vX[vStars.f_v1], vStars.vY[vStars.f_v1], vStars.vZ[vStars.f_v1]);

glNormal3f(vStars.vNx[vStars.f_n2], vStars.vNy[vStars.f_n2], vStars.vNz[vStars.f_n2]);
glTexCoord3f(vStars.vTu[vStars.f_vt2], vStars.vTv[vStars.f_vt2], vStars.vTw[vStars.f_vt2]);
glVertex3f(vStars.vX[vStars.f_v2], vStars.vY[vStars.f_v2], vStars.vZ[vStars.f_v2]);

glNormal3f(vStars.vNx[vStars.f_n3], vStars.vNy[vStars.f_n3], vStars.vNz[vStars.f_n3]);
glTexCoord3f(vStars.vTu[vStars.f_vt3], vStars.vTv[vStars.f_vt3], vStars.vTw[vStars.f_vt3]);
glVertex3f(vStars.vX[vStars.f_v3], vStars.vY[vStars.f_v3], vStars.vZ[vStars.f_v3]);
}
glEnd();
glEndList();
}






EDIT:
Allright, this was me showing how blind and stupid a person can be :)
I had forgot that I had created a folder for my shaders and forgot to add that to the shader initialization. Sorry about that.

Now my next step would be to add one texture to the dark side of the globe and one to the light side.

[Edited by - tre on December 9, 2009 12:17:57 PM]

Share this post


Link to post
Share on other sites
Step two (blending two textures, one in light one in dark) is allmost done. I've got it working in ShaderDesigner.
The "day" texture won't work.

Here's my globe function:
void drawGlobe(float size, int slices){
glTranslatef(potX, potY, 0.0f);

glBindTexture(GL_TEXTURE_2D, texture[0].texID);
glActiveTexture(GL_TEXTURE0);
int tex_loc0 = glGetUniformLocation(shader.id(), "TextureUnit0");
glUniform1i(tex_loc0, 0);

glBindTexture(GL_TEXTURE_2D, texture[2].texID);
glActiveTexture(GL_TEXTURE0);
int tex_loc1 = glGetUniformLocation(shader.id(), "TextureUnit1");
glUniform1i(tex_loc1, 1);


glRotatef(-65.0f, 0, 1, 0);
glCallList(globe);
}


And the shaders:
// vertex shader
varying vec3 lightDir, normal;
varying vec2 texCoord;

void main(){
normal = normalize(gl_NormalMatrix * gl_Normal);
lightDir = normalize(vec3(gl_LightSource[0].position));

gl_TexCoord[0] = gl_MultiTexCoord0;
gl_TexCoord[1] = gl_MultiTexCoord0;

gl_Position = ftransform();
}

// fragment shader
varying vec3 lightDir, normal;
varying vec2 texCoord;
uniform sampler2D TextureUnit0;
uniform sampler2D TextureUnit1;

void main(){
vec3 ct, cf, c;
vec4 texel;
float intensity, at, af, a;

intensity = max(dot(lightDir, normalize(normal)), 0.0);

cf = intensity * (gl_FrontMaterial.diffuse).rgb +
gl_FrontMaterial.ambient.rgb;;
af = gl_FrontMaterial.diffuse.a;

texel = texture2D(TextureUnit0, vec2(gl_TexCoord[0].st));

ct = texel.rgb;
at = texel.a;

c = cf * ct;
a = af * at;

float coef = smoothstep(1.0, 0.0, intensity);
c += coef * vec3(texture2D(TextureUnit1, vec2(gl_TexCoord[0].st)));

gl_FragColor = vec4(c, a);
}


I'm using the Lighthouse3D Multitexture tutorial for this. I think the problem is in my globe function. I can't seem to be able to push the correct texture unit to the shader.
The shaders work great in ShaderDesigner.

Share this post


Link to post
Share on other sites
Allright. Since I'm done with this now I'm doing this new post instead of editing.

The day texture and the night texture blends nice together. It might need some tweaking to get it looking just right.

I just used the Lighthouse tutorial (Link) for those who want the same effect.
The problem was getting my OpenGL program connecting and passing information correctly to the shader and also excluding/reactivating the right texture for the star map.

glActiveTexture(GL_TEXTURE1); to activate the second texture unit and then reverting back to glActiveTexture(GL_TEXTURE0); before doing the star map. And everything works.


My next step is to create some sort of atmosphere for the globe. I'm thinking about creating a new shader for this. Is this the right way to go?
At the moment I'm just activating the fragment light + globe lights shader in initialization and then unbinding/binding where it's needed. So this time I thought I'd create a new shader in the same way and do a second set of unbind/bind.
Or should I try to squeeze this new shader information into the current shader?

And how do I go about creating an atmosphere? Should I create a new sphere around the globe and add the shader to that?
I'm not trying to make a physically correct atmosphere, though. Just something that can fool the user to believe in an atmosphere.

Later I'd like to add animating clouds. Can I create some sort of animated perlin noise shader? What would the most efficient way to create clouds be?

Hoping for some guidiance here :)

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Tags

  • Advertisement
  • Popular Now

  • Similar Content

    • By LifeArtist
      Good Evening,
      I want to make a 2D game which involves displaying some debug information. Especially for collision, enemy sights and so on ...
      First of I was thinking about all those shapes which I need will need for debugging purposes: circles, rectangles, lines, polygons.
      I am really stucked right now because of the fundamental question:
      Where do I store my vertices positions for each line (object)? Currently I am not using a model matrix because I am using orthographic projection and set the final position within the VBO. That means that if I add a new line I would have to expand the "points" array and re-upload (recall glBufferData) it every time. The other method would be to use a model matrix and a fixed vbo for a line but it would be also messy to exactly create a line from (0,0) to (100,20) calculating the rotation and scale to make it fit.
      If I proceed with option 1 "updating the array each frame" I was thinking of having 4 draw calls every frame for the lines vao, polygons vao and so on. 
      In addition to that I am planning to use some sort of ECS based architecture. So the other question would be:
      Should I treat those debug objects as entities/components?
      For me it would make sense to treat them as entities but that's creates a new issue with the previous array approach because it would have for example a transform and render component. A special render component for debug objects (no texture etc) ... For me the transform component is also just a matrix but how would I then define a line?
      Treating them as components would'nt be a good idea in my eyes because then I would always need an entity. Well entity is just an id !? So maybe its a component?
      Regards,
      LifeArtist
    • By QQemka
      Hello. I am coding a small thingy in my spare time. All i want to achieve is to load a heightmap (as the lowest possible walking terrain), some static meshes (elements of the environment) and a dynamic character (meaning i can move, collide with heightmap/static meshes and hold a varying item in a hand ). Got a bunch of questions, or rather problems i can't find solution to myself. Nearly all are deal with graphics/gpu, not the coding part. My c++ is on high enough level.
      Let's go:
      Heightmap - i obviously want it to be textured, size is hardcoded to 256x256 squares. I can't have one huge texture stretched over entire terrain cause every pixel would be enormous. Thats why i decided to use 2 specified textures. First will be a tileset consisting of 16 square tiles (u v range from 0 to 0.25 for first tile and so on) and second a 256x256 buffer with 0-15 value representing index of the tile from tileset for every heigtmap square. Problem is, how do i blend the edges nicely and make some computationally cheap changes so its not obvious there are only 16 tiles? Is it possible to generate such terrain with some existing program?
      Collisions - i want to use bounding sphere and aabb. But should i store them for a model or entity instance? Meaning i have 20 same trees spawned using the same tree model, but every entity got its own transformation (position, scale etc). Storing collision component per instance grats faster access + is precalculated and transformed (takes additional memory, but who cares?), so i stick with this, right? What should i do if object is dynamically rotated? The aabb is no longer aligned and calculating per vertex min/max everytime object rotates/scales is pretty expensive, right?
      Drawing aabb - problem similar to above (storing aabb data per instance or model). This time in my opinion per model is enough since every instance also does not have own vertex buffer but uses the shared one (so 20 trees share reference to one tree model). So rendering aabb is about taking the model's aabb, transforming with instance matrix and voila. What about aabb vertex buffer (this is more of a cosmetic question, just curious, bumped onto it in time of writing this). Is it better to make it as 8 points and index buffer (12 lines), or only 2 vertices with min/max x/y/z and having the shaders dynamically generate 6 other vertices and draw the box? Or maybe there should be just ONE 1x1x1 cube box template moved/scaled per entity?
      What if one model got a diffuse texture and a normal map, and other has only diffuse? Should i pass some bool flag to shader with that info, or just assume that my game supports only diffuse maps without fancy stuff?
      There were several more but i forgot/solved them at time of writing
      Thanks in advance
    • By RenanRR
      Hi All,
      I'm reading the tutorials from learnOpengl site (nice site) and I'm having a question on the camera (https://learnopengl.com/Getting-started/Camera).
      I always saw the camera being manipulated with the lookat, but in tutorial I saw the camera being changed through the MVP arrays, which do not seem to be camera, but rather the scene that changes:
      Vertex Shader:
      #version 330 core layout (location = 0) in vec3 aPos; layout (location = 1) in vec2 aTexCoord; out vec2 TexCoord; uniform mat4 model; uniform mat4 view; uniform mat4 projection; void main() { gl_Position = projection * view * model * vec4(aPos, 1.0f); TexCoord = vec2(aTexCoord.x, aTexCoord.y); } then, the matrix manipulated:
      ..... glm::mat4 projection = glm::perspective(glm::radians(fov), (float)SCR_WIDTH / (float)SCR_HEIGHT, 0.1f, 100.0f); ourShader.setMat4("projection", projection); .... glm::mat4 view = glm::lookAt(cameraPos, cameraPos + cameraFront, cameraUp); ourShader.setMat4("view", view); .... model = glm::rotate(model, glm::radians(angle), glm::vec3(1.0f, 0.3f, 0.5f)); ourShader.setMat4("model", model);  
      So, some doubts:
      - Why use it like that?
      - Is it okay to manipulate the camera that way?
      -in this way, are not the vertex's positions that changes instead of the camera?
      - I need to pass MVP to all shaders of object in my scenes ?
       
      What it seems, is that the camera stands still and the scenery that changes...
      it's right?
       
       
      Thank you
       
    • By dpadam450
      Sampling a floating point texture where the alpha channel holds 4-bytes of packed data into the float. I don't know how to cast the raw memory to treat it as an integer so I can perform bit-shifting operations.

      int rgbValue = int(textureSample.w);//4 bytes of data packed as color
      // algorithm might not be correct and endianness might need switching.
      vec3 extractedData = vec3(  rgbValue & 0xFF000000,  (rgbValue << 8) & 0xFF000000, (rgbValue << 16) & 0xFF000000);
      extractedData /= 255.0f;
    • By Devashish Khandelwal
      While writing a simple renderer using OpenGL, I faced an issue with the glGetUniformLocation function. For some reason, the location is coming to be -1.
      Anyone has any idea .. what should I do?
  • Advertisement