Sign in to follow this  

OpenGL Implementing Effect Scripting

This topic is 2897 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

So I took a first pass at implementing effect scripting, and was hoping to get some feedback on the approach I took. While I'm pretty happy with the approach (which seems extremely flexible), I'm still (relatively) new to game programming and have never had any real code review, so I have a constant worry that I'm making a large number of high level and low level errors. The most recent thing I'm working on is implementing SAS scripting for my effects (I'm using cgfx with OpenGL, though I think most of the things here would be equally valid (minus slight implementation differences) in DirectX.) So here's what I'm doing: Data:
union ScriptArg
	unsigned int uiArg;
	float floatArg;
	float vec2Arg[2];
	float vec3Arg[3];
	float vec4Arg[4];

typedef void(*ScriptCommand)(IFXScript &scriptInstance, const ScriptArg &scriptArg);

struct ScriptElem
	ScriptCommand command;
	ScriptArg	  arg;

typedef void(*ScriptCommandBuilder)(IFXScript &scriptInstance, ScriptElem &scriptElem, const std::string &stringArg);

typedef void(*RenderFunc)();

So I'm essentially just storing a function pointer corresponding to whatever implementation I have of the SAS command along with a union holding whatever the argument was (With some preprocessing of the arguments done - each command has its own function for putting together its ScriptElem struct. And here are the script classes:
class IFXScript
	RenderFunc tempFunc;
	unsigned int effectHandle;
	unsigned int handle;
	std::vector<ScriptElem> script;

	unordered_map<unsigned int, TexInfo> TextureMap;  
	void AddElem(const std::string &commandString, const std::string &argString);
	void AddTex(unsigned int paramNum);
	void Run(RenderFunc);
	virtual void SetSurface() = 0;  


class TechniqueScript : public IFXScript
	TechniqueScript() {};
	TechniqueScript(unsigned int techniqueHandle, unsigned int effect_handle);
	unordered_map<unsigned int, PassScript*> passMap;  
	SurfConfig Surface;
	inline void SetSurface() {SetSurf(Surface);};

class PassScript : public IFXScript
	TechniqueScript* parentTechnique;
	unsigned int passHandle;
	std::vector<ScriptElem> script;
	PassScript() {};
	PassScript(unsigned int passHandle, unsigned int effect_handle, TechniqueScript* parent);
	~PassScript() {};

	//Sets the FBO with the rendertargets 
	//currently defined in the TechniqueScript's
	//Surface variable.  PassScript will pass this
	//up to its parent TechniqueScript
	//Rendertarget change script commands
	//should only change the Surface variable.
	//SetSurface will need to be called before
	//the Draw to actually set the targets
	inline void SetSurface() {parentTechnique->SetSurface();};

(I know - nothing is encapsulated. I'm going to go back and fix that once I get a better handle on what I need to create accessor functions for) So after parsing, what I end up with for each Technique or Pass script is a vector full of function pointers and arguments. Running the script is just:
void IFXScript::Run(RenderFunc tFunc)
	tempFunc = tFunc;
	vector<ScriptElem>::iterator myScriptIter;
	for (myScriptIter = script.begin(); myScriptIter != script.end(); ++myScriptIter)
		ScriptElem &curElem = *myScriptIter;
		(curElem.command)(*this, curElem.arg);

I'm midway through implementing the actual command functions at the moment. Mostly, I just want to know if this approach to implementing the scripting looks good on paper, and whether I'm making any severely suboptimal choices in my implementation. I'm worrying more about the overall architecture of it, and if I'm unwittingly making a mistake that will hurt me in the long run. Any constructive criticism would be much appreciated!

Share this post

Link to post
Share on other sites
Sign in to follow this  

  • Similar Content

    • By _OskaR
      I have an OpenGL application but without possibility to wite own shaders.
      I need to perform small VS modification - is possible to do it in an alternative way? Do we have apps or driver modifictions which will catch the shader sent to GPU and override it?
    • By xhcao
      Does sync be needed to read texture content after access texture image in compute shader?
      My simple code is as below,
      glBindImageTexture(0, texture[0], 0, GL_FALSE, 3, GL_READ_ONLY, GL_R32UI);
      glBindImageTexture(1, texture[1], 0, GL_FALSE, 4, GL_WRITE_ONLY, GL_R32UI);
      glDispatchCompute(1, 1, 1);
      // Does sync be needed here?
      glBindFramebuffer(GL_READ_FRAMEBUFFER, framebuffer);
                                     GL_TEXTURE_CUBE_MAP_POSITIVE_X + face, texture[1], 0);
      glReadPixels(0, 0, kWidth, kHeight, GL_RED_INTEGER, GL_UNSIGNED_INT, outputValues);
      Compute shader is very simple, imageLoad content from texture[0], and imageStore content to texture[1]. Does need to sync after dispatchCompute?
    • By Jonathan2006
      My question: is it possible to transform multiple angular velocities so that they can be reinserted as one? My research is below:
      // This works quat quaternion1 = GEQuaternionFromAngleRadians(angleRadiansVector1); quat quaternion2 = GEMultiplyQuaternions(quaternion1, GEQuaternionFromAngleRadians(angleRadiansVector2)); quat quaternion3 = GEMultiplyQuaternions(quaternion2, GEQuaternionFromAngleRadians(angleRadiansVector3)); glMultMatrixf(GEMat4FromQuaternion(quaternion3).array); // The first two work fine but not the third. Why? quat quaternion1 = GEQuaternionFromAngleRadians(angleRadiansVector1); vec3 vector1 = GETransformQuaternionAndVector(quaternion1, angularVelocity1); quat quaternion2 = GEQuaternionFromAngleRadians(angleRadiansVector2); vec3 vector2 = GETransformQuaternionAndVector(quaternion2, angularVelocity2); // This doesn't work //quat quaternion3 = GEQuaternionFromAngleRadians(angleRadiansVector3); //vec3 vector3 = GETransformQuaternionAndVector(quaternion3, angularVelocity3); vec3 angleVelocity = GEAddVectors(vector1, vector2); // Does not work: vec3 angleVelocity = GEAddVectors(vector1, GEAddVectors(vector2, vector3)); static vec3 angleRadiansVector; vec3 angularAcceleration = GESetVector(0.0, 0.0, 0.0); // Sending it through one angular velocity later in my motion engine angleVelocity = GEAddVectors(angleVelocity, GEMultiplyVectorAndScalar(angularAcceleration, timeStep)); angleRadiansVector = GEAddVectors(angleRadiansVector, GEMultiplyVectorAndScalar(angleVelocity, timeStep)); glMultMatrixf(GEMat4FromEulerAngle(angleRadiansVector).array); Also how do I combine multiple angularAcceleration variables? Is there an easier way to transform the angular values?
    • By dpadam450
      I have this code below in both my vertex and fragment shader, however when I request glGetUniformLocation("Lights[0].diffuse") or "Lights[0].attenuation", it returns -1. It will only give me a valid uniform location if I actually use the diffuse/attenuation variables in the VERTEX shader. Because I use position in the vertex shader, it always returns a valid uniform location. I've read that I can share uniforms across both vertex and fragment, but I'm confused what this is even compiling to if this is the case.
      #define NUM_LIGHTS 2
      struct Light
          vec3 position;
          vec3 diffuse;
          float attenuation;
      uniform Light Lights[NUM_LIGHTS];
    • By pr033r
      I have a Bachelor project on topic "Implenet 3D Boid's algorithm in OpenGL". All OpenGL issues works fine for me, all rendering etc. But when I started implement the boid's algorithm it was getting worse and worse. I read article ( inspirate from another code (here: but it still doesn't work like in tutorials and videos. For example the main problem: when I apply Cohesion (one of three main laws of boids) it makes some "cycling knot". Second, when some flock touch to another it scary change the coordination or respawn in origin (x: 0, y:0. z:0). Just some streng things. 
      I followed many tutorials, change a try everything but it isn't so smooth, without lags like in another videos. I really need your help. 
      My code (optimalizing branch):
      Exe file (if you want to look) and models folder (for those who will download the sources):
      Thanks for any help...

  • Popular Now