Sign in to follow this  
Simopi

OpenGL OpenGL & GLSL

Recommended Posts

Simopi    100
Hi, i'm new in GLSL. After so many search about bump mapping i don't understand what is the way to have a correct rendering. Because i don't know very well how GLSL works, and the math of the normals too :P I compute normals in this way:
 Vec3f a, b;
  a = Vector3Offset(v3, v2);
  b = Vector3Offset(v1, v2);

  Vec3f normal = a^b; //cross product 
Where Vector3Offset is v3-v2 and v1-v2. Then i compute tangents and binormals. Btw it seems normals are wrong. If i understand well, gl_Normal variable (in GLSL) contains the normal. To have it, i must call:
  
glEnableVertexAttribArrayARB(2);
glVertexAttribPointerARB(2, 3, GL_FLOAT, false, 0, normalsArray); 
Is that right? Thanks for your time, and sorry for my english.

Share this post


Link to post
Share on other sites
panic    211
gl_Vertex, gl_Normal etc are deprecated functionality and I suggest you don't use them at all. The correct way to use glVertexAttribPointer with opengl 2.0+ would be to first extract the position of your normal attribute from the shader. Don't assume that the normal will be at a specific index as you have done here (you assume it will be at index 2, ie the third attribute in your shader).

For example, if your shader looks like this:

attribute vec4 Vertex; // Input vertex declared as "Vertex"
attribute vec3 Normal; // Input normal declared as "Normal"
varying vec3 v_normal; // output normal

void main()
{
gl_Position = Vertex; // Output untransformed vertex
v_normal = Normal; // Pass on normal to fragment shader
}



Then you would want to setup your attributepointers as such:

// This fetches the attribute indices from the shader.
// the string "Vertex" and "Normal" matches the attributes
// declared in the shader
GLint vertex_index = glGetAttribLocation(program, "Vertex");
GLint normal_index = glGetAttribLocation(program, "Normal");

// Need to calculate the stride of a complete vertex
// in this case, two float3 (24 bytes)
GLuint stride = sizeof(GLfloat)*3 + sizeof(GLfloat)*3;

glEnableVertexAttribArray(vertex_index);
glVertexAttribPointer(vertex_index, 3, GL_FLOAT, false, stride, vertexArray);

glEnableVertexAttribArray(normal_index);
glVertexAttribPointer(normal_index, 3, GL_FLOAT, false, stride, normalsArray);



Also, make sure you normalize your normals after that cross product ;)

Share this post


Link to post
Share on other sites
AndyEsser    394
Quote:
Original post by Simopi
Vec3f normal = a^b; //cross product


Anyone else thing this looks wrong and should be:


Vec3f normal = cross(a, b); // cross product



Share this post


Link to post
Share on other sites
Simopi    100
@HuntsMan I use GLSL 1.5, this is the answer from the glGetString(GL_SHADING_LANGUAGE_VERSION).

Thanks for the answers, i'll try to apply your suggestions and i'll post here my progress ^_^

Share this post


Link to post
Share on other sites
Simopi    100
Hi guys, now i can see the model with bump mapping. Thanks for the suggestions. But there is something wrong. Again...
Here the rendering:
Click

What's wrong?

Share this post


Link to post
Share on other sites
panic    211
Hard to tell. Kind of looks like your vertex indices are slightly off. If you are using indexed vertices that is.

How does your vertex layout look? And how does your drawcall look?

Share this post


Link to post
Share on other sites
Simopi    100
Ok, i try to explain my work:

i use vertex arrays to render the 3ds object. If i don't use shader, the model seems ok. The problem is when i use the shader.

OpenGL source:

I compute the normals in this way:


Vec3f triangle = obj->getShape().triangle.at(k);

//Triangle vertices
Vec3f v1 = obj->getShape().vertex.at(triangle.i1);
Vec3f v2 = obj->getShape().vertex.at(triangle.i2);
Vec3f v3 = obj->getShape().vertex.at(triangle.i3);

Vec3f a, b;
a = v3-v2;
b = v1-v2;

Vec3f normal = a^b; //cross product

//Texture coordinates
Vec2f st1 = obj->getShape().texture.at(triangle.i1);
Vec2f st2 = obj->getShape().texture.at(triangle.i2);
Vec2f st3 = obj->getShape().texture.at(triangle.i3);

Vec2f c, d;
c = st3-st2;
d = st1-st2;

float coef = 1/ (c.x * d.y - d.x * c.y);
Vec3f tangent;

tangent.x = coef * ((v1.x * d.y) + (v2.x * -c.y));
tangent.y = coef * ((v1.y * d.y) + (v2.y * -c.y));
tangent.z = coef * ((v1.z * d.y) + (v2.z * -c.y));

tangent.normalize();
normal.normalize();

Vec3f binormal = tangent^normal; //cross product






Then i put everything into an array. For example, the normal array will be:


normalArray[i++] = normal.x;
normalArray[i++] = normal.y;
normalArray[i++] = normal.z;






Then i call glNormalArray(... normalArray);

For tangents and binormals i use vertex attributes, declared into shader:


attribute vec3 tangent;






and in opengl i call glVertexAttribPointer(...);

To render the vertices:


glDrawElements(GL_TRIANGLES, shape.triangle.size()*3, GL_UNSIGNED_SHORT, indexPointer);


Thanks for the patience!

[Edited by - Simopi on February 18, 2010 1:26:22 PM]

Share this post


Link to post
Share on other sites
Kasya    207
is attribute supported in GLSL 1.5? Try with in and out and see if it works. And check with glBindAttribLocation instead of glGetAttribLocation.

Share this post


Link to post
Share on other sites
Aks9    1499
Quote:
Original post by Simopi
@HuntsMan I use GLSL 1.5, this is the answer from the glGetString(GL_SHADING_LANGUAGE_VERSION).

[smile][smile][smile] [grin]
HuntsMan asked you what GLSL version you're targeting, not what is the supported version!
The correct answer you can get if you find directive #version in the beginning of your shaders. If there is no #version directive, you are writing shaders for GLSL 1.1! Fortunately, NVIDIA enables mixing all versions of GLSL (as well as Cg).

Before going to further GLSL programming, I strongly recommend to read few beginning chapters from the "Orange book", or some good tutorial.

Share this post


Link to post
Share on other sites
Simopi    100
Unfortunately there are not good tutorials. There is the cube tutorial, and everyone is able to implement it... btw you can close. I found the problem ;)

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Similar Content

    • By cebugdev
      hi all,

      i am trying to build an OpenGL 2D GUI system, (yeah yeah, i know i should not be re inventing the wheel, but this is for educational and some other purpose only),
      i have built GUI system before using 2D systems such as that of HTML/JS canvas, but in 2D system, i can directly match a mouse coordinates to the actual graphic coordinates with additional computation for screen size/ratio/scale ofcourse.
      now i want to port it to OpenGL, i know that to render a 2D object in OpenGL we specify coordiantes in Clip space or use the orthographic projection, now heres what i need help about.
      1. what is the right way of rendering the GUI? is it thru drawing in clip space or switching to ortho projection?
      2. from screen coordinates (top left is 0,0 nd bottom right is width height), how can i map the mouse coordinates to OpenGL 2D so that mouse events such as button click works? In consideration ofcourse to the current screen/size dimension.
      3. when let say if the screen size/dimension is different, how to handle this? in my previous javascript 2D engine using canvas, i just have my working coordinates and then just perform the bitblk or copying my working canvas to screen canvas and scale the mouse coordinates from there, in OpenGL how to work on a multiple screen sizes (more like an OpenGL ES question).
      lastly, if you guys know any books, resources, links or tutorials that handle or discuss this, i found one with marekknows opengl game engine website but its not free,
      Just let me know. Did not have any luck finding resource in google for writing our own OpenGL GUI framework.
      IF there are no any available online, just let me know, what things do i need to look into for OpenGL and i will study them one by one to make it work.
      thank you, and looking forward to positive replies.
    • By fllwr0491
      I have a few beginner questions about tesselation that I really have no clue.
      The opengl wiki doesn't seem to talk anything about the details.
       
      What is the relationship between TCS layout out and TES layout in?
      How does the tesselator know how control points are organized?
          e.g. If TES input requests triangles, but TCS can output N vertices.
             What happens in this case?
      In this article,
      http://www.informit.com/articles/article.aspx?p=2120983
      the isoline example TCS out=4, but TES in=isoline.
      And gl_TessCoord is only a single one.
      So which ones are the control points?
      How are tesselator building primitives?
    • By Orella
      I've been developing a 2D Engine using SFML + ImGui.
      Here you can see an image
      The editor is rendered using ImGui and the scene window is a sf::RenderTexture where I draw the GameObjects and then is converted to ImGui::Image to render it in the editor.
      Now I need to create a 3D Engine during this year in my Bachelor Degree but using SDL2 + ImGui and I want to recreate what I did with the 2D Engine. 
      I've managed to render the editor like I did in the 2D Engine using this example that comes with ImGui. 
      3D Editor preview
      But I don't know how to create an equivalent of sf::RenderTexture in SDL2, so I can draw the 3D scene there and convert it to ImGui::Image to show it in the editor.
      If you can provide code will be better. And if you want me to provide any specific code tell me.
      Thanks!
    • By Picpenguin
      Hi
      I'm new to learning OpenGL and still learning C. I'm using SDL2, glew, OpenGL 3.3, linmath and stb_image.
      I started following through learnopengl.com and got through it until I had to load models. The problem is, it uses Assimp for loading models. Assimp is C++ and uses things I don't want in my program (boost for example) and C support doesn't seem that good.
      Things like glVertexAttribPointer and shaders are still confusing to me, but I have to start somewhere right?
      I can't seem to find any good loading/rendering tutorials or source code that is simple to use and easy to understand.
      I have tried this for over a week by myself, searching for solutions but so far no luck. With tinyobjloader-c and project that uses it, FantasyGolfSimulator, I was able to actually load the model with plain color (always the same color no matter what I do) on screen and move it around, but cannot figure out how to use textures or use its multiple textures with it.
      I don't ask much: I just want to load models with textures in them, maybe have lights affect them (directional spotlight etc). Also, some models have multiple parts and multiple textures in them, how can I handle those?
      Are there solutions anywhere?
      Thank you for your time. Sorry if this is a bit confusing, English isn't my native language
    • By dpadam450
      FINALLY, upgrading my engine to openGL 4. I was having some trouble so I started with a stripped down application and was wondering if VAO's are required, because I have a sample working, but if I remove the VAO then it doesn't seem to like drawing my triangle.
  • Popular Now