Sign in to follow this  
tenspd137

OpenGL GLSL shader not compiling, any thoughts why?[solved]

Recommended Posts

tenspd137    100
Hi all, I have been trying to learn OpenGL to use for game programming (eventually). I started with the book "Beginning OpenGL Game Programming". I went through and compiled the examples, and in the last chapter where everything is put together, the program seems to compile fine. But when I run it, I get the following error: Could not compile shader: 9 GLSL Shader: Shader contains errors, please validate this shader! 0(12) : err Could not compile the shaders, they are invalid Could not initialize the terrain's shader So I went into the data/shaders/glsl.30 directory and opened up the terrain.vert and terrain.frag shader programs. They are terrain.vert
#version 130

uniform mat4 projection_matrix;
uniform mat4 modelview_matrix;
uniform mat3 normal_matrix;

uniform vec4 material_ambient;
uniform vec4 material_diffuse;
uniform vec4 material_specular;
uniform vec4 material_emissive;
uniform float material_shininess;

struct light {
	vec4 position;
	vec4 diffuse;
	vec4 specular;
	vec4 ambient;
};

uniform light light0;

//invariant in vec3 a_Vertex;
//const in vec3 a_Vertex;
in vec3 a_Vertex;
in vec2 a_TexCoord0;
in float a_TexCoord1;

in vec3 a_Normal;

out vec4 color;
out vec2 texCoord0;
out float texCoord1;

void main(void) 
{
	vec3 N = normalize(normal_matrix * a_Normal);	
	vec3 L = normalize(modelview_matrix * light0.position).xyz;
	float NdotL = max(dot(N, L.xyz), 0.0);

	vec4 finalColor = material_ambient * light0.ambient;
	vec4 pos = modelview_matrix * vec4(a_Vertex, 1.0);	
	vec3 E = -pos.xyz;

	if (NdotL > 0.0) 
	{
		vec3 HV = normalize(L + E);
		finalColor += material_diffuse * light0.diffuse * NdotL;

		float NdotHV = max(dot(N, HV), 0.0);
		color += material_specular * light0.specular * pow(NdotHV, material_shininess);	
	}

	color = finalColor;
	texCoord0 = a_TexCoord0;
	texCoord1 = a_TexCoord1;

	gl_Position = projection_matrix * pos;	
}



and terrain.frag
#version 130

uniform sampler2D texture0;
uniform sampler1D texture1;

in vec4 color;
in vec2 texCoord0;
in float texCoord1;
out vec4 outColor;

void main(void) {
	outColor = color * texture(texture0, texCoord0.st) * texture(texture1, texCoord1.s);	// 
}



I can't see anything wrong, but then I may not know what to look for. These are for GL3.0 / GLSL 1.3. My graphics card is NVIDIA GTS 8800, GL3.2, GLX 1.4, Shader v 1.5. I tried compiling this a while back and it worked, but I am sure I have updated since then. I know things are getting deprecated and what not, but I thought that it should be backwards compatible. MAybe not... Does anyone have any ideas? I looked around for suggestions on debugging, but I couldn't find anything really useful, and I don't see a web page listed for this book or I would ask there first. Thanks in advance for any help / suggestions. [Edited by - tenspd137 on March 20, 2010 2:39:19 AM]

Share this post


Link to post
Share on other sites
tenspd137    100
Thanks for the suggestion. I tried that. No luck. Just curious - what version nvidia drivers are you using? Maybe it is a driver issue?

Mine are 195.30.

Share this post


Link to post
Share on other sites
karwosts    840
Do you have enough understanding of the program to see where those error messages are being generated from? Usually if there is some kind of error you can get a message with glGetShaderiv.

At the very least you should be able to narrow it down to either the frag or the vert shader, as they are compiled separately and each have their own error logs.

Share this post


Link to post
Share on other sites
tenspd137    100
I found the problem:

outColor = color * texture(texture0, texCoord0.st) * texture(texture1, texCoord1.s);

texCoord1.s should be just texCoord1

The .s implies it is a vector of some sort. Since it a float, it has no .s

Works great now.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Similar Content

    • By cebugdev
      hi all,

      i am trying to build an OpenGL 2D GUI system, (yeah yeah, i know i should not be re inventing the wheel, but this is for educational and some other purpose only),
      i have built GUI system before using 2D systems such as that of HTML/JS canvas, but in 2D system, i can directly match a mouse coordinates to the actual graphic coordinates with additional computation for screen size/ratio/scale ofcourse.
      now i want to port it to OpenGL, i know that to render a 2D object in OpenGL we specify coordiantes in Clip space or use the orthographic projection, now heres what i need help about.
      1. what is the right way of rendering the GUI? is it thru drawing in clip space or switching to ortho projection?
      2. from screen coordinates (top left is 0,0 nd bottom right is width height), how can i map the mouse coordinates to OpenGL 2D so that mouse events such as button click works? In consideration ofcourse to the current screen/size dimension.
      3. when let say if the screen size/dimension is different, how to handle this? in my previous javascript 2D engine using canvas, i just have my working coordinates and then just perform the bitblk or copying my working canvas to screen canvas and scale the mouse coordinates from there, in OpenGL how to work on a multiple screen sizes (more like an OpenGL ES question).
      lastly, if you guys know any books, resources, links or tutorials that handle or discuss this, i found one with marekknows opengl game engine website but its not free,
      Just let me know. Did not have any luck finding resource in google for writing our own OpenGL GUI framework.
      IF there are no any available online, just let me know, what things do i need to look into for OpenGL and i will study them one by one to make it work.
      thank you, and looking forward to positive replies.
    • By fllwr0491
      I have a few beginner questions about tesselation that I really have no clue.
      The opengl wiki doesn't seem to talk anything about the details.
       
      What is the relationship between TCS layout out and TES layout in?
      How does the tesselator know how control points are organized?
          e.g. If TES input requests triangles, but TCS can output N vertices.
             What happens in this case?
      In this article,
      http://www.informit.com/articles/article.aspx?p=2120983
      the isoline example TCS out=4, but TES in=isoline.
      And gl_TessCoord is only a single one.
      So which ones are the control points?
      How are tesselator building primitives?
    • By Orella
      I've been developing a 2D Engine using SFML + ImGui.
      Here you can see an image
      The editor is rendered using ImGui and the scene window is a sf::RenderTexture where I draw the GameObjects and then is converted to ImGui::Image to render it in the editor.
      Now I need to create a 3D Engine during this year in my Bachelor Degree but using SDL2 + ImGui and I want to recreate what I did with the 2D Engine. 
      I've managed to render the editor like I did in the 2D Engine using this example that comes with ImGui. 
      3D Editor preview
      But I don't know how to create an equivalent of sf::RenderTexture in SDL2, so I can draw the 3D scene there and convert it to ImGui::Image to show it in the editor.
      If you can provide code will be better. And if you want me to provide any specific code tell me.
      Thanks!
    • By Picpenguin
      Hi
      I'm new to learning OpenGL and still learning C. I'm using SDL2, glew, OpenGL 3.3, linmath and stb_image.
      I started following through learnopengl.com and got through it until I had to load models. The problem is, it uses Assimp for loading models. Assimp is C++ and uses things I don't want in my program (boost for example) and C support doesn't seem that good.
      Things like glVertexAttribPointer and shaders are still confusing to me, but I have to start somewhere right?
      I can't seem to find any good loading/rendering tutorials or source code that is simple to use and easy to understand.
      I have tried this for over a week by myself, searching for solutions but so far no luck. With tinyobjloader-c and project that uses it, FantasyGolfSimulator, I was able to actually load the model with plain color (always the same color no matter what I do) on screen and move it around, but cannot figure out how to use textures or use its multiple textures with it.
      I don't ask much: I just want to load models with textures in them, maybe have lights affect them (directional spotlight etc). Also, some models have multiple parts and multiple textures in them, how can I handle those?
      Are there solutions anywhere?
      Thank you for your time. Sorry if this is a bit confusing, English isn't my native language
    • By dpadam450
      FINALLY, upgrading my engine to openGL 4. I was having some trouble so I started with a stripped down application and was wondering if VAO's are required, because I have a sample working, but if I remove the VAO then it doesn't seem to like drawing my triangle.
  • Popular Now