• Advertisement
Sign in to follow this  

Unity [solved] pointer from stl list iterator?

This topic is 2860 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

edit: this problem is solved, I am now asking for help here. Hi, firstly I will show an example application that represents my issue:
class cell{
  public:
    float top,left,bottom,right;

  //other methods and members

};

list<cell> cellList;
list<cell>::iterator cellIter;

//finds the cell that a point is in and returns a pointer to the cell
cell* findCell(float x,float y){
  for(cellIter = cellList.begin();cellIter != cellList.end();cellIter++){
    //if point is inside the cell
    if(x<=cellIter->right && x>=cellIter->left && y<=cellIter->top && y>=cellIter->bottom){
      break; //break the loop
    }
  }
  
  return (*cellIter);
}



I want findCell to return a pointer to the cell. Firstly I have to say that iterators confuse me a bit, they seem to be neither one thing nor the other, in the loop they work just like a pointer, but I can't return the iterator as the pointer, and I can't type cast it (tried a few other things untill I landed on the return line above). Also, cellList does not alter within the main loop, it is only edited on map initialisation. I really don't want to be passing object data around everywhere as that would be inefficient. (if it matters, I am programming this to learn how occlusion and collision grouping can be organised in an fps engine) What is the correct solution? Or should I find a different way to do the same task? edit: I found some discussions which spoke about the boost library, boost may shine light on any problems I have with lists of pointers but does it help me with this issue? [Edited by - Bozebo on April 25, 2010 8:30:44 PM]

Share this post


Link to post
Share on other sites
Advertisement
Quote:
Firstly I have to say that iterators confuse me a bit, they seem to be neither one thing nor the other,
in the loop they work just like a pointer, but I can't return the iterator as the pointer, and I can't type cast it (tried a few other things untill I landed on the code above).
As you note, although iterators can behave like pointers in some ways, they are not themselves pointers. (Well, strictly speaking, they might be in some cases, but as far as the user is concerned they have their own type, and aren't necessarily convertible to 'real' pointers.)

In this case though, you should be able to write:
return &(*cellIter);
Here, the 'deference' operator for the iterator is invoked, returning a reference to the pointed-at object. You can then take the address of the object as you would normally.

[Edit: I don't know that the Boost libraries have any direct relevance to the problem, as this is really just a basic issue of understanding how to use and manipulate iterators. I'll also mention that there are some other potential design issues here - such as the passing around of raw pointers, the brute-force search through the list of cells, and the use of list rather than, say, vector - that might warrant some examination once you get the basics working.]

Share this post


Link to post
Share on other sites
struct is_inside {
is_inside(float x_, float y_) : x(x_), y(y_) {}
bool operator()(cell & c) {
return (x >= c.left &&
x < c.right &&
y >= c.bottom &&
y < c.top);
}
private:
float x, y;
}

...
typedef std::list<cell> CellList;
CellList cellList;

CellList::iterator result = std::find_if(cellList.begin(), cellList.end(), is_inside(x,y));
if (result == cellList.end()) {
// not found
} else {
// result is first found cell
}




To find all cells that contain the point:
CellList::iterator result = cellList.begin();
while (result != cellList.end()) {
result = std::find_if(result, cellList.end(), is_inside(x,y));
if (result != cellList.end()) {
// (x,y) is inside result
}
}




Share this post


Link to post
Share on other sites
Quote:
Original post by Antheus
*** Source Snippet Removed ***

To find all cells that contain the point:
*** Source Snippet Removed ***
I'm not sure that those code samples address the OP's question. The OP was asking specifically about how to derive a pointer from a list iterator, which doesn't seem to be addressed at all in the above code samples.

Of course using algorithms from the standard library (as shown in your example code) is arguably preferable to writing out the loop manually, but I think that in most practical applications you'd want to use some sort of spatial hierarchy for this anyway (in other words, you probably wouldn't want to use a brute-force linear search for this, regardless of how the code for the search is written).

Share this post


Link to post
Share on other sites
Thanks for the help.

It is working nicely now, and I remembered that my cells are maintaining a list of adjacent cells (as is the map format). Rather than looping through all cells I should of definitely make it check only adjacent cells.

I thought about using vectors for that but I didn't see any reason to at the time. Is it that vectors are sequentially indexed (faster random access vs slower middle insertion) which makes them a better choice?

Should I use vectors or lists for my entities?
Noting that I need to order translucent drawing.

Should I maintain entities and their drawing system separately?

I love working on projects like this :D

(edit: oh now I have a segfault to deal with ^_^)

[Edited by - Bozebo on April 25, 2010 2:24:59 PM]

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Tags

  • Advertisement
  • Popular Now

  • Similar Content

    • By Manuel Berger
      Hello fellow devs!
      Once again I started working on an 2D adventure game and right now I'm doing the character-movement/animation. I'm not a big math guy and I was happy about my solution, but soon I realized that it's flawed.
      My player has 5 walking-animations, mirrored for the left side: up, upright, right, downright, down. With the atan2 function I get the angle between player and destination. To get an index from 0 to 4, I divide PI by 5 and see how many times it goes into the player-destination angle.

      In Pseudo-Code:
      angle = atan2(destination.x - player.x, destination.y - player.y) //swapped y and x to get mirrored angle around the y axis
      index = (int) (angle / (PI / 5));
      PlayAnimation(index); //0 = up, 1 = up_right, 2 = right, 3 = down_right, 4 = down

      Besides the fact that when angle is equal to PI it produces an index of 5, this works like a charm. Or at least I thought so at first. When I tested it, I realized that the up and down animation is playing more often than the others, which is pretty logical, since they have double the angle.

      What I'm trying to achieve is something like this, but with equal angles, so that up and down has the same range as all other directions.

      I can't get my head around it. Any suggestions? Is the whole approach doomed?

      Thank you in advance for any input!
       
    • By devbyskc
      Hi Everyone,
      Like most here, I'm a newbie but have been dabbling with game development for a few years. I am currently working full-time overseas and learning the craft in my spare time. It's been a long but highly rewarding adventure. Much of my time has been spent working through tutorials. In all of them, as well as my own attempts at development, I used the audio files supplied by the tutorial author, or obtained from one of the numerous sites online. I am working solo, and will be for a while, so I don't want to get too wrapped up with any one skill set. Regarding audio, the files I've found and used are good for what I was doing at the time. However I would now like to try my hand at customizing the audio more. My game engine of choice is Unity and it has an audio mixer built in that I have experimented with following their tutorials. I have obtained a great book called Game Audio Development with Unity 5.x that I am working through. Half way through the book it introduces using FMOD to supplement the Unity Audio Mixer. Later in the book, the author introduces Reaper (a very popular DAW) as an external program to compose and mix music to be integrated with Unity. I did some research on DAWs and quickly became overwhelmed. Much of what I found was geared toward professional sound engineers and sound designers. I am in no way trying or even thinking about getting to that level. All I want to be able to do is take a music file, and tweak it some to get the sound I want for my game. I've played with Audacity as well, but it didn't seem to fit the bill. So that is why I am looking at a better quality DAW. Since being solo, I am also under a budget contraint. So of all the DAW software out there, I am considering Reaper or Presonus Studio One due to their pricing. My question is, is investing the time to learn about using a DAW to tweak a sound file worth it? Are there any solo developers currently using a DAW as part of their overall workflow? If so, which one? I've also come across Fabric which is a Unity plug-in that enhances the built-in audio mixer. Would that be a better alternative?
      I know this is long, and maybe I haven't communicated well in trying to be brief. But any advice from the gurus/vets would be greatly appreciated. I've leaned so much and had a lot of fun in the process. BTW, I am also a senior citizen (I cut my programming teeth back using punch cards and Structured Basic when it first came out). If anyone needs more clarification of what I am trying to accomplish please let me know.  Thanks in advance for any assistance/advice.
    • By Yosef BenSadon
      Hi , I was considering this start up http://adshir.com/, for investment and i would like a little bit of feedback on what the developers community think about the technology.
      So far what they have is a demo that runs in real time on a Tablet at over 60FPS, it runs locally on the  integrated GPU of the i7 . They have a 20 000 triangles  dinosaur that looks impressive,  better than anything i saw on a mobile device, with reflections and shadows looking very close to what they would look in the real world. They achieved this thanks to a  new algorithm of a rendering technique called Path tracing/Ray tracing, that  is very demanding and so far it is done mostly for static images.
      From what i checked around there is no real option for real time ray tracing (60 FPS on consumer devices). There was imagination technologies that were supposed to release a chip that supports real time ray tracing, but i did not found they had a product in the market or even if the technology is finished as their last demo  i found was with a PC.  The other one is OTOY with their brigade engine that is still not released and if i understand well is more a cloud solution than in hardware solution .
      Would there  be a sizable  interest in the developers community in having such a product as a plug-in for existing game engines?  How important  is Ray tracing to the  future of high end real time graphics?
    • By bryandalo
      Good day,

      I just wanted to share our casual game that is available for android.

      Description: Fight your way from the ravenous plant monster for survival through flips. The rules are simple, drag and release your phone screen. Improve your skills and show it to your friends with the games quirky ranks. Select an array of characters using the orb you acquire throughout the game.

      Download: https://play.google.com/store/apps/details?id=com.HellmodeGames.FlipEscape&hl=en
       
      Trailer: 
       
    • By khawk
      Watch the latest from Unity.
       
  • Advertisement