Sign in to follow this  

Unity [solved] pointer from stl list iterator?

This topic is 2788 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

edit: this problem is solved, I am now asking for help here. Hi, firstly I will show an example application that represents my issue:
class cell{
  public:
    float top,left,bottom,right;

  //other methods and members

};

list<cell> cellList;
list<cell>::iterator cellIter;

//finds the cell that a point is in and returns a pointer to the cell
cell* findCell(float x,float y){
  for(cellIter = cellList.begin();cellIter != cellList.end();cellIter++){
    //if point is inside the cell
    if(x<=cellIter->right && x>=cellIter->left && y<=cellIter->top && y>=cellIter->bottom){
      break; //break the loop
    }
  }
  
  return (*cellIter);
}



I want findCell to return a pointer to the cell. Firstly I have to say that iterators confuse me a bit, they seem to be neither one thing nor the other, in the loop they work just like a pointer, but I can't return the iterator as the pointer, and I can't type cast it (tried a few other things untill I landed on the return line above). Also, cellList does not alter within the main loop, it is only edited on map initialisation. I really don't want to be passing object data around everywhere as that would be inefficient. (if it matters, I am programming this to learn how occlusion and collision grouping can be organised in an fps engine) What is the correct solution? Or should I find a different way to do the same task? edit: I found some discussions which spoke about the boost library, boost may shine light on any problems I have with lists of pointers but does it help me with this issue? [Edited by - Bozebo on April 25, 2010 8:30:44 PM]

Share this post


Link to post
Share on other sites
Quote:
Firstly I have to say that iterators confuse me a bit, they seem to be neither one thing nor the other,
in the loop they work just like a pointer, but I can't return the iterator as the pointer, and I can't type cast it (tried a few other things untill I landed on the code above).
As you note, although iterators can behave like pointers in some ways, they are not themselves pointers. (Well, strictly speaking, they might be in some cases, but as far as the user is concerned they have their own type, and aren't necessarily convertible to 'real' pointers.)

In this case though, you should be able to write:
return &(*cellIter);
Here, the 'deference' operator for the iterator is invoked, returning a reference to the pointed-at object. You can then take the address of the object as you would normally.

[Edit: I don't know that the Boost libraries have any direct relevance to the problem, as this is really just a basic issue of understanding how to use and manipulate iterators. I'll also mention that there are some other potential design issues here - such as the passing around of raw pointers, the brute-force search through the list of cells, and the use of list rather than, say, vector - that might warrant some examination once you get the basics working.]

Share this post


Link to post
Share on other sites
struct is_inside {
is_inside(float x_, float y_) : x(x_), y(y_) {}
bool operator()(cell & c) {
return (x >= c.left &&
x < c.right &&
y >= c.bottom &&
y < c.top);
}
private:
float x, y;
}

...
typedef std::list<cell> CellList;
CellList cellList;

CellList::iterator result = std::find_if(cellList.begin(), cellList.end(), is_inside(x,y));
if (result == cellList.end()) {
// not found
} else {
// result is first found cell
}




To find all cells that contain the point:
CellList::iterator result = cellList.begin();
while (result != cellList.end()) {
result = std::find_if(result, cellList.end(), is_inside(x,y));
if (result != cellList.end()) {
// (x,y) is inside result
}
}




Share this post


Link to post
Share on other sites
Quote:
Original post by Antheus
*** Source Snippet Removed ***

To find all cells that contain the point:
*** Source Snippet Removed ***
I'm not sure that those code samples address the OP's question. The OP was asking specifically about how to derive a pointer from a list iterator, which doesn't seem to be addressed at all in the above code samples.

Of course using algorithms from the standard library (as shown in your example code) is arguably preferable to writing out the loop manually, but I think that in most practical applications you'd want to use some sort of spatial hierarchy for this anyway (in other words, you probably wouldn't want to use a brute-force linear search for this, regardless of how the code for the search is written).

Share this post


Link to post
Share on other sites
Thanks for the help.

It is working nicely now, and I remembered that my cells are maintaining a list of adjacent cells (as is the map format). Rather than looping through all cells I should of definitely make it check only adjacent cells.

I thought about using vectors for that but I didn't see any reason to at the time. Is it that vectors are sequentially indexed (faster random access vs slower middle insertion) which makes them a better choice?

Should I use vectors or lists for my entities?
Noting that I need to order translucent drawing.

Should I maintain entities and their drawing system separately?

I love working on projects like this :D

(edit: oh now I have a segfault to deal with ^_^)

[Edited by - Bozebo on April 25, 2010 2:24:59 PM]

Share this post


Link to post
Share on other sites

This topic is 2788 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Forum Statistics

    • Total Topics
      628659
    • Total Posts
      2984079
  • Similar Content

    • By arash khalaqhdoust
      hey guys i hope you doing all well. last night i released my first game in google app store, i really appreciate you guys  to download it. and share your reviews about it
      the idea of game comes from mini hackgame of Bioshock.
       link of download:
      https://play.google.com/store/apps/details?id=com.RVBinary.piperist
      many thanks
    • By ForgedInteractive
      Who We Are
      We are Forged Interactive, a small team of like-minded game developers with the sole purpose of making games we love! Currently, we're progressing very quickly with our first project and there are plenty of opportunities and work for new interested programmers. With this project, our development platform is Unity 5.5.2 and C# as our behavioral language. Since this project is our first release, the game itself is a smaller project though progress is moving quickly. We are looking to finalize the current project and get started on future projects in the near future and are expanding our team to do so.
       
      Who We Are Looking For:
      Programmer Level Designer  
      About the Game
      Ours is the tale of two siblings, thrown into a world of chaos. Living in the shadow of their parents' heroic deeds and their Uncle's colorful military career, Finn and Atia are about to become the next force to shape our world. How will you rise through the ranks of Hereilla and what will be your legacy? Once defeated your enemies turn coat and join you in your adventures. Players can enjoy a range of troops and abilities based on their gameplay style which become more important as maps introduce more challenging terrain, enemies and bosses. Strong orc knights, dangerous shamans, and even a dragon are out on the prowl. Knowing when to fight and when to run, and how to manage your army is essential. Your actions alone decide the fate of this world.
       
      Previous Work by Team
      Although we are working towards our first game as Forged Interactive, our team members themselves have worked on titles including and not limited to:
      Final Fantasy Kingsglaive FIFA 2017 Xcom 2 Civilization  
      What do we expect?
      Reference work or portfolio. Examples what have you already done and what projects you have worked on academic or otherwise. The ability to commit to the project on a regular basis. If you are going on a two-week trip, we don't mind, but it would be good if you could commit 10+ hours to the project each week. Willingness to work with a royalty based compensation model, you will be paid when the game launches. Openness to learning new tools and techniques
       
      What can we offer?
      Continuous support and availability from our side. You have the ability to give design input, and creative say in the development of the game. Shown in credits on websites, in-game and more. Insight and contacts from within the Industry.
       
      Contact
      If you are interested in knowing more or joining, please email or PM us on Skype. A member of our management team will reply to you within 48 hours.
       
      E-mail: Recruitment@ForgedInteractive.com
      Skype: ForgedInteractive
       
      Regards,
      David, Colin and Joseph
       
      Follow us on:
      Facebook: https://www.facebook.com/ForgedInteractive/
      Twitter: @ForgedInteract
      Youtube: https://www.youtube.com/channel/UCpK3zhq5ToOeDpdI0Eik-Ug?view_as=subscriber
      Reddit: www.reddit.com/user/Forged_Interactive

    • By dell96
      I'm trying to make my first project but I'm stuck i don't know how to make my crate to start to spawn again when i hit the start button after i die.
      hoping someone can help!!!
      Crate.cs
      CrateSpawn.cs
      Cratework.cs
      GameController.cs
      GameManager.cs
  • Popular Now