Sign in to follow this  
karwosts

OpenGL GL_INVALID_OP in fullscreen mode only

Recommended Posts

I've had a simple game working fine, and have had no problems until I decided to switch it over to fullscreen mode. Unfortunately once I enable fullscreen mode I am starting to receive GL_INVALID_OPERATION errors every time I check glGetError. This doesn't happen in windowed mode, and I'm trying to understand what might be causing this to happen. The window goes into fullscreen mode just fine, and actually partially works, all of my fullscreen background quads are rendered and some of my background shaders are executing properly, but none of my meshes are appearing. So I know that OpenGL is functioning to some extent. Anyway that is all anecdotal, just really trying to figure out why I'm getting these errors. I'll paste my startup code and see if anyone notices anything.
int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine, int nShowCmd)
{
	WNDCLASSEX windowClass;		// window class
	HWND	   hwnd;			// window handle
	MSG		   msg;				// message
	RECT	   windowRect;

	windowRect.left=(long)0;						// Set Left Value To 0
	windowRect.right=(long)WINDOWWIDTH;	// Set Right Value To Requested Width
	windowRect.top=(long)0;							// Set Top Value To 0
	windowRect.bottom=(long)WINDOWHEIGHT;	// Set Bottom Value To Requested Height

	// fill out the window class structure
	windowClass.cbSize			= sizeof(WNDCLASSEX);
	windowClass.style			= CS_HREDRAW | CS_VREDRAW | CS_OWNDC;
	windowClass.lpfnWndProc		= MainWindowProc;
	windowClass.cbClsExtra		= 0;
	windowClass.cbWndExtra		= 0;
	windowClass.hInstance		= hInstance;
	windowClass.hIcon			= LoadIcon(NULL, IDI_APPLICATION);	// default icon
	windowClass.hCursor			= LoadCursor(NULL, IDC_ARROW);		// default arrow
	windowClass.hbrBackground	= NULL;								// don't need background
	windowClass.lpszMenuName	= NULL;								// no menu
	windowClass.lpszClassName	= "GLClass";
	windowClass.hIconSm			= LoadIcon(NULL, IDI_WINLOGO);		// windows logo small icon

	if (!RegisterClassEx(&windowClass)){
		DWORD err = GetLastError();
		return 0;
	}

	CreateGLWindow(windowClass,windowRect,hInstance,&hwnd);
	...

Looking good so far...
bool CreateGLWindow(WNDCLASSEX windowClass, RECT windowRect, HINSTANCE hInstance, HWND *hwnd){

	DWORD	   dwExStyle;		// Window Extended Style
	DWORD	   dwStyle;			// Window Style

	HGLRC hRC;


	if (fullscreen)								// fullscreen?
	{

		int monitors = GetSystemMetrics(SM_CMONITORS);
		
		DISPLAY_DEVICE dd;
		DEVMODE dm;
		dd.cb= sizeof(dd);

		std::vector<DISPLAY_DEVICE> devices;
		std::vector<DEVMODE> devmodes;
		int i = 0;
		while(EnumDisplayDevices(0,i,&dd,0)){
			devices.push_back(dd);
			EnumDisplaySettings(dd.DeviceName,ENUM_CURRENT_SETTINGS,&dm);
			devmodes.push_back(dm);
			i++;
		}


		DEVMODE dmScreenSettings;					// device mode
		memset(&dmScreenSettings,0,sizeof(dmScreenSettings));
		dmScreenSettings.dmSize = sizeof(dmScreenSettings);	
		dmScreenSettings.dmPelsWidth = devmodes[1].dmPelsWidth;			// screen width
		dmScreenSettings.dmPelsHeight = devmodes[1].dmPelsHeight;			// screen height
		dmScreenSettings.dmBitsPerPel = devmodes[1].dmBitsPerPel;				// bits per pixel
		dmScreenSettings.dmFields=DM_BITSPERPEL|DM_PELSWIDTH|DM_PELSHEIGHT;

		if (ChangeDisplaySettingsEx(devices[1].DeviceName,&dmScreenSettings,0, CDS_FULLSCREEN,0) != DISP_CHANGE_SUCCESSFUL)
		{
			MessageBox(NULL, "Display mode failed", NULL, MB_OK);
			fullscreen = FALSE;	
		}
	}

	if (fullscreen)								// Are We Still In Fullscreen Mode?
	{
		dwExStyle=WS_EX_APPWINDOW;					// Window Extended Style
		dwStyle=WS_POPUP;						// Windows Style
		ShowCursor(FALSE);						// Hide Mouse Pointer
	}
	else
	{
		dwExStyle=WS_EX_APPWINDOW | WS_EX_WINDOWEDGE;			// Window Extended Style
		dwStyle=WS_OVERLAPPEDWINDOW;					// Windows Style
	}

	AdjustWindowRectEx(&windowRect, dwStyle, FALSE, dwExStyle);		// Adjust Window To True Requested Size


	*hwnd = CreateWindowEx(NULL,									// extended style
		"GLClass",							// class name16829936
		"Isle",	// app name
		dwStyle | WS_CLIPCHILDREN |
		WS_CLIPSIBLINGS,
		0, 0,								// x,y coordinate
		windowRect.right - windowRect.left,
		windowRect.bottom - windowRect.top, // width, height
		NULL,								// handle to parent
		NULL,								// handle to menu
		hInstance,							// application instance
		NULL);								// no extra params


This section is the only difference I have between fullscreen and windowed mode, just changing some Display Settings. I'm not real experienced here so its possible I'm doing something stupid. Calling CreateWindowEx fires off a CALLBACK MainWindowProc with message WM_SIZE, where I'm checking for opengl error. In windowed mode this passes just fine, while failing with GL_INVALID_OPERATION in fullscreen. Any ideas?

Share this post


Link to post
Share on other sites
I don't understand this:
devices[1]...
Anyway, could you post the actual change code? If it's just a ChangeDisplaySettingsEx, then I think you need a AdjustWindowRectEx too.

What happens if you start with fullscreen initially? (not just toggling to it).

Share this post


Link to post
Share on other sites
Quote:
...devices[1]...


Guess I should have explained that better. I'm using a two-monitor environment, and that is the device for my second monitor. Code could be incorrect, but I'm just cobbling together bits and pieces I've found from various sources. I get the same behavior if I use devices[0] too (main monitor).

Quote:

Anyway, could you post the actual change code? If it's just a ChangeDisplaySettingsEx, then I think you need a AdjustWindowRectEx too.


I'm not sure I understand what 'actual change code' you're referring to. That is every line of code I use up through when I get the glError. I do have AdjustWindowRectEx too, its the last line before CreateWindowEx.

Quote:

What happens if you start with fullscreen initially? (not just toggling to it).
I'm not sure how you would do this.

Thanks for looking.

Share this post


Link to post
Share on other sites
Sorry, I guess it's morning.

I was referring to your change-to-fullscreen code. When you push the "change-to-fullscreen-key".

Or maybe I misunderstood something.

"This section is the only difference I have between fullscreen and windowed mode, just changing some Display Settings"

I don't understand this sentence. Clarifying "some Display Settings" would be useful.

Share this post


Link to post
Share on other sites
Oh sorry. This is the initialization code for my program, I'm not changing it once its running.

Program opens with WinMain, WinMain calls CreateGLWindow, CreateGLWindow calls CreateWindowEx which causes WM_SIZE message where the opengl error is caught.

When I said the only difference between fullscreen and windowed mode, I meant that I'm selecting fullscreen or windowed mode by hardcoding variable 'fullscreen' to true or false. When I start defined to windowed mode initialization works fine, if I start in fullscreen mode the initialization is causing errors.

I said I was 'changing Display Settings' because I was calling the winapi function "ChangeDisplaySettings". Not actually changing anything once its running.

Share this post


Link to post
Share on other sites
What happens if you remove the device-lister stuff, and just use hard-coded devmode settings for the fullscreen?

My window create for fullscreen:
AdjustWindowRectEx(&WindowRect, WS_POPUP|WS_VISIBLE, FALSE, WS_EX_TOPMOST);
CreateWindowEx(WS_EX_TOPMOST,WIND_CLASS_NAME,WIND_CLASS_NAME,WS_POPUP|WS_VISIBLE,...

You doesn't seem to use the dwExstyle (you pass NULL instead)

Share this post


Link to post
Share on other sites
Maybe you miss this from the device lister stuff:
memset(&dd,0,sizeof(DISPLAY_DEVICE));
memset(&dm,0,sizeof(DEVMODE));//the same for other DEVMODE variables
dm.dmSize = sizeof(DEVMODE);//the same for other DEVMODE variables
There are some flags that need to be set to zero (or something else). I use zero.

Share this post


Link to post
Share on other sites
Found the problem, I was calling setup projection on WM_SIZE event. For some reason when using WS_POPUP style on the first WM_SIZE event the OpenGL context is not ready, although when using the WS_OVERLAPPEDWINDOW style the context is ready on the first WM_SIZE event.

Anyway just threw an if(isInitialized) check around my projection setup and its got no problem now.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Forum Statistics

    • Total Topics
      627733
    • Total Posts
      2978837
  • Similar Content

    • By DelicateTreeFrog
      Hello! As an exercise for delving into modern OpenGL, I'm creating a simple .obj renderer. I want to support things like varying degrees of specularity, geometry opacity, things like that, on a per-material basis. Different materials can also have different textures. Basic .obj necessities. I've done this in old school OpenGL, but modern OpenGL has its own thing going on, and I'd like to conform as closely to the standards as possible so as to keep the program running correctly, and I'm hoping to avoid picking up bad habits this early on.
      Reading around on the OpenGL Wiki, one tip in particular really stands out to me on this page:
      For something like a renderer for .obj files, this sort of thing seems almost ideal, but according to the wiki, it's a bad idea. Interesting to note!
      So, here's what the plan is so far as far as loading goes:
      Set up a type for materials so that materials can be created and destroyed. They will contain things like diffuse color, diffuse texture, geometry opacity, and so on, for each material in the .mtl file. Since .obj files are conveniently split up by material, I can load different groups of vertices/normals/UVs and triangles into different blocks of data for different models. When it comes to the rendering, I get a bit lost. I can either:
      Between drawing triangle groups, call glUseProgram to use a different shader for that particular geometry (so a unique shader just for the material that is shared by this triangle group). or
      Between drawing triangle groups, call glUniform a few times to adjust different parameters within the "master shader", such as specularity, diffuse color, and geometry opacity. In both cases, I still have to call glBindTexture between drawing triangle groups in order to bind the diffuse texture used by the material, so there doesn't seem to be a way around having the CPU do *something* during the rendering process instead of letting the GPU do everything all at once.
      The second option here seems less cluttered, however. There are less shaders to keep up with while one "master shader" handles it all. I don't have to duplicate any code or compile multiple shaders. Arguably, I could always have the shader program for each material be embedded in the material itself, and be auto-generated upon loading the material from the .mtl file. But this still leads to constantly calling glUseProgram, much more than is probably necessary in order to properly render the .obj. There seem to be a number of differing opinions on if it's okay to use hundreds of shaders or if it's best to just use tens of shaders.
      So, ultimately, what is the "right" way to do this? Does using a "master shader" (or a few variants of one) bog down the system compared to using hundreds of shader programs each dedicated to their own corresponding materials? Keeping in mind that the "master shaders" would have to track these additional uniforms and potentially have numerous branches of ifs, it may be possible that the ifs will lead to additional and unnecessary processing. But would that more expensive than constantly calling glUseProgram to switch shaders, or storing the shaders to begin with?
      With all these angles to consider, it's difficult to come to a conclusion. Both possible methods work, and both seem rather convenient for their own reasons, but which is the most performant? Please help this beginner/dummy understand. Thank you!
    • By JJCDeveloper
      I want to make professional java 3d game with server program and database,packet handling for multiplayer and client-server communicating,maps rendering,models,and stuffs Which aspect of java can I learn and where can I learn java Lwjgl OpenGL rendering Like minecraft and world of tanks
    • By AyeRonTarpas
      A friend of mine and I are making a 2D game engine as a learning experience and to hopefully build upon the experience in the long run.

      -What I'm using:
          C++;. Since im learning this language while in college and its one of the popular language to make games with why not.     Visual Studios; Im using a windows so yea.     SDL or GLFW; was thinking about SDL since i do some research on it where it is catching my interest but i hear SDL is a huge package compared to GLFW, so i may do GLFW to start with as learning since i may get overwhelmed with SDL.  
      -Questions
      Knowing what we want in the engine what should our main focus be in terms of learning. File managements, with headers, functions ect. How can i properly manage files with out confusing myself and my friend when sharing code. Alternative to Visual studios: My friend has a mac and cant properly use Vis studios, is there another alternative to it?  
    • By ferreiradaselva
      Both functions are available since 3.0, and I'm currently using `glMapBuffer()`, which works fine.
      But, I was wondering if anyone has experienced advantage in using `glMapBufferRange()`, which allows to specify the range of the mapped buffer. Could this be only a safety measure or does it improve performance?
      Note: I'm not asking about glBufferSubData()/glBufferData. Those two are irrelevant in this case.
    • By xhcao
      Before using void glBindImageTexture(    GLuint unit, GLuint texture, GLint level, GLboolean layered, GLint layer, GLenum access, GLenum format), does need to make sure that texture is completeness. 
  • Popular Now