I just finished my first complete project with C++ and even though it seems a bit unrealistic to expect anyone to take the time to look through the source critically...I would greatly appreciate anyone if they did.



I've also included an executable.
This is, as you can see, a Tetris clone as per the main site's suggestion, and my code was heavily influenced by this example. I'm using SDL for input/output.

Download link

You use the up arrow to spin, other arrows for movement, P key to pause, escape key to exit, and the spacebar to drop pieces immediately.

Any feedback, constructive or otherwise is welcome, and I think that I will try to make something more interesting now.

Suggestions for drawing text would be especially welcome.

Thank you for your time.

EDIT: Also it has just occured to me that I forgot to add a restarting feature near the end...

I tried running the app, but got 'This application has failed to start because MSVCR100.dll was not found'. (This is on Windows XP.)

It would take me a while to really go through the code thoroughly, but from a quick once-over, it looks quite good. Here are some random observations:

- You seem to be going for an object-oriented, C++-style approach in general. In keeping with that, I'd suggest replacing your various #define's with named constants or enums.

- Don't write empty non-virtual destructors (the compiler-generated destructor will suffice).

- It looks like all the member data in c_control is public (not sure if that was intentional).

- If s_screen is the SDL_Surface for the window itself, I don't think you need to free it at shutdown (you might check the SDL docs to make sure).

Again, this was only a very cursory once-over; I didn't really get into the program logic or overall design. What I saw looked nice and clean though.

As for rendering text, you might look into the SDL_ttf library (or whatever it's called).

Thank you for taking the time to reply, I suppose it would be nice if you were able to actually run it, but I'm not skilled enough toa dd anything you wouldn't see in any other Tetris clone.

I'm assuming that I downloaded whatever DLL that is at some point and have forgotten, hm...

So enumerations are better then? I will look into changing that...

About the public members...I realy have some issues with the whole public/private bit...and Visual Studio isn't helping by automatically making things public lol.

I will definately look into "SDL_ttf"...now, thank you for the suggestion.

I just want to say nice work! While I'm sure you weren't focusing on this, I do suggest that you pick nicer colors in the future. For the MSVCR100.dll, you'll probably need to look into the Visual C++ 2010 redistributables.

Quote:Original post by Ezbez
I just want to say nice work! While I'm sure you weren't focusing on this, I do suggest that you pick nicer colors in the future. For the MSVCR100.dll, you'll probably need to look into the Visual C++ 2010 redistributables.

Thank you, and about the colors, is there a better way than searching for/copying hex colors to define colors? If not, what variable type should I use to stor '0xFFFFFFff' and the like to pass? I tried character constant but that did not work.

EDIT: Thank you for suggesting that tutorial site, I'm going through 3 or 4 tutorial lists at the moment lol so I will definately need to move that set up.

The only surface that I used in that case was the screen surface, and I used... I used boxColor from the gfx library for alll of the drawing, but I will try to lear about the 'SDL_image' that was mentioned...

THANK YOU for telling me about the User defined types, I've beenw ondering what all the Uint's in the libraries were, that makes sense. I think that I will finish those tutorials before I try another project.

Do you know how to create c++ project templates in VS10 via the custom wizard by chance? My recent files are a bit confusing because every solution is called 'sdl_base.'

EDIT: I think that I'm misreading the 'Microsoft Visual C++ 2010 Redistributable Package' description, does installing that change how executables are created? or does it allow the person installing to run exe's that I created?

EDIT:: Completely random, but do 'object_names' listed after a class declarations closing bracket but before the semi-colon count as a global declaration for an identifier for the class? Also, does it actually create the object or just declare it?

EDIT::: I was messing around with global variabels to just test some things and returned...

1>blabla\c_piece.cpp(10): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int1>blabla\c_piece.cpp(10): error C2086: 'int iii' : redefinition

Don't those two errors directly contradict each other? If it is missing a type specifier, than when was it originally defined to be illegally defiend here?

[Edited by - wioneo on July 18, 2010 9:44:07 PM]

Well done in completing your first game in C++. I know the first one is hard because I'm still trying to my first game in C++.

I've never actually used SDL before but I have heard of it how much different is it to using the Win32 API?