Sign in to follow this  

DX11 DirectX Fullscreen crash

This topic is 2638 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Hello everyone, I've been following a tutorial over at http://www.directxtutorial.com as well as through many different books but have been coming across the same problem every time. Whenever I try to launch a window through directX in fullscreen mode, it always crashes and windows pops up saying "We're searching for an answer to this problem", ect.

Here is the code:

(Sorry, I'm not sure if gamedev.net has a tag for posting code or not)

// include the basic windows header files and the Direct3D header files
#include <windows.h>
#include <windowsx.h>
#include <d3d11.h>
#include <d3dx11.h>
#include <d3dx10.h>

// include the Direct3D Library file
#pragma comment (lib, "d3d11.lib")
#pragma comment (lib, "d3dx11.lib")
#pragma comment (lib, "d3dx10.lib")

// define the screen resolution
#define SCREEN_WIDTH 800
#define SCREEN_HEIGHT 600

// global declarations
IDXGISwapChain *swapchain; // the pointer to the swap chain interface
ID3D11Device *dev; // the pointer to our Direct3D device interface
ID3D11DeviceContext *devcon; // the pointer to our Direct3D device context
ID3D11RenderTargetView *backbuffer; // the pointer to our back buffer

// function prototypes
void InitD3D(HWND hWnd); // sets up and initializes Direct3D
void RenderFrame(void); // renders a single frame
void CleanD3D(void); // closes Direct3D and releases memory

// the WindowProc function prototype
LRESULT CALLBACK WindowProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam);


// the entry point for any Windows program
int WINAPI WinMain(HINSTANCE hInstance,
HINSTANCE hPrevInstance,
LPSTR lpCmdLine,
int nCmdShow)
{
HWND hWnd;
WNDCLASSEX wc;

ZeroMemory(&wc, sizeof(WNDCLASSEX));

wc.cbSize = sizeof(WNDCLASSEX);
wc.style = CS_HREDRAW | CS_VREDRAW;
wc.lpfnWndProc = WindowProc;
wc.hInstance = hInstance;
wc.hCursor = LoadCursor(NULL, IDC_ARROW);
// wc.hbrBackground = (HBRUSH)COLOR_WINDOW; // no longer needed
wc.lpszClassName = L"WindowClass";

RegisterClassEx(&wc);

RECT wr = {0, 0, SCREEN_WIDTH, SCREEN_HEIGHT};
AdjustWindowRect(&wr, WS_OVERLAPPEDWINDOW, FALSE);

hWnd = CreateWindowEx(NULL,
L"WindowClass",
L"Our First Direct3D Program",
WS_OVERLAPPEDWINDOW,
300,
300,
wr.right - wr.left,
wr.bottom - wr.top,
NULL,
NULL,
hInstance,
NULL);

ShowWindow(hWnd, nCmdShow);

// set up and initialize Direct3D
InitD3D(hWnd);

// enter the main loop:

MSG msg;

while(TRUE)
{
if(PeekMessage(&msg, NULL, 0, 0, PM_REMOVE))
{
TranslateMessage(&msg);
DispatchMessage(&msg);

if(msg.message == WM_QUIT)
break;
}

RenderFrame();
}

// clean up DirectX and COM
CleanD3D();

return msg.wParam;
}


// this is the main message handler for the program
LRESULT CALLBACK WindowProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam)
{
switch(message)
{
case WM_DESTROY:
{
PostQuitMessage(0);
return 0;
} break;
}

return DefWindowProc (hWnd, message, wParam, lParam);
}


// this function initializes and prepares Direct3D for use
void InitD3D(HWND hWnd)
{
// create a struct to hold information about the swap chain
DXGI_SWAP_CHAIN_DESC scd;

// clear out the struct for use
ZeroMemory(&scd, sizeof(DXGI_SWAP_CHAIN_DESC));

// fill the swap chain description struct
scd.BufferCount = 1; // one back buffer
scd.BufferDesc.Format = DXGI_FORMAT_R8G8B8A8_UNORM; // use 32-bit color
scd.BufferDesc.Width = SCREEN_WIDTH; // set the back buffer width
scd.BufferDesc.Height = SCREEN_HEIGHT; // set the back buffer height
scd.BufferUsage = DXGI_USAGE_RENDER_TARGET_OUTPUT; // how swap chain is to be used
scd.OutputWindow = hWnd; // the window to be used
scd.SampleDesc.Count = 4; // how many multisamples
scd.Windowed = TRUE; // windowed/full-screen mode
scd.Flags = DXGI_SWAP_CHAIN_FLAG_ALLOW_MODE_SWITCH; // allow full-screen switching

// create a device, device context and swap chain using the information in the scd struct
D3D11CreateDeviceAndSwapChain(NULL,
D3D_DRIVER_TYPE_HARDWARE,
NULL,
NULL,
NULL,
NULL,
D3D11_SDK_VERSION,
&scd,
&swapchain,
&dev,
NULL,
&devcon);


// get the address of the back buffer
ID3D11Texture2D *pBackBuffer;
swapchain->GetBuffer(0, __uuidof(ID3D11Texture2D), (LPVOID*)&pBackBuffer);

// use the back buffer address to create the render target
dev->CreateRenderTargetView(pBackBuffer, NULL, &backbuffer);
pBackBuffer->Release();

// set the render target as the back buffer
devcon->OMSetRenderTargets(1, &backbuffer, NULL);


// Set the viewport
D3D11_VIEWPORT viewport;
ZeroMemory(&viewport, sizeof(D3D11_VIEWPORT));

viewport.TopLeftX = 0;
viewport.TopLeftY = 0;
viewport.Width = SCREEN_WIDTH;
viewport.Height = SCREEN_HEIGHT;

devcon->RSSetViewports(1, &viewport);
}


// this is the function used to render a single frame
void RenderFrame(void)
{
// clear the back buffer to a deep blue
devcon->ClearRenderTargetView(backbuffer, D3DXCOLOR(0.0f, 0.2f, 0.4f, 1.0f));

// do 3D rendering on the back buffer here

// switch the back buffer and the front buffer
swapchain->Present(0, 0);
}


// this is the function that cleans up Direct3D and COM
void CleanD3D(void)
{
swapchain->SetFullscreenState(FALSE, NULL); // switch to windowed mode

// close and release all existing COM objects
swapchain->Release();
backbuffer->Release();
dev->Release();
devcon->Release();
}

I am have the newest DirectX SDK downloaded and am using Microsoft's Visual C++ 2010 Express edition. If anyone knows what the problem might be, please let me know.

Thanks

Share this post


Link to post
Share on other sites
Argh, I hoped that the author would have finally got around to doing some error checking in his code, apparently not...

You're not checking if any functions fail. Most D3D functions return a HRESULT value, which you should be checking with the SUCCEEDED or FAILED macro to determine if the function failed.

In your code, if D3D11CreateDeviceAndSwapChain fails, you go on to use the swapchain variable, which is a null or uninitialised pointer, which will cause the crash.

You should also be running your code in the debugger, so it'll break to the debugger when it crashes, let you see what line of code caused the crash, and examine the variables to determine the cause. Here is a good tutorial on using Visual Studio's debugger.

Share this post


Link to post
Share on other sites
Quote:
Original post by ProgrammerDX
Doesn't checking the HRESULT return value for each function cause a performance hit on your program?
Not in any noticeable way, no. It's about 3 assembly instructions, and the simplest DirectX call will be several hundred or thousand.

And besides, you have to do the check, unless you want your app to crash.

Share this post


Link to post
Share on other sites
Hiding the border and maximizing the window is 100% stable and much faster to activate. You can't change the screen resolution in this method but you can answer IM calls without terminating the application.

http://www.codeguru.com/forum/showthread.php?t=500867

Share this post


Link to post
Share on other sites
Thank you for the replies everyone. I'm having trouble figuring out exactly where and how I'm supposed to use HRESULT, though. I've searched around but can't find where in this code it should go. I attempted to use it below in the bolded areas, but I'm sure it's incorrect.

Any more information would be greatly appreciated.

Thanks.

(note, I declared HRESULT hr at the beginning of the program.)


// create a device, device context and swap chain using the information in the scd struct
hr = D3D11CreateDeviceAndSwapChain(NULL,
D3D_DRIVER_TYPE_HARDWARE,
NULL,
NULL,
NULL,
NULL,
D3D11_SDK_VERSION,
&scd,
&swapchain,
&dev,
NULL,
&devcon);


// get the address of the back buffer
ID3D11Texture2D *pBackBuffer;
swapchain->GetBuffer(0, __uuidof(ID3D11Texture2D), (LPVOID*)&pBackBuffer);

// use the back buffer address to create the render target
dev->CreateRenderTargetView(pBackBuffer, NULL, &backbuffer);
pBackBuffer->Release();

// set the render target as the back buffer
devcon->OMSetRenderTargets(1, &backbuffer, NULL);


// Set the viewport
D3D11_VIEWPORT viewport;
ZeroMemory(&viewport, sizeof(D3D11_VIEWPORT));

viewport.TopLeftX = 0;
viewport.TopLeftY = 0;
viewport.Width = SCREEN_WIDTH;
viewport.Height = SCREEN_HEIGHT;

devcon->RSSetViewports(1, &viewport);

InitPipeline();
InitGraphics();

if(FAILED(hr)){
// Handle error
}


}

Share this post


Link to post
Share on other sites
It's quite easy. Every time you call a DX API function that returns an HRESULT, you check it ASAP. This means right after calling this function. In the example you gave us, you tried to create a swap chain then used it and verified afterwards if it has been created: this is clearly the wrong way and will make your program crash.

Examples:

if(FAILED(D3D11CreateDeviceAndSwapChain(...)))
throw std::exception("Something failed");

if(FAILED(swapchain->GetBuffer(...)))
throw std::exception("Something failed");




I wrote a function & macro just for that code. Throwing an exception is acceptable if the function is not supposed to fail that often (which is the case in 99.99% of dx calls). Please don't buy into the myth that checking error states or throwing exceptions will make your code considerably slower. The latter might have a bigger performance hit, if you use it in the wrong way. Notifying about exceptional states that shouldn't happen (for example an API call failing that shouldn't, a resource not being able to load) is the prime purpose of exceptions, combined with the fact that you don't deal with errors at the throw side, but the catch side.


typedef boost::error_info<struct file_, std::string> file;
typedef boost::error_info<struct file_, std::string> api_message;
typedef boost::error_info<struct file_, std::string> api_function;
typedef boost::error_info<struct tag_api_call,std::string> api_call;
typedef boost::error_info<struct tag_d3d11_hresult,HRESULT> d3d11_result;

class d3d11_exception : virtual public std::exception, virtual public boost::exception
{
public:

d3d11_exception(const std::string& what) : std::exception(what) {}

HRESULT getAPIResult() const
{
if(const HRESULT* err = boost::get_error_info<d3d11_result>(*this))
return *err;
else
return D3D_OK;
}



/**
* Verifies the given result from a D3D11 API call and throws an exception in case the it failed.
*/

static void verify_call(HRESULT hr, const char* call, const char* file, const char* function, int line)
{
if(FAILED(hr))
{
throw d3d11_exception(format("A D3D11 API call failed: %1%(%2%)") % readableResult(hr) % hr)
<< debug_info_m(file, function, line)
<< d3d11_result(hr)
<< api_call(call)
;
}
}



/**
* This function returns a readable result string for the given HRESULT.
* Currently, all DXGI error codes are known
*/

static const char* readableResult(HRESULT hr)
{
switch(hr)
{
case DXGI_ERROR_DEVICE_HUNG: return __STR__(DXGI_ERROR_DEVICE_HUNG);
case DXGI_ERROR_DEVICE_REMOVED: return __STR__(DXGI_ERROR_DEVICE_REMOVED);
case DXGI_ERROR_DEVICE_RESET: return __STR__(DXGI_ERROR_DEVICE_RESET);
case DXGI_ERROR_DRIVER_INTERNAL_ERROR: return __STR__(DXGI_ERROR_DRIVER_INTERNAL_ERROR);
case DXGI_ERROR_FRAME_STATISTICS_DISJOINT: return __STR__(DXGI_ERROR_FRAME_STATISTICS_DISJOINT);
case DXGI_ERROR_GRAPHICS_VIDPN_SOURCE_IN_USE: return __STR__(DXGI_ERROR_GRAPHICS_VIDPN_SOURCE_IN_USE);
case DXGI_ERROR_INVALID_CALL: return __STR__(DXGI_ERROR_INVALID_CALL);
case DXGI_ERROR_MORE_DATA: return __STR__(DXGI_ERROR_MORE_DATA);
case DXGI_ERROR_NONEXCLUSIVE: return __STR__(DXGI_ERROR_NONEXCLUSIVE);
case DXGI_ERROR_NOT_CURRENTLY_AVAILABLE: return __STR__(DXGI_ERROR_NOT_CURRENTLY_AVAILABLE);
case DXGI_ERROR_NOT_FOUND: return __STR__(DXGI_ERROR_NOT_FOUND);
case DXGI_ERROR_REMOTE_CLIENT_DISCONNECTED: return __STR__(DXGI_ERROR_REMOTE_CLIENT_DISCONNECTED);
case DXGI_ERROR_REMOTE_OUTOFMEMORY: return __STR__(DXGI_ERROR_REMOTE_OUTOFMEMORY);
case DXGI_ERROR_WAS_STILL_DRAWING: return __STR__(DXGI_ERROR_WAS_STILL_DRAWING);
case DXGI_ERROR_UNSUPPORTED: return __STR__(DXGI_ERROR_UNSUPPORTED);
case S_OK: return __STR__(S_OK);
default: return "Unknown hresult";
}
}
};
///////////////////////////////////////////////////////////////////////////////////////////////////

/**
* This macro executes the given D3D11 call and tests if it returned an error code.
* (Tested via the FAILED macro from Microsoft).
*/

#define D3D11_API(x) d3d11_exception::verify_call((x), #x, __FILE__, __FUNCTION__, __LINE__)


Share this post


Link to post
Share on other sites

This topic is 2638 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Forum Statistics

    • Total Topics
      628749
    • Total Posts
      2984496
  • Similar Content

    • By GreenGodDiary
      Having some issues with a geometry shader in a very basic DX app.
      We have an assignment where we are supposed to render a rotating textured quad, and in the geometry shader duplicate this quad and offset it by its normal. Very basic stuff essentially.
      My issue is that the duplicated quad, when rendered in front of the original quad, seems to fail the Z test and thus the original quad is rendered on top of it.
      Whats even weirder is that this only happens for one of the triangles in the duplicated quad, against one of the original quads triangles.

      Here's a video to show you what happens: Video (ignore the stretched textures)

      Here's my GS: (VS is simple passthrough shader and PS is just as basic)
      struct VS_OUT { float4 Pos : SV_POSITION; float2 UV : TEXCOORD; }; struct VS_IN { float4 Pos : POSITION; float2 UV : TEXCOORD; }; cbuffer cbPerObject : register(b0) { float4x4 WVP; }; [maxvertexcount(6)] void main( triangle VS_IN input[3], inout TriangleStream< VS_OUT > output ) { //Calculate normal float4 faceEdgeA = input[1].Pos - input[0].Pos; float4 faceEdgeB = input[2].Pos - input[0].Pos; float3 faceNormal = normalize(cross(faceEdgeA.xyz, faceEdgeB.xyz)); //Input triangle, transformed for (uint i = 0; i < 3; i++) { VS_OUT element; VS_IN vert = input[i]; element.Pos = mul(vert.Pos, WVP); element.UV = vert.UV; output.Append(element); } output.RestartStrip(); for (uint j = 0; j < 3; j++) { VS_OUT element; VS_IN vert = input[j]; element.Pos = mul(vert.Pos + float4(faceNormal, 0.0f), WVP); element.Pos.xyz; element.UV = vert.UV; output.Append(element); } }  
      I havent used geometry shaders much so im not 100% on what happens behind the scenes.
      Any tips appreciated! 
    • By mister345
      Hi, I'm building a game engine using DirectX11 in c++.
      I need a basic physics engine to handle collisions and motion, and no time to write my own.
      What is the easiest solution for this? Bullet and PhysX both seem too complicated and would still require writing my own wrapper classes, it seems. 
      I found this thing called PAL - physics abstraction layer that can support bullet, physx, etc, but it's so old and no info on how to download or install it.
      The simpler the better. Please let me know, thanks!
    • By Hexaa
      I try to draw lines with different thicknesses using the geometry shader approach from here:
      https://forum.libcinder.org/topic/smooth-thick-lines-using-geometry-shader
      It seems to work great on my development machine (some Intel HD). However, if I try it on my target (Nvidia NVS 300, yes it's old) I get different results. See the attached images. There
      seem to be gaps in my sine signal that the NVS 300 device creates, the intel does what I want and expect in the other picture.
      It's a shame, because I just can't figure out why. I expect it to be the same. I get no Error in the debug output, with enabled native debugging. I disabled culling with CullMode.None. Could it be some z-fighting? I have little clue about it but I tested to play around with the RasterizerStateDescription and DepthBias properties with no success, no change at all. Maybe I miss something there?
      I develop the application with SharpDX btw.
      Any clues or help is very welcome
       


    • By Beny Benz
      Hi,
      I'm currently trying to write a shader which shoud compute a fast fourier transform of some data, manipulating the transformed data, do an inverse FFT an then displaying the result as vertex offset and color. I use Unity3d and HLSL as shader language. One of the main problems is that the data should not be passed from CPU to GPU for every frame if possible. My original plan was to use a vertex shader and do the fft there, but I fail to find out how to store changing data betwen shader calls/passes. I found a technique called ping-ponging which seems to be based on writing and exchangeing render targets, but I couldn't find an example for HLSL as a vertex shader yet.
      I found https://social.msdn.microsoft.com/Forums/en-US/c79a3701-d028-41d9-ad74-a2b3b3958383/how-to-render-to-multiple-render-targets-in-hlsl?forum=xnaframework
      which seem to use COLOR0 and COLOR1 as such render targets.
      Is it even possible to do such calculations on the gpu only? (/in this shader stage?, because I need the result of the calculation to modify the vertex offsets there)
      I also saw the use of compute shaders in simmilar projects (ocean wave simulation), do they realy copy data between CPU / GPU for every frame?
      How does this ping-ponging / rendertarget switching technique work in HLSL?
      Have you seen an example of usage?
      Any answer would be helpfull.
      Thank you
      appswert
    • By ADDMX
      Hi
      Just a simple question about compute shaders (CS5, DX11).
      Do the atomic operations (InterlockedAdd in my case) should work without any issues on RWByteAddressBuffer and be globaly coherent ?
      I'v come back from CUDA world and commited fairly simple kernel that does some job, the pseudo-code is as follows:
      (both kernels use that same RWByteAddressBuffer)
      first kernel does some job and sets Result[0] = 0;
      (using Result.Store(0, 0))
      I'v checked with debugger, and indeed the value stored at dword 0 is 0
      now my second kernel
      RWByteAddressBuffer Result;  [numthreads(8, 8, 8)] void main() {     for (int i = 0; i < 5; i++)     {         uint4 v0 = DoSomeCalculations1();         uint4 v1 = DoSomeCalculations2();         uint4 v2 = DoSomeCalculations3();                  if (v0.w == 0 && v1.w == 0 && v2.w)             continue;         //    increment counter by 3, and get it previous value         // this should basically allocate space for 3 uint4 values in buffer         uint prev;         Result.InterlockedAdd(0, 3, prev);                  // this fills the buffer with 3 uint4 values (+1 is here as the first 16 bytes is occupied by DrawInstancedIndirect data)         Result.Store4((prev+0+1)*16, v0);         Result.Store4((prev+1+1)*16, v1);         Result.Store4((prev+2+1)*16, v2);     } } Now I invoke it with Dispatch(4,4,4)
      Now I use DrawInstancedIndirect to draw the buffer, but ocassionaly there is missed triangle here and there for a frame, as if the atomic counter does not work as expected
      do I need any additional synchronization there ?
      I'v tried 'AllMemoryBarrierWithGroupSync' at the end of kernel, but without effect.
      If I do not use atomic counter, and istead just output empty vertices (that will transform into degenerated triangles) the all is OK - as if I'm missing some form of synchronization, but I do not see such a thing in DX11.
      I'v tested on both old and new nvidia hardware (680M and 1080, the behaviour is that same).
       
  • Popular Now