Sign in to follow this  
DranoMax

DX11 DirectX Fullscreen crash

Recommended Posts

Hello everyone, I've been following a tutorial over at http://www.directxtutorial.com as well as through many different books but have been coming across the same problem every time. Whenever I try to launch a window through directX in fullscreen mode, it always crashes and windows pops up saying "We're searching for an answer to this problem", ect.

Here is the code:

(Sorry, I'm not sure if gamedev.net has a tag for posting code or not)

// include the basic windows header files and the Direct3D header files
#include <windows.h>
#include <windowsx.h>
#include <d3d11.h>
#include <d3dx11.h>
#include <d3dx10.h>

// include the Direct3D Library file
#pragma comment (lib, "d3d11.lib")
#pragma comment (lib, "d3dx11.lib")
#pragma comment (lib, "d3dx10.lib")

// define the screen resolution
#define SCREEN_WIDTH 800
#define SCREEN_HEIGHT 600

// global declarations
IDXGISwapChain *swapchain; // the pointer to the swap chain interface
ID3D11Device *dev; // the pointer to our Direct3D device interface
ID3D11DeviceContext *devcon; // the pointer to our Direct3D device context
ID3D11RenderTargetView *backbuffer; // the pointer to our back buffer

// function prototypes
void InitD3D(HWND hWnd); // sets up and initializes Direct3D
void RenderFrame(void); // renders a single frame
void CleanD3D(void); // closes Direct3D and releases memory

// the WindowProc function prototype
LRESULT CALLBACK WindowProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam);


// the entry point for any Windows program
int WINAPI WinMain(HINSTANCE hInstance,
HINSTANCE hPrevInstance,
LPSTR lpCmdLine,
int nCmdShow)
{
HWND hWnd;
WNDCLASSEX wc;

ZeroMemory(&wc, sizeof(WNDCLASSEX));

wc.cbSize = sizeof(WNDCLASSEX);
wc.style = CS_HREDRAW | CS_VREDRAW;
wc.lpfnWndProc = WindowProc;
wc.hInstance = hInstance;
wc.hCursor = LoadCursor(NULL, IDC_ARROW);
// wc.hbrBackground = (HBRUSH)COLOR_WINDOW; // no longer needed
wc.lpszClassName = L"WindowClass";

RegisterClassEx(&wc);

RECT wr = {0, 0, SCREEN_WIDTH, SCREEN_HEIGHT};
AdjustWindowRect(&wr, WS_OVERLAPPEDWINDOW, FALSE);

hWnd = CreateWindowEx(NULL,
L"WindowClass",
L"Our First Direct3D Program",
WS_OVERLAPPEDWINDOW,
300,
300,
wr.right - wr.left,
wr.bottom - wr.top,
NULL,
NULL,
hInstance,
NULL);

ShowWindow(hWnd, nCmdShow);

// set up and initialize Direct3D
InitD3D(hWnd);

// enter the main loop:

MSG msg;

while(TRUE)
{
if(PeekMessage(&msg, NULL, 0, 0, PM_REMOVE))
{
TranslateMessage(&msg);
DispatchMessage(&msg);

if(msg.message == WM_QUIT)
break;
}

RenderFrame();
}

// clean up DirectX and COM
CleanD3D();

return msg.wParam;
}


// this is the main message handler for the program
LRESULT CALLBACK WindowProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam)
{
switch(message)
{
case WM_DESTROY:
{
PostQuitMessage(0);
return 0;
} break;
}

return DefWindowProc (hWnd, message, wParam, lParam);
}


// this function initializes and prepares Direct3D for use
void InitD3D(HWND hWnd)
{
// create a struct to hold information about the swap chain
DXGI_SWAP_CHAIN_DESC scd;

// clear out the struct for use
ZeroMemory(&scd, sizeof(DXGI_SWAP_CHAIN_DESC));

// fill the swap chain description struct
scd.BufferCount = 1; // one back buffer
scd.BufferDesc.Format = DXGI_FORMAT_R8G8B8A8_UNORM; // use 32-bit color
scd.BufferDesc.Width = SCREEN_WIDTH; // set the back buffer width
scd.BufferDesc.Height = SCREEN_HEIGHT; // set the back buffer height
scd.BufferUsage = DXGI_USAGE_RENDER_TARGET_OUTPUT; // how swap chain is to be used
scd.OutputWindow = hWnd; // the window to be used
scd.SampleDesc.Count = 4; // how many multisamples
scd.Windowed = TRUE; // windowed/full-screen mode
scd.Flags = DXGI_SWAP_CHAIN_FLAG_ALLOW_MODE_SWITCH; // allow full-screen switching

// create a device, device context and swap chain using the information in the scd struct
D3D11CreateDeviceAndSwapChain(NULL,
D3D_DRIVER_TYPE_HARDWARE,
NULL,
NULL,
NULL,
NULL,
D3D11_SDK_VERSION,
&scd,
&swapchain,
&dev,
NULL,
&devcon);


// get the address of the back buffer
ID3D11Texture2D *pBackBuffer;
swapchain->GetBuffer(0, __uuidof(ID3D11Texture2D), (LPVOID*)&pBackBuffer);

// use the back buffer address to create the render target
dev->CreateRenderTargetView(pBackBuffer, NULL, &backbuffer);
pBackBuffer->Release();

// set the render target as the back buffer
devcon->OMSetRenderTargets(1, &backbuffer, NULL);


// Set the viewport
D3D11_VIEWPORT viewport;
ZeroMemory(&viewport, sizeof(D3D11_VIEWPORT));

viewport.TopLeftX = 0;
viewport.TopLeftY = 0;
viewport.Width = SCREEN_WIDTH;
viewport.Height = SCREEN_HEIGHT;

devcon->RSSetViewports(1, &viewport);
}


// this is the function used to render a single frame
void RenderFrame(void)
{
// clear the back buffer to a deep blue
devcon->ClearRenderTargetView(backbuffer, D3DXCOLOR(0.0f, 0.2f, 0.4f, 1.0f));

// do 3D rendering on the back buffer here

// switch the back buffer and the front buffer
swapchain->Present(0, 0);
}


// this is the function that cleans up Direct3D and COM
void CleanD3D(void)
{
swapchain->SetFullscreenState(FALSE, NULL); // switch to windowed mode

// close and release all existing COM objects
swapchain->Release();
backbuffer->Release();
dev->Release();
devcon->Release();
}

I am have the newest DirectX SDK downloaded and am using Microsoft's Visual C++ 2010 Express edition. If anyone knows what the problem might be, please let me know.

Thanks

Share this post


Link to post
Share on other sites
Argh, I hoped that the author would have finally got around to doing some error checking in his code, apparently not...

You're not checking if any functions fail. Most D3D functions return a HRESULT value, which you should be checking with the SUCCEEDED or FAILED macro to determine if the function failed.

In your code, if D3D11CreateDeviceAndSwapChain fails, you go on to use the swapchain variable, which is a null or uninitialised pointer, which will cause the crash.

You should also be running your code in the debugger, so it'll break to the debugger when it crashes, let you see what line of code caused the crash, and examine the variables to determine the cause. Here is a good tutorial on using Visual Studio's debugger.

Share this post


Link to post
Share on other sites
Quote:
Original post by ProgrammerDX
Doesn't checking the HRESULT return value for each function cause a performance hit on your program?
Not in any noticeable way, no. It's about 3 assembly instructions, and the simplest DirectX call will be several hundred or thousand.

And besides, you have to do the check, unless you want your app to crash.

Share this post


Link to post
Share on other sites
Hiding the border and maximizing the window is 100% stable and much faster to activate. You can't change the screen resolution in this method but you can answer IM calls without terminating the application.

http://www.codeguru.com/forum/showthread.php?t=500867

Share this post


Link to post
Share on other sites
Thank you for the replies everyone. I'm having trouble figuring out exactly where and how I'm supposed to use HRESULT, though. I've searched around but can't find where in this code it should go. I attempted to use it below in the bolded areas, but I'm sure it's incorrect.

Any more information would be greatly appreciated.

Thanks.

(note, I declared HRESULT hr at the beginning of the program.)


// create a device, device context and swap chain using the information in the scd struct
hr = D3D11CreateDeviceAndSwapChain(NULL,
D3D_DRIVER_TYPE_HARDWARE,
NULL,
NULL,
NULL,
NULL,
D3D11_SDK_VERSION,
&scd,
&swapchain,
&dev,
NULL,
&devcon);


// get the address of the back buffer
ID3D11Texture2D *pBackBuffer;
swapchain->GetBuffer(0, __uuidof(ID3D11Texture2D), (LPVOID*)&pBackBuffer);

// use the back buffer address to create the render target
dev->CreateRenderTargetView(pBackBuffer, NULL, &backbuffer);
pBackBuffer->Release();

// set the render target as the back buffer
devcon->OMSetRenderTargets(1, &backbuffer, NULL);


// Set the viewport
D3D11_VIEWPORT viewport;
ZeroMemory(&viewport, sizeof(D3D11_VIEWPORT));

viewport.TopLeftX = 0;
viewport.TopLeftY = 0;
viewport.Width = SCREEN_WIDTH;
viewport.Height = SCREEN_HEIGHT;

devcon->RSSetViewports(1, &viewport);

InitPipeline();
InitGraphics();

if(FAILED(hr)){
// Handle error
}


}

Share this post


Link to post
Share on other sites
It's quite easy. Every time you call a DX API function that returns an HRESULT, you check it ASAP. This means right after calling this function. In the example you gave us, you tried to create a swap chain then used it and verified afterwards if it has been created: this is clearly the wrong way and will make your program crash.

Examples:

if(FAILED(D3D11CreateDeviceAndSwapChain(...)))
throw std::exception("Something failed");

if(FAILED(swapchain->GetBuffer(...)))
throw std::exception("Something failed");




I wrote a function & macro just for that code. Throwing an exception is acceptable if the function is not supposed to fail that often (which is the case in 99.99% of dx calls). Please don't buy into the myth that checking error states or throwing exceptions will make your code considerably slower. The latter might have a bigger performance hit, if you use it in the wrong way. Notifying about exceptional states that shouldn't happen (for example an API call failing that shouldn't, a resource not being able to load) is the prime purpose of exceptions, combined with the fact that you don't deal with errors at the throw side, but the catch side.


typedef boost::error_info<struct file_, std::string> file;
typedef boost::error_info<struct file_, std::string> api_message;
typedef boost::error_info<struct file_, std::string> api_function;
typedef boost::error_info<struct tag_api_call,std::string> api_call;
typedef boost::error_info<struct tag_d3d11_hresult,HRESULT> d3d11_result;

class d3d11_exception : virtual public std::exception, virtual public boost::exception
{
public:

d3d11_exception(const std::string& what) : std::exception(what) {}

HRESULT getAPIResult() const
{
if(const HRESULT* err = boost::get_error_info<d3d11_result>(*this))
return *err;
else
return D3D_OK;
}



/**
* Verifies the given result from a D3D11 API call and throws an exception in case the it failed.
*/

static void verify_call(HRESULT hr, const char* call, const char* file, const char* function, int line)
{
if(FAILED(hr))
{
throw d3d11_exception(format("A D3D11 API call failed: %1%(%2%)") % readableResult(hr) % hr)
<< debug_info_m(file, function, line)
<< d3d11_result(hr)
<< api_call(call)
;
}
}



/**
* This function returns a readable result string for the given HRESULT.
* Currently, all DXGI error codes are known
*/

static const char* readableResult(HRESULT hr)
{
switch(hr)
{
case DXGI_ERROR_DEVICE_HUNG: return __STR__(DXGI_ERROR_DEVICE_HUNG);
case DXGI_ERROR_DEVICE_REMOVED: return __STR__(DXGI_ERROR_DEVICE_REMOVED);
case DXGI_ERROR_DEVICE_RESET: return __STR__(DXGI_ERROR_DEVICE_RESET);
case DXGI_ERROR_DRIVER_INTERNAL_ERROR: return __STR__(DXGI_ERROR_DRIVER_INTERNAL_ERROR);
case DXGI_ERROR_FRAME_STATISTICS_DISJOINT: return __STR__(DXGI_ERROR_FRAME_STATISTICS_DISJOINT);
case DXGI_ERROR_GRAPHICS_VIDPN_SOURCE_IN_USE: return __STR__(DXGI_ERROR_GRAPHICS_VIDPN_SOURCE_IN_USE);
case DXGI_ERROR_INVALID_CALL: return __STR__(DXGI_ERROR_INVALID_CALL);
case DXGI_ERROR_MORE_DATA: return __STR__(DXGI_ERROR_MORE_DATA);
case DXGI_ERROR_NONEXCLUSIVE: return __STR__(DXGI_ERROR_NONEXCLUSIVE);
case DXGI_ERROR_NOT_CURRENTLY_AVAILABLE: return __STR__(DXGI_ERROR_NOT_CURRENTLY_AVAILABLE);
case DXGI_ERROR_NOT_FOUND: return __STR__(DXGI_ERROR_NOT_FOUND);
case DXGI_ERROR_REMOTE_CLIENT_DISCONNECTED: return __STR__(DXGI_ERROR_REMOTE_CLIENT_DISCONNECTED);
case DXGI_ERROR_REMOTE_OUTOFMEMORY: return __STR__(DXGI_ERROR_REMOTE_OUTOFMEMORY);
case DXGI_ERROR_WAS_STILL_DRAWING: return __STR__(DXGI_ERROR_WAS_STILL_DRAWING);
case DXGI_ERROR_UNSUPPORTED: return __STR__(DXGI_ERROR_UNSUPPORTED);
case S_OK: return __STR__(S_OK);
default: return "Unknown hresult";
}
}
};
///////////////////////////////////////////////////////////////////////////////////////////////////

/**
* This macro executes the given D3D11 call and tests if it returned an error code.
* (Tested via the FAILED macro from Microsoft).
*/

#define D3D11_API(x) d3d11_exception::verify_call((x), #x, __FILE__, __FUNCTION__, __LINE__)


Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Partner Spotlight

  • Forum Statistics

    • Total Topics
      627642
    • Total Posts
      2978354
  • Similar Content

    • By evelyn4you
      hi,
      i have read very much about the binding of a constantbuffer to a shader but something is still unclear to me.
      e.g. when performing :   vertexshader.setConstantbuffer ( buffer,  slot )
       is the buffer bound
      a.  to the VertexShaderStage
      or
      b. to the VertexShader that is currently set as the active VertexShader
      Is it possible to bind a constantBuffer to a VertexShader e.g. VS_A and keep this binding even after the active VertexShader has changed ?
      I mean i want to bind constantbuffer_A  to VS_A, an Constantbuffer_B to VS_B  and  only use updateSubresource without using setConstantBuffer command every time.

      Look at this example:
      SetVertexShader ( VS_A )
      updateSubresource(buffer_A)
      vertexshader.setConstantbuffer ( buffer_A,  slot_A )
      perform drawcall       ( buffer_A is used )

      SetVertexShader ( VS_B )
      updateSubresource(buffer_B)
      vertexshader.setConstantbuffer ( buffer_B,  slot_A )
      perform drawcall   ( buffer_B is used )
      SetVertexShader ( VS_A )
      perform drawcall   (now which buffer is used ??? )
       
      I ask this question because i have made a custom render engine an want to optimize to
      the minimum  updateSubresource, and setConstantbuffer  calls
       
       
       
       
       
    • By noodleBowl
      I got a quick question about buffers when it comes to DirectX 11. If I bind a buffer using a command like:
      IASetVertexBuffers IASetIndexBuffer VSSetConstantBuffers PSSetConstantBuffers  and then later on I update that bound buffer's data using commands like Map/Unmap or any of the other update commands.
      Do I need to rebind the buffer again in order for my update to take effect? If I dont rebind is that really bad as in I get a performance hit? My thought process behind this is that if the buffer is already bound why do I need to rebind it? I'm using that same buffer it is just different data
       
    • By Rockmover
      I am really stuck with something that should be very simple in DirectX 11. 
      1. I can draw lines using a PC (position, colored) vertices and a simple shader just fine.
      2. I can draw 3D triangles using PCN (position, colored, normal) vertices just fine (even transparency and SpecularBlinnPhong shaders).
       
      However, if I'm using my 3D shader, and I want to draw my PC lines in the same scene how can I do that?
       
      If I change my lines to PCN and pass them to the 3D shader with my triangles, then the lighting screws them all up.  I only want the lighting for the 3D triangles, but no SpecularBlinnPhong/Lighting for the lines (just PC). 
      I am sure this is because if I change the lines to PNC there is not really a correct "normal" for the lines.  
      I assume I somehow need to draw the 3D triangles using one shader, and then "switch" to another shader and draw the lines?  But I have no clue how to use two different shaders in the same scene.  And then are the lines just drawn on top of the triangles, or vice versa (maybe draw order dependent)?  
      I must be missing something really basic, so if anyone can just point me in the right direction (or link to an example showing the implementation of multiple shaders) that would be REALLY appreciated.
       
      I'm also more than happy to post my simple test code if that helps as well!
       
      THANKS SO MUCH IN ADVANCE!!!
    • By Reitano
      Hi,
      I am writing a linear allocator of per-frame constants using the DirectX 11.1 API. My plan is to replace the traditional constant allocation strategy, where most of the work is done by the driver behind my back, with a manual one inspired by the DirectX 12 and Vulkan APIs.
      In brief, the allocator maintains a list of 64K pages, each page owns a constant buffer managed as a ring buffer. Each page has a history of the N previous frames. At the beginning of a new frame, the allocator retires the frames that have been processed by the GPU and frees up the corresponding space in each page. I use DirectX 11 queries for detecting when a frame is complete and the ID3D11DeviceContext1::VS/PSSetConstantBuffers1 methods for binding constant buffers with an offset.
      The new allocator appears to be working but I am not 100% confident it is actually correct. In particular:
      1) it relies on queries which I am not too familiar with. Are they 100% reliable ?
      2) it maps/unmaps the constant buffer of each page at the beginning of a new frame and then writes the mapped memory as the frame is built. In pseudo code:
      BeginFrame:
          page.data = device.Map(page.buffer)
          device.Unmap(page.buffer)
      RenderFrame
          Alloc(size, initData)
              ...
              memcpy(page.data + page.start, initData, size)
          Alloc(size, initData)
              ...
              memcpy(page.data + page.start, initData, size)
      (Note: calling Unmap at the end of a frame prevents binding the mapped constant buffers and triggers an error in the debug layer)
      Is this valid ? 
      3) I don't fully understand how many frames I should keep in the history. My intuition says it should be equal to the maximum latency reported by IDXGIDevice1::GetMaximumFrameLatency, which is 3 on my machine. But, this value works fine in an unit test while on a more complex demo I need to manually set it to 5, otherwise the allocator starts overwriting previous frames that have not completed yet. Shouldn't the swap chain Present method block the CPU in this case ?
      4) Should I expect this approach to be more efficient than the one managed by the driver ? I don't have meaningful profile data yet.
      Is anybody familiar with the approach described above and can answer my questions and discuss the pros and cons of this technique based on his experience ? 
      For reference, I've uploaded the (WIP) allocator code at https://paste.ofcode.org/Bq98ujP6zaAuKyjv4X7HSv.  Feel free to adapt it in your engine and please let me know if you spot any mistakes
      Thanks
      Stefano Lanza
       
    • By Matt Barr
      Hey all. I've been working with compute shaders lately, and was hoping to build out some libraries to reuse code. As a prerequisite for my current project, I needed to sort a big array of data in my compute shader, so I was going to implement quicksort as a library function. My implementation was going to use an inout array to apply the changes to the referenced array.

      I spent half the day yesterday debugging in visual studio before I realized that the solution, while it worked INSIDE the function, reverted to the original state after returning from the function.

      My hack fix was just to inline the code, but this is not a great solution for the future.  Any ideas? I've considered just returning an array of ints that represents the sorted indices.
  • Popular Now