Back to General and Gameplay Programming

[.net] Sorting bitmaps by size

General and Gameplay Programming Programming

Started by Headkaze November 09, 2010 11:31 PM

5 comments, last by Zipster 13 years, 5 months ago

Headkaze

607

Author

November 09, 2010 11:31 PM

I have a custom class for sorting bitmaps by their size

class BitmapSizeComparer : IComparer<ImageNode>{    public int Compare(ImageNode x, ImageNode y)    {        using (Bitmap bmp1 = FileIO.LoadBitmap(x.FileName))        {            using (Bitmap bmp2 = FileIO.LoadBitmap(y.FileName))            {                if (bmp1 != null && bmp2 != null)                    return -(bmp1.Width * bmp1.Height).CompareTo(bmp2.Width * bmp2.Height);            }        }        return 0;    }}

But I want to change it to sort by width and then height rather than width * height. How can I modify it to do that or would I need to sort twice?

turnpast

1,011

November 10, 2010 12:54 PM

Try comparing the widths, if the result is non zero return it. Otherwise return the comparison of the heights.

If you are comfortable with linq you can also look into the SortBy and ThenBy methods for a more concise implementation.

Hope this helps

ernow

732

November 10, 2010 02:08 PM

Please do realize that the code you posted will be very slow because for each compare action files are read from disc. My guess is that it would be a lot faster if you read all the Sizes first and compare them so you read all the files just once.

Headkaze

607

Author

November 10, 2010 02:55 PM

Quote:Original post by ernow
Please do realize that the code you posted will be very slow because for each compare action files are read from disc. My guess is that it would be a lot faster if you read all the Sizes first and compare them so you read all the files just once.

I realized that after my post and the Bitmap's sizes are now stored in ImageNode in its constructor.

Thanks turnpast here is the final method..

class BitmapSizeComparer : IComparer<ImageNode>{    public int Compare(ImageNode x, ImageNode y)    {        int widthCompare = -(x.Size.Width).CompareTo(y.Size.Width);        int heightCompare = -(x.Size.Height).CompareTo(y.Size.Height);        return (widthCompare != 0 ? widthCompare : heightCompare);    }}

[Edited by - Headkaze on November 10, 2010 3:55:47 PM]

ranakor

439

November 11, 2010 07:03 AM

what's the context of this code? are the bitmaps already used elsewhere/in memory or do you really need to unload them at the end? is it a memory issue if they are all loaded at once and all removed at once instead of 2 by 2?
If not i'd simply load them all , get rid of the comparer, do an orderby and then dispose of them all?
Images.OrderBy(img=>img.Width * img.Height);

Come fight my brute... if you DARE!!

Headkaze

607

Author

November 12, 2010 05:00 PM

It's for an application that packs images into texture sheets (texture atlases). I believe the packing algorithm has better results sorting by width then height rather than width * height.

I did not want to load all the bitmap's into memory at once, so they must be loaded and then sorted, then loaded again to draw onto the texture sheet.

Zipster

2,420

November 13, 2010 03:01 AM

An easy optimization is to only load the BMP headers to get size information so that you can perform the sorting, and only load the full bitmap once when it's packed. A quick Google came up with this.

[.net] Sorting bitmaps by size

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

[.net] Sorting bitmaps by size

This topic is closed to new replies.

Popular Topics

Recommended Tutorials

Reticulating splines