Archived

This topic is now archived and is closed to further replies.

OpenGL Loading bitmaps/targas in OpenGL

This topic is 5977 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Ok, I have tried time and time again. I have written a basic load bitmap function and load targa function, but they both don''t work at all. I''ll post the code and see if you can help me. GLImage class definition: (look at the IMAGE struct I made since that is important too)
#ifndef GLIMAGE
#define GLIMAGE

//  Define the universal bitmap id
#define BITMAP_ID 0x4D42

#include "stdio.h"	//  Holds the file manipulation routines

//  Structure that holds pertinent information about image formats
typedef struct
{
	short int		width;		//  Width of the image
	short int		height;		//  Height of the image
	unsigned char	*data;		//  Data of the image
} IMAGE;

//  The definition fo the GLImage class
class GLImage
{
	private:
		FILE				*file;				//  The file pointer

		//  Bitmap variables
		IMAGE				*bmpImage;			//  Structure that holds pertinent information about the Windows bitmap format
		BITMAPFILEHEADER	bitmapFileHeader;	//  The bitmap file header
		BITMAPINFOHEADER	bitmapInfoHeader;	//  The bitmap information header

		//  Targa variables
		IMAGE				*tgaImage;			//  Structure that holds pertinent information about the Targa image format
		unsigned char		imageTypeCode;		//  The image type (i.e. 1, 2, or 3)
		unsigned char		bitCount;			//  The bit count of the Targa image
		unsigned char		ucharBad;			//  Garbage unsigned char data
		short int			sintBad;			//  Garbage short int data
		long				imageSize;			//  Size of the TGA image
		int					colorMode;			//  Holds color mode - 4 for RGBA  - 3 for RGB

	public:
		//  Loads a Windows bitmap file
		IMAGE* LoadBMPFile(char *filename);

		//  Loads a Targa image format file
		IMAGE* LoadTGAFile(char *filename);
};

#endif
Ok that was the class, here are the function declerations:
//  Include neccessary header files
#include "stdafx.h"		//  Header file for Windows
#include "GLImage.h"	//  Header file for the GLImage class

//  Loads a Windows bitmap file
IMAGE* GLImage::LoadBMPFile(char* filename)
{
	//  Open the filename in "read binary" mode
	file = fopen(filename, "rb");

	//  If the file couldn''t be opened return NULL
	if(file == NULL)
		return NULL;

	//  Read the bitmap file header
	fread(&bitmapFileHeader, sizeof(BITMAPFILEHEADER), 1, file);

	//  Verify that this is a bitmap by checking for the universal bitmap ID
	if(bitmapFileHeader.bfType != BITMAP_ID)
	{
		//  This is not a bitmap so close the file and return NULL
		fclose(file);

		return NULL;
	}

	//  Read the bitmap information header
	fread(&bitmapInfoHeader, sizeof(BITMAPINFOHEADER), 1, file);

	//  Move the file pointer to the beginning of the bitmap data
	fseek(file, bitmapFileHeader.bfOffBits, SEEK_SET);

	//  Allocate new space for the bmpImage
	bmpImage = new IMAGE;

	if(bmpImage == NULL)
	{
		//  Memory allocation failed so free the bmpImage, close the file, and return NULL
		delete bmpImage;
		fclose(file);

		return NULL;
	}

	//  Allocate enough memory for the bitmap image data
	bmpImage->data = new unsigned char[bitmapInfoHeader.biSizeImage];

	//  Verify memory allocation
	if(bmpImage->data == NULL)
	{
		//  Memory allocation failed so free the bitmapImage data, free the bmpImage, close the file, and return NULL
		delete [] bmpImage->data;
		delete bmpImage;
		fclose(file);

		return NULL;
	}

	//  Read in the bitmap image data
	fread(bmpImage->data, 1, bitmapInfoHeader.biSizeImage, file);

	//  Make sure the bitmap image data was read
	if(bmpImage->data == NULL)
	{
		//  Bitmap image was not read so free the bitmapImage data, free the bmpImage, close the file, and return NULL
		delete [] bmpImage->data;
		delete bmpImage;
		fclose(file);

		return NULL;
	}

	unsigned char tempRGB = NULL;	//  Temporary BGR->RGB swap variable

	//  Swap the R and B values to get RGB since the bitmap color format is in BGR
	for(int imageIdx = 0; imageIdx < bitmapInfoHeader.biSizeImage; imageIdx += 3)
	{
		tempRGB = bmpImage->data[imageIdx];
		bmpImage->data[imageIdx] = bmpImage->data[imageIdx + 2];
		bmpImage->data[imageIdx + 2] = tempRGB;
	}

	fclose(file);			//  Close the file

	return bmpImage;		//  Return the bitmap image since it was a success
}

//  Loads a Targa image format file
IMAGE* GLImage::LoadTGAFile(char *filename)
{
	//  Open the filename in "read binary" mode
	file = fopen(filename, "rb");

	//  If the file couldn''t be opened return NULL
	if(file == NULL)
		return NULL;

	//  Read first two bytes of data we don''t need
	fread(&ucharBad, sizeof(unsigned char), 1, file);
	fread(&ucharBad, sizeof(unsigned char), 1, file);

	//  Read in the image type
	fread(&imageTypeCode, sizeof(unsigned char), 1, file);

	//  Currently supported Targa file formats are 2-Uncompressed RGB and 3-Uncompressed black and white
	if(imageTypeCode != 2 && imageTypeCode != 3)
	{
		//  If it is not a supported type of Targa image close the file and return NULL
		fclose(file);

		return NULL;
	}

	//  Read 13 bytes of data we don''t need
	fread(&sintBad, sizeof(short int), 1, file);
	fread(&sintBad, sizeof(short int), 1, file);
	fread(&ucharBad, sizeof(unsigned char), 1, file);
	fread(&sintBad, sizeof(short int), 1, file);
	fread(&sintBad, sizeof(short int), 1, file);

	//  Allocate new space for the tgaImage
	tgaImage = new IMAGE;

	if(tgaImage == NULL)
	{
		//  Memory allocation failed so free the tgaImage, close the file, and return NULL
		delete tgaImage;
		fclose(file);

		return NULL;
	}

	//  Read image dimensions
	fread(&tgaImage->width, sizeof(short int), 1, file);
	fread(&tgaImage->height, sizeof(short int), 1, file);

	//  Read image bit depth
	fread(&bitCount, sizeof(unsigned char), 1, file);

	//  Read one byte of data we don''t need
	fread(&ucharBad, sizeof(unsigned char), 1, file);

	//  colorMode -> 3 = BGR, 4 = BGRA
	colorMode = bitCount / 8;
	imageSize = tgaImage->width * tgaImage->height * colorMode;

	//  Allocate memory for the image data
	tgaImage->data = new unsigned char[sizeof(unsigned char) * imageSize];

	//  Verify memory allocation
	if(tgaImage->data == NULL)
	{
		//  Memory allocation failed so free the targaImage data, free the tgaImage, close the file, and return NULL
		delete [] tgaImage->data;
		delete tgaImage;
		fclose(file);

		return NULL;
	}
	
	//  Read in the image data
	fread(tgaImage->data, sizeof(unsigned char), imageSize, file);

	//  Make sure the targa image data was read
	if(tgaImage->data == NULL)
	{
		//  Targa image was not read so free the targaImage data, free the tgaImage, close the file, and return NULL
		delete [] tgaImage->data;
		delete tgaImage;
		fclose(file);

		return NULL;
	}

	unsigned char colorSwap;	//  Swap variable used to exchange the R and B values

	//  Change BGR to RGB so OpenGL can read the image data
	for(int imageIdx = 0; imageIdx < imageSize; imageIdx += colorMode)
	{
		colorSwap = tgaImage->data[imageIdx];
		tgaImage->data[imageIdx] = tgaImage->data[imageIdx + 2];
		tgaImage->data[imageIdx + 2] = colorSwap;
	}

	fclose(file);		//  Close the file

	return tgaImage;	//  Loading of the TGA file was a successs
}
I think the way to use it in the code is self-explanatory if you have done this type of thing before. It goes a little like this: texture; IMAGE* image; GLImage i; // Load The Bitmap, Check For Errors, If Bitmap''s Not Found Quit if (TextureImage[0]=LoadBMP("Data/Crate.bmp")) { glGenTextures(1, &texture); glBindTexture(GL_TEXTURE_2D, texture); glTexParameteri(GL_TEXTURE_2D,GL_TEXTURE_MAG_FILTER,GL_NEAREST); glTexParameteri(GL_TEXTURE_2D,GL_TEXTURE_MIN_FILTER,GL_NEAREST); glTexImage2D(GL_TEXTURE_2D, 0, GL_RGB, image->width, image->height, 0, GL_RGB, GL_UNSIGNED_BYTE, image->data); } ..... Clear the memory ..... Etc. Ok, well if you have survived it this far ;-) I really appreciate that you took time out of your busy schedule to help me. If I was going to guess it is a pointer problem somewhere, but I can''t find it. I have also tried using the gluBuild2DMipmaps() in place of the glTexImage2D. I also get an error if the width is greater than 128. I tested it on three different comps with different video cards etc. and it still gave an error. SO, if you can help me in the smallest way my day will be a lot brighter. THANKS!

Share this post


Link to post
Share on other sites
Thats a lot of weird lookin code...
All I can say is, the bitmap/targa file width and height both need to be a power of two, ie 16, 32, 64, etc. Also... I wrote my own bitmap and targa loading routines and I found that some types swapped the blue and red colours round, I think it was blue and red anyway... So don''t be discouraged if you see weird colours.

Share this post


Link to post
Share on other sites
I had a problem with loading bitmaps as well. Per the advice of someone else here, I tried saving my bitmaps with PaintShop Pro 7 and everything work perfectly after that. You can download it free (demo) from their site. Just do a google search for PaintShop Pro and you''ll find it.

- Mike

Share this post


Link to post
Share on other sites

  • Similar Content

    • By khawk
      We've just released all of the source code for the NeHe OpenGL lessons on our Github page at https://github.com/gamedev-net/nehe-opengl. code - 43 total platforms, configurations, and languages are included.
      Now operated by GameDev.net, NeHe is located at http://nehe.gamedev.net where it has been a valuable resource for developers wanting to learn OpenGL and graphics programming.

      View full story
    • By TheChubu
      The Khronos™ Group, an open consortium of leading hardware and software companies, announces from the SIGGRAPH 2017 Conference the immediate public availability of the OpenGL® 4.6 specification. OpenGL 4.6 integrates the functionality of numerous ARB and EXT extensions created by Khronos members AMD, Intel, and NVIDIA into core, including the capability to ingest SPIR-V™ shaders.
      SPIR-V is a Khronos-defined standard intermediate language for parallel compute and graphics, which enables content creators to simplify their shader authoring and management pipelines while providing significant source shading language flexibility. OpenGL 4.6 adds support for ingesting SPIR-V shaders to the core specification, guaranteeing that SPIR-V shaders will be widely supported by OpenGL implementations.
      OpenGL 4.6 adds the functionality of these ARB extensions to OpenGL’s core specification:
      GL_ARB_gl_spirv and GL_ARB_spirv_extensions to standardize SPIR-V support for OpenGL GL_ARB_indirect_parameters and GL_ARB_shader_draw_parameters for reducing the CPU overhead associated with rendering batches of geometry GL_ARB_pipeline_statistics_query and GL_ARB_transform_feedback_overflow_querystandardize OpenGL support for features available in Direct3D GL_ARB_texture_filter_anisotropic (based on GL_EXT_texture_filter_anisotropic) brings previously IP encumbered functionality into OpenGL to improve the visual quality of textured scenes GL_ARB_polygon_offset_clamp (based on GL_EXT_polygon_offset_clamp) suppresses a common visual artifact known as a “light leak” associated with rendering shadows GL_ARB_shader_atomic_counter_ops and GL_ARB_shader_group_vote add shader intrinsics supported by all desktop vendors to improve functionality and performance GL_KHR_no_error reduces driver overhead by allowing the application to indicate that it expects error-free operation so errors need not be generated In addition to the above features being added to OpenGL 4.6, the following are being released as extensions:
      GL_KHR_parallel_shader_compile allows applications to launch multiple shader compile threads to improve shader compile throughput WGL_ARB_create_context_no_error and GXL_ARB_create_context_no_error allow no error contexts to be created with WGL or GLX that support the GL_KHR_no_error extension “I’m proud to announce OpenGL 4.6 as the most feature-rich version of OpenGL yet. We've brought together the most popular, widely-supported extensions into a new core specification to give OpenGL developers and end users an improved baseline feature set. This includes resolving previous intellectual property roadblocks to bringing anisotropic texture filtering and polygon offset clamping into the core specification to enable widespread implementation and usage,” said Piers Daniell, chair of the OpenGL Working Group at Khronos. “The OpenGL working group will continue to respond to market needs and work with GPU vendors to ensure OpenGL remains a viable and evolving graphics API for all its customers and users across many vital industries.“
      The OpenGL 4.6 specification can be found at https://khronos.org/registry/OpenGL/index_gl.php. The GLSL to SPIR-V compiler glslang has been updated with GLSL 4.60 support, and can be found at https://github.com/KhronosGroup/glslang.
      Sophisticated graphics applications will also benefit from a set of newly released extensions for both OpenGL and OpenGL ES to enable interoperability with Vulkan and Direct3D. These extensions are named:
      GL_EXT_memory_object GL_EXT_memory_object_fd GL_EXT_memory_object_win32 GL_EXT_semaphore GL_EXT_semaphore_fd GL_EXT_semaphore_win32 GL_EXT_win32_keyed_mutex They can be found at: https://khronos.org/registry/OpenGL/index_gl.php
      Industry Support for OpenGL 4.6
      “With OpenGL 4.6 our customers have an improved set of core features available on our full range of OpenGL 4.x capable GPUs. These features provide improved rendering quality, performance and functionality. As the graphics industry’s most popular API, we fully support OpenGL and will continue to work closely with the Khronos Group on the development of new OpenGL specifications and extensions for our customers. NVIDIA has released beta OpenGL 4.6 drivers today at https://developer.nvidia.com/opengl-driver so developers can use these new features right away,” said Bob Pette, vice president, Professional Graphics at NVIDIA.
      "OpenGL 4.6 will be the first OpenGL release where conformant open source implementations based on the Mesa project will be deliverable in a reasonable timeframe after release. The open sourcing of the OpenGL conformance test suite and ongoing work between Khronos and X.org will also allow for non-vendor led open source implementations to achieve conformance in the near future," said David Airlie, senior principal engineer at Red Hat, and developer on Mesa/X.org projects.

      View full story
    • By _OskaR
      Hi,
      I have an OpenGL application but without possibility to wite own shaders.
      I need to perform small VS modification - is possible to do it in an alternative way? Do we have apps or driver modifictions which will catch the shader sent to GPU and override it?
    • By xhcao
      Does sync be needed to read texture content after access texture image in compute shader?
      My simple code is as below,
      glUseProgram(program.get());
      glBindImageTexture(0, texture[0], 0, GL_FALSE, 3, GL_READ_ONLY, GL_R32UI);
      glBindImageTexture(1, texture[1], 0, GL_FALSE, 4, GL_WRITE_ONLY, GL_R32UI);
      glDispatchCompute(1, 1, 1);
      // Does sync be needed here?
      glUseProgram(0);
      glBindFramebuffer(GL_READ_FRAMEBUFFER, framebuffer);
      glFramebufferTexture2D(GL_READ_FRAMEBUFFER, GL_COLOR_ATTACHMENT0,
                                     GL_TEXTURE_CUBE_MAP_POSITIVE_X + face, texture[1], 0);
      glReadPixels(0, 0, kWidth, kHeight, GL_RED_INTEGER, GL_UNSIGNED_INT, outputValues);
       
      Compute shader is very simple, imageLoad content from texture[0], and imageStore content to texture[1]. Does need to sync after dispatchCompute?
    • By Jonathan2006
      My question: is it possible to transform multiple angular velocities so that they can be reinserted as one? My research is below:
      // This works quat quaternion1 = GEQuaternionFromAngleRadians(angleRadiansVector1); quat quaternion2 = GEMultiplyQuaternions(quaternion1, GEQuaternionFromAngleRadians(angleRadiansVector2)); quat quaternion3 = GEMultiplyQuaternions(quaternion2, GEQuaternionFromAngleRadians(angleRadiansVector3)); glMultMatrixf(GEMat4FromQuaternion(quaternion3).array); // The first two work fine but not the third. Why? quat quaternion1 = GEQuaternionFromAngleRadians(angleRadiansVector1); vec3 vector1 = GETransformQuaternionAndVector(quaternion1, angularVelocity1); quat quaternion2 = GEQuaternionFromAngleRadians(angleRadiansVector2); vec3 vector2 = GETransformQuaternionAndVector(quaternion2, angularVelocity2); // This doesn't work //quat quaternion3 = GEQuaternionFromAngleRadians(angleRadiansVector3); //vec3 vector3 = GETransformQuaternionAndVector(quaternion3, angularVelocity3); vec3 angleVelocity = GEAddVectors(vector1, vector2); // Does not work: vec3 angleVelocity = GEAddVectors(vector1, GEAddVectors(vector2, vector3)); static vec3 angleRadiansVector; vec3 angularAcceleration = GESetVector(0.0, 0.0, 0.0); // Sending it through one angular velocity later in my motion engine angleVelocity = GEAddVectors(angleVelocity, GEMultiplyVectorAndScalar(angularAcceleration, timeStep)); angleRadiansVector = GEAddVectors(angleRadiansVector, GEMultiplyVectorAndScalar(angleVelocity, timeStep)); glMultMatrixf(GEMat4FromEulerAngle(angleRadiansVector).array); Also how do I combine multiple angularAcceleration variables? Is there an easier way to transform the angular values?
  • Popular Now