• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
MatsK

[web] PHP warnings...

8 posts in this topic

Hi!
I'm new to PHP and trying to make a login form. I keep getting the warnings:

[code][b]Notice[/b]: Undefined index: TxtFname in [b]C:\Programfiler\xampp\htdocs\login.php[/b] on line [b]3[/b]

[b]Notice[/b]: Undefined index: TxtPwd in [b]C:\Programfiler\xampp\htdocs\login.php[/b] on line [b]4[/b][/code]

[font="Times New Roman"][size="3"]Here is my code:[/size][/font]
[font="Times New Roman"] [/font][font="'Times New Roman"]
[size=2][/size][code]
[size=2]<?php[/size]
[size=2]/* Created on: 16.03.2011 */[/size]
[size=2]$TxtFname = $_POST["TxtFname"];[/size]
[size=2]$TxtPwd = $_POST["TxtPwd"];[/size]
[size=2]
[/size]
[size=2]if (!isset($_POST["BtnSubmit"])) //If form is not submitted to itself yet...[/size]
[size=2]{ [/size]
[size=2]?>[/size]
[size=2]<html>[/size]
[size=2]<body>[/size]
[size=2] <form method="post" action="<?php echo $PHP_SELF;?>">[/size]
[size=2] Brukernavn:<input type="text" size="20" maxlength="20" name="TxtFname"><br />[/size]
[size=2] Passord:<input type="text" size="20" maxlength="20" name="TxtPwd"><br /><br />[/size]
[size=2] <input type="submit" value="Logg inn" name="BtnSubmit">[/size]
[size=2] <br />[/size]
[size=2] </form>[/size]
[size=2] <?[/size]
[size=2] } [/size]
[size=2] else[/size]
[size=2] {[/size]
[size=2] //TODO: DB...[/size]
[size=2] }[/size]
[size=2] ?>[/size]
[size=2]</body>[/size]
[size=2]</html>[/size][/code]
[size=2][/size][/font][b]
[/b]
0

Share this post


Link to post
Share on other sites
Not sure why the code boxes get [size=2] and [ b ] in them.

I think the [ code ][/ code ] tags are bugged...
0

Share this post


Link to post
Share on other sites
The $_POST superglobal will only contain values of fields that have been POSTed to the page. To determine whether the values exist you can use isset:

[code]if (isset($_POST['BtnSubmit'], $_POST['TxtFname'], $_POST['TxtPwd'])) {
# BtnSubmit, TxtFname and TxtPwd have been submitted - try logging on.
}[/code]

Historically, register_globals would put any incoming variables (whether they come from $_SERVER, $_POST, $_GET etc) into their own variables (so you could access $_POST['TxtFname'] as $TextFname). This feature (which is a bit of a security hole) has been switched off by default for a while now, so $PHP_SELF should be $_SERVER['PHP_SELF'].
1

Share this post


Link to post
Share on other sites
Hm.
I changed my code to:


[code]
<?php
/* Created on: 16.03.2011 */
$TxtFname = $_POST["TxtFname"];
$TxtPwd = $_POST["TxtPwd"];

if (!isset($_POST["BtnSubmit"], $_POST['TxtFname'], $_POST['TxtPwd'])) //If form is not submitted to itself yet...
{
?>
<html>
<img src="Boligmagasinet - headding.jpg">
<link rel=stylesheet href="login-style.css">

<body>
<div class="hovermenu">
<ul>
<li><a href="index.html">Hjem</a></li><a href="index.html"></a>
<li><a href="about.html">Om oss</a></li>
<li><a href="contact.html">Kontakt</a></li>
<li><a href="mags.html">Magasiner</a></li>
</ul>
</div>

<form method="post" action="<?php echo $_SERVER['PHP_SELF'];?>">
Brukernavn:<input type="text" size="20" maxlength="20" name="TxtFname"><br />
Passord:<input type="text" size="20" maxlength="20" name="TxtPwd"><br /><br />
<input type="submit" value="Logg inn" name="BtnSubmit">
<br />
</form>
<?
}
else
{
//TODO: DB...
}
?>
</body>
</html>[/code]


but I still get the warnings :\
0

Share this post


Link to post
Share on other sites
You are always trying to read from $_POST["TxtFname"], $_POST["TxtPwd"] even when they aren't set. The code to read them should go into the "else" branch.
0

Share this post


Link to post
Share on other sites
Really?

I've been looking at a [url="http://www.tizag.com/phpT/examples/formfinale.php"]tutorial[/url].

Is the code there old code?
0

Share this post


Link to post
Share on other sites
[quote name='MatsK' timestamp='1300277570' post='4786467']
Really?

I've been looking at a [url="http://www.tizag.com/phpT/examples/formfinale.php"]tutorial[/url].

Is the code there old code?
[/quote]

Alot of php tutorials are just plain bad, (The same is true for language tutorials in general)
2

Share this post


Link to post
Share on other sites
Hm, yeah, I guess.
I ended up just changing the form so it POSTed to a regular, plain php file. I didn't really get the whole concept of POSTing to itself.
0

Share this post


Link to post
Share on other sites
When you grab variables from POST, REQUEST, or GET (or really, any array, but especially these ones), you need to check to see if the variable you re looking for was actually sent by the client. Get into the habit of doing this:

$foo = isset($_POST['foo']) ? $_POST['foo'] : NULL; // or some sane default

This avoids array index warnings. NEVER assume incoming data is what you would expect or that it is even present at all.

PS - and yes, 95%+ of PHP tutorials are awful.Everyone is an "expert"!
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0