Sign in to follow this  
mickd

OpenGL Adding values to FloatBuffers

Recommended Posts

mickd    100
Hi guys, I've stumbled across a bug in my code. A few of my friends and i have all had a look through it, and still cant figure it out. I also posted this on the opengl official forums a while ago, but since FloatBuffer is a java implementation, i thought it might be more appropriate to post it here!

Any help greatly appreciated!

[b]The program:[/b]
I'm creating a flame in a simple particle system. It has the ability to do the bezier calculations on the cpu or through the shader (toggle-able). Adding particles while its rendering without using the shader works perfectly.

[b]The problem:[/b]
When i turn on the shader, adding particles to the FloatBuffers behave unexpectedly.

Say i have my current floatbuffer, which can hold 3000 floats (before it buffer overflows), and i have exactly 3000 floats in it. While not using the shader, if i increase the number of floats to 4500, my code creates a new floatbuffer that can hold double the previous one (6k floats), copies the old 3000 floats into it, and adds the new 1500 floats ontop of it.

The result is i have a float buffer that can hold 6000 floats, and has 4500 in it currently.

When i do the same thing when the shader is turned in, instead of adding the 1500 extra floats ontop of the 3000, it seems like its wiping the buffer clean, and adding the 1500 new floats.

The result is i have a float buffer that can hold 3000 still (since it never tried to add the 3001st float, the function never creates a bigger buffer), but with only 1500 floats (the new floats i think) only.

I hope that makes some sense. The weird thing is, its the exact same createParticle() code that is being called when the cpu calculated flame or the shader calculated flame is running.

All attributes are bound and passed successfully into the vertex shader this time!

Here's hopefully all the relevant code...

The drawing code: drawParticles is called in display()
[code]
double lastRendered = System.currentTimeMillis();

protected void drawParticles(GL gl) {

gl.glColor4f(0.7f, 0.2f, 0.1f, 0.8f);
gl.glPointSize(20);

if(useShader) {

GPUrenderer(gl);
}
else {

CPUrenderer(gl);
}

if((System.currentTimeMillis() - lastRendered) >= 30) {

time += 0.03f;
lastRendered = System.currentTimeMillis();
}

if(time > 1) time = 0;
}

private void CPUrenderer(GL gl) {

gl.glUseProgram(0);

gl.glBegin(GL.GL_POINTS);

FlameParticle particle;
Vector3D particleLocation;

for(int i = 0; i < particleList.size(); i++) {

particle = (FlameParticle)particleList.get(i);

particleLocation = particle.currPosition(time);

gl.glVertex3f(particleLocation.x, particleLocation.y, particleLocation.z);
}

gl.glEnd();
}

private void GPUrenderer(GL gl) {

gl.glUseProgram(shader.getProgram());

gl.glUniform1f(gl.glGetUniformLocation(shader.getProgram(), "time"), time);

// System.out.println(cp1.capacity());


cp0.rewind();
gl.glVertexPointer(3, GL.GL_FLOAT, 0, cp0); // bezier cp0
cp1.rewind();
gl.glVertexAttribPointer(BEZIER_CP1, 3, GL.GL_FLOAT, false, 0, cp1);
cp2.rewind();
gl.glVertexAttribPointer(BEZIER_CP2, 3, GL.GL_FLOAT, false, 0, cp2);
cp3.rewind();
gl.glVertexAttribPointer(BEZIER_CP3, 3, GL.GL_FLOAT, false, 0, cp3);
startTime.rewind();
gl.glVertexAttribPointer(START_TIME, 1, GL.GL_FLOAT, false, 0, startTime);

gl.glEnableClientState(GL.GL_VERTEX_ARRAY); // bezier cp0
// gl.glEnableVertexAttribArray(BEZIER_CP0);
gl.glEnableVertexAttribArray(BEZIER_CP1);
gl.glEnableVertexAttribArray(BEZIER_CP2);
gl.glEnableVertexAttribArray(BEZIER_CP3);
gl.glEnableVertexAttribArray(START_TIME);

gl.glDrawArrays(GL.GL_POINTS, 0, particleList.size());

gl.glDisableClientState(GL.GL_VERTEX_ARRAY); // bezier cp0
// gl.glDisableVertexAttribArray(BEZIER_CP0);
gl.glDisableVertexAttribArray(BEZIER_CP1);
gl.glDisableVertexAttribArray(BEZIER_CP2);
gl.glDisableVertexAttribArray(BEZIER_CP3);
gl.glDisableVertexAttribArray(START_TIME);
}
[/code]

setting up the floatbuffers initially, called in init()
[code]
protected FloatBuffer cp0, cp1, cp2, cp3, startTime;

protected void setupBuffers() {

cp0 = BufferUtil.newFloatBuffer(3 * 1000);
cp1 = BufferUtil.newFloatBuffer(3 * 1000);
cp2 = BufferUtil.newFloatBuffer(3 * 1000);
cp3 = BufferUtil.newFloatBuffer(3 * 1000);
startTime = BufferUtil.newFloatBuffer(1000);
}
[/code]

addParticles(amount to add) called when i press + on the keyboard
[code]
private void addParticles(int toAdd) {

int count = 0;

while(count < toAdd) {

createParticle();

count++;
}
}

protected void createParticle() {

FlameParticle particle = new FlameParticle();

particleList.add(particle);

FloatBuffer temp;

if(cp0.remaining() < 3) {
System.out.println("here");
// cp0.rewind();
temp = BufferUtil.newFloatBuffer(cp0.capacity());
temp.put(cp0);
temp.rewind();
cp0.rewind();
cp0 = BufferUtil.newFloatBuffer(cp0.capacity() * 2);
cp0.put(temp);
// cp0.position(temp.position());
}

if(cp1.remaining() < 3) {

// cp1.rewind();
temp = BufferUtil.newFloatBuffer(cp1.capacity());
temp.put(cp1);
temp.rewind();
cp1.rewind();
cp1 = BufferUtil.newFloatBuffer(cp1.capacity() * 2);
cp1.put(temp);
// cp1.position(temp.position());
}

if(cp2.remaining() < 3) {

// cp2.rewind();
temp = BufferUtil.newFloatBuffer(cp2.capacity());
temp.put(cp2);
temp.rewind();
cp2.rewind();
cp2 = BufferUtil.newFloatBuffer(cp2.capacity() * 2);
cp2.put(temp);
// cp2.position(temp.position());
}

if(cp3.remaining() < 3) {

// cp3.rewind();
temp = BufferUtil.newFloatBuffer(cp3.capacity());
temp.put(cp3);
temp.rewind();
cp3.rewind();
cp3 = BufferUtil.newFloatBuffer(cp3.capacity() * 2);
cp3.put(temp);
// cp3.position(temp.position());
}

if(startTime.remaining() < 1) {

// startTime.rewind();
temp = BufferUtil.newFloatBuffer(startTime.capacity());
temp.put(startTime);
temp.rewind();
startTime.rewind();
startTime = BufferUtil.newFloatBuffer(startTime.capacity() * 2);
startTime.put(temp);
// startTime.position(temp.position());
}

// System.out.println(cp0.position());

// cp0.position((particleList.size()-1)*3);
// cp1.position((particleList.size()-1)*3);
// cp2.position((particleList.size()-1)*3);
// cp3.position((particleList.size()-1)*3);
// startTime.position(particleList.size()-1);

cp0.put(particle.cp0.x);
cp0.put(particle.cp0.y);
cp0.put(particle.cp0.z);

cp1.put(particle.cp1.x);
cp1.put(particle.cp1.y);
cp1.put(particle.cp1.z);

cp2.put(particle.cp2.x);
cp2.put(particle.cp2.y);
cp2.put(particle.cp2.z);

cp3.put(particle.cp3.x);
cp3.put(particle.cp3.y);
cp3.put(particle.cp3.z);

startTime.put(particle.startTime);

System.out.println(cp0.position());
System.out.println("remaining " + cp0.remaining());
System.out.println("capacity " + cp0.capacity());

}

[/code]

I hope that's everything relevant. To recap: when i toggle "useShader" to true, adding to FloatBuffers seems to "clear" the buffer before adding particles. When "useShader" is false, FloatBuffer's work as intended.

Once again, any help would be greatly appreciated!!

Share this post


Link to post
Share on other sites
Danny02    279
i don't think u got the "GPU" drawing right. You need some Buffer Objects to draw from. The attributepointer functions don't work as u think. The last attribut is a offset into an uploaded BO. Your framework probably uses the position of the FloatBuffer(?).

Share this post


Link to post
Share on other sites
karwosts    840
[quote]
You need some Buffer Objects to draw from. The attributepointer functions don't work as u think. The last attribut is a offset into an uploaded BO. Your framework probably uses the position of the FloatBuffer(?).
[/quote]

That's not quite true, if you use attribute pointers without a buffer bound, the last argument, [i]pointer[/i], is treated as a pointer into system memory. This is called using vertex arrays, and his syntax appears to be correct (though I don't know the language).

To OP: have you tried stepping through in a debugger and seeing what's going on when you add particles?

Share this post


Link to post
Share on other sites
karwosts    840
[quote name='Danny02' timestamp='1302368372' post='4796404']
sure?
[/quote]

Yes.

[url="http://www.songho.ca/opengl/gl_vertexarray.html"]Vertex Arrays[/url]

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Partner Spotlight

  • Similar Content

    • By pseudomarvin
      I assumed that if a shader is computationally expensive then the execution is just slower. But running the following GLSL FS instead just crashes
      void main() { float x = 0; float y = 0; int sum = 0; for (float x = 0; x < 10; x += 0.00005) { for (float y = 0; y < 10; y += 0.00005) { sum++; } } fragColor = vec4(1, 1, 1 , 1.0); } with unhandled exception in nvoglv32.dll. Are there any hard limits on the number of steps/time that a shader can take before it is shut down? I was thinking about implementing some time intensive computation in shaders where it would take on the order of seconds to compute a frame, is that possible? Thanks.
    • By Arulbabu Donbosco
      There are studios selling applications which is just copying any 3Dgraphic content and regenerating into another new window. especially for CAVE Virtual reality experience. so that the user opens REvite or CAD or any other 3D applications and opens a model. then when the user selects the rendered window the VR application copies the 3D model information from the OpenGL window. 
      I got the clue that the VR application replaces the windows opengl32.dll file. how this is possible ... how can we copy the 3d content from the current OpenGL window.
      anyone, please help me .. how to go further... to create an application like VR CAVE. 
       
      Thanks
    • By cebugdev
      hi all,

      i am trying to build an OpenGL 2D GUI system, (yeah yeah, i know i should not be re inventing the wheel, but this is for educational and some other purpose only),
      i have built GUI system before using 2D systems such as that of HTML/JS canvas, but in 2D system, i can directly match a mouse coordinates to the actual graphic coordinates with additional computation for screen size/ratio/scale ofcourse.
      now i want to port it to OpenGL, i know that to render a 2D object in OpenGL we specify coordiantes in Clip space or use the orthographic projection, now heres what i need help about.
      1. what is the right way of rendering the GUI? is it thru drawing in clip space or switching to ortho projection?
      2. from screen coordinates (top left is 0,0 nd bottom right is width height), how can i map the mouse coordinates to OpenGL 2D so that mouse events such as button click works? In consideration ofcourse to the current screen/size dimension.
      3. when let say if the screen size/dimension is different, how to handle this? in my previous javascript 2D engine using canvas, i just have my working coordinates and then just perform the bitblk or copying my working canvas to screen canvas and scale the mouse coordinates from there, in OpenGL how to work on a multiple screen sizes (more like an OpenGL ES question).
      lastly, if you guys know any books, resources, links or tutorials that handle or discuss this, i found one with marekknows opengl game engine website but its not free,
      Just let me know. Did not have any luck finding resource in google for writing our own OpenGL GUI framework.
      IF there are no any available online, just let me know, what things do i need to look into for OpenGL and i will study them one by one to make it work.
      thank you, and looking forward to positive replies.
    • By fllwr0491
      I have a few beginner questions about tesselation that I really have no clue.
      The opengl wiki doesn't seem to talk anything about the details.
       
      What is the relationship between TCS layout out and TES layout in?
      How does the tesselator know how control points are organized?
          e.g. If TES input requests triangles, but TCS can output N vertices.
             What happens in this case?
      In this article,
      http://www.informit.com/articles/article.aspx?p=2120983
      the isoline example TCS out=4, but TES in=isoline.
      And gl_TessCoord is only a single one.
      So which ones are the control points?
      How are tesselator building primitives?
    • By Orella
      I've been developing a 2D Engine using SFML + ImGui.
      Here you can see an image
      The editor is rendered using ImGui and the scene window is a sf::RenderTexture where I draw the GameObjects and then is converted to ImGui::Image to render it in the editor.
      Now I need to create a 3D Engine during this year in my Bachelor Degree but using SDL2 + ImGui and I want to recreate what I did with the 2D Engine. 
      I've managed to render the editor like I did in the 2D Engine using this example that comes with ImGui. 
      3D Editor preview
      But I don't know how to create an equivalent of sf::RenderTexture in SDL2, so I can draw the 3D scene there and convert it to ImGui::Image to show it in the editor.
      If you can provide code will be better. And if you want me to provide any specific code tell me.
      Thanks!
  • Popular Now