Sign in to follow this  


Recommended Posts

I've been at this for hours and IMO my code looks pretty clear-cut. Nevertheless, I'm obviously missing something because two things are happening that I'm unable to explain:

1) first off, I'm trying to blur my shadowmap cascades (I'm using four)
2) my source is a four-layer float 32 GL_TEXTURE_2D_ARRAY RGB target (call it [i]texVSM[/i]), which is updated properly in the VSM projective phase
3) [b]Peculiarity 1[/b]: for some reason my VSM FBO requires me to bind the target array ([i]texVSM[/i]) to a texture (input) although no texture look-ups are being done inside the shader (it just calculates the moments and stores them in the active slice); if I don't bind the texture, the depth buffer is updated, but the color attachment ([i]texVSM[/i]) is not. As usual, I'm selecting my output slice by calling:

[i]glFramebufferTextureLayerEXT(GL_FRAMEBUFFER_EXT, GL_COLOR_ATTACHMENT0_EXT + iIndex, iHandle, 0, iLayerIndex);[/i]

I'm relatively sure you don't need to bind a texture for it to work as an FBO attachment.

4) rendering shadows as-is at this point works nicely (save for the first peculiarity)
5) my second FBO expects [i]texVSM [/i]as its input at TU 0 and writes to another 3D texture attachment (call it [i]texBlurVSM[/i]) (I've also given it a go by binding the output target as its primary input)
6) [b]Peculiarity 2[/b]: nothing is ever written to [i]texBlurVSM[/i], even if I set the shader to output a constant color. This is very weird, because the code is pretty much identical to that of the first FBO, except for the fact that it's a post-processing effect and just draws a single quad. In other words, I'm unable to copy anything from one 3D texture to another through an FBO proxy. I've disable depth testing and masking for the blur FBO and it makes no difference

At this point I'm rather out of ideas as to what to even try or change. So far I have something like 6 FBO's in use and they all work just fine save for the blur one.

Here's a stitched-together mock-up of the code I'm using for both FBOs (these calls are pseudocode for actual OpenGL calls):

fbo = CreateFBO();
fbo->AddAttachement(new Texture);
fbo->AddInputs(...); //basically adds all texture handles to the FBO's internal list for automated binding

fbo->Enable(); //updates attachments and calls glBindTexture() for all inputs (texture targets and TU's are automatically taken care of)
for(i to numCascades)
fbo->ActivateLayer(i); //calls glFramebufferTextureLayerEXT() as above for all attached output targets
//RenderShadowCasters() for the projective phase
//Draw a quad over the viewport for the blur phase

Any thoughts?

Share this post

Link to post
Share on other sites
I think you might need a call to glDrawBuffer or glDrawBuffers, if you want to render to something other than GL_COLOR_ATTACHMENT0.

Incidentally, from what I remember of rendering to a 3d / array texture layer, the call to glFramebufferTextureLayer attaches one layer of the texture to the attachment point. So if you're only rendering to one layer at a time, you might as well use GL_COLOR_ATTACHMENT0 for all of them, instead of GL_COLOR_ATTACHMENT0 + i. (If I'm not misunderstanding what you're doing with iIndex / iLayerIndex here).

On the other hand, if you want to render to several layers at once, you should attach them all to separate attachment points once, then output multiple values from the shader (using gl_FragData or different out locations). I'm not sure what your AddAttachment(new Texture) call does -> if this is the whole 3D texture, it's not necessary, you just need to attach the individual layers. (Binding the whole 3D texture is instead used with gl_Layer in a geometry shader to render to each layer.)

Share this post

Link to post
Share on other sites
Could you try and explain what's happening and why you think there's anything wrong. If you're trying to validate your results using gDebugger you would find that it simply doesn't work when it comes to layered FBOs.

Also FBO's are very VERY picky when it comes to which calls you're using and I've personally experienced different behaviors using the EXT, ARB and core calls. So try to translate the pseudocode into actual ogl calls so we have a chance to see which you're using.

Also if you're trying to render to several layeres at once do as __sprite also said - Pick a layer using a geometry shader as that's the only way atm. If you try to do that you need to bind the layered texture to the FBO using the glFramebufferTexture() call NOT the layered one as that only binds a single slice.

Share this post

Link to post
Share on other sites
Cheers for the answers!

Ugh, work never helps to reply faster; but I finally have the time to post the full code (the iterator iIndex for the attachment number is from a generic piece of code that binds any number of added attachments - it's not specific to this example). The GL code that is called is (note that I'm actually checking each and every GL FBO call for errors and doing rather strict compatibility and format/error checking, which I have removed for clarity):

//accepts an already propely created texture ref; additional error and compatibility checking is done here
void FBO:AddAttachment(TEXHANDLE tex)
int iIndex = output.size() - 1;

if(GetNumLayers(tex) > 1)
glFramebufferTexture3DEXT(GL_FRAMEBUFFER_EXT, GL_COLOR_ATTACHMENT0_EXT + iIndex, GL_TEXTURE_3D, GetHandle(tex), 0, 0)
glFramebufferTexture2DEXT(GL_FRAMEBUFFER_EXT, GL_COLOR_ATTACHMENT0_EXT + iIndex, GL_TEXTURE_2D, GetHandle(tex), 0)

void FBO:AddInput(TEXHANDLE tex)

void FBO::Enable()
//set up the target list for glDrawBuffers(); the output[] array contains refs to actual target handles

UINT iNumActiveTargets = 0;

for(UINT i = 0; i < GD_MAX_TEXTURE_UNITS; i++)
{ mrt[i] = GL_COLOR_ATTACHMENT0_EXT + i; iNumActiveTargets = i + 1; }
mrt[i] = NULL;

glBindFramebufferEXT(GL_FRAMEBUFFER_EXT, iHandle);

glDrawBuffers(iNumActiveTargets, mrt);

for(i to numinputs)
glBindTexture(GetTarget(input[i]), GetHandle(intput[i]);

void FBO::ActivatLayer(int iLayerIndex)
glFramebufferTextureLayerEXT(GL_FRAMEBUFFER_EXT, GL_DEPTH_ATTACHMENT_EXT, iHandle, 0, iLayerIndex);
for(iIndex all attachmetns)
glFramebufferTextureLayerEXT(GL_FRAMEBUFFER_EXT, GL_COLOR_ATTACHMENT0_EXT + iIndex, iHandle, 0, iLayerIndex);

I hope there are no mistakes in the above code as I had to copy these bits together from all over the place (my code is structured in an object-oriented manner on multiple levels). I'm not including my texture generation code, which is used to actually create all the targets as it's an all-around piece of code and contains some hacks (nevertheless, I use it all over the place and it works just fine, both for 2D and 3D targets). If there's any other code I can include, please let me know; I'm guessing that, if anything, the above bit should be to blame, though.

>> (Binding the whole 3D texture is instead used with gl_Layer in a geometry shader to render to each layer.)

My Cascaded VSM store depth code uses the above method of output layer selection and works just fine; why would I need to use a geometry shader here?

Also, I'm only rendering to a single slice at once (the calling code structure in the OP loops through each layer and does the magic individually on each one)!

Or am I misunderstanding the whole thing?

Thanks for the input!

Share this post

Link to post
Share on other sites
If you are rendering to 1 slice at a time, then
glDrawBuffers(iNumActiveTargets, mrt);

probably needs to be
glDrawBuffers(1, mrt);

Share this post

Link to post
Share on other sites
Your ActivateLayer function looks incomplete / wrong, you might want to check you've copied it here correctly. (You're attaching a layer of some texture as a depth attachment, then iterating something and attaching that same layer as color outputs... even if that's allowed in the specs (which seems unlikely) it doesn't make any sense).

Your enable function also appears to be adding a draw buffer for every attachment, but you say you only want to render to one attachment. I'm not sure what the specs say happens if you only output to one drawbuffer having specified several, but it may be undefined (at least for the buffers you don't output to).

(I'm not sure that putting inputs in the fbo class really makes sense from a conceptual viewpoint of what a framebuffer object actually is either?)

In the end, you appear to want to render to one output attachment at a time. That output just happens to be a layer of a 3D texture. So you want something like this:

[font="Lucida Console"][size="1"]// At startup:
Create your fbo.
Attach the depth buffer (assuming this stays constant, if not, do so at render time).

// At render time:
For each layer of 3D texture
* Attach one layer of 3D texture to COLOR_ATTACHMENT0 (using glFramebufferTextureLayer).
* Render to that layer (just output gl_FragColor).[/size]
OR something like this:

[font="Lucida Console"][size="1"]// At startup:
Create your fbo.
Attach depth buffer (assuming it's constant...)
Attach 3D texture to GL_COLOR_ATTACHMENT0 (using glFramebufferTexture).

// At render time:
Render once (use a geometry shader to output vertices once for each layer, using gl_Layer to specify which. Fragment shader outputs to gl_FragColor.)
On the other hand, if you really wanted to render to multiple attachments, your code would look something like this:

[font="Lucida Console"][size="1"]// At startup:
Create fbo.
Attach depth buffer.
Attach one layer of 3D texture to each attachment point (using glFramebufferTextureLayer).

// At render time:
Render once (Fragment shader outputs a value to each attachment using gl_FragData[n]).[/size][/font]

Share this post

Link to post
Share on other sites
V-Man - my code automatically degenerates to rendering to just one attachment if there is just one color target attached :). Generally working with 2 or more attachements made me write an FBO class that automatically takes care of any number of attached targets.


You're absolutely right - I made a mistake when copying the code. The layer activation code should be (with some more elaboration):

void FBO::ActivatLayer(int iLayerIndex)
//activate the desired layer for the depth buffer (assumed to be 3D)
glFramebufferTextureLayerEXT(GL_FRAMEBUFFER_EXT, GL_DEPTH_ATTACHMENT_EXT, iDepthHandle, 0, iLayerIndex);
//loop through all color attachments (assumed to be 3D and have the same number of layers as the depth buffer) and activate the desired layer
for(iIndex in all attachments)
glFramebufferTextureLayerEXT(GL_FRAMEBUFFER_EXT, GL_COLOR_ATTACHMENT0_EXT + iIndex, output[iIndex], 0, iLayerIndex);

[left]Which assumes the FBO has any number of color attachments and a single depth attachment, all of which have the same number of layers. The reason I'm not just activating attachment 0 is because I'm looping through all color targets and activating them to their rightful attachments at the requested layer. Again, this degenerates to what V-Man wrote if there is only one attachment. The same applies to Enable() - the code assumes the FBO can have up to GD_MAX_TEXTURE_UNITS attachments, but only enables those that have actual targets attached to them. Unless I'm blind to boot, I'm pretty sure there are no logic problems with this code.

What is especially annoying is the fact that OpenGL is generating zero errors (as mentioned in the OP, I'm actually checking each and every FBO call for errors and none are generated - I've removed the checks for clarity from the posted code). Is there any way I can check if my GTX 260M is even supposed to support this? I mean, maybe the drivers are silently letting the code slip, but there's no actual hardware support.

Share this post

Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Announcements

  • Forum Statistics

    • Total Topics
    • Total Posts
  • Similar Content

    • By mellinoe
      Hi all,
      First time poster here, although I've been reading posts here for quite a while. This place has been invaluable for learning graphics programming -- thanks for a great resource!
      Right now, I'm working on a graphics abstraction layer for .NET which supports D3D11, Vulkan, and OpenGL at the moment. I have implemented most of my planned features already, and things are working well. Some remaining features that I am planning are Compute Shaders, and some flavor of read-write shader resources. At the moment, my shaders can just get simple read-only access to a uniform (or constant) buffer, a texture, or a sampler. Unfortunately, I'm having a tough time grasping the distinctions between all of the different kinds of read-write resources that are available. In D3D alone, there seem to be 5 or 6 different kinds of resources with similar but different characteristics. On top of that, I get the impression that some of them are more or less "obsoleted" by the newer kinds, and don't have much of a place in modern code. There seem to be a few pivots:
      The data source/destination (buffer or texture) Read-write or read-only Structured or unstructured (?) Ordered vs unordered (?) These are just my observations based on a lot of MSDN and OpenGL doc reading. For my library, I'm not interested in exposing every possibility to the user -- just trying to find a good "middle-ground" that can be represented cleanly across API's which is good enough for common scenarios.
      Can anyone give a sort of "overview" of the different options, and perhaps compare/contrast the concepts between Direct3D, OpenGL, and Vulkan? I'd also be very interested in hearing how other folks have abstracted these concepts in their libraries.
    • By aejt
      I recently started getting into graphics programming (2nd try, first try was many years ago) and I'm working on a 3d rendering engine which I hope to be able to make a 3D game with sooner or later. I have plenty of C++ experience, but not a lot when it comes to graphics, and while it's definitely going much better this time, I'm having trouble figuring out how assets are usually handled by engines.
      I'm not having trouble with handling the GPU resources, but more so with how the resources should be defined and used in the system (materials, models, etc).
      This is my plan now, I've implemented most of it except for the XML parts and factories and those are the ones I'm not sure of at all:
      I have these classes:
      For GPU resources:
      Geometry: holds and manages everything needed to render a geometry: VAO, VBO, EBO. Texture: holds and manages a texture which is loaded into the GPU. Shader: holds and manages a shader which is loaded into the GPU. For assets relying on GPU resources:
      Material: holds a shader resource, multiple texture resources, as well as uniform settings. Mesh: holds a geometry and a material. Model: holds multiple meshes, possibly in a tree structure to more easily support skinning later on? For handling GPU resources:
      ResourceCache<T>: T can be any resource loaded into the GPU. It owns these resources and only hands out handles to them on request (currently string identifiers are used when requesting handles, but all resources are stored in a vector and each handle only contains resource's index in that vector) Resource<T>: The handles given out from ResourceCache. The handles are reference counted and to get the underlying resource you simply deference like with pointers (*handle).  
      And my plan is to define everything into these XML documents to abstract away files:
      Resources.xml for ref-counted GPU resources (geometry, shaders, textures) Resources are assigned names/ids and resource files, and possibly some attributes (what vertex attributes does this geometry have? what vertex attributes does this shader expect? what uniforms does this shader use? and so on) Are reference counted using ResourceCache<T> Assets.xml for assets using the GPU resources (materials, meshes, models) Assets are not reference counted, but they hold handles to ref-counted resources. References the resources defined in Resources.xml by names/ids. The XMLs are loaded into some structure in memory which is then used for loading the resources/assets using factory classes:
      Factory classes for resources:
      For example, a texture factory could contain the texture definitions from the XML containing data about textures in the game, as well as a cache containing all loaded textures. This means it has mappings from each name/id to a file and when asked to load a texture with a name/id, it can look up its path and use a "BinaryLoader" to either load the file and create the resource directly, or asynchronously load the file's data into a queue which then can be read from later to create the resources synchronously in the GL context. These factories only return handles.
      Factory classes for assets:
      Much like for resources, these classes contain the definitions for the assets they can load. For example, with the definition the MaterialFactory will know which shader, textures and possibly uniform a certain material has, and with the help of TextureFactory and ShaderFactory, it can retrieve handles to the resources it needs (Shader + Textures), setup itself from XML data (uniform values), and return a created instance of requested material. These factories return actual instances, not handles (but the instances contain handles).
      Is this a good or commonly used approach? Is this going to bite me in the ass later on? Are there other more preferable approaches? Is this outside of the scope of a 3d renderer and should be on the engine side? I'd love to receive and kind of advice or suggestions!
    • By nedondev
      I 'm learning how to create game by using opengl with c/c++ coding, so here is my fist game. In video description also have game contain in Dropbox. May be I will make it better in future.
    • By Abecederia
      So I've recently started learning some GLSL and now I'm toying with a POM shader. I'm trying to optimize it and notice that it starts having issues at high texture sizes, especially with self-shadowing.
      Now I know POM is expensive either way, but would pulling the heightmap out of the normalmap alpha channel and in it's own 8bit texture make doing all those dozens of texture fetches more cheap? Or is everything in the cache aligned to 32bit anyway? I haven't implemented texture compression yet, I think that would help? But regardless, should there be a performance boost from decoupling the heightmap? I could also keep it in a lower resolution than the normalmap if that would improve performance.
      Any help is much appreciated, please keep in mind I'm somewhat of a newbie. Thanks!
    • By test opty
      I'm trying to learn OpenGL through a website and have proceeded until this page of it. The output is a simple triangle. The problem is the complexity.
      I have read that page several times and tried to analyse the code but I haven't understood the code properly and completely yet. This is the code:
      #include <glad/glad.h> #include <GLFW/glfw3.h> #include <C:\Users\Abbasi\Desktop\std_lib_facilities_4.h> using namespace std; //****************************************************************************** void framebuffer_size_callback(GLFWwindow* window, int width, int height); void processInput(GLFWwindow *window); // settings const unsigned int SCR_WIDTH = 800; const unsigned int SCR_HEIGHT = 600; const char *vertexShaderSource = "#version 330 core\n" "layout (location = 0) in vec3 aPos;\n" "void main()\n" "{\n" " gl_Position = vec4(aPos.x, aPos.y, aPos.z, 1.0);\n" "}\0"; const char *fragmentShaderSource = "#version 330 core\n" "out vec4 FragColor;\n" "void main()\n" "{\n" " FragColor = vec4(1.0f, 0.5f, 0.2f, 1.0f);\n" "}\n\0"; //******************************* int main() { // glfw: initialize and configure // ------------------------------ glfwInit(); glfwWindowHint(GLFW_CONTEXT_VERSION_MAJOR, 3); glfwWindowHint(GLFW_CONTEXT_VERSION_MINOR, 3); glfwWindowHint(GLFW_OPENGL_PROFILE, GLFW_OPENGL_CORE_PROFILE); // glfw window creation GLFWwindow* window = glfwCreateWindow(SCR_WIDTH, SCR_HEIGHT, "My First Triangle", nullptr, nullptr); if (window == nullptr) { cout << "Failed to create GLFW window" << endl; glfwTerminate(); return -1; } glfwMakeContextCurrent(window); glfwSetFramebufferSizeCallback(window, framebuffer_size_callback); // glad: load all OpenGL function pointers if (!gladLoadGLLoader((GLADloadproc)glfwGetProcAddress)) { cout << "Failed to initialize GLAD" << endl; return -1; } // build and compile our shader program // vertex shader int vertexShader = glCreateShader(GL_VERTEX_SHADER); glShaderSource(vertexShader, 1, &vertexShaderSource, nullptr); glCompileShader(vertexShader); // check for shader compile errors int success; char infoLog[512]; glGetShaderiv(vertexShader, GL_COMPILE_STATUS, &success); if (!success) { glGetShaderInfoLog(vertexShader, 512, nullptr, infoLog); cout << "ERROR::SHADER::VERTEX::COMPILATION_FAILED\n" << infoLog << endl; } // fragment shader int fragmentShader = glCreateShader(GL_FRAGMENT_SHADER); glShaderSource(fragmentShader, 1, &fragmentShaderSource, nullptr); glCompileShader(fragmentShader); // check for shader compile errors glGetShaderiv(fragmentShader, GL_COMPILE_STATUS, &success); if (!success) { glGetShaderInfoLog(fragmentShader, 512, nullptr, infoLog); cout << "ERROR::SHADER::FRAGMENT::COMPILATION_FAILED\n" << infoLog << endl; } // link shaders int shaderProgram = glCreateProgram(); glAttachShader(shaderProgram, vertexShader); glAttachShader(shaderProgram, fragmentShader); glLinkProgram(shaderProgram); // check for linking errors glGetProgramiv(shaderProgram, GL_LINK_STATUS, &success); if (!success) { glGetProgramInfoLog(shaderProgram, 512, nullptr, infoLog); cout << "ERROR::SHADER::PROGRAM::LINKING_FAILED\n" << infoLog << endl; } glDeleteShader(vertexShader); glDeleteShader(fragmentShader); // set up vertex data (and buffer(s)) and configure vertex attributes float vertices[] = { -0.5f, -0.5f, 0.0f, // left 0.5f, -0.5f, 0.0f, // right 0.0f, 0.5f, 0.0f // top }; unsigned int VBO, VAO; glGenVertexArrays(1, &VAO); glGenBuffers(1, &VBO); // bind the Vertex Array Object first, then bind and set vertex buffer(s), //and then configure vertex attributes(s). glBindVertexArray(VAO); glBindBuffer(GL_ARRAY_BUFFER, VBO); glBufferData(GL_ARRAY_BUFFER, sizeof(vertices), vertices, GL_STATIC_DRAW); glVertexAttribPointer(0, 3, GL_FLOAT, GL_FALSE, 3 * sizeof(float), (void*)0); glEnableVertexAttribArray(0); // note that this is allowed, the call to glVertexAttribPointer registered VBO // as the vertex attribute's bound vertex buffer object so afterwards we can safely unbind glBindBuffer(GL_ARRAY_BUFFER, 0); // You can unbind the VAO afterwards so other VAO calls won't accidentally // modify this VAO, but this rarely happens. Modifying other // VAOs requires a call to glBindVertexArray anyways so we generally don't unbind // VAOs (nor VBOs) when it's not directly necessary. glBindVertexArray(0); // uncomment this call to draw in wireframe polygons. //glPolygonMode(GL_FRONT_AND_BACK, GL_LINE); // render loop while (!glfwWindowShouldClose(window)) { // input // ----- processInput(window); // render // ------ glClearColor(0.2f, 0.3f, 0.3f, 1.0f); glClear(GL_COLOR_BUFFER_BIT); // draw our first triangle glUseProgram(shaderProgram); glBindVertexArray(VAO); // seeing as we only have a single VAO there's no need to // bind it every time, but we'll do so to keep things a bit more organized glDrawArrays(GL_TRIANGLES, 0, 3); // glBindVertexArray(0); // no need to unbind it every time // glfw: swap buffers and poll IO events (keys pressed/released, mouse moved etc.) glfwSwapBuffers(window); glfwPollEvents(); } // optional: de-allocate all resources once they've outlived their purpose: glDeleteVertexArrays(1, &VAO); glDeleteBuffers(1, &VBO); // glfw: terminate, clearing all previously allocated GLFW resources. glfwTerminate(); return 0; } //************************************************** // process all input: query GLFW whether relevant keys are pressed/released // this frame and react accordingly void processInput(GLFWwindow *window) { if (glfwGetKey(window, GLFW_KEY_ESCAPE) == GLFW_PRESS) glfwSetWindowShouldClose(window, true); } //******************************************************************** // glfw: whenever the window size changed (by OS or user resize) this callback function executes void framebuffer_size_callback(GLFWwindow* window, int width, int height) { // make sure the viewport matches the new window dimensions; note that width and // height will be significantly larger than specified on retina displays. glViewport(0, 0, width, height); } As you see, about 200 lines of complicated code only for a simple triangle. 
      I don't know what parts are necessary for that output. And also, what the correct order of instructions for such an output or programs is, generally. That start point is too complex for a beginner of OpenGL like me and I don't know how to make the issue solved. What are your ideas please? What is the way to figure both the code and the whole program out correctly please?
      I wish I'd read a reference that would teach me OpenGL through a step-by-step method. 
  • Popular Now