Sign in to follow this  
Seabolt

OpenGL glClear locks system

Recommended Posts

Hey guys, I'm reposting this since the last one didn't get many replies and I'm at my wits end.

So basically I am working on an EXTREMELY basic OpenGL program. All i want it to do is clear the screen blue going through my pipeline. Now I have my HDC and HGLRC all set up and not NULL. Glew doesn't throw any errors, Set and ChoosePixelFormat have no problems, and wglCreateContext and wglMakeCurrent both work without throwing any errors. But when the game starts calling glClear, the entire game freezes up. The message pump is still running, and if I step through it, I'm still receiving WM_PAINT messages. The system will still respond, but its really slow, like ten to forty-five seconds slow. I'm posting all relevant code

This is my window set up

[code]// Create a window
WNDCLASSEX wcex;
wcex.cbSize = sizeof(WNDCLASSEX);
wcex.style = CS_HREDRAW | CS_VREDRAW | CS_OWNDC;
wcex.lpfnWndProc = (WNDPROC)MainWndProc;
wcex.cbClsExtra = 0;
wcex.cbWndExtra = 0;
wcex.hInstance = hInstance;
wcex.hIcon = NULL;
wcex.hCursor = (HCURSOR)LoadCursor(NULL, IDC_ARROW);
wcex.hbrBackground = NULL;
wcex.lpszMenuName = NULL;
wcex.lpszClassName = TEXT("Thunderclad Engine"); // Should be unique
wcex.hIconSm = NULL;

// Select window styles
UINT unStyle,unStyleX;
unStyleX = WS_EX_APPWINDOW | WS_EX_WINDOWEDGE; // Window Extended Style
unStyle = WS_OVERLAPPEDWINDOW;

// Describe our window placement
WINDOWPLACEMENT wndPlacement;
wndPlacement.length = sizeof(WINDOWPLACEMENT);
wndPlacement.ptMaxPosition.x = 0;
wndPlacement.ptMaxPosition.y = 0;
wndPlacement.ptMinPosition.x = 0;
wndPlacement.ptMinPosition.y = 0;
wndPlacement.rcNormalPosition.bottom = g_nWindowHeight;
wndPlacement.rcNormalPosition.left = 0;
wndPlacement.rcNormalPosition.top = 0;
wndPlacement.rcNormalPosition.right = g_nWindowWidth;
[/code]

Here's where I create the window

[code]// First we must register the class
assert( RegisterClassEx( in_wndClassDescription ) != 0 );

RECT windowRect; // Grabs Rectangle Upper Left / Lower Right Values
windowRect.left=(long)0; // Set Left Value To 0
windowRect.right=(long)in_nWindowWidth; // Set Right Value To Requested Width
windowRect.top=(long)0; // Set Top Value To 0
windowRect.bottom=(long)in_nWindowHeight; // Set Bottom Value To Requested Height

// Get a pixel perfect window
AdjustWindowRectEx( &windowRect, in_unWindowStyle, FALSE, in_unWindowExStyle );

// Then we must create the window from the data provided;
out_handleWindow = CreateWindowEx( in_unWindowExStyle,
in_wndClassDescription->lpszClassName,
in_szProgramName,
WS_CLIPSIBLINGS | WS_CLIPCHILDREN | in_unWindowStyle,
0,
0,
in_nWindowWidth,
in_nWindowHeight,
NULL,
NULL,
in_handleCurrentInstance,
NULL );

assert( out_handleWindow != NULL );


// Show the window and start updating it
ShowWindow( out_handleWindow, SW_SHOW );
UpdateWindow( out_handleWindow );

[/code]




Here's where I init the device

[code]

//////////////////////////////////////////////////////////////////////////
// Platform Specific Initialization (Windows)
#if USING_WINDOWS

// Store the HWND
m_handleWindowHandle = programWindow->GetWindowHandle();

// Do a NULL check if we are in Debug
ASSERT_NULL( m_handleWindowHandle );

// Get the Device Context
m_handleDeviceContext = GetDC( m_handleWindowHandle );

// Null check the DC
ASSERT_NULL( m_handleDeviceContext );

//////////////////////////////////////////////////////////////////////////
// Set the pixel format
m_tPixelFormat.nSize = sizeof( PIXELFORMATDESCRIPTOR ); // Size of the PFD
m_tPixelFormat.nVersion = 1; // Set the version number
m_tPixelFormat.dwFlags = ( PFD_DRAW_TO_WINDOW | // Set the formats
PFD_SUPPORT_OPENGL |
PFD_DOUBLEBUFFER );
m_tPixelFormat.iPixelType = PFD_TYPE_RGBA; // Set the color format
m_tPixelFormat.cColorBits = 32; // Set the color depth
m_tPixelFormat.cDepthBits = 32; // Set the depth buffer depth
m_tPixelFormat.cStencilBits = 0; // Set the stencil buffer depth
m_tPixelFormat.iLayerType = PFD_MAIN_PLANE; // Set the layer for the app

// See if there is a pixel format that will match our requests
int nPixelFormat = 0;
ASSERT_FALSE( nPixelFormat = ChoosePixelFormat( m_handleDeviceContext,
&m_tPixelFormat ) );

ASSERT_FALSE( SetPixelFormat( m_handleDeviceContext,
nPixelFormat,
&m_tPixelFormat ) );
//////////////////////////////////////////////////////////////////////////

//////////////////////////////////////////////////////////////////////////
// So far so good... Now we try to create our RenderContext (HRC)
HGLRC tempContext = wglCreateContext( m_handleDeviceContext );
ASSERT_NULL( tempContext );

// See if the tempContext will work
ASSERT_FALSE( wglMakeCurrent( m_handleDeviceContext, tempContext ) );

GLenum error = glewInit();
if( error != GLEW_OK )
{
fprintf(stderr, "Error: %s\n", glewGetErrorString(error));
}

if( wglewIsSupported( "WGL_ARB_create_context" ) == 1 )
{
// Define our attributes for using OpenGL 3.0 and forward
int attribs[] = {
WGL_CONTEXT_MAJOR_VERSION_ARB, 3,//we want a 3.0 context
WGL_CONTEXT_MINOR_VERSION_ARB, 0,
//and it shall be forward compatible so that we can only use up to date functionality
WGL_CONTEXT_FLAGS_ARB, WGL_CONTEXT_FORWARD_COMPATIBLE_BIT_ARB,
0}; //zero indicates the end of the array

m_handleGLRenderContext = wglCreateContextAttribsARB( m_handleDeviceContext, 0, attribs );
ASSERT_NULL( m_handleGLRenderContext );
ASSERT_FALSE( wglMakeCurrent( NULL, NULL ) );
ASSERT_FALSE( wglDeleteContext( tempContext ) );
ASSERT_FALSE( wglMakeCurrent( m_handleDeviceContext, m_handleGLRenderContext ) );
}
else
{
m_handleGLRenderContext = tempContext;
}
//////////////////////////////////////////////////////////////////////////
#endif

Resize( programWindow->GetWindowWidth(), programWindow->GetWindowHeight() )
[/code]




Here's where I init the renderer

[code]

glEnable(GL_DEPTH_TEST); // Enable depth testing
glDepthFunc( GL_LEQUAL ); // Reject anything less than or equal to the current depth
glClearDepth( 1.0f ); // We clear to full depth
glClearStencil( 0 ); // We clear the stencil buffer to false
glCullFace(GL_FRONT); // Enable culling
glClearColor(0.5f, 0.5f, 1.0f, 1.0f); // The color to clear the background to
[/code]




And lastly here's my WndProc

[code] switch( unMessage )
{
case WM_SIZE:
// Resize the window
CDeviceManager::GetInstance()->Resize( LOWORD( lParam ),
HIWORD( lParam ) );
break;
case WM_PAINT:
if( CGame::GetInstance()->IsGameActive() )
{
CGame::GetInstance()->Render();
}
break;
case WM_CLOSE:
// Free up resources if the red x is pressed
CGame::GetInstance()->Destroy();
CDeviceManager::GetInstance()->Destroy();
g_cWindow.Destroy();

break;
default:
return DefWindowProc( handleWindow,
unMessage,
wParam,
lParam );
[/code]




Please guys, I'm at my wits end on this.

Also if I press close, when it registers about minute later, I do see the clear color for just a second :/

Share this post


Link to post
Share on other sites
Hmm, do you require any specific Version of OpenGL?
But SFML or SDL or even GLUT might give you a better start into the OpenGL World. If you need to use a specific Version Context, you can download SFML 2, which let's you choose one. If not, download SFML 1.6. It is extreme easy to use OpenGL with SFML and you don't have to manage all this Windows Stuff.
It also makes your code platform independent to a certain degree.

Besides that:
[quote]
An application returns zero if it processes this message.
[/quote]
You must return zero if you handle WM_PAINT.
[url="http://msdn.microsoft.com/en-us/library/dd145213%28v=vs.85%29.aspx"]http://msdn.microsof...v=vs.85%29.aspx[/url]

That's what I meant with the Windows Stuff :).

edit:
SFML Window:

[code]
// Earlier in the class-definition:
sf::RenderWindow* m_window;

sf::ContextSettings context;
context.AntialiasingLevel = m_settings.fsaa;
context.DepthBits = m_settings.bpp;
context.MajorVersion = 3;
context.MinorVersion = 3;
context.StencilBits = 24;

m_window = new sf::RenderWindow(sf::VideoMode(static_cast<unsigned int>(m_settings.width), static_cast<unsigned int>(m_settings.height),
m_settings.bpp), m_settings.caption, flags, context);
[/code]

Share this post


Link to post
Share on other sites
@NicoG

I don't require any specific version or anything like that, this is mostly just educational. I just got a job where we use OpenGL for rendering and I've been a DirectX guy for awhile now, so I'm trying to get more intimate with OpenGL :) So I want to try and implement this without using someone else's code, though it seems almost impossible to avoid using GLUT and GLEW... :/


But thanks for that info! It didn't fix anything, but still, thanks!

Share this post


Link to post
Share on other sites
Why do you want to avoid GLew?
Do you really want to write a hundred lines of Codes with wglGetProcAdress?
GLew is a fine lib and I don't want to live without it anymore as an OpenGL Programmer. Trust me.

Just download SFML 2 and create the Context as I showed you. If you want to have a 3.x Core Profile, so older Functions don't work do this:
Go to WglContext.cpp and go to line 252:
Change the Attributes to this:
[code]
int attributes[] =
{
WGL_CONTEXT_MAJOR_VERSION_ARB, mySettings.MajorVersion,
WGL_CONTEXT_MINOR_VERSION_ARB, mySettings.MinorVersion,
WGL_CONTEXT_PROFILE_MASK_ARB, WGL_CONTEXT_CORE_PROFILE_BIT_ARB,
0, 0
};
[/code]

That's a bit dirty hack and you need to comment out some other deprecated functions (fixed functions like glMatrixMode) inside SFML 2, but then it works. They don't support core profiles yet though.
For me, it works :).

But you could also just use GLUT, which is a fine Tool for quick programming.

[quote]
So I want to try and implement this without using someone else's code, though it seems almost impossible to avoid using GLUT and GLEW... :/
[/quote]
Yeah, but such thing as a window, is really no task to make a drama of. ^^ Be productive and don't reinvent the Wheel.

Share this post


Link to post
Share on other sites
Haha I understand what you mean by not reinventing the wheel, and of course I don't want to write a hundred lines of code to do what GLEW does, but that doesn't mean I don't want to learn what I can do or how these things work. I'm not doing this to be productive or to get a studio up and off the ground, I'm doing this to learn something new. if I use something like SFML, yes I can have things working faster, but I defeat the whole point of me tackling this thing in the first place. I'm only asking for help here because it seems like everything is saying its ok but the program is far from. I'm not trying to be disrespectful, but this is just what I'm trying to accomplish :)

Share this post


Link to post
Share on other sites
The only explanation I have is this one:

Render commands that are send to OpenGL are not executed immediately but enqueued and executed later. When you send a command that will alter a resource that is still locked by a previous command, then blocking will occur. Perhaps the current backbuffer is such a resource w.r.t. glClear. Now, glFlush instructs OpenGL to execute all pending commands as quick as possible. Therefore it is meaningful to send a glFlush (but not a glFinish in this case) before swapping buffers.

However, even without glFlush I would expect OpenGL to do its job, even if perhaps not at as performant as possible.

Share this post


Link to post
Share on other sites
Right, and that's why I'm trying to eliminate the glFlush() call.

What do you mean by w.r.t glClear() though?

Sorry I've never heard that acronym.

I do believe that somewhere the call is being blocked because when I run the program through glDEBugger I get some where in the tens of thousands of calls to the context in a frame, when all I call is two gl functions. Something is up there, I just can't seem to figure out what is eating all of those calls.

Share this post


Link to post
Share on other sites
[code]

// Start the message loop
MSG msg;
while( CGame::GetInstance()->IsGameActive() )
{
if( PeekMessage( &msg, NULL, 0, 0, PM_REMOVE ) )
{
if( msg.message == WM_QUIT )
{
break;
}

TranslateMessage( &msg );
DispatchMessage( &msg );
}
else if( CGame::GetInstance()->IsGameActive() )
{
CGame::GetInstance()->Update();
CGame::GetInstance()->Render();
}
}



[/code]

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Announcements

  • Forum Statistics

    • Total Topics
      628379
    • Total Posts
      2982353
  • Similar Content

    • By test opty
      Hi all,
       
      I'm starting OpenGL using a tut on the Web. But at this point I would like to know the primitives needed for creating a window using OpenGL. So on Windows and using MS VS 2017, what is the simplest code required to render a window with the title of "First Rectangle", please?
       
       
    • By DejayHextrix
      Hi, New here. 
      I need some help. My fiance and I like to play this mobile game online that goes by real time. Her and I are always working but when we have free time we like to play this game. We don't always got time throughout the day to Queue Buildings, troops, Upgrades....etc.... 
      I was told to look into DLL Injection and OpenGL/DirectX Hooking. Is this true? Is this what I need to learn? 
      How do I read the Android files, or modify the files, or get the in-game tags/variables for the game I want? 
      Any assistance on this would be most appreciated. I been everywhere and seems no one knows or is to lazy to help me out. It would be nice to have assistance for once. I don't know what I need to learn. 
      So links of topics I need to learn within the comment section would be SOOOOO.....Helpful. Anything to just get me started. 
      Thanks, 
      Dejay Hextrix 
    • By mellinoe
      Hi all,
      First time poster here, although I've been reading posts here for quite a while. This place has been invaluable for learning graphics programming -- thanks for a great resource!
      Right now, I'm working on a graphics abstraction layer for .NET which supports D3D11, Vulkan, and OpenGL at the moment. I have implemented most of my planned features already, and things are working well. Some remaining features that I am planning are Compute Shaders, and some flavor of read-write shader resources. At the moment, my shaders can just get simple read-only access to a uniform (or constant) buffer, a texture, or a sampler. Unfortunately, I'm having a tough time grasping the distinctions between all of the different kinds of read-write resources that are available. In D3D alone, there seem to be 5 or 6 different kinds of resources with similar but different characteristics. On top of that, I get the impression that some of them are more or less "obsoleted" by the newer kinds, and don't have much of a place in modern code. There seem to be a few pivots:
      The data source/destination (buffer or texture) Read-write or read-only Structured or unstructured (?) Ordered vs unordered (?) These are just my observations based on a lot of MSDN and OpenGL doc reading. For my library, I'm not interested in exposing every possibility to the user -- just trying to find a good "middle-ground" that can be represented cleanly across API's which is good enough for common scenarios.
      Can anyone give a sort of "overview" of the different options, and perhaps compare/contrast the concepts between Direct3D, OpenGL, and Vulkan? I'd also be very interested in hearing how other folks have abstracted these concepts in their libraries.
    • By aejt
      I recently started getting into graphics programming (2nd try, first try was many years ago) and I'm working on a 3d rendering engine which I hope to be able to make a 3D game with sooner or later. I have plenty of C++ experience, but not a lot when it comes to graphics, and while it's definitely going much better this time, I'm having trouble figuring out how assets are usually handled by engines.
      I'm not having trouble with handling the GPU resources, but more so with how the resources should be defined and used in the system (materials, models, etc).
      This is my plan now, I've implemented most of it except for the XML parts and factories and those are the ones I'm not sure of at all:
      I have these classes:
      For GPU resources:
      Geometry: holds and manages everything needed to render a geometry: VAO, VBO, EBO. Texture: holds and manages a texture which is loaded into the GPU. Shader: holds and manages a shader which is loaded into the GPU. For assets relying on GPU resources:
      Material: holds a shader resource, multiple texture resources, as well as uniform settings. Mesh: holds a geometry and a material. Model: holds multiple meshes, possibly in a tree structure to more easily support skinning later on? For handling GPU resources:
      ResourceCache<T>: T can be any resource loaded into the GPU. It owns these resources and only hands out handles to them on request (currently string identifiers are used when requesting handles, but all resources are stored in a vector and each handle only contains resource's index in that vector) Resource<T>: The handles given out from ResourceCache. The handles are reference counted and to get the underlying resource you simply deference like with pointers (*handle).  
      And my plan is to define everything into these XML documents to abstract away files:
      Resources.xml for ref-counted GPU resources (geometry, shaders, textures) Resources are assigned names/ids and resource files, and possibly some attributes (what vertex attributes does this geometry have? what vertex attributes does this shader expect? what uniforms does this shader use? and so on) Are reference counted using ResourceCache<T> Assets.xml for assets using the GPU resources (materials, meshes, models) Assets are not reference counted, but they hold handles to ref-counted resources. References the resources defined in Resources.xml by names/ids. The XMLs are loaded into some structure in memory which is then used for loading the resources/assets using factory classes:
      Factory classes for resources:
      For example, a texture factory could contain the texture definitions from the XML containing data about textures in the game, as well as a cache containing all loaded textures. This means it has mappings from each name/id to a file and when asked to load a texture with a name/id, it can look up its path and use a "BinaryLoader" to either load the file and create the resource directly, or asynchronously load the file's data into a queue which then can be read from later to create the resources synchronously in the GL context. These factories only return handles.
      Factory classes for assets:
      Much like for resources, these classes contain the definitions for the assets they can load. For example, with the definition the MaterialFactory will know which shader, textures and possibly uniform a certain material has, and with the help of TextureFactory and ShaderFactory, it can retrieve handles to the resources it needs (Shader + Textures), setup itself from XML data (uniform values), and return a created instance of requested material. These factories return actual instances, not handles (but the instances contain handles).
       
       
      Is this a good or commonly used approach? Is this going to bite me in the ass later on? Are there other more preferable approaches? Is this outside of the scope of a 3d renderer and should be on the engine side? I'd love to receive and kind of advice or suggestions!
      Thanks!
    • By nedondev
      I 'm learning how to create game by using opengl with c/c++ coding, so here is my fist game. In video description also have game contain in Dropbox. May be I will make it better in future.
      Thanks.
  • Popular Now