Sign in to follow this  
FelixK15

OpenGL Thoughts about independent graphical implementation (2D)

Recommended Posts

FelixK15    335
Hello everyone,

currently I'm thinking about the graphical rendering in my 2D project.

This is my class structure at the moment:
[img]http://imageshack.us/m/607/3791/possiblesolution1.png[/img]

I've got the interface IGraphic, which gets implemented by BaseGraphic.
The concrete classes SDL_Graphic and OpenGL_Graphic inherit from BaseGraphic.

The graphics gets drawn on the global screen surface (currently an SDL_Surface) via the method draw().

That works pretty good at the moment but because it may will be that some day I want to add other graphical implementations (e.g. DirectX_Graphic)
the SDL_Surface as the screen surface won't work anymore.

That's why I thought of the following architecture:
[img]http://imageshack.us/m/221/2071/possiblesolution2.png[/img]

In this architecture the whole rendering happens in the specific IGraphicManager implementations.

The GraphicManager class does have an array of IGraphic pointern and every implementation of IGraphicManager does
have its own datastructure fot the screen surface (They just actually have to cast the IGraphic pointers).

After the rendering happend, the IGraphic array will get emptied and filled again each frame.

My question is, if there's anything that does speak against this architecture?

Share this post


Link to post
Share on other sites
Hodgman    51334
[font="Courier New"]IGraphicManager[/font] [i]has many[/i] [font="Courier New"]IGraphic[/font].

[font="Courier New"]SDL_GraphicManager[/font] [i]is a[/i] [font="Courier New"]IGraphicManager[/font], and [font="Courier New"]OpenGL_Graphic[/font] [i]is a[/i] [font="Courier New"]IGraphic[/font].

So it follows that it's valid for [font="Courier New"]SDL_GraphicManager[/font] to have an [font="Courier New"]OpenGL_Graphic[/font] (or a [font="Courier New"]D3D_Graphic[/font], etc).
[hr]That said... it's a common design and should serve you fine, it's just technically an incorrect use of inheritance.

Share this post


Link to post
Share on other sites
haegarr    7372
To ensure consistency, IGraphicManager should not provide public routines to add an object with the iGraphic interface. Instead, it may provide public factory methods where clients request new instances of IGraphic, and those instances would become "automatically" member of the particular m_graphics[] field before the factory returns.

Share this post


Link to post
Share on other sites
FelixK15    335
[quote name='haegarr' timestamp='1305703194' post='4812307']
To ensure consistency, IGraphicManager should not provide public routines to add an object with the iGraphic interface. Instead, it may provide public factory methods where clients request new instances of IGraphic, and those instances would become "automatically" member of the particular m_graphics[] field before the factory returns.
[/quote]

I thought about making IGraphic a friend class of IGraphicManager so IGraphic can add itself to the array.
(instead of calling draw() of the IGraphic implementation)

Actually I currently have a GraphicsFactory for creating instances of IGraphic implementations. The problem is that if the IGraphic instance gets added to the GraphicsManagers array only by the factory it will only get drawn once. That is because I wanted to empty the array everytime it drew every IGraphic on the screen (as described above).

Share this post


Link to post
Share on other sites
haegarr    7372
[quote name='FelixK15' timestamp='1305704995' post='4812319']
...
Actually I currently have a GraphicsFactory for creating instances of IGraphic implementations. The problem is that if the IGraphic instance gets added to the GraphicsManagers array only by the factory it will only get drawn once. That is because I wanted to empty the array everytime it drew every IGraphic on the screen (as described above).
[/quote]
Sorry, I haven't noticed that m_graphics[] is for storing rendering jobs. I should have read your OP more carefully. Perhaps the overused term "manager" has confused me ;)

Nevertheless, the principle still holds. Any collection of IGraphic that hold all instances of IGraphic is a kind of scene description (e.g. an array m_allGraphics[]). If IGraphicManager provides a factory for suited IGraphic instances [i]and[/i] the allGraphics collection, and further does not publicly allow to add IGraphic instances to that collection, then type consistency (in this sense of Hodgman's comment) is given. For sure, you have to ensure something similar for [i]any[/i] collection.

Not offending, but ... that brings up the question whether the overall design is that clear at all. I mean IGraphic is AFAIS a renderable, a renderer (because of draw()), has an own resource management (hinted at by the loadGraphic routine), represents a render job. What happens when sound comes into play? Of course, I have no deep insight into your design just from those one or two diagrams, but I personally have the impression it is the way you go, and I would ever try to avoid such an aggregation of different functionality. IMHO your design massively violates the "single responsibility principle".

Usually concepts like shared resources (requiring a central resource management), outsourced batch processing (often needed when dealing with sprites and similar masses of renderable objects; we're speaking of a 2D project here, right?), exchangeable graphic APIs (and other sub-systems), aspect oriented management of game objects (I mean dropping the omnipotent scene graph approach), pluggable game objects (to avoid the accumulation of from case-to-case mostly superfluous functionality in base classes) ... all lead to "degrading" a renderable to just that: A description of graphical rendering, but not more.

Just my 2 EUR-Cent. Edited by haegarr

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Similar Content

    • By pseudomarvin
      I assumed that if a shader is computationally expensive then the execution is just slower. But running the following GLSL FS instead just crashes
      void main() { float x = 0; float y = 0; int sum = 0; for (float x = 0; x < 10; x += 0.00005) { for (float y = 0; y < 10; y += 0.00005) { sum++; } } fragColor = vec4(1, 1, 1 , 1.0); } with unhandled exception in nvoglv32.dll. Are there any hard limits on the number of steps/time that a shader can take before it is shut down? I was thinking about implementing some time intensive computation in shaders where it would take on the order of seconds to compute a frame, is that possible? Thanks.
    • By Arulbabu Donbosco
      There are studios selling applications which is just copying any 3Dgraphic content and regenerating into another new window. especially for CAVE Virtual reality experience. so that the user opens REvite or CAD or any other 3D applications and opens a model. then when the user selects the rendered window the VR application copies the 3D model information from the OpenGL window. 
      I got the clue that the VR application replaces the windows opengl32.dll file. how this is possible ... how can we copy the 3d content from the current OpenGL window.
      anyone, please help me .. how to go further... to create an application like VR CAVE. 
       
      Thanks
    • By cebugdev
      hi all,

      i am trying to build an OpenGL 2D GUI system, (yeah yeah, i know i should not be re inventing the wheel, but this is for educational and some other purpose only),
      i have built GUI system before using 2D systems such as that of HTML/JS canvas, but in 2D system, i can directly match a mouse coordinates to the actual graphic coordinates with additional computation for screen size/ratio/scale ofcourse.
      now i want to port it to OpenGL, i know that to render a 2D object in OpenGL we specify coordiantes in Clip space or use the orthographic projection, now heres what i need help about.
      1. what is the right way of rendering the GUI? is it thru drawing in clip space or switching to ortho projection?
      2. from screen coordinates (top left is 0,0 nd bottom right is width height), how can i map the mouse coordinates to OpenGL 2D so that mouse events such as button click works? In consideration ofcourse to the current screen/size dimension.
      3. when let say if the screen size/dimension is different, how to handle this? in my previous javascript 2D engine using canvas, i just have my working coordinates and then just perform the bitblk or copying my working canvas to screen canvas and scale the mouse coordinates from there, in OpenGL how to work on a multiple screen sizes (more like an OpenGL ES question).
      lastly, if you guys know any books, resources, links or tutorials that handle or discuss this, i found one with marekknows opengl game engine website but its not free,
      Just let me know. Did not have any luck finding resource in google for writing our own OpenGL GUI framework.
      IF there are no any available online, just let me know, what things do i need to look into for OpenGL and i will study them one by one to make it work.
      thank you, and looking forward to positive replies.
    • By fllwr0491
      I have a few beginner questions about tesselation that I really have no clue.
      The opengl wiki doesn't seem to talk anything about the details.
       
      What is the relationship between TCS layout out and TES layout in?
      How does the tesselator know how control points are organized?
          e.g. If TES input requests triangles, but TCS can output N vertices.
             What happens in this case?
      In this article,
      http://www.informit.com/articles/article.aspx?p=2120983
      the isoline example TCS out=4, but TES in=isoline.
      And gl_TessCoord is only a single one.
      So which ones are the control points?
      How are tesselator building primitives?
    • By Orella
      I've been developing a 2D Engine using SFML + ImGui.
      Here you can see an image
      The editor is rendered using ImGui and the scene window is a sf::RenderTexture where I draw the GameObjects and then is converted to ImGui::Image to render it in the editor.
      Now I need to create a 3D Engine during this year in my Bachelor Degree but using SDL2 + ImGui and I want to recreate what I did with the 2D Engine. 
      I've managed to render the editor like I did in the 2D Engine using this example that comes with ImGui. 
      3D Editor preview
      But I don't know how to create an equivalent of sf::RenderTexture in SDL2, so I can draw the 3D scene there and convert it to ImGui::Image to show it in the editor.
      If you can provide code will be better. And if you want me to provide any specific code tell me.
      Thanks!
  • Popular Now