Sign in to follow this  
Salatinjsh

OpenGL GL lighting problem

Recommended Posts

Hi!

I'm learning OpenGL using GLUT window. So far i have made a colorful cube rotating on y and x asis and now i have added lighting but it doesnt work. It only makes it all in shadow but it should make nice perspectively shaded cube.

There is the code and i hope i'll have help :

[code]
#include <GL/glew.h>
#include <GL/glut.h>

GLfloat rotquad;

GLfloat LightPosition[] = { 0, 0, 0, 1 };
GLfloat LightAmbient[] = { 1, 1, 1, 1 };
GLfloat LightDiffuse[] = { 1, 1, 1, 1 };

bool light = false;
bool diffuse = false;
bool emissive = false;
bool specular = false;

void Keyboard (unsigned char key, int x, int y)
{
if (key=='l')
{
light=!light;
if (!light)
{
glDisable(GL_LIGHTING);
} else
{
glEnable(GL_LIGHTING);
}
}
}

void KeyboardSpec (int key, int x, int y)
{

}


void Init()
{
glEnable (GL_BLEND);
glEnable (GL_DEPTH_TEST);
glEnable (GL_COLOR_MATERIAL);
glEnable (GL_LIGHT1);
}

void SetUpLight ()
{
glLightfv(GL_LIGHT1, GL_AMBIENT, LightAmbient);
glLightfv(GL_LIGHT1, GL_DIFFUSE, LightDiffuse);
glLightfv(GL_LIGHT1, GL_POSITION, LightPosition);
}

void Display()
{
glClearColor(0.2, 0.2, 0.2, 1);
glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);
glBlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA);
glLoadIdentity();

glTranslatef(0, 0, -6);

glRotatef(rotquad, 1, 0, 0);
glRotatef(rotquad, 0, 1, 0);

glBegin(GL_QUADS); // Start Drawing The Cube

glColor4f(1, 0, 0, 1);
glVertex3f( 1.0f, 1.0f,-1.0f); // Top Right Of The Quad (Top)
glVertex3f(-1.0f, 1.0f,-1.0f); // Top Left Of The Quad (Top)
glVertex3f(-1.0f, 1.0f, 1.0f); // Bottom Left Of The Quad (Top)
glVertex3f( 1.0f, 1.0f, 1.0f); // Bottom Right Of The Quad (Top)

glColor4f(0, 1, 1, 1);
glVertex3f( 1.0f,-1.0f, 1.0f); // Top Right Of The Quad (Bottom)
glVertex3f(-1.0f,-1.0f, 1.0f); // Top Left Of The Quad (Bottom)
glVertex3f(-1.0f,-1.0f,-1.0f); // Bottom Left Of The Quad (Bottom)
glVertex3f( 1.0f,-1.0f,-1.0f); // Bottom Right Of The Quad (Bottom)

glColor4f(1, 0, 1, 1);
glVertex3f( 1.0f, 1.0f, 1.0f); // Top Right Of The Quad (Front)
glVertex3f(-1.0f, 1.0f, 1.0f); // Top Left Of The Quad (Front)
glVertex3f(-1.0f,-1.0f, 1.0f); // Bottom Left Of The Quad (Front)
glVertex3f( 1.0f,-1.0f, 1.0f); // Bottom Right Of The Quad (Front)

glColor4f(1, 1, 0, 1);
glVertex3f( 1.0f,-1.0f,-1.0f); // Bottom Left Of The Quad (Back)
glVertex3f(-1.0f,-1.0f,-1.0f); // Bottom Right Of The Quad (Back)
glVertex3f(-1.0f, 1.0f,-1.0f); // Top Right Of The Quad (Back)
glVertex3f( 1.0f, 1.0f,-1.0f); // Top Left Of The Quad (Back)

glColor4f(0, 0, 1, 1);
glVertex3f(-1.0f, 1.0f, 1.0f); // Top Right Of The Quad (Left)
glVertex3f(-1.0f, 1.0f,-1.0f); // Top Left Of The Quad (Left)
glVertex3f(-1.0f,-1.0f,-1.0f); // Bottom Left Of The Quad (Left)
glVertex3f(-1.0f,-1.0f, 1.0f); // Bottom Right Of The Quad (Left)

glColor4f(0, 1, 0, 1);
glVertex3f( 1.0f, 1.0f,-1.0f); // Top Right Of The Quad (Right)
glVertex3f( 1.0f, 1.0f, 1.0f); // Top Left Of The Quad (Right)
glVertex3f( 1.0f,-1.0f, 1.0f); // Bottom Left Of The Quad (Right)
glVertex3f( 1.0f,-1.0f,-1.0f); // Bottom Right Of The Quad (Right)
glEnd();

rotquad -= 1.5f;

glutSwapBuffers();
}

void OnReshape(int width, int height)
{
glViewport(0, 0, (GLsizei)width, (GLsizei)height); // Set our viewport to the size of our window
glMatrixMode(GL_PROJECTION);
glLoadIdentity();
gluPerspective(60, (GLfloat)width / (GLfloat)height, 1.0, 100.0);
glMatrixMode(GL_MODELVIEW); // Switch back to the model view matrix, so that we can start drawing shapes correctly
}

int main(int argc, char **argv)
{
glutInit(&argc, argv); // Initialize GLUT
glutInitDisplayMode (GLUT_DOUBLE| GLUT_RGBA); // Set up a basic display buffer (only single buffered for now)
glutInitWindowSize (500, 500); // Set the width and height of the window
glutInitWindowPosition (100, 100); // Set the position of the window
glutCreateWindow ("First GLUT window"); // Set the title for the window

Init();

glutDisplayFunc (Display);
glutIdleFunc (Display);
glutKeyboardFunc (Keyboard);
glutSpecialFunc (KeyboardSpec);
glutReshapeFunc (OnReshape);

glutMainLoop(); // Enter GLUT's main loop

return 0;
}[/code]

few functions may be quite strange, thats because i have combined header and files asociated to it ;) (im not sure that im saing it right because not english :D )

Share this post


Link to post
Share on other sites
Looks like you need to add normals in. Lighting calculations require the normal of the surface being lit to determine the final lighting coefficients.
A glNormal3f(x, y, z); call is required for each normal you are using, e.g.:

[size="2"][color="#000000"]glColor4f[/color][color="#666600"]([/color][color="#006666"]1[/color][color="#666600"],[/color] [color="#006666"]0[/color][color="#666600"],[/color] [color="#006666"]0[/color][color="#666600"],[/color] [color="#006666"]1[/color][color="#666600"]);[/color][color="#666600"] [/color][/size]
[size="2"][color="#666600"]glNormal3f( 0.0f, 1.0f, 0.0f); // normal facing upwards
[/color]glVertex3f[color="#666600"]([/color] [color="#006666"]1.0f[/color][color="#666600"],[/color] [color="#006666"]1.0f[/color][color="#666600"],-[/color][color="#006666"]1.0f[/color][color="#666600"]);[/color] [color="#880000"]// Top Right Of The Quad (Top)[/color][color="#000000"]
glVertex3f[/color][color="#666600"](-[/color][color="#006666"]1.0f[/color][color="#666600"],[/color] [color="#006666"]1.0f[/color][color="#666600"],-[/color][color="#006666"]1.0f[/color][color="#666600"]);[/color] [color="#880000"]// Top Left Of The Quad (Top)[/color][color="#000000"]
glVertex3f[/color][color="#666600"](-[/color][color="#006666"]1.0f[/color][color="#666600"],[/color] [color="#006666"]1.0f[/color][color="#666600"],[/color] [color="#006666"]1.0f[/color][color="#666600"]);[/color] [color="#880000"]// Bottom Left Of The Quad (Top)[/color][color="#000000"]
glVertex3f[/color][color="#666600"]([/color] [color="#006666"]1.0f[/color][color="#666600"],[/color] [color="#006666"]1.0f[/color][color="#666600"],[/color] [color="#006666"]1.0f[/color][color="#666600"]);[/color] [color="#880000"]// Bottom Right Of The Quad (Top)[/color] [/size]
This will set the normal used for those four vertices (any any following, until the next glNormal3f call or glEnd.
Hope this helps.

/edit Wow this text editor is bad.

Share this post


Link to post
Share on other sites
[quote name='Salatinjsh' timestamp='1305819066' post='4813031']
may work but i dont know how it works and cant get it working, i'm reading about normals now in opengl website but anyway can't make it working :(
[/quote]

Try glEnable(GL_LIGHTING);
Check this out:

[url="http://www.sjbaker.org/steve/omniv/opengl_lighting.html"]http://www.sjbaker.o...l_lighting.html[/url]


[url="http://translate.google.com/translate?sl=auto&tl=lv&js=n&prev=_t&hl=en&ie=UTF-8&layout=2&eotf=1&u=http%3A%2F%2Fwww.sjbaker.org%2Fsteve%2Fomniv%2Fopengl_lighting.html"]Google translated to latvian, shame it doesn't do the image aswell.[/url]

Share this post


Link to post
Share on other sites
[quote name='bluntman' timestamp='1305820466' post='4813042']
Try glEnable(GL_LIGHTING);
Check this out:

[url="http://www.sjbaker.org/steve/omniv/opengl_lighting.html"]http://www.sjbaker.o...l_lighting.html[/url]


[url="http://translate.google.com/translate?sl=auto&tl=lv&js=n&prev=_t&hl=en&ie=UTF-8&layout=2&eotf=1&u=http%3A%2F%2Fwww.sjbaker.org%2Fsteve%2Fomniv%2Fopengl_lighting.html"]Google translated to latvian, shame it doesn't do the image aswell.[/url]

[/quote]

Thx nice page, made my mind clear but i still can't get light working :@ :@




EDIT: I GOT THE LIGHT THANK U GUYS!!!!!!


I found that the problem realy was with normals :D

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Announcements

  • Forum Statistics

    • Total Topics
      628379
    • Total Posts
      2982353
  • Similar Content

    • By test opty
      Hi all,
       
      I'm starting OpenGL using a tut on the Web. But at this point I would like to know the primitives needed for creating a window using OpenGL. So on Windows and using MS VS 2017, what is the simplest code required to render a window with the title of "First Rectangle", please?
       
       
    • By DejayHextrix
      Hi, New here. 
      I need some help. My fiance and I like to play this mobile game online that goes by real time. Her and I are always working but when we have free time we like to play this game. We don't always got time throughout the day to Queue Buildings, troops, Upgrades....etc.... 
      I was told to look into DLL Injection and OpenGL/DirectX Hooking. Is this true? Is this what I need to learn? 
      How do I read the Android files, or modify the files, or get the in-game tags/variables for the game I want? 
      Any assistance on this would be most appreciated. I been everywhere and seems no one knows or is to lazy to help me out. It would be nice to have assistance for once. I don't know what I need to learn. 
      So links of topics I need to learn within the comment section would be SOOOOO.....Helpful. Anything to just get me started. 
      Thanks, 
      Dejay Hextrix 
    • By mellinoe
      Hi all,
      First time poster here, although I've been reading posts here for quite a while. This place has been invaluable for learning graphics programming -- thanks for a great resource!
      Right now, I'm working on a graphics abstraction layer for .NET which supports D3D11, Vulkan, and OpenGL at the moment. I have implemented most of my planned features already, and things are working well. Some remaining features that I am planning are Compute Shaders, and some flavor of read-write shader resources. At the moment, my shaders can just get simple read-only access to a uniform (or constant) buffer, a texture, or a sampler. Unfortunately, I'm having a tough time grasping the distinctions between all of the different kinds of read-write resources that are available. In D3D alone, there seem to be 5 or 6 different kinds of resources with similar but different characteristics. On top of that, I get the impression that some of them are more or less "obsoleted" by the newer kinds, and don't have much of a place in modern code. There seem to be a few pivots:
      The data source/destination (buffer or texture) Read-write or read-only Structured or unstructured (?) Ordered vs unordered (?) These are just my observations based on a lot of MSDN and OpenGL doc reading. For my library, I'm not interested in exposing every possibility to the user -- just trying to find a good "middle-ground" that can be represented cleanly across API's which is good enough for common scenarios.
      Can anyone give a sort of "overview" of the different options, and perhaps compare/contrast the concepts between Direct3D, OpenGL, and Vulkan? I'd also be very interested in hearing how other folks have abstracted these concepts in their libraries.
    • By aejt
      I recently started getting into graphics programming (2nd try, first try was many years ago) and I'm working on a 3d rendering engine which I hope to be able to make a 3D game with sooner or later. I have plenty of C++ experience, but not a lot when it comes to graphics, and while it's definitely going much better this time, I'm having trouble figuring out how assets are usually handled by engines.
      I'm not having trouble with handling the GPU resources, but more so with how the resources should be defined and used in the system (materials, models, etc).
      This is my plan now, I've implemented most of it except for the XML parts and factories and those are the ones I'm not sure of at all:
      I have these classes:
      For GPU resources:
      Geometry: holds and manages everything needed to render a geometry: VAO, VBO, EBO. Texture: holds and manages a texture which is loaded into the GPU. Shader: holds and manages a shader which is loaded into the GPU. For assets relying on GPU resources:
      Material: holds a shader resource, multiple texture resources, as well as uniform settings. Mesh: holds a geometry and a material. Model: holds multiple meshes, possibly in a tree structure to more easily support skinning later on? For handling GPU resources:
      ResourceCache<T>: T can be any resource loaded into the GPU. It owns these resources and only hands out handles to them on request (currently string identifiers are used when requesting handles, but all resources are stored in a vector and each handle only contains resource's index in that vector) Resource<T>: The handles given out from ResourceCache. The handles are reference counted and to get the underlying resource you simply deference like with pointers (*handle).  
      And my plan is to define everything into these XML documents to abstract away files:
      Resources.xml for ref-counted GPU resources (geometry, shaders, textures) Resources are assigned names/ids and resource files, and possibly some attributes (what vertex attributes does this geometry have? what vertex attributes does this shader expect? what uniforms does this shader use? and so on) Are reference counted using ResourceCache<T> Assets.xml for assets using the GPU resources (materials, meshes, models) Assets are not reference counted, but they hold handles to ref-counted resources. References the resources defined in Resources.xml by names/ids. The XMLs are loaded into some structure in memory which is then used for loading the resources/assets using factory classes:
      Factory classes for resources:
      For example, a texture factory could contain the texture definitions from the XML containing data about textures in the game, as well as a cache containing all loaded textures. This means it has mappings from each name/id to a file and when asked to load a texture with a name/id, it can look up its path and use a "BinaryLoader" to either load the file and create the resource directly, or asynchronously load the file's data into a queue which then can be read from later to create the resources synchronously in the GL context. These factories only return handles.
      Factory classes for assets:
      Much like for resources, these classes contain the definitions for the assets they can load. For example, with the definition the MaterialFactory will know which shader, textures and possibly uniform a certain material has, and with the help of TextureFactory and ShaderFactory, it can retrieve handles to the resources it needs (Shader + Textures), setup itself from XML data (uniform values), and return a created instance of requested material. These factories return actual instances, not handles (but the instances contain handles).
       
       
      Is this a good or commonly used approach? Is this going to bite me in the ass later on? Are there other more preferable approaches? Is this outside of the scope of a 3d renderer and should be on the engine side? I'd love to receive and kind of advice or suggestions!
      Thanks!
    • By nedondev
      I 'm learning how to create game by using opengl with c/c++ coding, so here is my fist game. In video description also have game contain in Dropbox. May be I will make it better in future.
      Thanks.
  • Popular Now