Sign in to follow this  

OpenGL Couple of Issues with VBOs

This topic is 2419 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

So I've finally got enough time on my hands to start properly learning to use OpenGL, but VBOs are throwing me a little bit. I wrote some model and texture loading code for a single object OBJ file and a targa file and got that all to render fine. However it's pretty inefficient, there's a fair bit of duplication which I need to find a way of getting rid of. After getting basic load-and-draw functionality working I started looking into VBOs. Here I'm hitting on another problem: although I'm using the same data and indexing, my normals and texture coords screw up. Both of these problems stem from the fact that I can't quite pin down how I'm supposed to be indexing the data in any usable, efficient way. I get the principles behind it, but I still find OpenGL's handling of buffers a little vague.

Mesh loading and buffer generation, called once when program is started: [url="http://pastebin.com/BEy2RCSc"]http://pastebin.com/BEy2RCSc[/url] (commented some dodgy stuff I need help with)
Render, called repeatedly: [url="http://pastebin.com/RAvSHNPc"]http://pastebin.com/RAvSHNPc[/url] (I think this is probably fine, but just in case)

Just to visualise the problem I'm having, this is the mesh loaded the old way, without VBOs:
[url="http://www.youtube.com/watch?v=3BFUrZobhg8"]http://www.youtube.c...h?v=3BFUrZobhg8[/url]

And with the alterations for VBOs:
[url="http://img43.imageshack.us/img43/8315/screenshot20110603at232.png"]http://img43.imagesh...110603at232.png[/url]
[url="http://img849.imageshack.us/img849/8315/screenshot20110603at232.png"]http://img849.images...110603at232.png[/url]

As you can see, the vertices seem to be fine, but the normals and texture coords are off.

Share this post


Link to post
Share on other sites
The first few lines are already confusing me and the code looks like you seem to believe that a Vector and a Vertex is the same kind of thing. Otherwise it makes zero sense to allocate numNormals*sizeof(Vertex) for your normals.

A vector is a bunch of coordinates, a vertex is a collection of a bunch of attributes like position, normal, texcoord, color, etc... if one of them is different it's not the same vertex. Don't try anything weird like using one normal for multiple vertices. You can do that in immediate mode, but not with buffers (at least not without trickery). If you feel like trying out something new, maybe you can put something together using this:
[url="http://www.opengl.org/registry/specs/ARB/instanced_arrays.txt"]http://www.opengl.or...nced_arrays.txt[/url]

As far as I understand, the index for each attribute stream is divided by a number you can specify yourself, so technically you could reuse a normal or texcoord if you get the order of all attributes right. Trying a thought experiment for cubes (again, assuming I understand the extension correctly):

normals[6] = {n1, n2, n3, n4, n5, n6} //setting a divisor of 4
texcoord[4] = {t1, t2, t3, t4} //setting a divisor of 6
position[6*4] = {p1, p2, p3, p4, p5, p6, p7, p8, p9, p10, p11, p12, p13, p14, p15, p16, .... } //setting a divisor of 1, each 4 entries make up one side of the cube
indices[6*4] = { 0,1,2,3, 4,5,6,7, 8,9,10,11, 12,13,14,15, .... }

Now when sending your draw call (as quads for simplicities sake), you would get the following vertices:

n1, t1, p1
n1, t1, p2
n1, t1, p3
n1, t1, p4

n2, t1, p5
n2, t1, p6

So after a bit of fiddling I don't think you can fix the order of the attributes to make it work. If you can find an arrangement that works (or even one that works for generic models) you're a better man than me. Rule of thumb: if you have a sharp edge, you can not share vertices.

Share this post


Link to post
Share on other sites
Alright. OBJ files store the attributes separately, so there's a list with all the coordinates of the vertices, then list of all the texture coordinates etc. which I think is probably what caused my confusion. Thanks for the advice, I'll take a crack at this ASAP.

Share this post


Link to post
Share on other sites
I didn't go through all the code, but these few lines of code are wrong:

[code] memcpy(mesh->vbo_buffer, mesh->vertices, vertex_size);
memcpy(mesh->vbo_buffer + normal_size, mesh->meshNormals, normal_size);
memcpy(mesh->vbo_buffer + normal_size + texturecoord_size, mesh->meshTexCoords, texturecoord_size);[/code]
The offset for 2nd line should be vertex_size, and the offset for the 3rd line should be vertex_size + normal_size. When you load the positions (in your code, mesh->vertices) in, the end of that array will be mesh->vertices + vertex_size, which gives you the offset for the 2nd line. And same applies for the 2nd line, to get the offset for the 3rd line.

So the code should be:


[code] memcpy(mesh->vbo_buffer, mesh->vertices, vertex_size);
memcpy(mesh->vbo_buffer + vertex_size, mesh->meshNormals, normal_size);
memcpy(mesh->vbo_buffer + vertex_size + normal_size, mesh->meshTexCoords, texturecoord_size);[/code]

Share this post


Link to post
Share on other sites
/facepalm

I was thinking that myself earlier, could have sworn I'd corrected it... Apparently not.

Edit: Well now it draws perfectly, and I feel a little embarrassed.

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Similar Content

    • By xhcao
      Does sync be needed to read texture content after access texture image in compute shader?
      My simple code is as below,
      glUseProgram(program.get());
      glBindImageTexture(0, texture[0], 0, GL_FALSE, 3, GL_READ_ONLY, GL_R32UI);
      glBindImageTexture(1, texture[1], 0, GL_FALSE, 4, GL_WRITE_ONLY, GL_R32UI);
      glDispatchCompute(1, 1, 1);
      // Does sync be needed here?
      glUseProgram(0);
      glBindFramebuffer(GL_READ_FRAMEBUFFER, framebuffer);
      glFramebufferTexture2D(GL_READ_FRAMEBUFFER, GL_COLOR_ATTACHMENT0,
                                     GL_TEXTURE_CUBE_MAP_POSITIVE_X + face, texture[1], 0);
      glReadPixels(0, 0, kWidth, kHeight, GL_RED_INTEGER, GL_UNSIGNED_INT, outputValues);
       
      Compute shader is very simple, imageLoad content from texture[0], and imageStore content to texture[1]. Does need to sync after dispatchCompute?
    • By Jonathan2006
      My question: is it possible to transform multiple angular velocities so that they can be reinserted as one? My research is below:
      // This works quat quaternion1 = GEQuaternionFromAngleRadians(angleRadiansVector1); quat quaternion2 = GEMultiplyQuaternions(quaternion1, GEQuaternionFromAngleRadians(angleRadiansVector2)); quat quaternion3 = GEMultiplyQuaternions(quaternion2, GEQuaternionFromAngleRadians(angleRadiansVector3)); glMultMatrixf(GEMat4FromQuaternion(quaternion3).array); // The first two work fine but not the third. Why? quat quaternion1 = GEQuaternionFromAngleRadians(angleRadiansVector1); vec3 vector1 = GETransformQuaternionAndVector(quaternion1, angularVelocity1); quat quaternion2 = GEQuaternionFromAngleRadians(angleRadiansVector2); vec3 vector2 = GETransformQuaternionAndVector(quaternion2, angularVelocity2); // This doesn't work //quat quaternion3 = GEQuaternionFromAngleRadians(angleRadiansVector3); //vec3 vector3 = GETransformQuaternionAndVector(quaternion3, angularVelocity3); vec3 angleVelocity = GEAddVectors(vector1, vector2); // Does not work: vec3 angleVelocity = GEAddVectors(vector1, GEAddVectors(vector2, vector3)); static vec3 angleRadiansVector; vec3 angularAcceleration = GESetVector(0.0, 0.0, 0.0); // Sending it through one angular velocity later in my motion engine angleVelocity = GEAddVectors(angleVelocity, GEMultiplyVectorAndScalar(angularAcceleration, timeStep)); angleRadiansVector = GEAddVectors(angleRadiansVector, GEMultiplyVectorAndScalar(angleVelocity, timeStep)); glMultMatrixf(GEMat4FromEulerAngle(angleRadiansVector).array); Also how do I combine multiple angularAcceleration variables? Is there an easier way to transform the angular values?
    • By dpadam450
      I have this code below in both my vertex and fragment shader, however when I request glGetUniformLocation("Lights[0].diffuse") or "Lights[0].attenuation", it returns -1. It will only give me a valid uniform location if I actually use the diffuse/attenuation variables in the VERTEX shader. Because I use position in the vertex shader, it always returns a valid uniform location. I've read that I can share uniforms across both vertex and fragment, but I'm confused what this is even compiling to if this is the case.
       
      #define NUM_LIGHTS 2
      struct Light
      {
          vec3 position;
          vec3 diffuse;
          float attenuation;
      };
      uniform Light Lights[NUM_LIGHTS];
       
       
    • By pr033r
      Hello,
      I have a Bachelor project on topic "Implenet 3D Boid's algorithm in OpenGL". All OpenGL issues works fine for me, all rendering etc. But when I started implement the boid's algorithm it was getting worse and worse. I read article (http://natureofcode.com/book/chapter-6-autonomous-agents/) inspirate from another code (here: https://github.com/jyanar/Boids/tree/master/src) but it still doesn't work like in tutorials and videos. For example the main problem: when I apply Cohesion (one of three main laws of boids) it makes some "cycling knot". Second, when some flock touch to another it scary change the coordination or respawn in origin (x: 0, y:0. z:0). Just some streng things. 
      I followed many tutorials, change a try everything but it isn't so smooth, without lags like in another videos. I really need your help. 
      My code (optimalizing branch): https://github.com/pr033r/BachelorProject/tree/Optimalizing
      Exe file (if you want to look) and models folder (for those who will download the sources):
      http://leteckaposta.cz/367190436
      Thanks for any help...

    • By Andrija
      I am currently trying to implement shadow mapping into my project , but although i can render my depth map to the screen and it looks okay , when i sample it with shadowCoords there is no shadow.
      Here is my light space matrix calculation
      mat4x4 lightViewMatrix; vec3 sun_pos = {SUN_OFFSET * the_sun->direction[0], SUN_OFFSET * the_sun->direction[1], SUN_OFFSET * the_sun->direction[2]}; mat4x4_look_at(lightViewMatrix,sun_pos,player->pos,up); mat4x4_mul(lightSpaceMatrix,lightProjMatrix,lightViewMatrix); I will tweak the values for the size and frustum of the shadow map, but for now i just want to draw shadows around the player position
      the_sun->direction is a normalized vector so i multiply it by a constant to get the position.
      player->pos is the camera position in world space
      the light projection matrix is calculated like this:
      mat4x4_ortho(lightProjMatrix,-SHADOW_FAR,SHADOW_FAR,-SHADOW_FAR,SHADOW_FAR,NEAR,SHADOW_FAR); Shadow vertex shader:
      uniform mat4 light_space_matrix; void main() { gl_Position = light_space_matrix * transfMatrix * vec4(position, 1.0f); } Shadow fragment shader:
      out float fragDepth; void main() { fragDepth = gl_FragCoord.z; } I am using deferred rendering so i have all my world positions in the g_positions buffer
      My shadow calculation in the deferred fragment shader:
      float get_shadow_fac(vec4 light_space_pos) { vec3 shadow_coords = light_space_pos.xyz / light_space_pos.w; shadow_coords = shadow_coords * 0.5 + 0.5; float closest_depth = texture(shadow_map, shadow_coords.xy).r; float current_depth = shadow_coords.z; float shadow_fac = 1.0; if(closest_depth < current_depth) shadow_fac = 0.5; return shadow_fac; } I call the function like this:
      get_shadow_fac(light_space_matrix * vec4(position,1.0)); Where position is the value i got from sampling the g_position buffer
      Here is my depth texture (i know it will produce low quality shadows but i just want to get it working for now):
      sorry because of the compression , the black smudges are trees ... https://i.stack.imgur.com/T43aK.jpg
      EDIT: Depth texture attachment:
      glTexImage2D(GL_TEXTURE_2D, 0,GL_DEPTH_COMPONENT24,fbo->width,fbo->height,0,GL_DEPTH_COMPONENT,GL_FLOAT,NULL); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE); glFramebufferTexture2D(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_TEXTURE_2D, fbo->depthTexture, 0);
  • Popular Now