Sign in to follow this  
Blips

OpenGL Possibly corrupt VBO/IBO?

Recommended Posts

I'm currently attempting to get vertex buffer objects to work with interleaved data for indexed triangles.

I've manually confirmed that both the index data and the actual vertex data is correct [i]prior[/i] to being loaded into their appropriate buffer objects. The array holding the index data is simply an array of unsigned shorts. The vertex array is an array of floats with the following format (with each bracket symbolizing a float):

[vect x][vect y][vect z] [texture u][texture v] [norm x][norm y][norm z] [r g b a]

In total, each vertex in array is a series of 9 floats. I have the following offsets and strides as:

[code]
newMesh.vertexOffset = 0;
newMesh.vertexStride = sizeof(GLfloat) * 6;
newMesh.uvOffset = sizeof(GLfloat) * 3;
newMesh.uvStride = sizeof(GLfloat) * 7;
newMesh.normalOffset = sizeof(GLfloat) * 5;
newMesh.normalStride = sizeof(GLfloat) * 6;
newMesh.colorOffset = sizeof(GLfloat) * 8;
newMesh.colorStride = sizeof(GLfloat) * 8;
[/code]

Here is where and how I create the buffer objects. I was originally using glMapBufferOES() but replaced it with a simpler solution in an attempt to find what is wrong. The arrays being passed into the objects are allocated dynamically, but I'm unsure if I should free them after having passed them to the buffer objects.

[code]
glGenBuffers(1, &vertexBufferID);
glBindBuffer(GL_ARRAY_BUFFER, vertexBufferID);
glBufferData(GL_ARRAY_BUFFER, vertexBufferSize, vertexBufferList, GL_DYNAMIC_DRAW);
glBindBuffer(GL_ARRAY_BUFFER, 0);

//creating index buffer object
glGenBuffers(1, &indexBufferID);
glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, indexBufferID);
glBufferData(GL_ELEMENT_ARRAY_BUFFER, indexBufferSize, indexBufferList, GL_STATIC_DRAW);
glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, 0);
[/code]

The buffer sizes have been checked and rechecked and are correct. And here is how I actually go about attempting to render the content. It's probably safe to ignore the texture code block but I included it just in case:

[code]
glPushMatrix();

glTranslatef(tempMeshInstance.x ,tempMeshInstance.y, tempMeshInstance.z);
glRotatef(tempMeshInstance.rotX, 1.0f, 0.0f, 0.0f);
glRotatef(tempMeshInstance.rotY, 0.0f, 1.0f, 0.0f);
glRotatef(tempMeshInstance.rotZ, 0.0f, 0.0f, 1.0f);
glScalef(tempMeshInstance.scaleX, tempMeshInstance.scaleY, tempMeshInstance.scaleZ);

//binding vertices
glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, tempMeshInstance.meshPtr.indexBufferID);
//binding vertex buffer objects
glBindBuffer(GL_ARRAY_BUFFER, tempMeshInstance.meshPtr.vertexBufferID);
//passing the mesh instance data to OpenGL
glMaterialfv(GL_BACK, GL_AMBIENT_AND_DIFFUSE, tempMeshInstance.material);
glVertexPointer(3, GL_FLOAT, tempMeshInstance.meshPtr.vertexStride, ((char *)NULL + (tempMeshInstance.meshPtr.vertexOffset)));
glTexCoordPointer(2, GL_FLOAT, tempMeshInstance.meshPtr.uvStride, ((char *)NULL + (tempMeshInstance.meshPtr.uvOffset)));
glNormalPointer(GL_FLOAT, tempMeshInstance.meshPtr.normalStride, ((char *)NULL + (tempMeshInstance.meshPtr.normalOffset)));
glColorPointer(4, GL_UNSIGNED_BYTE, tempMeshInstance.meshPtr.colorStride, ((char *)NULL + (tempMeshInstance.meshPtr.colorOffset)));

//working with textures
if (tempMeshInstance.meshPtr.textureID != prevTextureID && tempMeshInstance.meshPtr.textureID != 0) {
glBindTexture(GL_TEXTURE_2D, tempMeshInstance.meshPtr.textureID);
//if 2d texturing is disabled, renable it
if (!glIsEnabled(GL_TEXTURE_2D))
glEnable(GL_TEXTURE_2D);
} else if (tempMeshInstance.meshPtr.textureID == 0 && glIsEnabled(GL_TEXTURE_2D))
glDisable(GL_TEXTURE_2D);
prevTextureID = tempMeshInstance.meshPtr.textureID;

//rendering the mesh instance
glDrawElements(tempMeshInstance.meshPtr.renderFormat, tempMeshInstance.meshPtr.indices, GL_UNSIGNED_SHORT, ((char *)NULL + (0)));
//popping the matrix off the stack
glPopMatrix();

//continuing through list
gameObjs = gameObjs.nextNode;
glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, 0);
glBindBuffer(GL_ARRAY_BUFFER, 0);
[/code]

And this is the lovely rendering I'm rewarded with:

[img]http://img204.imageshack.us/img204/7107/img0019o.png[/img]

Which looks nothing like what the actual object used to look like. So in summary, I don't know if the buffer objects are somehow becoming corrupted, or if I'm incorrectly using the buffer objects (strides and offsets?), or if I'm incorrectly creating the buffer objects, but something is clearly wrong.

And clues or hints as to what may be causing this would be more than welcome!

Share this post


Link to post
Share on other sites
"Stride' should be the same.for each attribite; the size of a whole vertex (sizeof(float) *9 in your case.

Also, how are you counting RGBA as one float?

Share this post


Link to post
Share on other sites
[quote name='johnchapman' timestamp='1312954903' post='4847047']
"Stride' should be the same.for each attribite; the size of a whole vertex (sizeof(float) *9 in your case.

Also, how are you counting RGBA as one float?
[/quote]

Oh I thought stride was spacing in bytes between two like components (so the bytes between two repetitions of normal data for example). I tried treating the one float for the RGBA data as 4 separate bytes, and hoped that OpenGL would be able to work with it given I've specified color to be unsigned bytes. There's a good chance I'll have to change it I'm guessing though.

I'll try making your suggested changes.

Share this post


Link to post
Share on other sites
[quote name='Blips' timestamp='1312958072' post='4847054']Oh I thought stride was spacing in bytes between two like components (so the bytes between two repetitions of normal data for example).[/quote]

It is, but your understanding of the effect that has on your params seem to be incorrect. If you think about it, the normal data will be at the same offset for each vertex (in fact every component of the vertex will be at the same offset for each vertex - position at 0, texcoords at 12, etc) so the difference between two vertexes will always be the size of your vertex struct.

[quote name='Blips' timestamp='1312958072' post='4847054']I tried treating the one float for the RGBA data as 4 separate bytes, and hoped that OpenGL would be able to work with it given I've specified color to be unsigned bytes. There's a good chance I'll have to change it I'm guessing though.

I'll try making your suggested changes.[/quote]

I'd suggest not trying anything fancy when you're getting something new working for the first time. Do it the slow/more storage/predictable way instead. There's too much going on in this code and you need to be able to isolate errors to specific causes.

Share this post


Link to post
Share on other sites
[quote name='mhagain' timestamp='1312968409' post='4847089']
[quote name='Blips' timestamp='1312958072' post='4847054']Oh I thought stride was spacing in bytes between two like components (so the bytes between two repetitions of normal data for example).[/quote]

It is, but your understanding of the effect that has on your params seem to be incorrect. If you think about it, the normal data will be at the same offset for each vertex (in fact every component of the vertex will be at the same offset for each vertex - position at 0, texcoords at 12, etc) so the difference between two vertexes will always be the size of your vertex struct.
[/quote]
Just clarifying here, because the word "between" is often the source of the confusion when misunderstanding the stride. The stride is [i]the distance from the start of one attribute to the start of the next consecutive entry[/i], not the "empty" space between two consecutive attributes (which would be from the end of one to the beginning of the next). If you have a tightly packed array of an interleaved vertex structure, the stride for all attributes is, as mhagain said, simply the size of the vertex itself; no need for fancy calculations with the individual attributes.

Share this post


Link to post
Share on other sites
[quote name='Brother Bob' timestamp='1312969390' post='4847094']Just clarifying here, because the word "between" is often the source of the confusion when misunderstanding the stride. The stride is [i]the distance from the start of one attribute to the start of the next consecutive entry[/i], not the "empty" space between two consecutive attributes (which would be from the end of one to the beginning of the next). If you have a tightly packed array of an interleaved vertex structure, the stride for all attributes is, as mhagain said, simply the size of the vertex itself; no need for fancy calculations with the individual attributes.[/quote]

Said it better than I did.

It's actually easier if you use a struct for your vertexes rather than a float array - you'll see the layout in your code clearer, reduces potential for error, offsets are just a small bit of pointer arithmetic, and you can use sizeof (mystruct) for your stride param.

Share this post


Link to post
Share on other sites
[quote name='mhagain' timestamp='1312991821' post='4847194']
[quote name='Brother Bob' timestamp='1312969390' post='4847094']Just clarifying here, because the word "between" is often the source of the confusion when misunderstanding the stride. The stride is [i]the distance from the start of one attribute to the start of the next consecutive entry[/i], not the "empty" space between two consecutive attributes (which would be from the end of one to the beginning of the next). If you have a tightly packed array of an interleaved vertex structure, the stride for all attributes is, as mhagain said, simply the size of the vertex itself; no need for fancy calculations with the individual attributes.[/quote]

Said it better than I did.

It's actually easier if you use a struct for your vertexes rather than a float array - you'll see the layout in your code clearer, reduces potential for error, offsets are just a small bit of pointer arithmetic, and you can use sizeof (mystruct) for your stride param.
[/quote]

Yeah I'm already working on changing the small program I wrote converting Wavefront files to binary files to use structs rather than an array of floats. Then I'll do the same changes to the actual game!

Thanks guys for help and clarification. It's really appreciated.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Forum Statistics

    • Total Topics
      627752
    • Total Posts
      2978928
  • Similar Content

    • By DelicateTreeFrog
      Hello! As an exercise for delving into modern OpenGL, I'm creating a simple .obj renderer. I want to support things like varying degrees of specularity, geometry opacity, things like that, on a per-material basis. Different materials can also have different textures. Basic .obj necessities. I've done this in old school OpenGL, but modern OpenGL has its own thing going on, and I'd like to conform as closely to the standards as possible so as to keep the program running correctly, and I'm hoping to avoid picking up bad habits this early on.
      Reading around on the OpenGL Wiki, one tip in particular really stands out to me on this page:
      For something like a renderer for .obj files, this sort of thing seems almost ideal, but according to the wiki, it's a bad idea. Interesting to note!
      So, here's what the plan is so far as far as loading goes:
      Set up a type for materials so that materials can be created and destroyed. They will contain things like diffuse color, diffuse texture, geometry opacity, and so on, for each material in the .mtl file. Since .obj files are conveniently split up by material, I can load different groups of vertices/normals/UVs and triangles into different blocks of data for different models. When it comes to the rendering, I get a bit lost. I can either:
      Between drawing triangle groups, call glUseProgram to use a different shader for that particular geometry (so a unique shader just for the material that is shared by this triangle group). or
      Between drawing triangle groups, call glUniform a few times to adjust different parameters within the "master shader", such as specularity, diffuse color, and geometry opacity. In both cases, I still have to call glBindTexture between drawing triangle groups in order to bind the diffuse texture used by the material, so there doesn't seem to be a way around having the CPU do *something* during the rendering process instead of letting the GPU do everything all at once.
      The second option here seems less cluttered, however. There are less shaders to keep up with while one "master shader" handles it all. I don't have to duplicate any code or compile multiple shaders. Arguably, I could always have the shader program for each material be embedded in the material itself, and be auto-generated upon loading the material from the .mtl file. But this still leads to constantly calling glUseProgram, much more than is probably necessary in order to properly render the .obj. There seem to be a number of differing opinions on if it's okay to use hundreds of shaders or if it's best to just use tens of shaders.
      So, ultimately, what is the "right" way to do this? Does using a "master shader" (or a few variants of one) bog down the system compared to using hundreds of shader programs each dedicated to their own corresponding materials? Keeping in mind that the "master shaders" would have to track these additional uniforms and potentially have numerous branches of ifs, it may be possible that the ifs will lead to additional and unnecessary processing. But would that more expensive than constantly calling glUseProgram to switch shaders, or storing the shaders to begin with?
      With all these angles to consider, it's difficult to come to a conclusion. Both possible methods work, and both seem rather convenient for their own reasons, but which is the most performant? Please help this beginner/dummy understand. Thank you!
    • By JJCDeveloper
      I want to make professional java 3d game with server program and database,packet handling for multiplayer and client-server communicating,maps rendering,models,and stuffs Which aspect of java can I learn and where can I learn java Lwjgl OpenGL rendering Like minecraft and world of tanks
    • By AyeRonTarpas
      A friend of mine and I are making a 2D game engine as a learning experience and to hopefully build upon the experience in the long run.

      -What I'm using:
          C++;. Since im learning this language while in college and its one of the popular language to make games with why not.     Visual Studios; Im using a windows so yea.     SDL or GLFW; was thinking about SDL since i do some research on it where it is catching my interest but i hear SDL is a huge package compared to GLFW, so i may do GLFW to start with as learning since i may get overwhelmed with SDL.  
      -Questions
      Knowing what we want in the engine what should our main focus be in terms of learning. File managements, with headers, functions ect. How can i properly manage files with out confusing myself and my friend when sharing code. Alternative to Visual studios: My friend has a mac and cant properly use Vis studios, is there another alternative to it?  
    • By ferreiradaselva
      Both functions are available since 3.0, and I'm currently using `glMapBuffer()`, which works fine.
      But, I was wondering if anyone has experienced advantage in using `glMapBufferRange()`, which allows to specify the range of the mapped buffer. Could this be only a safety measure or does it improve performance?
      Note: I'm not asking about glBufferSubData()/glBufferData. Those two are irrelevant in this case.
    • By xhcao
      Before using void glBindImageTexture(    GLuint unit, GLuint texture, GLint level, GLboolean layered, GLint layer, GLenum access, GLenum format), does need to make sure that texture is completeness. 
  • Popular Now