Sign in to follow this  
L. Spiro

OpenGL Normal-Mapping Woes

Recommended Posts

This is my shader:

float mix( in float _fX, in float _fY, in float _fA ) { return _fX + _fA * (_fY - _fX); }
float2 mix( in float2 _fX, in float2 _fY, in float _fA ) { return _fX + _fA * (_fY - _fX); }
float3 mix( in float3 _fX, in float3 _fY, in float _fA ) { return _fX + _fA * (_fY - _fX); }
float4 mix( in float4 _fX, in float4 _fY, in float _fA ) { return _fX + _fA * (_fY - _fX); }
float2 mix( in float2 _fX, in float2 _fY, in float2 _fA ) { return _fX + _fA * (_fY - _fX); }
float3 mix( in float3 _fX, in float3 _fY, in float3 _fA ) { return _fX + _fA * (_fY - _fX); }
float4 mix( in float4 _fX, in float4 _fY, in float4 _fA ) { return _fX + _fA * (_fY - _fX); }

matrix<float, 4, 4> g_mViewMatrix;
matrix<float, 3, 3> g_mNormalMatrix;
vector<float, 4> g_vDiffuseMaterial;
vector<float, 4> g_vAmbientMaterial;
vector<float, 4> g_vEmissiveMaterial;
vector<float, 4> g_vSpecularMaterial;
float g_fPower;
int g_iTotalDirLights;
int g_iTotalPointLights;
vector<float, 4> g_vLightVectors[8];
vector<float, 4> g_vLightHalfVectors[8];
vector<float, 4> g_vLightAmbients[8];
vector<float, 4> g_vLightDiffuses[8];
vector<float, 4> g_vLightSpeculars[8];
vector<float, 4> g_vLightAttens[8];
vector<float, 4> g_vLightRanges[8];
vector<float, 3> g_vSpotLightDirs[8];
vector<float, 4> g_vSkyColor;
vector<float, 4> g_vGroundColor;
sampler2D g_sSampler2dTex0;
sampler2D g_sSampler2dTex1;
sampler2D g_sSampler2dTex2;
sampler2D g_sSampler2dTex3;
sampler2D g_sSampler2dTex4;
sampler2D g_sSampler2dTex5;
sampler2D g_sSampler2dTex6;
sampler2D g_sSampler2dTex7;

vector<float, 4> cDiffuse;
vector<float, 4> cSpecular;

LSE_COLOR_PAIR GetDirLightColors(vector<float, 3> _vNormalInViewSpace, vector<float, 4> _vPosVector, int _iIndex){
// Removed to save space.

void Main(in vector<float, 2> _vIn2dTex0:TEXCOORD2, in vector<float, 3> _vInNormal:NORMAL0, in vector<float, 3> _vInTangent:TANGENT1, in vector<float, 3> _vInBiNormal:BINORMAL1, in vector<float, 4> _vInPos:POSITION0, in vector<float, 4> _vInEyePos:TEXCOORD1, out vector<float, 4> _vOutColor:COLOR0){
// Determine the normal. Read from the normal map and offset the input normal by that amount.
vector<float, 3> vNormalizedNormal = tex2D(g_sSampler2dTex1, _vIn2dTex0).xyz;
vNormalizedNormal = ((vNormalizedNormal*2.0)-1.0);
vNormalizedNormal = normalize(((normalize(_vInNormal) + (vNormalizedNormal.x*_vInTangent)) + (vNormalizedNormal.y*_vInBiNormal)));

// For calculating the specular component of lighting.
vector<float, 4> vViewPosToEye = -normalize(_vInEyePos);

LSE_COLOR_PAIR cpLightColors = {
vector<float, 4>(0.0, 0.0, 0.0, 0.0),
vector<float, 4>(0.0, 0.0, 0.0, 0.0)
for(int I = 0; I < g_iTotalDirLights; I++) {
LSE_COLOR_PAIR cpThis = GetDirLightColors(vNormalizedNormal, vViewPosToEye, I);
cpLightColors.cDiffuse += cpThis.cDiffuse;
cpLightColors.cSpecular += cpThis.cSpecular;

// Apply hemisphere ambient lighting.
vector<float, 3> vUp = mul(g_mViewMatrix, vector<float, 4>(0.0, 1.0, 0.0, 0.0)).xyz; += mix(,, ((dot(vUp, vNormalizedNormal) * 0.5) + 0.5));

// Sample the diffuse color from the texture.
_vOutColor = vector<float, 4>(tex2D(g_sSampler2dTex0, _vIn2dTex0).xyz, g_vDiffuseMaterial.w); *=;

// Apply lighting. = (( * + (g_vSpecularMaterial*cpLightColors.cSpecular).xyz);

In this form it produces this incorrect result:

This is how it should look:

The good image is taken from the OpenGL version of my engine, which uses exactly the same shader for rendering (but translated to GLSL, not HLSL). For the nay-sayers, here is the GLSL version of the exact same shader:

#version 130
precision mediump float;
out vec4 _vOutColor;
in vec4 LSG_VERT_OUT_PIXEL_IN_369_1/*_vInEyePos*/;
in vec4 LSG_VERT_OUT_PIXEL_IN_365_0/*_vInPos*/;
in vec3 LSG_VERT_OUT_PIXEL_IN_360_1/*_vInBiNormal*/;
in vec3 LSG_VERT_OUT_PIXEL_IN_368_1/*_vInTangent*/;
in vec3 LSG_VERT_OUT_PIXEL_IN_364_0/*_vInNormal*/;
in vec2 LSG_VERT_OUT_PIXEL_IN_369_2/*_vIn2dTex0*/;

uniform mat4x4 g_mViewMatrix;
uniform mat3x3 g_mNormalMatrix;
uniform vec4 g_vDiffuseMaterial;
uniform vec4 g_vAmbientMaterial;
uniform vec4 g_vEmissiveMaterial;
uniform vec4 g_vSpecularMaterial;
uniform float g_fPower;
uniform int g_iTotalDirLights;
uniform int g_iTotalPointLights;
uniform vec4 g_vLightVectors[8];
uniform vec4 g_vLightHalfVectors[8];
uniform vec4 g_vLightAmbients[8];
uniform vec4 g_vLightDiffuses[8];
uniform vec4 g_vLightSpeculars[8];
uniform vec4 g_vLightAttens[8];
uniform vec4 g_vLightRanges[8];
uniform vec3 g_vSpotLightDirs[8];
uniform vec4 g_vSkyColor;
uniform vec4 g_vGroundColor;
uniform sampler2D g_sSampler2dTex0;
uniform sampler2D g_sSampler2dTex1;
uniform sampler2D g_sSampler2dTex2;
uniform sampler2D g_sSampler2dTex3;
uniform sampler2D g_sSampler2dTex4;
uniform sampler2D g_sSampler2dTex5;
uniform sampler2D g_sSampler2dTex6;
uniform sampler2D g_sSampler2dTex7;

vec4 cDiffuse;
vec4 cSpecular;

LSE_COLOR_PAIR GetDirLightColors(in vec3 _vNormalInViewSpace, in vec4 _vPosVector, in int _iIndex){
// Removed to save space.

void main(){
// Determine the normal. Read from the normal map and offset the input normal by that amount.
vec3 vNormalizedNormal = vec3(texture(g_sSampler2dTex1, LSG_VERT_OUT_PIXEL_IN_369_2/*_vIn2dTex0*/).xyz);
vNormalizedNormal = ((vNormalizedNormal*2.0)-1.0);
vNormalizedNormal = normalize(((normalize(LSG_VERT_OUT_PIXEL_IN_364_0/*_vInNormal*/) + (vNormalizedNormal.x*LSG_VERT_OUT_PIXEL_IN_368_1/*_vInTangent*/)) + (vNormalizedNormal.y*LSG_VERT_OUT_PIXEL_IN_360_1/*_vInBiNormal*/)));

// For calculating the specular component of lighting.
vec4 vViewPosToEye = vec4(-normalize(LSG_VERT_OUT_PIXEL_IN_369_1/*_vInEyePos*/));

LSE_COLOR_PAIR cpLightColors = LSE_COLOR_PAIR( vec4(0.0, 0.0, 0.0, 0.0), vec4(0.0, 0.0, 0.0, 0.0) );

for(int I = 0; I < g_iTotalDirLights; I++){
LSE_COLOR_PAIR cpThis = GetDirLightColors(vNormalizedNormal, vViewPosToEye, I);
cpLightColors.cDiffuse += cpThis.cDiffuse;
cpLightColors.cSpecular += cpThis.cSpecular;

// Apply hemisphere ambient lighting.
vec3 vUp = vec3(((g_mViewMatrix) * (vec4(0.0, 1.0, 0.0, 0.0))).xyz); += mix(,, ((dot(vUp, vNormalizedNormal) * 0.5) + 0.5));

// Sample the diffuse color from the texture.
_vOutColor = vec4(texture(g_sSampler2dTex0, LSG_VERT_OUT_PIXEL_IN_369_2/*_vIn2dTex0*/).xyz, g_vDiffuseMaterial.w); *=;

// Apply lighting. = (( * + (g_vSpecularMaterial*cpLightColors.cSpecular).xyz);

So indeed the shaders match in logic exactly.
So I checked my inputs.
I exported all of my OpenGL vertex buffers and then added some temporary code to load them into the Direct3D 9 vertex buffers, which ensured that the two sets of vertex buffers were all exactly alike. The result was the same.

So I changed the out color to show me tangents, binormals, input normals, everything.
Input normals matched but the tangent and binormal were wrong.

This is how I transform the tangent (and likewise with the binormal) in the vertex shader:
[code]_vOutTangent = normalize(mul(g_mNormalMatrix, _vInTangent));[/code] HLSL
[code]LSG_VERT_OUT_PIXEL_IN_360_1/*_vOutBiNormal*/ = normalize(((g_mNormalMatrix) * (_vInBiNormal)));[/code] GLSL
If I change it to this:
[code]_vOutTangent = _vInTangent;[/code]
…and then change the output color in the pixel shader to the tangent value, the result is the same in both HLSL and GLSL. That means initially the input is the same. The data coming in from the vertex buffers is fine. It gets lost when transformed.

The input normals are transformed the same way, and they are always a match between GLSL and HLSL.
Of course, the order of my matrix multiplication is correct, or else I would never be able to get vertices, normals, etc. to match between them.
I have tried transposing the matrices before transforming the tangent and binormal, and also reversing the order of the multiply. The result is the same.

Any ideas?
Yogurt Emperor

Made the code more readable for those among us who may be human.

Share this post

Link to post
Share on other sites
The code for both languages is generated from LSSL (L. Spiro Shader Language).
So whitespace and comments were stripped. I added back some of it for posting here (and removed all of the #line directives).

So that is the reason for the lack of whitespace and comments.
I will edit a bit more into the code.

Yogurt Emperor

Share this post

Link to post
Share on other sites
Just posting the solution here in case it can help someone else.

This problem went away when I aligned my vertex buffer elements to every 32 bytes.
By changing only the stride of each element, this bug has gone away. Most likely this is a Direct3D bug.

L. Spiro

Share this post

Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Announcements

  • Forum Statistics

    • Total Topics
    • Total Posts
  • Similar Content

    • By test opty
      Hi all,
      I'm starting OpenGL using a tut on the Web. But at this point I would like to know the primitives needed for creating a window using OpenGL. So on Windows and using MS VS 2017, what is the simplest code required to render a window with the title of "First Rectangle", please?
    • By DejayHextrix
      Hi, New here. 
      I need some help. My fiance and I like to play this mobile game online that goes by real time. Her and I are always working but when we have free time we like to play this game. We don't always got time throughout the day to Queue Buildings, troops, Upgrades....etc.... 
      I was told to look into DLL Injection and OpenGL/DirectX Hooking. Is this true? Is this what I need to learn? 
      How do I read the Android files, or modify the files, or get the in-game tags/variables for the game I want? 
      Any assistance on this would be most appreciated. I been everywhere and seems no one knows or is to lazy to help me out. It would be nice to have assistance for once. I don't know what I need to learn. 
      So links of topics I need to learn within the comment section would be SOOOOO.....Helpful. Anything to just get me started. 
      Dejay Hextrix 
    • By mellinoe
      Hi all,
      First time poster here, although I've been reading posts here for quite a while. This place has been invaluable for learning graphics programming -- thanks for a great resource!
      Right now, I'm working on a graphics abstraction layer for .NET which supports D3D11, Vulkan, and OpenGL at the moment. I have implemented most of my planned features already, and things are working well. Some remaining features that I am planning are Compute Shaders, and some flavor of read-write shader resources. At the moment, my shaders can just get simple read-only access to a uniform (or constant) buffer, a texture, or a sampler. Unfortunately, I'm having a tough time grasping the distinctions between all of the different kinds of read-write resources that are available. In D3D alone, there seem to be 5 or 6 different kinds of resources with similar but different characteristics. On top of that, I get the impression that some of them are more or less "obsoleted" by the newer kinds, and don't have much of a place in modern code. There seem to be a few pivots:
      The data source/destination (buffer or texture) Read-write or read-only Structured or unstructured (?) Ordered vs unordered (?) These are just my observations based on a lot of MSDN and OpenGL doc reading. For my library, I'm not interested in exposing every possibility to the user -- just trying to find a good "middle-ground" that can be represented cleanly across API's which is good enough for common scenarios.
      Can anyone give a sort of "overview" of the different options, and perhaps compare/contrast the concepts between Direct3D, OpenGL, and Vulkan? I'd also be very interested in hearing how other folks have abstracted these concepts in their libraries.
    • By aejt
      I recently started getting into graphics programming (2nd try, first try was many years ago) and I'm working on a 3d rendering engine which I hope to be able to make a 3D game with sooner or later. I have plenty of C++ experience, but not a lot when it comes to graphics, and while it's definitely going much better this time, I'm having trouble figuring out how assets are usually handled by engines.
      I'm not having trouble with handling the GPU resources, but more so with how the resources should be defined and used in the system (materials, models, etc).
      This is my plan now, I've implemented most of it except for the XML parts and factories and those are the ones I'm not sure of at all:
      I have these classes:
      For GPU resources:
      Geometry: holds and manages everything needed to render a geometry: VAO, VBO, EBO. Texture: holds and manages a texture which is loaded into the GPU. Shader: holds and manages a shader which is loaded into the GPU. For assets relying on GPU resources:
      Material: holds a shader resource, multiple texture resources, as well as uniform settings. Mesh: holds a geometry and a material. Model: holds multiple meshes, possibly in a tree structure to more easily support skinning later on? For handling GPU resources:
      ResourceCache<T>: T can be any resource loaded into the GPU. It owns these resources and only hands out handles to them on request (currently string identifiers are used when requesting handles, but all resources are stored in a vector and each handle only contains resource's index in that vector) Resource<T>: The handles given out from ResourceCache. The handles are reference counted and to get the underlying resource you simply deference like with pointers (*handle).  
      And my plan is to define everything into these XML documents to abstract away files:
      Resources.xml for ref-counted GPU resources (geometry, shaders, textures) Resources are assigned names/ids and resource files, and possibly some attributes (what vertex attributes does this geometry have? what vertex attributes does this shader expect? what uniforms does this shader use? and so on) Are reference counted using ResourceCache<T> Assets.xml for assets using the GPU resources (materials, meshes, models) Assets are not reference counted, but they hold handles to ref-counted resources. References the resources defined in Resources.xml by names/ids. The XMLs are loaded into some structure in memory which is then used for loading the resources/assets using factory classes:
      Factory classes for resources:
      For example, a texture factory could contain the texture definitions from the XML containing data about textures in the game, as well as a cache containing all loaded textures. This means it has mappings from each name/id to a file and when asked to load a texture with a name/id, it can look up its path and use a "BinaryLoader" to either load the file and create the resource directly, or asynchronously load the file's data into a queue which then can be read from later to create the resources synchronously in the GL context. These factories only return handles.
      Factory classes for assets:
      Much like for resources, these classes contain the definitions for the assets they can load. For example, with the definition the MaterialFactory will know which shader, textures and possibly uniform a certain material has, and with the help of TextureFactory and ShaderFactory, it can retrieve handles to the resources it needs (Shader + Textures), setup itself from XML data (uniform values), and return a created instance of requested material. These factories return actual instances, not handles (but the instances contain handles).
      Is this a good or commonly used approach? Is this going to bite me in the ass later on? Are there other more preferable approaches? Is this outside of the scope of a 3d renderer and should be on the engine side? I'd love to receive and kind of advice or suggestions!
    • By nedondev
      I 'm learning how to create game by using opengl with c/c++ coding, so here is my fist game. In video description also have game contain in Dropbox. May be I will make it better in future.
  • Popular Now