Sign in to follow this  
Tordin

DX11 [DX11]Defferd Rendering

Recommended Posts

Hello!

Im working with Defferd rendering and i stumbeld on a wierd problem.

When i am using my own engine i cant get defferd rendering to work, EA, i cant seem to calulate the values right.
and i dont know in which end it could be lying it.

First tought was that i dident send the values to the shader correct. i lookt at pix and it told me that i acctualy did.
Then i tought it was somthing with my equation, and no, it´s not, i have calulated it over ten times.
Then i tought maybe it got somthing to do with my G-Buffer? and here is where i am right now.
when i did this the last time i saved the postion in world space, thats what im doing right now. but i still get wierd values.
Unforunelty i cant debug the pixel in PIX since it crashes every time i try to debug something there... o_O

When i am using another engine i get it working right away...

So internetZ, do you have any advice or clues?

Share this post


Link to post
Share on other sites
If you render the GBuffer outputs to the screen (or save them to file), do you see anything wrong with them? Try posting your code or render output here... someone might catch the bug.

Share this post


Link to post
Share on other sites
true true!

Here is the code for rendering the G buffer
[source]

VS_OUTPUT VS_NormalMapped( VS_INPUT IN )
{
VS_OUTPUT OUT;

float4 viewPos = mul(IN.imWorld,float4(IN.Position.xyz,1.0));
OUT.Position = viewPos;
OUT.Normal = IN.Normal;
OUT.UV = IN.UV;
viewPos = mul(g_MatrixView,viewPos);
OUT.Depth = abs((viewPos.z - 0.1f) / ( 128.0f - 0.1f));

return OUT;
}


//////////////////////////////////////////////////////////////////////////
//HULL & DOMAIN SHADERS
///////////////////////////////////////////////////////////////////////////

HS_CONSTANT_DATA_OUTPUT ConstantHS( InputPatch<VS_OUTPUT, 3> ip,uint PatchID : SV_PrimitiveID )
{
HS_CONSTANT_DATA_OUTPUT Output;
float2 UV = (ip[0].UV + ip[1].UV + ip[2].UV) / 3;
float TessFac = 1;
Output.Edges[0] = Output.Edges[1] = Output.Edges[2] = TessFac;
Output.Inside = TessFac;
return Output;
}

[domain("tri")]
[partitioning("fractional_odd")]
[outputtopology("triangle_cw")]
[outputcontrolpoints(3)]
[patchconstantfunc("ConstantHS")]
HS_OUTPUT HS( InputPatch<VS_OUTPUT, 3> IN,uint i : SV_OutputControlPointID,
uint PatchID : SV_PrimitiveID )
{
HS_OUTPUT OUT;
OUT.Position = IN[i].Position;
OUT.Normal = IN[i].Normal;
OUT.UV = IN[i].UV;
OUT.Depth = IN[i].Depth;
return OUT;

}

[domain("tri")]
DS_OUTPUT DS( HS_CONSTANT_DATA_OUTPUT input,float3 UV : SV_DomainLocation,const OutputPatch<HS_OUTPUT, 3> quad )
{
DS_OUTPUT Output;
//Calculate the new position
float time = 0.0f;
float3 finalPos = ( UV.x * quad[0].Position + UV.y * quad[1].Position + UV.z * quad[2].Position );
float finalDepth = ( UV.x * quad[0].Depth + UV.y * quad[1].Depth + UV.z * quad[2].Depth );
float3 finalNormal = ( UV.x * quad[0].Normal + UV.y * quad[1].Normal + UV.z * quad[2].Normal );
float3 normal = normalize(finalNormal);
float2 uv = ( UV.x * quad[0].UV + UV.y * quad[1].UV + UV.z * quad[2].UV );
float4 dis = color.SampleLevel(SamplerStateAnisoWrap, uv + time, 1);

//finalPos = finalPos + (normal * df);
Output.Position = mul( g_MatrixViewProj, float4(finalPos,1.0) );
Output.UV = uv;
Output.Normal = normal;
Output.Depth = finalDepth;
return Output;
}


PS_OUTPUT PS_NormalMapped( VS_OUTPUT IN )
{
PS_OUTPUT OUT;
float4 TexColor = color.Sample( SamplerStateAnisoWrap, IN.UV );
float3 Color = TexColor.rgb;

OUT.Color = float4( Color, 1.0 );
OUT.Depth = float4( IN.Depth,0.0,0.0,0.0 );
OUT.Pos = IN.Position;
OUT.Normal = float4(IN.Normal,1.0);

return OUT;
}
[/source]

Share this post


Link to post
Share on other sites
One more thing... can you explain in detail what the problem is? Showing a screenshot of desired output versus your engine's output will help (since you said you can get it working on other engines).

Share this post


Link to post
Share on other sites
[quote name='gsamour' timestamp='1313968308' post='4852045']
One more thing... can you explain in detail what the problem is? Showing a screenshot of desired output versus your engine's output will help (since you said you can get it working on other engines).
[/quote]

I gona explain the problem in code ;)

[source]

PS_OUTPUT PS_MAIN(VS_OUTPUT IN)
{
PS_OUTPUT OUT;
float3 texColor = tex0.Sample(SamplerStateAnisoWrap, IN.UV).xyz;
float3 texPosition = tex2.Sample(SamplerStateAnisoWrap, IN.UV).xyz;
float3 texNormal = tex3.Sample(SamplerStateAnisoWrap, IN.UV).xyz;
float3 color = texColor * 0.2;
for(int i = 0; i<g_NumLights; ++i)
{
float3 lightPos = g_LightPos[i];
float3 vec = texPosition - lightPos;
float vecLength = dot(vec,vec);
float intensity = 1.0 - saturate(vecLength / (g_LightRange[i] * g_LightRange[i]) );
color += texColor * intensity;
}
OUT.Color = float4(color,1.0);
return OUT;
}
[/source]

intensity will become zero.
And here is an explanation behind the entire equation.

1 : Get the postion from the texture
2 : Get the position from the light.
3 : Get a direction vector
4 : Get the length^2
5 : divide the length^2 by the max range^2 (of the light) (then we will get a value from 0->1 if the light is in range and 1->inf if the light is out of range)
6 : saturate this value so it rages from 0->1
7 : subtract one to get the less values futher away.
8 : add the color multiplyed by the intesity we calculated.

And this works for the other engine..

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Announcements

  • Forum Statistics

    • Total Topics
      628314
    • Total Posts
      2982022
  • Similar Content

    • By GreenGodDiary
      SOLVED: I had written 
      Dispatch(32, 24, 0) instead of
      Dispatch(32, 24, 1)  
       
      I'm attempting to implement some basic post-processing in my "engine" and the HLSL part of the Compute Shader and such I think I've understood, however I'm at a loss at how to actually get/use it's output for rendering to the screen.
      Assume I'm doing something to a UAV in my CS:
      RWTexture2D<float4> InputOutputMap : register(u0); I want that texture to essentially "be" the backbuffer.
       
      I'm pretty certain I'm doing something wrong when I create the views (what I think I'm doing is having the backbuffer be bound as render target aswell as UAV and then using it in my CS):
       
      DXGI_SWAP_CHAIN_DESC scd; ZeroMemory(&scd, sizeof(DXGI_SWAP_CHAIN_DESC)); scd.BufferCount = 1; scd.BufferDesc.Format = DXGI_FORMAT_R8G8B8A8_UNORM; scd.BufferUsage = DXGI_USAGE_RENDER_TARGET_OUTPUT | DXGI_USAGE_SHADER_INPUT | DXGI_USAGE_UNORDERED_ACCESS; scd.OutputWindow = wndHandle; scd.SampleDesc.Count = 1; scd.Windowed = TRUE; HRESULT hr = D3D11CreateDeviceAndSwapChain(NULL, D3D_DRIVER_TYPE_HARDWARE, NULL, NULL, NULL, NULL, D3D11_SDK_VERSION, &scd, &gSwapChain, &gDevice, NULL, &gDeviceContext); // get the address of the back buffer ID3D11Texture2D* pBackBuffer = nullptr; gSwapChain->GetBuffer(0, __uuidof(ID3D11Texture2D), (LPVOID*)&pBackBuffer); // use the back buffer address to create the render target gDevice->CreateRenderTargetView(pBackBuffer, NULL, &gBackbufferRTV); // set the render target as the back buffer CreateDepthStencilBuffer(); gDeviceContext->OMSetRenderTargets(1, &gBackbufferRTV, depthStencilView); //UAV for compute shader D3D11_UNORDERED_ACCESS_VIEW_DESC uavd; ZeroMemory(&uavd, sizeof(uavd)); uavd.Format = DXGI_FORMAT_R8G8B8A8_UNORM; uavd.ViewDimension = D3D11_UAV_DIMENSION_TEXTURE2D; uavd.Texture2D.MipSlice = 1; gDevice->CreateUnorderedAccessView(pBackBuffer, &uavd, &gUAV); pBackBuffer->Release();  
      After I render the scene, I dispatch like this:
      gDeviceContext->OMSetRenderTargets(0, NULL, NULL); m_vShaders["cs1"]->Bind(); gDeviceContext->CSSetUnorderedAccessViews(0, 1, &gUAV, 0); gDeviceContext->Dispatch(32, 24, 0); //hard coded ID3D11UnorderedAccessView* nullview = { nullptr }; gDeviceContext->CSSetUnorderedAccessViews(0, 1, &nullview, 0); gDeviceContext->OMSetRenderTargets(1, &gBackbufferRTV, depthStencilView); gSwapChain->Present(0, 0); Worth noting is the scene is rendered as usual, but I dont get any results from the CS (simple gaussian blur)
      I'm sure it's something fairly basic I'm doing wrong, perhaps my understanding of render targets / views / what have you is just completely wrong and my approach just makes no sense.

      If someone with more experience could point me in the right direction I would really appreciate it!

      On a side note, I'd really like to learn more about this kind of stuff. I can really see the potential of the CS aswell as rendering to textures and using them for whatever in the engine so I would love it if you know some good resources I can read about this!

      Thank you <3
       
      P.S I excluded the .hlsl since I cant imagine that being the issue, but if you think you need it to help me just ask

      P:P:S. As you can see this is my first post however I do have another account, but I can't log in with it because gamedev.net just keeps asking me to accept terms and then logs me out when I do over and over
    • By mister345
      Does buffer number matter in ID3D11DeviceContext::PSSetConstantBuffers()? I added 5 or six constant buffers to my framework, and later realized I had set the buffer number parameter to either 0 or 1 in all of them - but they still all worked! Curious why that is, and should they be set up to correspond to the number of constant buffers?
      Similarly, inside the buffer structs used to pass info into the hlsl shader, I added padding inside the c++ struct to make a struct containing a float3 be 16 bytes, but in the declaration of the same struct inside the hlsl shader file, it was missing the padding value - and it still worked! Do they need to be consistent or not? Thanks.
          struct CameraBufferType
          {
              XMFLOAT3 cameraPosition;
              float padding;
          };
    • By noodleBowl
      I was wondering if anyone could explain the depth buffer and the depth stencil state comparison function to me as I'm a little confused
      So I have set up a depth stencil state where the DepthFunc is set to D3D11_COMPARISON_LESS, but what am I actually comparing here? What is actually written to the buffer, the pixel that should show up in the front?
      I have these 2 quad faces, a Red Face and a Blue Face. The Blue Face is further away from the Viewer with a Z index value of -100.0f. Where the Red Face is close to the Viewer with a Z index value of 0.0f.
      When DepthFunc is set to D3D11_COMPARISON_LESS the Red Face shows up in front of the Blue Face like it should based on the Z index values. BUT if I change the DepthFunc to D3D11_COMPARISON_LESS_EQUAL the Blue Face shows in front of the Red Face. Which does not make sense to me, I would think that when the function is set to D3D11_COMPARISON_LESS_EQUAL the Red Face would still show up in front of the Blue Face as the Z index for the Red Face is still closer to the viewer
      Am I thinking of this comparison function all wrong?
      Vertex data just in case
      //Vertex date that make up the 2 faces Vertex verts[] = { //Red face Vertex(Vector4(0.0f, 0.0f, 0.0f), Color(1.0f, 0.0f, 0.0f)), Vertex(Vector4(100.0f, 100.0f, 0.0f), Color(1.0f, 0.0f, 0.0f)), Vertex(Vector4(100.0f, 0.0f, 0.0f), Color(1.0f, 0.0f, 0.0f)), Vertex(Vector4(0.0f, 0.0f, 0.0f), Color(1.0f, 0.0f, 0.0f)), Vertex(Vector4(0.0f, 100.0f, 0.0f), Color(1.0f, 0.0f, 0.0f)), Vertex(Vector4(100.0f, 100.0f, 0.0f), Color(1.0f, 0.0f, 0.0f)), //Blue face Vertex(Vector4(0.0f, 0.0f, -100.0f), Color(0.0f, 0.0f, 1.0f)), Vertex(Vector4(100.0f, 100.0f, -100.0f), Color(0.0f, 0.0f, 1.0f)), Vertex(Vector4(100.0f, 0.0f, -100.0f), Color(0.0f, 0.0f, 1.0f)), Vertex(Vector4(0.0f, 0.0f, -100.0f), Color(0.0f, 0.0f, 1.0f)), Vertex(Vector4(0.0f, 100.0f, -100.0f), Color(0.0f, 0.0f, 1.0f)), Vertex(Vector4(100.0f, 100.0f, -100.0f), Color(0.0f, 0.0f, 1.0f)), };  
    • By mellinoe
      Hi all,
      First time poster here, although I've been reading posts here for quite a while. This place has been invaluable for learning graphics programming -- thanks for a great resource!
      Right now, I'm working on a graphics abstraction layer for .NET which supports D3D11, Vulkan, and OpenGL at the moment. I have implemented most of my planned features already, and things are working well. Some remaining features that I am planning are Compute Shaders, and some flavor of read-write shader resources. At the moment, my shaders can just get simple read-only access to a uniform (or constant) buffer, a texture, or a sampler. Unfortunately, I'm having a tough time grasping the distinctions between all of the different kinds of read-write resources that are available. In D3D alone, there seem to be 5 or 6 different kinds of resources with similar but different characteristics. On top of that, I get the impression that some of them are more or less "obsoleted" by the newer kinds, and don't have much of a place in modern code. There seem to be a few pivots:
      The data source/destination (buffer or texture) Read-write or read-only Structured or unstructured (?) Ordered vs unordered (?) These are just my observations based on a lot of MSDN and OpenGL doc reading. For my library, I'm not interested in exposing every possibility to the user -- just trying to find a good "middle-ground" that can be represented cleanly across API's which is good enough for common scenarios.
      Can anyone give a sort of "overview" of the different options, and perhaps compare/contrast the concepts between Direct3D, OpenGL, and Vulkan? I'd also be very interested in hearing how other folks have abstracted these concepts in their libraries.
    • By turanszkij
      If I do a buffer update with MAP_NO_OVERWRITE or MAP_DISCARD, can I just write to the buffer after I called Unmap() on the buffer? It seems to work fine for me (Nvidia driver), but is it actually legal to do so? I have a graphics device wrapper and I don't want to expose Map/Unmap, but just have a function like void* AllocateFromRingBuffer(GPUBuffer* buffer, uint size, uint& offset); This function would just call Map on the buffer, then Unmap immediately and then return the address of the buffer. It usually does a MAP_NO_OVERWRITE, but sometimes it is a WRITE_DISCARD (when the buffer wraps around). Previously I have been using it so that the function expected the data upfront and would copy to the buffer between Map/Unmap, but now I want to extend functionality of it so that it would just return an address to write to.
  • Popular Now