• Advertisement
Sign in to follow this  

OpenGL GLSL Shader Help on normals

This topic is 2350 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

I am a beginner in GLSL and a lot of the tutorials are now outdated which are making my life hell. I am attempting to add a simple Lambert light to my textured cube I have in a VBO. Inside this VBO I store the texture coords, vertices, indices, and normals. Everything shows up well enough on the screen, but now I want to put these normals to use with lighting. The old way seemed to use these methods in GLSL (normal = gl_NormalMatrix * gl_Normal;) however, these functions are now deprecated as I understand. Currently the cube I am rendering is too dark in some areas while rotating the cube. Does anyone think they understand the problem going on here is? I can post more code from my OpenGL app if required, here are the pics and the GLSL code.
Pictures of Cube Rotating

Vertex Shader.
#version 330

uniform mat4 viewMatrix, projectionMatrix, modelMatrix;

in vec4 in_Position;
in vec3 in_Normal;
in vec2 in_UV;

out vec2 vfTexcood;
out vec3 vfLightDirection;
out vec3 vfNormal;

void main()
gl_Position = (projectionMatrix * viewMatrix * modelMatrix) * in_Position;
vfTexcood = in_UV;
vec3 fvLightPosition = vec3(-100.0f, 100.0f, -100.0f);

vec4 objectPosition = modelMatrix * in_Position;
vfLightDirection = ( modelMatrix * vec4(fvLightPosition, 1)).xyz - objectPosition.xyz;

vfNormal = in_Normal;

Fragment Shader

#version 330

uniform sampler2D textureMap;
uniform sampler2D bumpMap;

in vec2 vfTexcood;
in vec3 vfLightDirection;
in vec3 vfNormal;

out vec4 out_Color;

void main()
float facingRatio = dot(normalize(vfNormal), normalize(vfLightDirection));

vec4 myColor = vec4(0.5f, 0.4f, 0.7f, 1.0f);

out_Color = texture2D( textureMap, vfTexcood) * facingRatio * myColor;

Share this post

Link to post
Share on other sites
You multiply the light by the modelview matrix (so the normal is relative to the viewer) but you dont do that with the normal (it is in world space).

Share this post

Link to post
Share on other sites
I understand, but how do you do this in GLSL? I have tried this..

vfNormal = in_Normal * mat3(modelMatrix);

but, I think the problem is that I am casting it down to mat3 and is messing it up. Do my normals need to be vec4 datatypes?

Also, what is the gl_NormalMatrix and gl_Normal anyway? I think it would help if I understood what data are in these.rolleyes.gif

Share this post

Link to post
Share on other sites
Heres an explanation of normal matrix:


If I remember correctly the normal matrix is the same as the model matrix, except if you do non-uniform scaling, then it has to do some correction or the normal will be incorrect. But you can review the link to be sure.

I think for vfNormal it should be "mat3(modelMatrix) * in_Normal", not the reverse like you have it.

Share this post

Link to post
Share on other sites
vfNormal = mat3(modelMatrix)*in_Normal;

just like your other calls. The vector is always on the right side.

gl_NormalMatrix and gl_Normal anyway? ------gl_Normal is just the input. So it is the raw data untransformed that you sent with your VBO. gl_NormalMatrix is basically the same as the modelview matrix.

Share this post

Link to post
Share on other sites
gl_NormalMatrix is technically the transposed inverse of the 3x3 part of the modelview matrix. So using the CML maths library to calculate it on the cpu before sending it to the shader:

[source lang="cpp"]
// (mv_matrix is the modelview matrix)

n_matrix = cml::matrix33f_c(
mv_matrix(0,0), mv_matrix(0,1), mv_matrix(0,2),
mv_matrix(1,0), mv_matrix(1,1), mv_matrix(1,2),
mv_matrix(2,0), mv_matrix(2,1), mv_matrix(2,2));

// send n_matrix to shader...

IMHO, it's better to do this properly to begin with instead of hacking it with the modelview matrix, so it won't suddenly break when you change something apparently unrelated later.

Share this post

Link to post
Share on other sites
Thank you all for your help and guidance. I have got it working! Now for my next step : a phong bumpmap shader.cool.gif

Share this post

Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Tags

  • Advertisement
  • Popular Now

  • Similar Content

    • By LifeArtist
      Good Evening,
      I want to make a 2D game which involves displaying some debug information. Especially for collision, enemy sights and so on ...
      First of I was thinking about all those shapes which I need will need for debugging purposes: circles, rectangles, lines, polygons.
      I am really stucked right now because of the fundamental question:
      Where do I store my vertices positions for each line (object)? Currently I am not using a model matrix because I am using orthographic projection and set the final position within the VBO. That means that if I add a new line I would have to expand the "points" array and re-upload (recall glBufferData) it every time. The other method would be to use a model matrix and a fixed vbo for a line but it would be also messy to exactly create a line from (0,0) to (100,20) calculating the rotation and scale to make it fit.
      If I proceed with option 1 "updating the array each frame" I was thinking of having 4 draw calls every frame for the lines vao, polygons vao and so on. 
      In addition to that I am planning to use some sort of ECS based architecture. So the other question would be:
      Should I treat those debug objects as entities/components?
      For me it would make sense to treat them as entities but that's creates a new issue with the previous array approach because it would have for example a transform and render component. A special render component for debug objects (no texture etc) ... For me the transform component is also just a matrix but how would I then define a line?
      Treating them as components would'nt be a good idea in my eyes because then I would always need an entity. Well entity is just an id !? So maybe its a component?
    • By QQemka
      Hello. I am coding a small thingy in my spare time. All i want to achieve is to load a heightmap (as the lowest possible walking terrain), some static meshes (elements of the environment) and a dynamic character (meaning i can move, collide with heightmap/static meshes and hold a varying item in a hand ). Got a bunch of questions, or rather problems i can't find solution to myself. Nearly all are deal with graphics/gpu, not the coding part. My c++ is on high enough level.
      Let's go:
      Heightmap - i obviously want it to be textured, size is hardcoded to 256x256 squares. I can't have one huge texture stretched over entire terrain cause every pixel would be enormous. Thats why i decided to use 2 specified textures. First will be a tileset consisting of 16 square tiles (u v range from 0 to 0.25 for first tile and so on) and second a 256x256 buffer with 0-15 value representing index of the tile from tileset for every heigtmap square. Problem is, how do i blend the edges nicely and make some computationally cheap changes so its not obvious there are only 16 tiles? Is it possible to generate such terrain with some existing program?
      Collisions - i want to use bounding sphere and aabb. But should i store them for a model or entity instance? Meaning i have 20 same trees spawned using the same tree model, but every entity got its own transformation (position, scale etc). Storing collision component per instance grats faster access + is precalculated and transformed (takes additional memory, but who cares?), so i stick with this, right? What should i do if object is dynamically rotated? The aabb is no longer aligned and calculating per vertex min/max everytime object rotates/scales is pretty expensive, right?
      Drawing aabb - problem similar to above (storing aabb data per instance or model). This time in my opinion per model is enough since every instance also does not have own vertex buffer but uses the shared one (so 20 trees share reference to one tree model). So rendering aabb is about taking the model's aabb, transforming with instance matrix and voila. What about aabb vertex buffer (this is more of a cosmetic question, just curious, bumped onto it in time of writing this). Is it better to make it as 8 points and index buffer (12 lines), or only 2 vertices with min/max x/y/z and having the shaders dynamically generate 6 other vertices and draw the box? Or maybe there should be just ONE 1x1x1 cube box template moved/scaled per entity?
      What if one model got a diffuse texture and a normal map, and other has only diffuse? Should i pass some bool flag to shader with that info, or just assume that my game supports only diffuse maps without fancy stuff?
      There were several more but i forgot/solved them at time of writing
      Thanks in advance
    • By RenanRR
      Hi All,
      I'm reading the tutorials from learnOpengl site (nice site) and I'm having a question on the camera (https://learnopengl.com/Getting-started/Camera).
      I always saw the camera being manipulated with the lookat, but in tutorial I saw the camera being changed through the MVP arrays, which do not seem to be camera, but rather the scene that changes:
      Vertex Shader:
      #version 330 core layout (location = 0) in vec3 aPos; layout (location = 1) in vec2 aTexCoord; out vec2 TexCoord; uniform mat4 model; uniform mat4 view; uniform mat4 projection; void main() { gl_Position = projection * view * model * vec4(aPos, 1.0f); TexCoord = vec2(aTexCoord.x, aTexCoord.y); } then, the matrix manipulated:
      ..... glm::mat4 projection = glm::perspective(glm::radians(fov), (float)SCR_WIDTH / (float)SCR_HEIGHT, 0.1f, 100.0f); ourShader.setMat4("projection", projection); .... glm::mat4 view = glm::lookAt(cameraPos, cameraPos + cameraFront, cameraUp); ourShader.setMat4("view", view); .... model = glm::rotate(model, glm::radians(angle), glm::vec3(1.0f, 0.3f, 0.5f)); ourShader.setMat4("model", model);  
      So, some doubts:
      - Why use it like that?
      - Is it okay to manipulate the camera that way?
      -in this way, are not the vertex's positions that changes instead of the camera?
      - I need to pass MVP to all shaders of object in my scenes ?
      What it seems, is that the camera stands still and the scenery that changes...
      it's right?
      Thank you
    • By dpadam450
      Sampling a floating point texture where the alpha channel holds 4-bytes of packed data into the float. I don't know how to cast the raw memory to treat it as an integer so I can perform bit-shifting operations.

      int rgbValue = int(textureSample.w);//4 bytes of data packed as color
      // algorithm might not be correct and endianness might need switching.
      vec3 extractedData = vec3(  rgbValue & 0xFF000000,  (rgbValue << 8) & 0xFF000000, (rgbValue << 16) & 0xFF000000);
      extractedData /= 255.0f;
    • By Devashish Khandelwal
      While writing a simple renderer using OpenGL, I faced an issue with the glGetUniformLocation function. For some reason, the location is coming to be -1.
      Anyone has any idea .. what should I do?
  • Advertisement