Sign in to follow this  

OpenGL Gamma correction in OpenGL

This topic is 2278 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

I just realized that some games provide the user with the capability to set the "brightness" or gamma correction (CMIIW). I want to implement it but I wonder how would I go for it in OpenGL? Do you know if such a way exist? Thanks before :lol:

Share this post


Link to post
Share on other sites
[quote name='pcmaster' timestamp='1319189227' post='4874988']
Do it in your last screen-space shader or add one for that purpose. Just before presenting the image to the user.
[/quote]

duh, I don't use shaders atm. and the games I've played (that supports gamma correction) don't use shaders too (it's old games).

Share this post


Link to post
Share on other sites
There is a bit more to it than that.

Firstly your framework will need a gamma value. Default it to 2.2, but of course let the users change it.

After that, all of the colors you send to your shaders need to be sent in linear format. That includes your lights, materials, and especially your textures.
You will have to either convert the texels to linear space manually or use the GL_EXT_texture_sRGB extension (and why wouldn’t you?), but be aware that it prefers 2.4 for the gamma value over 2.2, and it uses a slightly more complicated conversion formula.
For materials and lights, don’t send the raw RGB values to the shaders. Use powf( 2.2 ) to convert to linear space (or 2.4).


Perform all of your blending in linear space.

Finally, once you are done rendering the scene, your last post-processing operation should be to gamma-correct the screen.
For each pixel, convert back into sRGB space via pow( THISPIXEL.rgb, 1.0f / GAMMA ).


Someone feel free to fact-check me on 1 point:
#1: Lights and materials might already be considered to be in linear space, in which case they should not be converted. But if they are, then you would get a value of 0.72974f back when you originally set the material value to 0.5f. So which way do we go? Convert only textures or convert them all?


L. Spiro

Share this post


Link to post
Share on other sites
wow that's a long response....umm I don't use shaders lol. the games that I talked about (NFS Porsche Unleashed) doesn't use shaders too (DX7 era). and I think it can be done without shaders. I think I can use a fullscreen quad and render it using additive blending/subtractive (depends on need). but that's too much fillrate intensive. and I thought I've ever read that you can use pixels bit shifting (I don't remember but it said that it shifts pixel color so pixels will get brighter). But I don't remember what api to use :huh:

Share this post


Link to post
Share on other sites
Gamma correction is a non-linear operation, so I doubt that you can do it with additive or subtractive blending or even another blending.

However, I'd say that gamma correction shouldn't be looked at in OpenGL at all. IMHO it is part of the windowing system or monitor device settings.

Share this post


Link to post
Share on other sites
As alluded to above, all modern graphics programming is based on shaders.

[s]You can find the old-school gamma extension [url="http://www.opengl.org/registry/specs/I3D/wgl_gamma.txt"]here[/url].[/s] Note, this isn't part of OpenGL, but Windows-OpenGL (wgl).
You can also find the legacy windows function [url="http://msdn.microsoft.com/en-us/library/dd372194(v=vs.85).aspx"]here[/url].

Share this post


Link to post
Share on other sites
[quote name='Hodgman' timestamp='1319201056' post='4875021']
As alluded to above, all modern graphics programming is based on shaders.

You can find the old-school gamma extension [url="http://www.opengl.org/registry/specs/I3D/wgl_gamma.txt"]here[/url]. Note, this isn't part of OpenGL, but Windows-OpenGL (wgl).
[/quote]

I've never seen any PCs that support WGL_I3D_gamma

Share this post


Link to post
Share on other sites
[quote name='V-man' timestamp='1319206076' post='4875048']I've never seen any PCs that support WGL_I3D_gamma[/quote]Ah, you're [url="http://www.kludx.com/capability.php?capability=569"]right[/url] -- that's a defunct 3dfx Voodoo specific extension. Edited my above post.

Share this post


Link to post
Share on other sites
I think what the OP was asking was: how did early pre-shader games implement their gamma controls? AFAICR Q3A had a gamma slider.

Share this post


Link to post
Share on other sites
Maybe I'm not getting this right, but isn't proper gamma correction in OpenGL as much as using the *_SRGB constant for defining textures (to convert to linear space), and creating a SRGB framebuffer (to convert back)?

This is something I understand runs completely in hardware nowadays without any special tweaks needed (and, also in absence of shaders).

Share this post


Link to post
Share on other sites
Old games (
of course I'm talking about Windows), use http://msdn.microsoft.com/en-us/library/dd372194%28VS.85%29.aspx

Share this post


Link to post
Share on other sites
[quote name='haegarr' timestamp='1319197126' post='4875007']
Gamma correction is a non-linear operation, so I doubt that you can do it with additive or subtractive blending or even another blending.

However, I'd say that gamma correction shouldn't be looked at in OpenGL at all. IMHO it is part of the windowing system or monitor device settings.
[/quote]

[url="http://developer.nvidia.com/node/181"]This[/url] article explains why you should perform your color blending in linear space.
I updated my engine to use linear lighting and it really made a difference. The colors are much more realistic now.


L. Spiro

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Similar Content

    • By xhcao
      Does sync be needed to read texture content after access texture image in compute shader?
      My simple code is as below,
      glUseProgram(program.get());
      glBindImageTexture(0, texture[0], 0, GL_FALSE, 3, GL_READ_ONLY, GL_R32UI);
      glBindImageTexture(1, texture[1], 0, GL_FALSE, 4, GL_WRITE_ONLY, GL_R32UI);
      glDispatchCompute(1, 1, 1);
      // Does sync be needed here?
      glUseProgram(0);
      glBindFramebuffer(GL_READ_FRAMEBUFFER, framebuffer);
      glFramebufferTexture2D(GL_READ_FRAMEBUFFER, GL_COLOR_ATTACHMENT0,
                                     GL_TEXTURE_CUBE_MAP_POSITIVE_X + face, texture[1], 0);
      glReadPixels(0, 0, kWidth, kHeight, GL_RED_INTEGER, GL_UNSIGNED_INT, outputValues);
       
      Compute shader is very simple, imageLoad content from texture[0], and imageStore content to texture[1]. Does need to sync after dispatchCompute?
    • By Jonathan2006
      My question: is it possible to transform multiple angular velocities so that they can be reinserted as one? My research is below:
      // This works quat quaternion1 = GEQuaternionFromAngleRadians(angleRadiansVector1); quat quaternion2 = GEMultiplyQuaternions(quaternion1, GEQuaternionFromAngleRadians(angleRadiansVector2)); quat quaternion3 = GEMultiplyQuaternions(quaternion2, GEQuaternionFromAngleRadians(angleRadiansVector3)); glMultMatrixf(GEMat4FromQuaternion(quaternion3).array); // The first two work fine but not the third. Why? quat quaternion1 = GEQuaternionFromAngleRadians(angleRadiansVector1); vec3 vector1 = GETransformQuaternionAndVector(quaternion1, angularVelocity1); quat quaternion2 = GEQuaternionFromAngleRadians(angleRadiansVector2); vec3 vector2 = GETransformQuaternionAndVector(quaternion2, angularVelocity2); // This doesn't work //quat quaternion3 = GEQuaternionFromAngleRadians(angleRadiansVector3); //vec3 vector3 = GETransformQuaternionAndVector(quaternion3, angularVelocity3); vec3 angleVelocity = GEAddVectors(vector1, vector2); // Does not work: vec3 angleVelocity = GEAddVectors(vector1, GEAddVectors(vector2, vector3)); static vec3 angleRadiansVector; vec3 angularAcceleration = GESetVector(0.0, 0.0, 0.0); // Sending it through one angular velocity later in my motion engine angleVelocity = GEAddVectors(angleVelocity, GEMultiplyVectorAndScalar(angularAcceleration, timeStep)); angleRadiansVector = GEAddVectors(angleRadiansVector, GEMultiplyVectorAndScalar(angleVelocity, timeStep)); glMultMatrixf(GEMat4FromEulerAngle(angleRadiansVector).array); Also how do I combine multiple angularAcceleration variables? Is there an easier way to transform the angular values?
    • By dpadam450
      I have this code below in both my vertex and fragment shader, however when I request glGetUniformLocation("Lights[0].diffuse") or "Lights[0].attenuation", it returns -1. It will only give me a valid uniform location if I actually use the diffuse/attenuation variables in the VERTEX shader. Because I use position in the vertex shader, it always returns a valid uniform location. I've read that I can share uniforms across both vertex and fragment, but I'm confused what this is even compiling to if this is the case.
       
      #define NUM_LIGHTS 2
      struct Light
      {
          vec3 position;
          vec3 diffuse;
          float attenuation;
      };
      uniform Light Lights[NUM_LIGHTS];
       
       
    • By pr033r
      Hello,
      I have a Bachelor project on topic "Implenet 3D Boid's algorithm in OpenGL". All OpenGL issues works fine for me, all rendering etc. But when I started implement the boid's algorithm it was getting worse and worse. I read article (http://natureofcode.com/book/chapter-6-autonomous-agents/) inspirate from another code (here: https://github.com/jyanar/Boids/tree/master/src) but it still doesn't work like in tutorials and videos. For example the main problem: when I apply Cohesion (one of three main laws of boids) it makes some "cycling knot". Second, when some flock touch to another it scary change the coordination or respawn in origin (x: 0, y:0. z:0). Just some streng things. 
      I followed many tutorials, change a try everything but it isn't so smooth, without lags like in another videos. I really need your help. 
      My code (optimalizing branch): https://github.com/pr033r/BachelorProject/tree/Optimalizing
      Exe file (if you want to look) and models folder (for those who will download the sources):
      http://leteckaposta.cz/367190436
      Thanks for any help...

    • By Andrija
      I am currently trying to implement shadow mapping into my project , but although i can render my depth map to the screen and it looks okay , when i sample it with shadowCoords there is no shadow.
      Here is my light space matrix calculation
      mat4x4 lightViewMatrix; vec3 sun_pos = {SUN_OFFSET * the_sun->direction[0], SUN_OFFSET * the_sun->direction[1], SUN_OFFSET * the_sun->direction[2]}; mat4x4_look_at(lightViewMatrix,sun_pos,player->pos,up); mat4x4_mul(lightSpaceMatrix,lightProjMatrix,lightViewMatrix); I will tweak the values for the size and frustum of the shadow map, but for now i just want to draw shadows around the player position
      the_sun->direction is a normalized vector so i multiply it by a constant to get the position.
      player->pos is the camera position in world space
      the light projection matrix is calculated like this:
      mat4x4_ortho(lightProjMatrix,-SHADOW_FAR,SHADOW_FAR,-SHADOW_FAR,SHADOW_FAR,NEAR,SHADOW_FAR); Shadow vertex shader:
      uniform mat4 light_space_matrix; void main() { gl_Position = light_space_matrix * transfMatrix * vec4(position, 1.0f); } Shadow fragment shader:
      out float fragDepth; void main() { fragDepth = gl_FragCoord.z; } I am using deferred rendering so i have all my world positions in the g_positions buffer
      My shadow calculation in the deferred fragment shader:
      float get_shadow_fac(vec4 light_space_pos) { vec3 shadow_coords = light_space_pos.xyz / light_space_pos.w; shadow_coords = shadow_coords * 0.5 + 0.5; float closest_depth = texture(shadow_map, shadow_coords.xy).r; float current_depth = shadow_coords.z; float shadow_fac = 1.0; if(closest_depth < current_depth) shadow_fac = 0.5; return shadow_fac; } I call the function like this:
      get_shadow_fac(light_space_matrix * vec4(position,1.0)); Where position is the value i got from sampling the g_position buffer
      Here is my depth texture (i know it will produce low quality shadows but i just want to get it working for now):
      sorry because of the compression , the black smudges are trees ... https://i.stack.imgur.com/T43aK.jpg
      EDIT: Depth texture attachment:
      glTexImage2D(GL_TEXTURE_2D, 0,GL_DEPTH_COMPONENT24,fbo->width,fbo->height,0,GL_DEPTH_COMPONENT,GL_FLOAT,NULL); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE); glFramebufferTexture2D(GL_FRAMEBUFFER, GL_DEPTH_ATTACHMENT, GL_TEXTURE_2D, fbo->depthTexture, 0);
  • Popular Now