• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Hardguy

Problem with shared keyword

6 posts in this topic

When using the shared keyword for an interface a class uses, I can not longer reload it properly.

Script code is something like
[code]shared interface iMyInterface {
void MyFunc();
}

class cMyClass : iMyInterface {
void MyFunc() {
//Do stuff
}
}[/code]

If I reload this script then calling MyFunc() from C++ code no longer works.

The way I reload is to use DiscardModule() in script engine and then create it from scratch (just like I did the first time it was created).

If I remove "shared" from iMyInterface declaration, all works fine.
0

Share this post


Link to post
Share on other sites
It is obviously related to the new "shared" functionality. I'll investigate it.

Do you get the new function id or function object after the build? It may or may not be the same, so you should always get a fresh id/object after re-building a script.

Are you calling the MyFunc() object on the interface or the object?
0

Share this post


Link to post
Share on other sites
I wasn't able to reproduce this problem. The following is the test I wrote. Please let me know if you're doing something different in your code:

[code]
engine = asCreateScriptEngine(ANGELSCRIPT_VERSION);
engine->SetMessageCallback(asMETHOD(CBufferedOutStream,Callback), &bout, asCALL_THISCALL);

const char *code =
"shared interface iMyInterface { \n"
" void MyFunc(); \n"
"} \n"
"class cMyClass : iMyInterface { \n"
" void MyFunc() { \n"
" } \n"
"} \n";

asIScriptModule *mod = engine->GetModule("1", asGM_ALWAYS_CREATE);
mod->AddScriptSection("code", code);
bout.buffer = "";
r = mod->Build();
if( r < 0 )
TEST_FAILED;

int id = mod->GetTypeIdByDecl("cMyClass");
asIObjectType *type = engine->GetObjectTypeById(id);
asIScriptFunction *func = type->GetMethodByDecl("void MyFunc()");
if( func == 0 )
TEST_FAILED;

asIScriptObject *obj = (asIScriptObject*)engine->CreateScriptObject(id);
asIScriptContext *ctx = engine->CreateContext();

ctx->Prepare(func);
ctx->SetObject(obj);
r = ctx->Execute();
if( r != asEXECUTION_FINISHED )
TEST_FAILED;

ctx->Release();
obj->Release();

engine->DiscardModule("1");

// Build the module again
mod = engine->GetModule("1", asGM_ALWAYS_CREATE);
mod->AddScriptSection("code", code);
bout.buffer = "";
r = mod->Build();
if( r < 0 )
TEST_FAILED;

id = mod->GetTypeIdByDecl("cMyClass");
type = engine->GetObjectTypeById(id);
func = type->GetMethodByDecl("void MyFunc()");
if( func == 0 )
TEST_FAILED;

obj = (asIScriptObject*)engine->CreateScriptObject(id);
ctx = engine->CreateContext();

ctx->Prepare(func);
ctx->SetObject(obj);
r = ctx->Execute();
if( r != asEXECUTION_FINISHED )
TEST_FAILED;

ctx->Release();
obj->Release();

engine->Release();
[/code]
0

Share this post


Link to post
Share on other sites
I made a bunch of testing now and found out my code example was wrong!

Here is how to reproduce:

[code]shared class iTest_Interface
{
void HelpFunc(){}
int mlBaseData;
}

//-----------------------------------

class cTest : iTest_Interface
{
cTest()
{
}

void DoSomething()
{
Print(" Inside DoSomething 1\n");
}
}[/code]
0

Share this post


Link to post
Share on other sites
Note that that code does not make any sense to use, and it was just me setting "shared" where it was not really needed.

Still it might be something worth looking into, as it is still a bug? Or perhaps something that the compiler should report as invalid?
0

Share this post


Link to post
Share on other sites
There is nothing wrong with the script. It is perfectly valid to have a non-shared class inherit from a shared class. The other way around is not valid though.

I'll give this new script a try and see if I can reproduce the problem.

[EDIT] Yes, now I was able to reproduce the problem. What happens is that when you discarded the module the object types were orphaned, but not yet destroyed as the garbage collector had not yet executed. When re-compiling the script the previously compiled and shared class was found again, but as it was orphaned, i.e. didn't belong to any module the code didn't behave correctly when trying to find the object methods.

I'll work on a solution for this.
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0