• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
rnw159

Anyone want a want a file encrypter I made?

5 posts in this topic

A friend asked me for a file encrypter a while ago, so I wrote one in console. He just told me that it has been really useful for him and I should consider giving it to other people. It just asked you to drag and drop the file on the screen, and it encrypts it with a key you can use to decrypt it from the same program.




Anyway, it is rar'd with this post if you want it.

[attachment=6713:Encrypt.rar]
1

Share this post


Link to post
Share on other sites
Just realized that it may look strange to ask people to run an exe file just like that. So can one brave person run it, then post proof that it is safe?
0

Share this post


Link to post
Share on other sites
You may not call main recursively, as you do in this program. In fact, this can probably overflow the stack if used repeatedly.

Using 'system' to call cls and pause is ugly, fragile, and a potential security vulnerability. (If I know that your program is run with elevated privileges, because it is used to encrypt certain files, then I can put a program with he name 'pause' or 'cls' in the same directory, and have that program be run instead of the one you intend; the titular vulnerability in the book [url="http://en.wikipedia.org/wiki/The_Cuckoo%27s_Egg"]The Cuckoo's Egg[/url] is very similar.)

You do not flush (by using std::endl instead of '\n' or otherwise) the output stream at times when you should - it is usually line-buffered, which is why it probably appears to work, but it does not have to be.

Function 'Base' has too many responsibilities and should be split up, separating input/output and actual computation.

You seed the random number generator far more often than you need or probably should do.

I'm not at all sure that you realize that fstreams use [url="http://en.wikipedia.org/wiki/RAII"]RAII[/url].

---

I'm not trying to be mean, but XOR encryption is a pretty standard beginner task - it's also very impractical, which is why it's not generally used in the real world - and I thought feedback on your code would be more useful. All the same, good job for completing a project which someone is finding useful!
1

Share this post


Link to post
Share on other sites
This was the first encryption software I ever made. I make games more often. I made it for a friend who wanted it real fast and couldn't tell any better. One of the reasons I don't post here very often is that when I do, I always get some guy who knows the area 100x better than I do and shoots down my work. Also, I just realized that the code is in the rar file. I did not mean to put it there.
-1

Share this post


Link to post
Share on other sites
[color=#008000][u][b]The RAR is safe[/b][/u].[/color]

However I have to agree with TheUnbeliever, it's a very very basic encryption method. But as long as someone finds it useful it's not wasted time! And you also get to get feedback on other aspects of your project (such as the code, not just the underlying algorithm), which is probably more constructive.

And, as long as you warned your friend this isn't to be used for sensitive information, there's no shame in using XOR encryption to hide stuff away from nosy people on the computer. In fact I do it sometimes to play pranks on people (or deter them from looking into my filesystem).
1

Share this post


Link to post
Share on other sites
I didn't shoot down your work, I don't think that's a fair assessment. I pointed out errors, some of them fairly serious, none of which were specific to encryption beyond a single passing comment. I know it's hard having your work criticised, but I'm not coming out guns blazing, just offering you an opportunity to learn. You don't have to heed anything in my post, but if you want to develop your programming, I would recommend at least looking into some of the stuff I mentioned.
1

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0