• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Servant of the Lord

ambiguous overload for 'operator[]'

6 posts in this topic

I'm trying to overload operator[], but am running into a weird compile error when I also overload the typecast operator for int.

Through some googling, I figured out the 'solution' to my problem, but I'm not understanding why there was a problem in the first place, or why this fixes it. I found the answer through a foreign language forum, and google translate didn't do a perfect job in helping me understand what was being said.

If you have a class like this:
[CODE]
class MyClass
{
public:
MyClass(){ }
MyClass &operator [](std::string string) {return *this;}
operator int() {return 0;}
};
[/CODE]


And try to compile this code:
[CODE]
MyClass myClass;
myClass["test"];
[/CODE]

It gives this compile-time error message:

[color=#aa0000]error: ambiguous overload for 'operator[]' in 'myClass["test"]'[/color]
[color=#aa0000]main.cpp:11: note: candidates are: operator[](int, const char*) <built-in>[/color]
[color=#aa0000]MyClass.h:5: note: MyClass& MyClass::operator[](std::string)[/color]


But works fine if you change the class to this:
[CODE]
class MyClass
{
public:
MyClass(){ }
MyClass &operator [](const char*) {return *this;} //const char* not std::string.
operator int() {return 0;}
};
[/CODE]

Why is an [i]operator[](int, const char*)[/i] "<built-in>" to my class? What for?
And why, if given the option between:
[i]operator[]([b]int[/b], const char*)[/i] and [i]operator[](std::string)[/i]
does it decide it's too 'ambiguous', when std::string can be constructed from const char*, and [i]operator[]([u][b]int[/b][/u], const char*)[/i] takes an [b]int [/b]as the first parameter?!

The weird thing, which especially confuses me, is why this error only occurs if I'm also overloading the typecast operator int or typecast operator bool, but not if I overload, say, typecast operator float.

I'm guessing it's because bool can be implicitly cast to int, and it somehow thinks I'm trying to do something like this: [i]myClass[(int)myClass][/i]

If I called this 'built in' [i]operator[int, const char*][/i] manually, what would happen? What is it there for?

My code currently works (by providing both [i](const char*)[/i] and [i](std::string)[/i] overloads for [i]operator[][/i]), but I'd like to understand [u]why[/u] there was a problem in the first place.
0

Share this post


Link to post
Share on other sites
Having the operator take an [i]std::string[/i] and passing a [i]char const *[/i] requires a conversion in order for the operator to be called, and likewise there is a conversion to the built in operator because of the implicit [i]int[/i] conversion. Both paths are equally valid, and there is a therefore an ambiguity.

Having the operator take a [i]char const *[/i] on the other hand requires no conversion for the operator to be called. Therefore, one path is more explicit that the other, and is chosen.
0

Share this post


Link to post
Share on other sites
That would imply const char* can be implicitly cast to int. Is that so? Why?

Also, why is operator[](int, const char*) a built in function? What is it used for?
0

Share this post


Link to post
Share on other sites
Weird.

So the following work [s](though the first I find odd)[/s]:
[i]std::cout << 5["xxxxxFxxx"];[/i]
[i]std::cout << "xxLxxx" [2];[/i]

[s]But this does not:
[i]std::cout << [3, "xxxMxx"];[/i]

So [i]operator[](int, const char*)[/i] is not 'built-in' to MyClass itself, but a global function[/s] (I re-read your post)

So:
[i]myClass["test"][/i]

...is interpreted as:
[i]int(myClass) ["test"] [/i] (with global ::operator[] for const char* string literals)

...and is unrelated to me having a [i]MyClass::operator[][/i], and just happenstance that the only time I'd ever use myClass[] is if I added operator[] to the class?
0

Share this post


Link to post
Share on other sites
[quote name='Servant of the Lord' timestamp='1326841462' post='4903822']
Weird.

So the following work (though the first I find odd):
[i]std::cout << 5["xxxxxFxxx"];[/i]
[i]std::cout << "xxLxxx" [2];[/i]

But this does not:
[i]std::cout << [3, "xxxMxx"];[/i]
[/quote]
The first two are correct, but the second one does not follow the syntax of the subscript operator, which is [i]a[c][/i]; one to the left of the brackets and one inside them. You can use the function call syntax also if you want.
[source]
MyClass foo;
foo.operator[]("hello world");
[/source]
The global one would not be considered since it simply isn't the correct syntax (it's a member function call). This will not cause any ambiguity, since there is only one overloaded [i]operator [][/i] as a member function, but it kind of defeats the purpose of having the operator and not just a regular member function.

[quote name='Servant of the Lord' timestamp='1326841462' post='4903822']
So [i]operator[](int, const char*)[/i] is not 'built-in' to MyClass itself, but a global function?
[/quote]
That is correct. The problem was that one of the parameters was implicitly coming from the class due to the cast operator, which allowed for a match.

[quote name='Servant of the Lord' timestamp='1326841462' post='4903822']
So:
[i]myClass["test"][/i]

...is interpreted as:
[i]int(myClass) ["test"] [/i] (with global ::operator[] for const char* string literals)

...and is unrelated to me having a [i]MyClass::operator[][/i], and just happenstance that the only time I'd ever use myClass[] is if I added operator[] to the class?
[/quote]
That is also correct.

This thread shows is why cast operators can be dangerous. The wrong one was silently called under the correct condition, and otherwise you at least got an error that made no sense if you didn't knew about this subscript deal. Unless you really have a good reason for the cast operator, prefer an explicit function like [i]std::string::c_str()[/i], perhaps [i]to_int()[/i] or something.
2

Share this post


Link to post
Share on other sites
Alright, thank you, that makes sense. I'll just remove the implicit cast for safety, but I'm glad I actually now understand what was going on - it was really confusing me.
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0