• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
Hyunkel

Compute Shader - shared memory race condition when using optimization level 3

12 posts in this topic

Here's a very simple compute shader to illustrate the problem:
[CODE]
#define size 17
RWStructuredBuffer<float> OutputBuffer : register(u0);
groupshared float SharedPositions[size * size];
[numthreads(size, size, 1)]
void CS( uint3 GroupID : SV_GroupID, uint3 DispatchThreadID : SV_DispatchThreadID, uint3 GroupThreadID : SV_GroupThreadID, uint GroupIndex : SV_GroupIndex )
{
// Write Vertex Position to shared memory
SharedPositions[GroupIndex] = 1.0f;
// Wait for Shared Memory to be ready
GroupMemoryBarrierWithGroupSync();
OutputBuffer[GroupIndex] = SharedPositions[GroupIndex];
}
[/CODE]

When compiling with D3D10_SHADER_OPTIMIZATION_LEVEL higher than 1, I get the following error:
[quote]error X3695: race condition writing to shared memory detected, consider making this write conditional.[/quote]

But since I write to "GroupIndex", no more than one thread will ever write to the same location.
What condition does the compiler require for this to compile properly?
0

Share this post


Link to post
Share on other sites
GroupIndex is only unique inside the thread group. So if there are multiple groups you end up with a race condition for the output buffer.
0

Share this post


Link to post
Share on other sites
Yes, but the groupshared memory is unique to each thread group, which is where the error is occurring. (or so I assume because it specifically says "race condition writing to shared memory")
My example is obviously not making much sense since each thread group would write to the same location of OutputBuffer,
I just quickly threw something simple together to illustrate my issue, my actual compute shader takes this into consideration.
0

Share this post


Link to post
Share on other sites
Is the error on writing to the shared memory, or writing to the output resource?
0

Share this post


Link to post
Share on other sites
It's definitely when writing to shared memory.
I completely removed any writing to output resources:

[code]// Shared memory
groupshared float SharedPositions[1];
[numthreads(1, 1, 1)]
void CS( uint3 GroupID : SV_GroupID, uint3 DispatchThreadID : SV_DispatchThreadID, uint3 GroupThreadID : SV_GroupThreadID, uint GroupIndex : SV_GroupIndex )
{
// Write something to shared memory
SharedPositions[GroupIndex] = 1.0f;
// Wait for Shared Memory to be ready
GroupMemoryBarrierWithGroupSync();
}[/code]

The error still occurs:
[quote]ErrorTest.hlsl(2,19): error X3695: race condition writing to shared memory detected, consider making this write conditional.[/quote]

Line 2 is: groupshared float SharedPositions[1];
Character 19 is SharedPositions[1];
0

Share this post


Link to post
Share on other sites
What the hell....
this errors as well:

[code]groupshared float SharedPositions[1];
[numthreads(1, 1, 1)]
void CS( )
{
}[/code]

Basically, as soon as I define shared memory and use an optimization flag of 2 or higher when compiling, it errors.
Could this be a bug in the shader compiler?
0

Share this post


Link to post
Share on other sites
I just tried compiling your shader with fxc.exe using /O3, and it compiles fine. Are you using cs_5_0?
1

Share this post


Link to post
Share on other sites
I just found [url="http://forums.create.msdn.com/forums/p/63981/392527.aspx"]this [/url]link - would you happen to be using the app verifier???
1

Share this post


Link to post
Share on other sites
[quote name='MJP' timestamp='1329075237' post='4912318']
I just tried compiling your shader with fxc.exe using /O3, and it compiles fine. Are you using cs_5_0?
[/quote]
It is working fine with fxc for me as well.
The problem only occurs with D3DX11CompileFromFile().
I am using cs_5_0.

[quote name='Jason Z' timestamp='1329075317' post='4912321']
I just found [url="http://forums.create.msdn.com/forums/p/63981/392527.aspx"]this [/url]link - would you happen to be using the app verifier???
[/quote]

This appear to be the exact same problem I'm experiencing.
However, I am not knowingly using app verifier.
It appears to be some sort of plugin for visual studio? If so I'm definitely not using it.
0

Share this post


Link to post
Share on other sites
[quote name='Hyunkel' timestamp='1329076263' post='4912326']
[quote name='MJP' timestamp='1329075237' post='4912318']
I just tried compiling your shader with fxc.exe using /O3, and it compiles fine. Are you using cs_5_0?
[/quote]
It is working fine with fxc for me as well.
The problem only occurs with D3DX11CompileFromFile().
I am using cs_5_0.

[quote name='Jason Z' timestamp='1329075317' post='4912321']
I just found [url="http://forums.create.msdn.com/forums/p/63981/392527.aspx"]this [/url]link - would you happen to be using the app verifier???
[/quote]

This appear to be the exact same problem I'm experiencing.
However, I am not knowingly using app verifier.
It appears to be some sort of plugin for visual studio? If so I'm definitely not using it.
[/quote]

Hi.
I've got exactly the same problem :(
is there any known solution / workaround please ?
0

Share this post


Link to post
Share on other sites
Unfortunately I haven't found a solution to the problem.
For now I'm compiling my compute shaders with fxc if I have to do a release build, which isn't very often.
0

Share this post


Link to post
Share on other sites
Hi. I've got something to avoid this compiler running while running from Visual Studio
add this option ([b]_NO_DEBUG_HEAP=1[/b]) to your solution
[url="http://blogs.msdn.com/b/ms_joc/archive/2009/02/19/why-is-my-app-so-much-slower-under-the-debugger.aspx"]http://blogs.msdn.com/b/ms_joc/archive/2009/02/19/why-is-my-app-so-much-slower-under-the-debugger.aspx[/url]
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0