• Advertisement
Sign in to follow this  

OpenGL OpenGL 3.2+ and GLSL texturing

This topic is 2157 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

Hello all, I have recently begun the switch from old OpenGL to the newer specification that uses VAO's and VBO's for like... everything.
I am having alot of trouble getting texturing to work with GLSL and my VAO's, I managed to get lighting and color with GLSL working earlier(using an individuale VBO for ther verts, color, and normals) so i know my view/projection/model matrixies are all okay. I manually generate all the verticies of a cube into v[108] (im not using TRIAGLE_STRIPS right now so its 2 tri's a side) and then the tex coords for each vertex into t[72]. Since each vertex of 3 floats only requires two tex coords right? Might be useful to know im going off Swiftless's OpenGL 4 GLSL tutorials so I'm using glm and glew.

Also I use glBindAttribute to always pass the vertices position as a vec3 and to pass the tex coords as a vec2 into my Shader program(the same way i passed verts, color and normals earlier)

Any way heres some code:

This generates my VAO from 2 VBO's, one fro my verts and the other tex coords.
[code]glGenVertexArrays(1, &vaoID);
glBindVertexArray(vaoID);

glGenBuffers(2, &vboID[0]);
//Verticies
glBindBuffer(GL_ARRAY_BUFFER, vboID[0]);
glBufferData(GL_ARRAY_BUFFER, 108 * sizeof(GLfloat), v, GL_STATIC_DRAW);
glVertexAttribPointer((GLuint)0, 3, GL_FLOAT, GL_FALSE, 0, 0);
glEnableVertexAttribArray(0);
//Tex Coords
glBindBuffer(GL_ARRAY_BUFFER, vboID[1]);
glBufferData(GL_ARRAY_BUFFER, 72 * sizeof(GLfloat), t, GL_STATIC_DRAW);
glVertexAttribPointer((GLuint)1, 2, GL_FLOAT, GL_FALSE, 0, 0);
glEnableVertexAttribArray(1);

glBindVertexArray(0);[/code]

Then I draw the cube like so:
[code]
shader->bind();
int projectionMatrixLocation = glGetUniformLocation(shader->id(), "projectionMatrix");
int viewMatrixLocation = glGetUniformLocation(shader->id(), "viewMatrix");
int modelMatrixLocation = glGetUniformLocation(shader->id(), "modelMatrix");
int texture_location = glGetUniformLocation(shader->id(), "texture_color");

glUniformMatrix4fv(projectionMatrixLocation, 1, GL_FALSE, &projectionMatrix[0][0]);
glUniformMatrix4fv(viewMatrixLocation, 1, GL_FALSE, &viewMatrix[0][0]);
glUniformMatrix4fv(modelMatrixLocation, 1, GL_FALSE, &modelMatrix[0][0]);

glActiveTexture(GL_TEXTURE0);
glBindTexture(GL_TEXTURE_2D, texture[0]);
glUniform1i(texture_location, 0);


glBindVertexArray(vaoID);
glDrawArrays(GL_TRIANGLES, 0, 36);
glBindVertexArray(0);


shader->unbind();
[/code]

...and my Vertex and Pixel(fragment) shaders respectivley:
[code]
#version 150 core

uniform mat4 projectionMatrix;
uniform mat4 viewMatrix;
uniform mat4 modelMatrix;

in vec3 in_Position;
in vec2 in_TexCoord;

void main(void){
gl_TexCoord[0] = in_TexCoord;

gl_Position = projectionMatrix * viewMatrix * modelMatrix * vec4(in_Position, 1.0);
}
[/code]

[code]
#version 150 core

uniform sampler2D texture_color;

void main(void){
gl_FragColor = texture2D(texture_color, gl_TexCoord[0].st);

}
[/code]
The result is a white cube that seems to lose its scaleing compared to when I specify a solid gl_FragColor

My assumtion is something to do with gl_TexCoord[0] not being a vec2 like in_TexCoord but I can't seem to find much/any documentaion on GLSL when using custom arrays for everything. All the examples I've seen use gl_MultiTexCoord[0] to pull the tex coords from the now depriciated glMultiTexCoordxx()... I think [img]http://public.gamedev.net//public/style_emoticons/default/happy.png[/img].
I can post the vertex and tex coords initialization routine if that would help but its alot of crap lol.
I apologize if I'm not giving enough info or too much lol. I greatly appreciate any help given!!

Share this post


Link to post
Share on other sites
Advertisement
I'm not sure about the gl_TexCoord[0] issue, but I would suggest just to define your own varying texcoord variable and not use the builtin one. Are you checking shaders and programs for compile errors?

You said you're using glBindAttribute, do you mean glBindAttribLocation?

Share this post


Link to post
Share on other sites
If you read Swiftless, he says:

[quote]In GLSL 1.50, we no longer have gl_ModelViewMatrix, gl_ProjectionMatrix, gl_Vertex, etc, etc[/quote] So it appears you cannot use the built-in texture coordinate array. Declare your own varying vec2 variable, set it to the attribute texture coordinate in the vertex shader, and feed it to the fragment shader. Also, don't use the built-in fragment color variable. Declare your own vec4. Something like this:


[code]
#version 150 core

uniform mat4 projectionMatrix;
uniform mat4 viewMatrix;
uniform mat4 modelMatrix;

in vec3 in_Position;
in vec2 in_TexCoord;


out vec2 out_TexCoord;


void main(void){
out_TexCoord = in_TexCoord;

gl_Position = projectionMatrix * viewMatrix * modelMatrix * vec4(in_Position, 1.0);
}


[/code]




[code]
#version 150 core

in vec2 out_TexCoord;
uniform sampler2D texture_color;
out vec4 FragColor;

void main(void){
FragColor = texture2D(texture_color, out_TexCoord.st);

}[/code]

If that doesn't work, check the stuff that Karwosts mentioned above.

Share this post


Link to post
Share on other sites
@karwosts - Yes I meant glBindAttribLocation, sorry I had literally been up all night working with the new GL specification and It was starting to hurt my brain lol.

Okay I dropped the usage of gl_TexCoord[0] and did as Jesse7 suggested but that still didn't work, although not because it's incorrect. The issue seems to be the texture loader I have been using all the time from all my intermediate mode stuff. Not sure what was wrong with it but replaceing it with Swiftless's RAW texture loader code and doing the things Jesse7 suggested worked like a charm. It may be worth noteing that in the fragment shader the line:
[code]FragColor = texture2D(texture_color, out_TexCoord.st); [/code]

You don't need the .st at the end of our varying vec2 out_TexCoord, or at least it works without it. What is the purpose of the .st at the end of a vec2 varialbe?
Anyways I hate the RAW format so I guess it's time to write my own Targa loader.
Thank you all for your help! ^_^

Share this post


Link to post
Share on other sites
[quote name='NimrodPSI' timestamp='1329868338' post='4915325']
What is the purpose of the .st at the end of a vec2 varialbe?
Anyways I hate the RAW format so I guess it's time to write my own Targa loader.
[/quote] I guess .st is redundant since we have a vec2. For loading Targas and a slew of other formats, you could use FreeImage or DevIL. SOIL is another one but it doesn't seem to work with a core profile.

Share this post


Link to post
Share on other sites
Well I had been using a pretty good Targa loader for a while and had even adapted the code to load my own height maps. Although I now have figured out why my texture loader wasn't working In the first place. I tried replaceing the filtering on the RAW texture loader to use mipmaps and used gluBuild2DMipmaps(); but as soon as I ran it resulted in the same black cube. So my old texture loader that also used mipmaps was wrong due to this. I've looked around a bit about GLSL mipmaping and found the command texture2dLod(); So I'm going to persue that route at some point.

Share this post


Link to post
Share on other sites
[quote name='NimrodPSI' timestamp='1329949496' post='4915691']
I tried replaceing the filtering on the RAW texture loader to use mipmaps and used gluBuild2DMipmaps(); but as soon as I ran it resulted in the same black cube. So my old texture loader that also used mipmaps was wrong due to this. I've looked around a bit about GLSL mipmaping and found the command texture2dLod(); So I'm going to persue that route at some point.
[/quote] Yeah, if you use deprecated code with a core profile you sometimes get weird stuff like black textures [img]http://public.gamedev.net//public/style_emoticons/default/blink.png[/img]. I don't much about that GLSL command, but another way of generating mipmaps is by calling glGenerateMipmap () right after you load the texture:
[code]

// use trilinear filtering
glBindTexture(GL_TEXTURE_2D, textureId);
glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR_MIPMAP_LINEAR);
glTexParameteri( GL_TEXTURE_2D,GL_TEXTURE_MAG_FILTER, GL_LINEAR );
glTexImage2D(GL_TEXTURE_2D,0,GL_RGBA, w, h, 0, GL_RGBA,GL_UNSIGNED_BYTE,pixels);

// generate mipmaps
glGenerateMipmap(GL_TEXTURE_2D);
[/code]

Share this post


Link to post
Share on other sites
Confirmed and working! Thank you, that was much easier than all the hassle of generating my own and passing them to GLSL or something. Now I just need to brush up on some matrix maths and I'm good to go lol.

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Now

  • Advertisement
  • Similar Content

    • By Balma Alparisi
      i got error 1282 in my code.
      sf::ContextSettings settings; settings.majorVersion = 4; settings.minorVersion = 5; settings.attributeFlags = settings.Core; sf::Window window; window.create(sf::VideoMode(1600, 900), "Texture Unit Rectangle", sf::Style::Close, settings); window.setActive(true); window.setVerticalSyncEnabled(true); glewInit(); GLuint shaderProgram = createShaderProgram("FX/Rectangle.vss", "FX/Rectangle.fss"); float vertex[] = { -0.5f,0.5f,0.0f, 0.0f,0.0f, -0.5f,-0.5f,0.0f, 0.0f,1.0f, 0.5f,0.5f,0.0f, 1.0f,0.0f, 0.5,-0.5f,0.0f, 1.0f,1.0f, }; GLuint indices[] = { 0,1,2, 1,2,3, }; GLuint vao; glGenVertexArrays(1, &vao); glBindVertexArray(vao); GLuint vbo; glGenBuffers(1, &vbo); glBindBuffer(GL_ARRAY_BUFFER, vbo); glBufferData(GL_ARRAY_BUFFER, sizeof(vertex), vertex, GL_STATIC_DRAW); GLuint ebo; glGenBuffers(1, &ebo); glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, ebo); glBufferData(GL_ELEMENT_ARRAY_BUFFER, sizeof(indices), indices,GL_STATIC_DRAW); glVertexAttribPointer(0, 3, GL_FLOAT, false, sizeof(float) * 5, (void*)0); glEnableVertexAttribArray(0); glVertexAttribPointer(1, 2, GL_FLOAT, false, sizeof(float) * 5, (void*)(sizeof(float) * 3)); glEnableVertexAttribArray(1); GLuint texture[2]; glGenTextures(2, texture); glActiveTexture(GL_TEXTURE0); glBindTexture(GL_TEXTURE_2D, texture[0]); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR); sf::Image* imageOne = new sf::Image; bool isImageOneLoaded = imageOne->loadFromFile("Texture/container.jpg"); if (isImageOneLoaded) { glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, imageOne->getSize().x, imageOne->getSize().y, 0, GL_RGBA, GL_UNSIGNED_BYTE, imageOne->getPixelsPtr()); glGenerateMipmap(GL_TEXTURE_2D); } delete imageOne; glActiveTexture(GL_TEXTURE1); glBindTexture(GL_TEXTURE_2D, texture[1]); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR); sf::Image* imageTwo = new sf::Image; bool isImageTwoLoaded = imageTwo->loadFromFile("Texture/awesomeface.png"); if (isImageTwoLoaded) { glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, imageTwo->getSize().x, imageTwo->getSize().y, 0, GL_RGBA, GL_UNSIGNED_BYTE, imageTwo->getPixelsPtr()); glGenerateMipmap(GL_TEXTURE_2D); } delete imageTwo; glUniform1i(glGetUniformLocation(shaderProgram, "inTextureOne"), 0); glUniform1i(glGetUniformLocation(shaderProgram, "inTextureTwo"), 1); GLenum error = glGetError(); std::cout << error << std::endl; sf::Event event; bool isRunning = true; while (isRunning) { while (window.pollEvent(event)) { if (event.type == event.Closed) { isRunning = false; } } glClear(GL_COLOR_BUFFER_BIT); if (isImageOneLoaded && isImageTwoLoaded) { glActiveTexture(GL_TEXTURE0); glBindTexture(GL_TEXTURE_2D, texture[0]); glActiveTexture(GL_TEXTURE1); glBindTexture(GL_TEXTURE_2D, texture[1]); glUseProgram(shaderProgram); } glBindVertexArray(vao); glDrawElements(GL_TRIANGLES, 6, GL_UNSIGNED_INT, nullptr); glBindVertexArray(0); window.display(); } glDeleteVertexArrays(1, &vao); glDeleteBuffers(1, &vbo); glDeleteBuffers(1, &ebo); glDeleteProgram(shaderProgram); glDeleteTextures(2,texture); return 0; } and this is the vertex shader
      #version 450 core layout(location=0) in vec3 inPos; layout(location=1) in vec2 inTexCoord; out vec2 TexCoord; void main() { gl_Position=vec4(inPos,1.0); TexCoord=inTexCoord; } and the fragment shader
      #version 450 core in vec2 TexCoord; uniform sampler2D inTextureOne; uniform sampler2D inTextureTwo; out vec4 FragmentColor; void main() { FragmentColor=mix(texture(inTextureOne,TexCoord),texture(inTextureTwo,TexCoord),0.2); } I was expecting awesomeface.png on top of container.jpg

    • By khawk
      We've just released all of the source code for the NeHe OpenGL lessons on our Github page at https://github.com/gamedev-net/nehe-opengl. code - 43 total platforms, configurations, and languages are included.
      Now operated by GameDev.net, NeHe is located at http://nehe.gamedev.net where it has been a valuable resource for developers wanting to learn OpenGL and graphics programming.

      View full story
    • By TheChubu
      The Khronos™ Group, an open consortium of leading hardware and software companies, announces from the SIGGRAPH 2017 Conference the immediate public availability of the OpenGL® 4.6 specification. OpenGL 4.6 integrates the functionality of numerous ARB and EXT extensions created by Khronos members AMD, Intel, and NVIDIA into core, including the capability to ingest SPIR-V™ shaders.
      SPIR-V is a Khronos-defined standard intermediate language for parallel compute and graphics, which enables content creators to simplify their shader authoring and management pipelines while providing significant source shading language flexibility. OpenGL 4.6 adds support for ingesting SPIR-V shaders to the core specification, guaranteeing that SPIR-V shaders will be widely supported by OpenGL implementations.
      OpenGL 4.6 adds the functionality of these ARB extensions to OpenGL’s core specification:
      GL_ARB_gl_spirv and GL_ARB_spirv_extensions to standardize SPIR-V support for OpenGL GL_ARB_indirect_parameters and GL_ARB_shader_draw_parameters for reducing the CPU overhead associated with rendering batches of geometry GL_ARB_pipeline_statistics_query and GL_ARB_transform_feedback_overflow_querystandardize OpenGL support for features available in Direct3D GL_ARB_texture_filter_anisotropic (based on GL_EXT_texture_filter_anisotropic) brings previously IP encumbered functionality into OpenGL to improve the visual quality of textured scenes GL_ARB_polygon_offset_clamp (based on GL_EXT_polygon_offset_clamp) suppresses a common visual artifact known as a “light leak” associated with rendering shadows GL_ARB_shader_atomic_counter_ops and GL_ARB_shader_group_vote add shader intrinsics supported by all desktop vendors to improve functionality and performance GL_KHR_no_error reduces driver overhead by allowing the application to indicate that it expects error-free operation so errors need not be generated In addition to the above features being added to OpenGL 4.6, the following are being released as extensions:
      GL_KHR_parallel_shader_compile allows applications to launch multiple shader compile threads to improve shader compile throughput WGL_ARB_create_context_no_error and GXL_ARB_create_context_no_error allow no error contexts to be created with WGL or GLX that support the GL_KHR_no_error extension “I’m proud to announce OpenGL 4.6 as the most feature-rich version of OpenGL yet. We've brought together the most popular, widely-supported extensions into a new core specification to give OpenGL developers and end users an improved baseline feature set. This includes resolving previous intellectual property roadblocks to bringing anisotropic texture filtering and polygon offset clamping into the core specification to enable widespread implementation and usage,” said Piers Daniell, chair of the OpenGL Working Group at Khronos. “The OpenGL working group will continue to respond to market needs and work with GPU vendors to ensure OpenGL remains a viable and evolving graphics API for all its customers and users across many vital industries.“
      The OpenGL 4.6 specification can be found at https://khronos.org/registry/OpenGL/index_gl.php. The GLSL to SPIR-V compiler glslang has been updated with GLSL 4.60 support, and can be found at https://github.com/KhronosGroup/glslang.
      Sophisticated graphics applications will also benefit from a set of newly released extensions for both OpenGL and OpenGL ES to enable interoperability with Vulkan and Direct3D. These extensions are named:
      GL_EXT_memory_object GL_EXT_memory_object_fd GL_EXT_memory_object_win32 GL_EXT_semaphore GL_EXT_semaphore_fd GL_EXT_semaphore_win32 GL_EXT_win32_keyed_mutex They can be found at: https://khronos.org/registry/OpenGL/index_gl.php
      Industry Support for OpenGL 4.6
      “With OpenGL 4.6 our customers have an improved set of core features available on our full range of OpenGL 4.x capable GPUs. These features provide improved rendering quality, performance and functionality. As the graphics industry’s most popular API, we fully support OpenGL and will continue to work closely with the Khronos Group on the development of new OpenGL specifications and extensions for our customers. NVIDIA has released beta OpenGL 4.6 drivers today at https://developer.nvidia.com/opengl-driver so developers can use these new features right away,” said Bob Pette, vice president, Professional Graphics at NVIDIA.
      "OpenGL 4.6 will be the first OpenGL release where conformant open source implementations based on the Mesa project will be deliverable in a reasonable timeframe after release. The open sourcing of the OpenGL conformance test suite and ongoing work between Khronos and X.org will also allow for non-vendor led open source implementations to achieve conformance in the near future," said David Airlie, senior principal engineer at Red Hat, and developer on Mesa/X.org projects.

      View full story
    • By _OskaR
      Hi,
      I have an OpenGL application but without possibility to wite own shaders.
      I need to perform small VS modification - is possible to do it in an alternative way? Do we have apps or driver modifictions which will catch the shader sent to GPU and override it?
    • By xhcao
      Does sync be needed to read texture content after access texture image in compute shader?
      My simple code is as below,
      glUseProgram(program.get());
      glBindImageTexture(0, texture[0], 0, GL_FALSE, 3, GL_READ_ONLY, GL_R32UI);
      glBindImageTexture(1, texture[1], 0, GL_FALSE, 4, GL_WRITE_ONLY, GL_R32UI);
      glDispatchCompute(1, 1, 1);
      // Does sync be needed here?
      glUseProgram(0);
      glBindFramebuffer(GL_READ_FRAMEBUFFER, framebuffer);
      glFramebufferTexture2D(GL_READ_FRAMEBUFFER, GL_COLOR_ATTACHMENT0,
                                     GL_TEXTURE_CUBE_MAP_POSITIVE_X + face, texture[1], 0);
      glReadPixels(0, 0, kWidth, kHeight, GL_RED_INTEGER, GL_UNSIGNED_INT, outputValues);
       
      Compute shader is very simple, imageLoad content from texture[0], and imageStore content to texture[1]. Does need to sync after dispatchCompute?
  • Advertisement