• Advertisement
Sign in to follow this  

OpenGL Bloom Fail

This topic is 2139 days old which is more than the 365 day threshold we allow for new replies. Please post a new topic.

If you intended to correct an error in the post then please contact us.

Recommended Posts

I have just implemented bloom in my engine but on the OpenGL side I have these black artifacts.
[attachment=7631:Ogl0.png][attachment=7628:Ogl1.png]

In Direct3D 9 they are fine.
[attachment=7629:Dx0.png][attachment=7630:Dx1.png]


They are both using the exact same shaders, being fed the exact same data, and using the same HDR formats (16-bit float).


I know that the problem is in the blur filters, both horizontal and vertical, but I can’t see why it is happening, especially when it doesn’t happen in Direct3D 9.

Horizontal blur.

[CODE]
#version 130
precision mediump float;
invariant gl_Position;
float shadow2dDepth(sampler2D s,vec2 v){return texture(s,v).z;}
out vec2 LSG_VERT_OUT_PIXEL_IN_379_0/*_vOut2dTex0*/;
in vec2 _vIn2dTex0;
in vec3 _vInPos;
uniform mat4x4 g_mModelViewProjMatrix;

void main(){
gl_Position = ((g_mModelViewProjMatrix) * (vec4( _vInPos, 1.0 )));

LSG_VERT_OUT_PIXEL_IN_379_0/*_vOut2dTex0*/ = _vIn2dTex0;
}

#version 130
precision mediump float;
out vec4 lsg_vColor[8];
float shadow2dDepth(sampler2D s,vec2 v){return texture(s,v).z;}
out vec4 _vOutColor;
in vec2 LSG_VERT_OUT_PIXEL_IN_379_0/*_vIn2dTex0*/;
in vec4 LSG_VERT_OUT_PIXEL_IN_375_0/*_vInPos*/;

uniform sampler2D g_sSampler2dTex0;

uniform float g_fOffsets[9];
uniform float g_fWeights[9];

void main() {
_vOutColor = vec4( 0.0, 0.0, 0.0, 0.0 );

for ( int I = 0; I < 9; I++ ) {
_vOutColor += (texture( g_sSampler2dTex0, LSG_VERT_OUT_PIXEL_IN_379_0/*_vIn2dTex0*/ +
vec2( g_fOffsets[I], 0.0 ) ) * g_fWeights[I]);

}

_vOutColor.w = 1.0;
}[/CODE]

I know it looks a little strange. This was generated output from my own shader language, and I added back some of the whitespace to make it more readable.

g_fOffsets has normal-looking values from -0.0049999999 to 0.0049999999.

g_fWeights:

[0x0] 0.032394581
[0x1] 0.077710561
[0x2] 0.14518245
[0x3] 0.21123920
[0x4] 0.23936538
[0x5] 0.21123920
[0x6] 0.14518245
[0x7] 0.077710561
[0x8] 0.032394581


The only difference with the vertical pass is g_fOffsets, which is normal because it is based off the height instead of the image.
Any ideas?


L. Spiro

Share this post


Link to post
Share on other sites
Advertisement
Those black artifacts are often indicative of NaN Pixels which get drawn as black on most GPUs.

NaN mostly results from divisions by 0. One typical example being 0/0.

Since any operation with a NaN value results in a NaN, you then get those black block artifacts when applying a filter.

You can test this in GLSL at the end of you shader with this code snippet:

[code]if (any(isnan(color))) {
color = vec4(1,0,0,1);
}[/code]

This will set NaN pixels to red.

Share this post


Link to post
Share on other sites
That was helpful information.

I found out that my bright pass is writing NaN values to the texture due to a dot() with a zero-vector (black texels).
Why it doesn’t have to all black texels I have no clue, but I applied the appropriate checks and fixed it.


Thank you.


L. Spiro

Share this post


Link to post
Share on other sites
[quote name='YogurtEmperor' timestamp='1331380056' post='4920884']
I found out that my bright pass is writing NaN values to the texture due to a dot() with a zero-vector (black texels).
[/quote]

Dot has no division, only multiplications... so it should not be the cause of NaN-value. The issue must be somewhere before that.. like it already was a NaN-value vector. Possible cause exponent of the floating point is not correctly interpreted (all bits are set to 1, according to IEEE-754).

Share this post


Link to post
Share on other sites
In glsl, the pow(x, y) function return value is undefined if x < 0 or if x = 0 && y = 0. I once had a situation where the specular multiplier and specular exponent of a specular map were both zero at some texels, which caused pow to return NaN. You can also check for that.

Share this post


Link to post
Share on other sites
I guess I was thinking dot() was a target because the returned value is relative to the lengths of the input vectors, and as we all know, a 0-vector has to be handled as a special case in order to avoid division by 0.

However it is correct in reality that both dot() and cross() have no divides.

Except apparently in OpenGL and OpenGL ES 2 implementations.
It [i]was[/i] the cause for the large black blocks. Simply by changing from this (bright pass, the only pass before doing a horizontal blur):

[CODE]
float fLuminance = dot( vAverage.rgb, vWeight );
if( fLuminance < g_fThresh ) {
vAverage = vec4( 0.0f, 0.0f, 0.0f, 1.0f );
}[/CODE]
to this:
[CODE]
float fLuminance = dot( vAverage.rgb, vWeight );
if( fLuminance < g_fThresh || isnan( fLuminance ) ) {
vAverage = vec4( 0.0f, 0.0f, 0.0f, 1.0f );
}[/CODE]
made the blocks go away. I rendered the result of the horizontal blue before and after this change and confirmed that without this change, the first blur has black streaks, with the change it is perfect.


Meanwhile, since a [i]typical[/i] dot() and cross() do not have divides, Direct3D 9 was working fine.
This appears to be unnecessary extra work being done by OpenGL. There is no reason for it to generate NaN here, unless it is specifically testing for the case of a 0-length input vector.


I do still have black dots (rather than blocks) and those appear in Direct3D 9 also, but I haven’t yet been able to find the cause.
Since I can render the bright pass and blurs, and they are always perfect, I know that it is in the last stage which combines them and does the tone mapping.

Anyway I will find it eventually.


L. Spiro


[EDIT]
I was thinking about another idea I have been entertaining—that the source image has NaN values in it that I could never see before because they are black pixels and the end result is still black.
Just tested it and it is correct.
It isn’t in the pow() but it is in the main image result.
I will remove my dot() checks since they are now superfluous, and will find the actual cause of my woes soon.
[/EDIT]

Share this post


Link to post
Share on other sites
[quote name='YogurtEmperor' timestamp='1331559786' post='4921328']
However it is correct in reality that both dot() and cross() have no divides.

Except apparently in OpenGL and OpenGL ES 2 implementations.
It [i]was[/i] the cause for the large black blocks. Simply by changing from this (bright pass, the only pass before doing a horizontal blur):
[/quote]

I don't think that makes sense. As far as I know, the only way for dot to return NaN is if one of the components are NaN. Are you sure the input is good..?

Share this post


Link to post
Share on other sites
Have you checked if the inputs to [font=courier new,courier,monospace]dot[/font] are [font=courier new,courier,monospace]nan[/font]s? e.g.[code]if( any(isnan( vAverage.rgb )) || any(isnan( vWeight )) ) {
vAverage = vec4( 0.0f, 1.0f, 0.0f, 1.0f );
}
else
{
float fLuminance = dot( vAverage.rgb, vWeight );
...
}[/code]

Share this post


Link to post
Share on other sites
For both replies, read my edit.

The dot() was not the culprit, the source image was. Something I had not considered accepting before because the results were always exactly what I had expected (a [0,0,0] input generates a [0,0,0] output regardless of any Nan’s).
I changed my checks for isnan() to those output by my main shader (which generates the image to be pre-processed), which I have used since the beginning, and that alone eliminated all errors in OpenGL.
Actually, now only Direct3D 9 has remaining problems.

However my check for isnan() comes at the very end of that shader, and is present in ALL variants. If a NaN is present, it cannot possibly be due to an NaN value being stored in the main image. So now OpenGL and OpenG ES 2 are working while Direct3D 9 is in the wrong. With my above change, only Direct3D 9 has black artifacts, and OpenGL is entirely 100% perfect, including the overall luminance calculation which was also sometimes turning full black due to NaN.

From here out I need to focus on the Direct3D side of things, but I gained enough insight from this topic that I should be able to solve the remaining issues on my own.


L. Spiro

Share this post


Link to post
Share on other sites
Sign in to follow this  

  • Advertisement
  • Advertisement
  • Popular Now

  • Advertisement
  • Similar Content

    • By Balma Alparisi
      i got error 1282 in my code.
      sf::ContextSettings settings; settings.majorVersion = 4; settings.minorVersion = 5; settings.attributeFlags = settings.Core; sf::Window window; window.create(sf::VideoMode(1600, 900), "Texture Unit Rectangle", sf::Style::Close, settings); window.setActive(true); window.setVerticalSyncEnabled(true); glewInit(); GLuint shaderProgram = createShaderProgram("FX/Rectangle.vss", "FX/Rectangle.fss"); float vertex[] = { -0.5f,0.5f,0.0f, 0.0f,0.0f, -0.5f,-0.5f,0.0f, 0.0f,1.0f, 0.5f,0.5f,0.0f, 1.0f,0.0f, 0.5,-0.5f,0.0f, 1.0f,1.0f, }; GLuint indices[] = { 0,1,2, 1,2,3, }; GLuint vao; glGenVertexArrays(1, &vao); glBindVertexArray(vao); GLuint vbo; glGenBuffers(1, &vbo); glBindBuffer(GL_ARRAY_BUFFER, vbo); glBufferData(GL_ARRAY_BUFFER, sizeof(vertex), vertex, GL_STATIC_DRAW); GLuint ebo; glGenBuffers(1, &ebo); glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, ebo); glBufferData(GL_ELEMENT_ARRAY_BUFFER, sizeof(indices), indices,GL_STATIC_DRAW); glVertexAttribPointer(0, 3, GL_FLOAT, false, sizeof(float) * 5, (void*)0); glEnableVertexAttribArray(0); glVertexAttribPointer(1, 2, GL_FLOAT, false, sizeof(float) * 5, (void*)(sizeof(float) * 3)); glEnableVertexAttribArray(1); GLuint texture[2]; glGenTextures(2, texture); glActiveTexture(GL_TEXTURE0); glBindTexture(GL_TEXTURE_2D, texture[0]); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR); sf::Image* imageOne = new sf::Image; bool isImageOneLoaded = imageOne->loadFromFile("Texture/container.jpg"); if (isImageOneLoaded) { glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, imageOne->getSize().x, imageOne->getSize().y, 0, GL_RGBA, GL_UNSIGNED_BYTE, imageOne->getPixelsPtr()); glGenerateMipmap(GL_TEXTURE_2D); } delete imageOne; glActiveTexture(GL_TEXTURE1); glBindTexture(GL_TEXTURE_2D, texture[1]); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR); glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR); sf::Image* imageTwo = new sf::Image; bool isImageTwoLoaded = imageTwo->loadFromFile("Texture/awesomeface.png"); if (isImageTwoLoaded) { glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, imageTwo->getSize().x, imageTwo->getSize().y, 0, GL_RGBA, GL_UNSIGNED_BYTE, imageTwo->getPixelsPtr()); glGenerateMipmap(GL_TEXTURE_2D); } delete imageTwo; glUniform1i(glGetUniformLocation(shaderProgram, "inTextureOne"), 0); glUniform1i(glGetUniformLocation(shaderProgram, "inTextureTwo"), 1); GLenum error = glGetError(); std::cout << error << std::endl; sf::Event event; bool isRunning = true; while (isRunning) { while (window.pollEvent(event)) { if (event.type == event.Closed) { isRunning = false; } } glClear(GL_COLOR_BUFFER_BIT); if (isImageOneLoaded && isImageTwoLoaded) { glActiveTexture(GL_TEXTURE0); glBindTexture(GL_TEXTURE_2D, texture[0]); glActiveTexture(GL_TEXTURE1); glBindTexture(GL_TEXTURE_2D, texture[1]); glUseProgram(shaderProgram); } glBindVertexArray(vao); glDrawElements(GL_TRIANGLES, 6, GL_UNSIGNED_INT, nullptr); glBindVertexArray(0); window.display(); } glDeleteVertexArrays(1, &vao); glDeleteBuffers(1, &vbo); glDeleteBuffers(1, &ebo); glDeleteProgram(shaderProgram); glDeleteTextures(2,texture); return 0; } and this is the vertex shader
      #version 450 core layout(location=0) in vec3 inPos; layout(location=1) in vec2 inTexCoord; out vec2 TexCoord; void main() { gl_Position=vec4(inPos,1.0); TexCoord=inTexCoord; } and the fragment shader
      #version 450 core in vec2 TexCoord; uniform sampler2D inTextureOne; uniform sampler2D inTextureTwo; out vec4 FragmentColor; void main() { FragmentColor=mix(texture(inTextureOne,TexCoord),texture(inTextureTwo,TexCoord),0.2); } I was expecting awesomeface.png on top of container.jpg

    • By khawk
      We've just released all of the source code for the NeHe OpenGL lessons on our Github page at https://github.com/gamedev-net/nehe-opengl. code - 43 total platforms, configurations, and languages are included.
      Now operated by GameDev.net, NeHe is located at http://nehe.gamedev.net where it has been a valuable resource for developers wanting to learn OpenGL and graphics programming.

      View full story
    • By TheChubu
      The Khronos™ Group, an open consortium of leading hardware and software companies, announces from the SIGGRAPH 2017 Conference the immediate public availability of the OpenGL® 4.6 specification. OpenGL 4.6 integrates the functionality of numerous ARB and EXT extensions created by Khronos members AMD, Intel, and NVIDIA into core, including the capability to ingest SPIR-V™ shaders.
      SPIR-V is a Khronos-defined standard intermediate language for parallel compute and graphics, which enables content creators to simplify their shader authoring and management pipelines while providing significant source shading language flexibility. OpenGL 4.6 adds support for ingesting SPIR-V shaders to the core specification, guaranteeing that SPIR-V shaders will be widely supported by OpenGL implementations.
      OpenGL 4.6 adds the functionality of these ARB extensions to OpenGL’s core specification:
      GL_ARB_gl_spirv and GL_ARB_spirv_extensions to standardize SPIR-V support for OpenGL GL_ARB_indirect_parameters and GL_ARB_shader_draw_parameters for reducing the CPU overhead associated with rendering batches of geometry GL_ARB_pipeline_statistics_query and GL_ARB_transform_feedback_overflow_querystandardize OpenGL support for features available in Direct3D GL_ARB_texture_filter_anisotropic (based on GL_EXT_texture_filter_anisotropic) brings previously IP encumbered functionality into OpenGL to improve the visual quality of textured scenes GL_ARB_polygon_offset_clamp (based on GL_EXT_polygon_offset_clamp) suppresses a common visual artifact known as a “light leak” associated with rendering shadows GL_ARB_shader_atomic_counter_ops and GL_ARB_shader_group_vote add shader intrinsics supported by all desktop vendors to improve functionality and performance GL_KHR_no_error reduces driver overhead by allowing the application to indicate that it expects error-free operation so errors need not be generated In addition to the above features being added to OpenGL 4.6, the following are being released as extensions:
      GL_KHR_parallel_shader_compile allows applications to launch multiple shader compile threads to improve shader compile throughput WGL_ARB_create_context_no_error and GXL_ARB_create_context_no_error allow no error contexts to be created with WGL or GLX that support the GL_KHR_no_error extension “I’m proud to announce OpenGL 4.6 as the most feature-rich version of OpenGL yet. We've brought together the most popular, widely-supported extensions into a new core specification to give OpenGL developers and end users an improved baseline feature set. This includes resolving previous intellectual property roadblocks to bringing anisotropic texture filtering and polygon offset clamping into the core specification to enable widespread implementation and usage,” said Piers Daniell, chair of the OpenGL Working Group at Khronos. “The OpenGL working group will continue to respond to market needs and work with GPU vendors to ensure OpenGL remains a viable and evolving graphics API for all its customers and users across many vital industries.“
      The OpenGL 4.6 specification can be found at https://khronos.org/registry/OpenGL/index_gl.php. The GLSL to SPIR-V compiler glslang has been updated with GLSL 4.60 support, and can be found at https://github.com/KhronosGroup/glslang.
      Sophisticated graphics applications will also benefit from a set of newly released extensions for both OpenGL and OpenGL ES to enable interoperability with Vulkan and Direct3D. These extensions are named:
      GL_EXT_memory_object GL_EXT_memory_object_fd GL_EXT_memory_object_win32 GL_EXT_semaphore GL_EXT_semaphore_fd GL_EXT_semaphore_win32 GL_EXT_win32_keyed_mutex They can be found at: https://khronos.org/registry/OpenGL/index_gl.php
      Industry Support for OpenGL 4.6
      “With OpenGL 4.6 our customers have an improved set of core features available on our full range of OpenGL 4.x capable GPUs. These features provide improved rendering quality, performance and functionality. As the graphics industry’s most popular API, we fully support OpenGL and will continue to work closely with the Khronos Group on the development of new OpenGL specifications and extensions for our customers. NVIDIA has released beta OpenGL 4.6 drivers today at https://developer.nvidia.com/opengl-driver so developers can use these new features right away,” said Bob Pette, vice president, Professional Graphics at NVIDIA.
      "OpenGL 4.6 will be the first OpenGL release where conformant open source implementations based on the Mesa project will be deliverable in a reasonable timeframe after release. The open sourcing of the OpenGL conformance test suite and ongoing work between Khronos and X.org will also allow for non-vendor led open source implementations to achieve conformance in the near future," said David Airlie, senior principal engineer at Red Hat, and developer on Mesa/X.org projects.

      View full story
    • By _OskaR
      Hi,
      I have an OpenGL application but without possibility to wite own shaders.
      I need to perform small VS modification - is possible to do it in an alternative way? Do we have apps or driver modifictions which will catch the shader sent to GPU and override it?
    • By xhcao
      Does sync be needed to read texture content after access texture image in compute shader?
      My simple code is as below,
      glUseProgram(program.get());
      glBindImageTexture(0, texture[0], 0, GL_FALSE, 3, GL_READ_ONLY, GL_R32UI);
      glBindImageTexture(1, texture[1], 0, GL_FALSE, 4, GL_WRITE_ONLY, GL_R32UI);
      glDispatchCompute(1, 1, 1);
      // Does sync be needed here?
      glUseProgram(0);
      glBindFramebuffer(GL_READ_FRAMEBUFFER, framebuffer);
      glFramebufferTexture2D(GL_READ_FRAMEBUFFER, GL_COLOR_ATTACHMENT0,
                                     GL_TEXTURE_CUBE_MAP_POSITIVE_X + face, texture[1], 0);
      glReadPixels(0, 0, kWidth, kHeight, GL_RED_INTEGER, GL_UNSIGNED_INT, outputValues);
       
      Compute shader is very simple, imageLoad content from texture[0], and imageStore content to texture[1]. Does need to sync after dispatchCompute?
  • Advertisement