Sign in to follow this  
metsfan

OpenGL Question about glBufferData

Recommended Posts

Hey all, I had a question about glBufferData which is probably simple to answer, but I can't seem to figure it out. I have several 3d models in my application that I use over and over. I had the idea to create a Model class, which reads in the mesh, then creates instances of a class called GLSLProgram, which is basically a level of abstraction on top of a GLSL shader program. I want to set it up so that when I create an instance of the model, it will initialize a new shader, and populate the shader program with the vertex, normal, and texel data, then when I draw the model, just update the modelview and projection matrices, and lighting information, so that OpenGL doesn't need to load the same vertex mesh data over and over. This method doesn't seem to be working, however if I re-populate the vertex buffer every time I draw the model, everything works fine. I know people are going to ask for code, so I'll include the Model class.

The main problem is that if I only set the vertex attrib data (which is a wrapper of glBufferData and glVertexAttribPointer) in the Model::CreateInstance method, the model shows up, but the vertices are in the completely wrong place. However, if I set the vertex data in the Model::Draw method, the model shows up fine every time. Can anyone think of why this is happening?

[code]#include "stdafx.h"
#include "Model.h"
#include <FreeImage.h>
Model::Model(std::string filename)
{
Initialize(filename, "model_basic.vert", "model_basic.frag", ModelType3DS);
}
Model::Model(std::string filename, std::string vertexShader, std::string fragmentShader)
{
Initialize(filename, vertexShader, fragmentShader, ModelType3DS);
}
Model::Model(std::string filename, std::string vertexShader, std::string fragmentShader, ModelType type)
{
Initialize(filename, vertexShader, fragmentShader, type);
}
void Model::Initialize(std::string filename, std::string vertexShader, std::string fragmentShader, ModelType type)
{
m_TotalFaces = 0;
m_VertexShader = vertexShader;
m_FragmentShader = fragmentShader;

m_model = lib3ds_file_load(filename.c_str());
// If loading the model failed, we throw an exception
if(!m_model)
{
throw strcat("Unable to load ", filename.c_str());
}
bbox = new BoundingBox();
glGenVertexArrays(1, &m_vaoHandle);
}
// Destructor
Model::~Model()
{
glDeleteBuffers(1, &m_vaoHandle);
if(m_model != NULL)
{
lib3ds_file_free(m_model);
}
for(int i = 0; i < m_Shaders.size(); i++) {
delete m_Shaders[i];
}
}
void Model::CreateInstance()
{
GLSLProgram *shader = new GLSLProgram(m_VertexShader, m_FragmentShader, 3);
if(shader->compile()) {
if(shader->link()) {

m_Positions.push_back(vec4());
m_Angles.push_back(0);
m_Scales.push_back(0);
shader->use();
shader->setAttribData("VertexPosition", vertices, sizeof(Lib3dsVector) * 3 * m_TotalFaces, GL_STATIC_DRAW);
shader->setAttribData("VertexNormal", normals, sizeof(Lib3dsVector) * 3 * m_TotalFaces, GL_STATIC_DRAW);
shader->setAttribData("VertexTexCoord", texels, sizeof(Lib3dsTexel) * 3 * m_TotalFaces, GL_STATIC_DRAW);
m_Shaders.push_back(shader);
}
}
}
void Model::ApplyTexture(int index, std::string textureFile, FREE_IMAGE_FORMAT type, GLenum texNum, int texId)
{
if(index < m_Shaders.size()) {
Util::load_texture(m_Shaders[index], textureFile, type, texNum, texId, "Tex1");
}
}
// Copy vertices and normals to the memory of the GPU
void Model::ReadData()
{
assert(m_model != NULL);

// Calculate the number of faces we have in total
GetFaces();

// Allocate memory for our vertices and normals
vertices = new Lib3dsVector[m_TotalFaces * 3];
normals = new Lib3dsVector[m_TotalFaces * 3];
texels = new Lib3dsVector[m_TotalFaces * 2];
Lib3dsMesh * mesh;
unsigned int FinishedFaces = 0;
// Loop through all the meshes
for(mesh = m_model->meshes;mesh != NULL;mesh = mesh->next)
{
lib3ds_mesh_calculate_normals(mesh, &normals[FinishedFaces*3]);
// Loop through every face
for(unsigned int cur_face = 0; cur_face < mesh->faces;cur_face++)
{
Lib3dsFace * face = &mesh->faceL[cur_face];
for(unsigned int i = 0;i < 3;i++)
{
float *pos = mesh->pointL[face->points[i]].pos;
/*vec4 pos_vec = vec4(pos[0], pos[1], pos[2], 1.0);
pos_vec = translate * pos_vec;
pos[0] = pos_vec.x;
pos[1] = pos_vec.y;
pos[2] = pos_vec.z;*/
memcpy(&vertices[FinishedFaces*3 + i], pos , sizeof(Lib3dsVector));
float *texel = mesh->texelL[face->points[i]];
if(texel) {
memcpy(&texels[FinishedFaces*2 + i], texel, sizeof(Lib3dsTexel));
}
bbox->AddPoint(vec3(pos[0], pos[1], pos[2]));
}
FinishedFaces++;
}
}
bbox->Calculate();
lib3ds_file_free(m_model);
m_model = NULL;
}
// Count the total number of faces this model has
void Model::GetFaces()
{
assert(m_model != NULL);

m_TotalFaces = 0;
Lib3dsMesh * mesh;
// Loop through every mesh
for(mesh = m_model->meshes;mesh != NULL;mesh = mesh->next)
{
// Add the number of faces this mesh has to the total faces
m_TotalFaces += mesh->faces;
}
}
// Render the model using Vertex Buffer Objects
void Model::Draw(int index, glm::mat4 modelViewMatrix, glm::mat4 projectionMatrix, glm::mat3 normalMatrix)
{
if(index < m_Shaders.size()) {
GLSLProgram *m_Shader = m_Shaders[index];
m_Shader->use();
m_Shader->setUniform("ModelViewMatrix", modelViewMatrix);
m_Shader->setUniform("NormalMatrix", normalMatrix);
m_Shader->setUniform("ProjectionMatrix", projectionMatrix);
m_Shader->setUniform("MVP", projectionMatrix * modelViewMatrix);
vec3 Kd = vec3(139/255.0f, 119/255.0f, 101/255.0f);
m_Shader->setUniform("Kd", Kd);
//program->setUniform("Ld", Kd);
vec3 Ka = vec3(139/255.0f, 119/255.0f, 101/255.0f);
m_Shader->setUniform("Ka", Ka);
vec3 Ks = vec3(1.0, 1.0, 1.0);
m_Shader->setUniform("Ks", Ks);
vec4 LightPosition = vec4(0.0f, 0.0f, 0.0f, 0.0f);
//LightPosition = projection * modelview * LightPosition;
m_Shader->setUniform("LightPosition", LightPosition);
vec3 LightIntensity = vec3(1.0f, 1.0f, 1.0f);
m_Shader->setUniform("LightIntensity", LightIntensity);
m_Shader->setUniform("Shininess", 3.0f);
m_Shader->setAttribData("VertexPosition", vertices, sizeof(Lib3dsVector) * 3 * m_TotalFaces, GL_STATIC_DRAW);
m_Shader->setAttribData("VertexNormal", normals, sizeof(Lib3dsVector) * 3 * m_TotalFaces, GL_STATIC_DRAW);
m_Shader->setAttribData("VertexTexCoord", texels, sizeof(Lib3dsTexel) * 2 * m_TotalFaces, GL_STATIC_DRAW);
//glBindVertexArray(m_vaoHandle);
glDrawArrays(GL_TRIANGLES, 0, m_TotalFaces * 3);
}
}
void Model::SetPosition(int index, vec3 newPosition)
{
if(m_Positions.size() > index) {
m_Positions[index] = vec4(newPosition, 1.0f);
}
}
vec4 Model::GetPosition(int index)
{
if(m_Positions.size() > index) {
return m_Positions[index];
}
return vec4();
}
void Model::SetAngle(int index, float angle)
{
if(m_Angles.size() > index) {
m_Angles[index] = angle;
}
}
float Model::GetAngle(int index)
{
if(m_Angles.size() > index) {
return m_Angles[index];
}
return 0;
}
void Model::SetScale(int index, float scale)
{
if(m_Scales.size() > index) {
m_Scales[index] = scale;
}
}
float Model::GetScale(int index)
{
if(m_Scales.size() > index) {
return m_Scales[index];
}
return 0;
}
[/code]

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

Sign in to follow this  

  • Forum Statistics

    • Total Topics
      627767
    • Total Posts
      2978989
  • Similar Content

    • By DelicateTreeFrog
      Hello! As an exercise for delving into modern OpenGL, I'm creating a simple .obj renderer. I want to support things like varying degrees of specularity, geometry opacity, things like that, on a per-material basis. Different materials can also have different textures. Basic .obj necessities. I've done this in old school OpenGL, but modern OpenGL has its own thing going on, and I'd like to conform as closely to the standards as possible so as to keep the program running correctly, and I'm hoping to avoid picking up bad habits this early on.
      Reading around on the OpenGL Wiki, one tip in particular really stands out to me on this page:
      For something like a renderer for .obj files, this sort of thing seems almost ideal, but according to the wiki, it's a bad idea. Interesting to note!
      So, here's what the plan is so far as far as loading goes:
      Set up a type for materials so that materials can be created and destroyed. They will contain things like diffuse color, diffuse texture, geometry opacity, and so on, for each material in the .mtl file. Since .obj files are conveniently split up by material, I can load different groups of vertices/normals/UVs and triangles into different blocks of data for different models. When it comes to the rendering, I get a bit lost. I can either:
      Between drawing triangle groups, call glUseProgram to use a different shader for that particular geometry (so a unique shader just for the material that is shared by this triangle group). or
      Between drawing triangle groups, call glUniform a few times to adjust different parameters within the "master shader", such as specularity, diffuse color, and geometry opacity. In both cases, I still have to call glBindTexture between drawing triangle groups in order to bind the diffuse texture used by the material, so there doesn't seem to be a way around having the CPU do *something* during the rendering process instead of letting the GPU do everything all at once.
      The second option here seems less cluttered, however. There are less shaders to keep up with while one "master shader" handles it all. I don't have to duplicate any code or compile multiple shaders. Arguably, I could always have the shader program for each material be embedded in the material itself, and be auto-generated upon loading the material from the .mtl file. But this still leads to constantly calling glUseProgram, much more than is probably necessary in order to properly render the .obj. There seem to be a number of differing opinions on if it's okay to use hundreds of shaders or if it's best to just use tens of shaders.
      So, ultimately, what is the "right" way to do this? Does using a "master shader" (or a few variants of one) bog down the system compared to using hundreds of shader programs each dedicated to their own corresponding materials? Keeping in mind that the "master shaders" would have to track these additional uniforms and potentially have numerous branches of ifs, it may be possible that the ifs will lead to additional and unnecessary processing. But would that more expensive than constantly calling glUseProgram to switch shaders, or storing the shaders to begin with?
      With all these angles to consider, it's difficult to come to a conclusion. Both possible methods work, and both seem rather convenient for their own reasons, but which is the most performant? Please help this beginner/dummy understand. Thank you!
    • By JJCDeveloper
      I want to make professional java 3d game with server program and database,packet handling for multiplayer and client-server communicating,maps rendering,models,and stuffs Which aspect of java can I learn and where can I learn java Lwjgl OpenGL rendering Like minecraft and world of tanks
    • By AyeRonTarpas
      A friend of mine and I are making a 2D game engine as a learning experience and to hopefully build upon the experience in the long run.

      -What I'm using:
          C++;. Since im learning this language while in college and its one of the popular language to make games with why not.     Visual Studios; Im using a windows so yea.     SDL or GLFW; was thinking about SDL since i do some research on it where it is catching my interest but i hear SDL is a huge package compared to GLFW, so i may do GLFW to start with as learning since i may get overwhelmed with SDL.  
      -Questions
      Knowing what we want in the engine what should our main focus be in terms of learning. File managements, with headers, functions ect. How can i properly manage files with out confusing myself and my friend when sharing code. Alternative to Visual studios: My friend has a mac and cant properly use Vis studios, is there another alternative to it?  
    • By ferreiradaselva
      Both functions are available since 3.0, and I'm currently using `glMapBuffer()`, which works fine.
      But, I was wondering if anyone has experienced advantage in using `glMapBufferRange()`, which allows to specify the range of the mapped buffer. Could this be only a safety measure or does it improve performance?
      Note: I'm not asking about glBufferSubData()/glBufferData. Those two are irrelevant in this case.
    • By xhcao
      Before using void glBindImageTexture(    GLuint unit, GLuint texture, GLint level, GLboolean layered, GLint layer, GLenum access, GLenum format), does need to make sure that texture is completeness. 
  • Popular Now