• Announcements

    • khawk

      Download the Game Design and Indie Game Marketing Freebook   07/19/17

      GameDev.net and CRC Press have teamed up to bring a free ebook of content curated from top titles published by CRC Press. The freebook, Practices of Game Design & Indie Game Marketing, includes chapters from The Art of Game Design: A Book of Lenses, A Practical Guide to Indie Game Marketing, and An Architectural Approach to Level Design. The GameDev.net FreeBook is relevant to game designers, developers, and those interested in learning more about the challenges in game development. We know game development can be a tough discipline and business, so we picked several chapters from CRC Press titles that we thought would be of interest to you, the GameDev.net audience, in your journey to design, develop, and market your next game. The free ebook is available through CRC Press by clicking here. The Curated Books The Art of Game Design: A Book of Lenses, Second Edition, by Jesse Schell Presents 100+ sets of questions, or different lenses, for viewing a game’s design, encompassing diverse fields such as psychology, architecture, music, film, software engineering, theme park design, mathematics, anthropology, and more. Written by one of the world's top game designers, this book describes the deepest and most fundamental principles of game design, demonstrating how tactics used in board, card, and athletic games also work in video games. It provides practical instruction on creating world-class games that will be played again and again. View it here. A Practical Guide to Indie Game Marketing, by Joel Dreskin Marketing is an essential but too frequently overlooked or minimized component of the release plan for indie games. A Practical Guide to Indie Game Marketing provides you with the tools needed to build visibility and sell your indie games. With special focus on those developers with small budgets and limited staff and resources, this book is packed with tangible recommendations and techniques that you can put to use immediately. As a seasoned professional of the indie game arena, author Joel Dreskin gives you insight into practical, real-world experiences of marketing numerous successful games and also provides stories of the failures. View it here. An Architectural Approach to Level Design This is one of the first books to integrate architectural and spatial design theory with the field of level design. The book presents architectural techniques and theories for level designers to use in their own work. It connects architecture and level design in different ways that address the practical elements of how designers construct space and the experiential elements of how and why humans interact with this space. Throughout the text, readers learn skills for spatial layout, evoking emotion through gamespaces, and creating better levels through architectural theory. View it here. Learn more and download the ebook by clicking here. Did you know? GameDev.net and CRC Press also recently teamed up to bring GDNet+ Members up to a 20% discount on all CRC Press books. Learn more about this and other benefits here.
Sign in to follow this  
Followers 0
seb69

Screen is darkened after post processing

8 posts in this topic

Hi everyone I am new here [img]http://public.gamedev.net//public/style_emoticons/default/smile.png[/img] (in DirectX at the same time).

So, I have done some post processing but I get something strange at the output, the screen is darkened.

My HLSL code is basic :

[code]texture g_txSrcColor;
sampler2D g_samSrcColor = sampler_state
{
Texture = <g_txSrcColor>;
AddressU = Clamp;
AddressV = Clamp;
MinFilter = Linear;
MagFilter = Linear;
MipFilter = Linear;
};
float4 PostProcessPS( float2 Tex : TEXCOORD0 ) : COLOR0
{
return tex2D(g_samSrcColor, Tex);
}
technique PostProcess
{
pass p0
{
VertexShader = null;
PixelShader = compile ps_3_0 PostProcessPS();
}
}[/code]

And the other side :

[code]
#define CUSTOMFVF (D3DFVF_XYZRHW | D3DFVF_TEX1)

struct PPVERT
{
float x, y, z, rhw;
float tu, tv;
const static D3DVERTEXELEMENT9 Decl[4];
};

const D3DVERTEXELEMENT9 PPVERT::Decl[4] =
{
{ 0, 0, D3DDECLTYPE_FLOAT4, D3DDECLMETHOD_DEFAULT, D3DDECLUSAGE_POSITIONT, 0 },
{ 0, 16, D3DDECLTYPE_FLOAT2, D3DDECLMETHOD_DEFAULT, D3DDECLUSAGE_TEXCOORD, 0 },
{ 0, 24, D3DDECLTYPE_FLOAT2, D3DDECLMETHOD_DEFAULT, D3DDECLUSAGE_TEXCOORD, 1 },
D3DDECL_END()
};[/code]

[code]
D3DXSaveTextureToFile("texture_in.bmp", D3DXIFF_BMP, g_pSceneTexture, NULL);
UINT nbPasses = 0;
pEffect->Begin(&nbPasses, 0);
for(UINT i = 0 ; i<nbPasses ; i++)
{
pEffect->BeginPass(i);
d3device->SetStreamSource( 0, g_pVertexQuadBuffer, 0, sizeof(PPVERT) );
d3device->SetFVF( CUSTOMFVF );
d3device->DrawPrimitive( D3DPT_TRIANGLESTRIP, 0, 2 );
pEffect->EndPass();
}
pEffect->End();
D3DXSaveSurfaceToFile("surface_out.bmp", D3DXIFF_BMP, g_pRenderSurface, NULL, NULL);[/code]

I have saved the input texture and the output surface (please have a look on the screenshots). Have I missed something? The thing is that I have no information of the scene (how the device has been initialised at the beginning, and there is three render passes) so I can not find where is the problem [img]http://public.gamedev.net//public/style_emoticons/default/sad.png[/img] . If you have any ideas go ahead.

Thanks in advance,

Sébastien

texture_in : [url="http://hpics.li/1dbe6d0"]http://hpics.li/1dbe6d0[/url]

surface_out : [url="http://hpics.li/2d85644"]http://hpics.li/2d85644[/url]
0

Share this post


Link to post
Share on other sites
this can happen if you haven't generated mip maps and sample between them (as they might be black). You can force sampling the first mip map stage by using the tex2DLod method.

This is just a guess as i think you are doing a fullscreen pass with the same resolution as the source texture (where it should sample the first mip map stage automatically) but its worth a try.
0

Share this post


Link to post
Share on other sites
So, I have tried tex2Dlod, unfortunately it's still the same output. Otherwise I use a screen aligned quad so it is the same resolution.

Edit: before discarding the solution, when do I have to use the tex2Dlod? I have tried this (both in VS and PS methods) :

[code]
float4 color = tex2Dlog(g_samSrcColor, float4(Tex,0.0f,0.0f));
[/code]
0

Share this post


Link to post
Share on other sites
Just set MipFilter to None if you don't want to use mip maps.

tex2Dlod is usually used if you want to explicitely select a mip level from the sampled texture.

If the input texture has the same dimensions as the output texture, mip levels aren't used anyway.

PS: Maybe it's caused by some blending options? try setting alphablendenable to false.
0

Share this post


Link to post
Share on other sites
Hi froop,

I have tried :

[code]
technique PostProcess
{
pass p0
{
AlphaBlendEnable = false;
VertexShader = null;
PixelShader = compile ps_3_0 PostProcessPS();
}
}
[/code]

with :

[code]
d3device->SetRenderState(D3DRS_ALPHABLENDENABLE, FALSE);
[/code]

But it's still the same result [img]http://public.gamedev.net//public/style_emoticons/default/sad.png[/img]. But it looks like an alpha issue... I also tried this :

[code]
float4 color = tex2D(g_samSrcColor, Tex);
return float4(color.rgb, 1.0f);
[/code]

But nothing...
0

Share this post


Link to post
Share on other sites
Try to return a specific color, without reading the texture:
[code]
return float4(1.0f, 0, 0, 1.0f);
[/code]
If you get a clean and 100 % bright red color, you'll know that the problem is somewhere in the texture lookup.
If you get a dark red color, you'll know that the problem is somewhere in the part where you render the quad.
0

Share this post


Link to post
Share on other sites
[quote name='Tom KQT' timestamp='1333637425' post='4928486']
Try to return a specific color, without reading the texture:
[code]
return float4(1.0f, 0, 0, 1.0f);
[/code]
If you get a clean and 100 % bright red color, you'll know that the problem is somewhere in the texture lookup.
If you get a dark red color, you'll know that the problem is somewhere in the part where you render the quad.
[/quote]

I get a clean red color..
0

Share this post


Link to post
Share on other sites
Maybe the sRGB flag is set it wrong.
I don’t know how to set it in DX9. You have to find out by yourself. Sorry.
0

Share this post


Link to post
Share on other sites
[quote name='jischneider' timestamp='1333640010' post='4928506']
Maybe the sRGB flag is set it wrong.
I don’t know how to set it in DX9. You have to find out by yourself. Sorry.
[/quote]

It works ! Thanks, It was a gamma issue. I have to disable the gamma correction ([url="http://msdn.microsoft.com/en-us/library/windows/desktop/bb173460%28v=vs.85%29.aspx"]http://msdn.microsof...v=vs.85%29.aspx[/url]).

So, it can be done both in HLSL or Direct3D.

HLSL :

[code]
sampler2D g_samSrcColor =
sampler_state
{
Texture = <g_txSrcColor>;
AddressU = Clamp;
AddressV = Clamp;
MinFilter = Linear;
MagFilter = Linear;
MipFilter = Linear;
SRGBTexture = false;
};

technique PostProcess
{
pass p0
{
VertexShader = null;
PixelShader = compile ps_3_0 PostProcessPS();
SRGBWriteEnable = false;
}
}
[/code]

or Direct3D :

[code]
d3device->SetSamplerState(0, D3DSAMP_SRGBTEXTURE, 0);
[/code]


Sébastien
0

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now
Sign in to follow this  
Followers 0